- 26 Nov, 2018 40 commits
-
-
Vadym Doroshenko authored
Now SubmissionIndicatorEvent is part of PasswordForm. But for using it with NewPasswordFormManager it should be a field of FormData. This CL extracts it to a separate file and to add FormData::submission_event field. The following CL will implement processing it in NewPasswordFormManaager. Bug: 831123 Change-Id: If5e886c29fdfa95396827291436ace66679cd83b Reviewed-on: https://chromium-review.googlesource.com/c/1341910Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#610806}
-
Sergio Villar Senin authored
It was using the SigninManager to set the authenticated (primary) account. Replaced by a call to the identity API. Bug: 903863 Change-Id: Ib82685ddd13e907d8f318e3079207763fd3c9f51 Reviewed-on: https://chromium-review.googlesource.com/c/1348329 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610805}
-
David Roger authored
Bug: 908123 Change-Id: I721da9b87f677f4e68c255537dd67436d5316721 Reviewed-on: https://chromium-review.googlesource.com/c/1349655Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#610804}
-
Vaclav Brozek authored
Due to issues with moveable arguments in GMock, the password_manager_unittest.cc uses the technique where instead of mocking a method with a std::unique_ptr argument, it forwards the raw pointer of that argument to a *Ptr variant of the original method and mocks that. This works as long as the expectations on the *Ptr method are always specified and handle freeing the argument properly. Assuming that every EXPECT_CALL on the *Ptr method is handling the argument correctly, there are two ways to complete the protection against leaks: (A) Make the whole mocked object a StrictMock. (B) Provide an ON_CALL default which deletes the raw pointer argument This CL goes with (B) because it does not take away the flexibility to use normal or NiceMock for the other mocked methods. Bug: 907794 Change-Id: I498c2cb4fd69c232406baad41278fab4defc5ac9 Reviewed-on: https://chromium-review.googlesource.com/c/1349656Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#610803}
-
Ross McIlroy authored
Moves to MaybeLocal version in api_event_handler.cc. This code should never through when creating the function, so explicitly converting with ToLocalChecked(). BUG=v8:7290,v8:8238 Change-Id: I542384b457133b37d6279313bcabf874ad690591 Reviewed-on: https://chromium-review.googlesource.com/c/1349218Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610802}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7284f296f47b..c40fe7c74edc Created with: gclient setdep -r src-internal@c40fe7c74edc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie764b2984a034491ad75f1ede5dfe218fab8f95a Reviewed-on: https://chromium-review.googlesource.com/c/1350573Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610801}
-
Mikel Astiz authored
Prior to this patch, desktop favicon downloading would only stop when a truly ideal icon is found, which means a favicon with perfect bitmaps sizes for all supported screen densities (often a .ico file with a 16x16 AND a 32x32 bitmap). This often leaded to all icons being downloaded, even for cases where it's obviously unnecessary. The patch adopts the logic we currently use on mobile within FaviconHandler::UpdateFaviconCandidate() in order to stop processing favicon candidates if there is little hope that the next ones will be any better. This requires some smartness for favicon candidates without an explicit 'sizes' attribute, which would score very low prior to this patch and hence would rarely be processed (if other candidates exist). Hence, we special-case them for desktop and score them highest during initial sorting, which mimics the behavior prior to this patch and guarantees they will be processed unless an ideal favicon is found before. It's rather trivial to rule out regressions for the following common scenarios: A. Mobile platforms: no behavioral changes as score stays zero for candidates without explicit 'sizes' attribute. B. A single favicon is listed by the page. C. Multiple favicons are listed and none have a 'sizes' attribute (sorting does nothing and all are processed unless an ideal one is found). D. Multiple favicons are listed and they all have an accurate 'sizes' attribute (scenario improved in this patch). The more complex scenario is when a web page lists multiple favicons and only some have a 'sizes' attribute. In this case, there is some minor risk for regressions given that the patch scores highest the favicons without a 'sizes' attribute, so they will be downloaded and processed earlier. Bug: 895175,705900,672076 Change-Id: I8216652ede25f55332cacc54d3e0a806fd8b7bc3 Reviewed-on: https://chromium-review.googlesource.com/c/1323551 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610800}
-
David Jean authored
Bug: 907873 Change-Id: I45f4723dd2e999175c4fc0d5168275a17fb3eaf4 Reviewed-on: https://chromium-review.googlesource.com/c/1348113 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#610799}
-
Takashi Toyoshima authored
This patch makes network::cors::OriginAccessEntry to use mojom::CorsOriginAccessMatchMode rather than inter-class enum. This also allows mojom::CorsOriginPattern to use the mojom::CorsOriginAccessMatchMode rather than bool so that it can represent complete OriginAccessEntry content. This is needed to have an entry set copy outside NetworkService. TBR=haraken@chromium.org Bug: 908324 Change-Id: I5a29e877baecdcd77dea0c7c16dd90dc66f93302 Reviewed-on: https://chromium-review.googlesource.com/c/1350554 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#610798}
-
Gustaf Ullberg authored
Enable tracking of the level of clockdrift seen by the WebRTC acoustic echo canceller. The histogram has three bins: 0: No clockdrift detected. 1: Clockdrift probable. 2: Clockdrift detected. Bug: webrtc:10014 Change-Id: Ide08da65177cc0fe32c96fcad19d87d6ab8c7dc5 Reviewed-on: https://chromium-review.googlesource.com/c/1341919Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Gustaf Ullberg <gustaf@chromium.org> Cr-Commit-Position: refs/heads/master@{#610797}
-
Yoav Weiss authored
This fixes a couple of bugs with the CSSPReloadScanner that made it miss rules in which the URL wasn't quoted or the rule didn't end with a semicolon. It also adds tentative WPT tests for that functionality, as the tests are also relevant for WebKit. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1331042 Bug: 903785 Change-Id: I401c252a42fbb96dee9c7942e0a4f8d5b6850244 TBR: kouhei Reviewed-on: https://chromium-review.googlesource.com/c/1349980Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#610796}
-
Keishi Hattori authored
This reverts commit b3203d70. Reason for revert: crbug.com/908352 MyFilesVolume test is failing. Original change's description: > Fix some tests when flag MyFilesVolume is enabled > > Add RootPaths.DOWNLOADS_PATH which sets the full path to Downloads > folder: "" when MyFilesVolume is disabled, which means Downloads is the > root; "/Downloads" when MyFilesVolume is enabled, which means that > Downloads it's a folder at root. > > Change tests that uses entry.fullPath to prefix with > RootPaths.DOWNLOADS_PATH so the tests passes with/without the flag > MyFilesVolume. > > Enable some tests to run with flag MyFilesVolumeEnabled which were > failing before this CL. > > NOTE: RootPaths.DOWNLOADS_PATH will be removed and the full path with > /Downloads will be in-lined when MyFiles as Volume is fully rolled out. > > --gtest_filter="DirectoryTreeContextMenu/FilesAppBrowserTest*" > --gtest_filter="CreateNewFolder/FilesAppBrowserTest*" > > Test: browser_tests > Bug: 873539 > Change-Id: I72f6dc314e50103c3cadf2299f582dcf84f4d9e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1350019 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610771} TBR=noel@chromium.org,lucmult@chromium.org Change-Id: Ibc50141f6bb9d60ae36693c252a9e9ac74a2c9c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873539 Reviewed-on: https://chromium-review.googlesource.com/c/1350561Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610795}
-
DongJun Kim authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I1322d8651a6a91cbb3e9e2d9fe9285fd793e813a Reviewed-on: https://chromium-review.googlesource.com/c/1348884Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#610794}
-
Kamila authored
Renamed the flag from ANDROID_SITE_SETTINGS_UI to ANDROID_SITE_SETTINGS_UI_REFRESH for more accuracy about what the flag covers. Bug: 882382 Change-Id: I914a742c89f71036cacae513ae735fb46666a6c8 Reviewed-on: https://chromium-review.googlesource.com/c/1344069 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Flaky on all Mac targets. See: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=media%2Fautoplay%2Fwebaudio-audio-context-resume.html TBR=mlamouri@chromium.org Bug: 908347 Change-Id: Ibe20cc3fd8a6cc91569a6b5119472ca8a99bfe8a Reviewed-on: https://chromium-review.googlesource.com/c/1349979Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610792}
-
Hitoshi Yoshida authored
We are using Chromium style in Blink, except for WebIDL based names. However, IDL compiler still generates code with WebKit name styles. This CL makes interface methods' names to be consistent with the new Blink coding style (=Chromium style + WebIDL based name). Bug: 761242 Change-Id: Id847042dcc22ee69cfee25253856ea2c185a527f Reviewed-on: https://chromium-review.googlesource.com/c/1350416Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#610791}
-
Hiroki Nakagawa authored
As a preparation of PlzDedicatedWorker, this CL makes browser-side loader classes for PlzSharedWorker reusable for PlzDedicatedWorker. Specifically, this CL introduces WorkerScriptFetchInitiator that is a static class to abstract SharedWorkerScriptFetcher and SharedWorkerScriptLoader. This doesn't change functional behavior. WorkerScriptFetchInitiator is now used only by SharedWorkerServiceImpl, but it will also be used by DedicatedWorkerHost in a follow-up CL. Next plan: Rename SharedWorkerScriptFetcher and SharedWorkerScriptLoader to WorkerScriptFetcher and WorkerScriptLoader respectively, and remove shared worker specific code from WorkerScriptFetchInitiator. See the design doc for details: https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing Change-Id: Iae37ebb8fec6f0843df4c11fac8c9d8abe5b6667 Bug: 906991 Reviewed-on: https://chromium-review.googlesource.com/c/1345704 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610790}
-
Rune Lillesveen authored
FindIt analysis says this is because of harfbuzz roll: https://crrev.com/c67f53b0b TBR=drott@chromium.org Bug: 908276 Change-Id: Iebf1efc0f0f462d8d8f5c967b62c8056586835b1 Reviewed-on: https://chromium-review.googlesource.com/c/1350178Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9103e90f6e6..7284f296f47b Created with: gclient setdep -r src-internal@7284f296f47b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2d4cd933d276f5220e2c3d1eef57bcaf40040341 Reviewed-on: https://chromium-review.googlesource.com/c/1350572Reviewed-by:
-
Matt Falkenhagen authored
Callsites must use UpdateURLs() instead to ensure dependent state is updated. Replace the getter with url(), which makes more sense for all provider types. Bug: 908311 Change-Id: I4741225a0aec82f150d906f0f8f1736ac0097705 Reviewed-on: https://chromium-review.googlesource.com/c/1350021 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610787}
-
Kouhei Ueno authored
Bug: 863305 Change-Id: Id6d4a4fe4fce240972af183b3b5d2921cff4e51b Reviewed-on: https://chromium-review.googlesource.com/c/1350442Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#610786}
-
Kent Tamura authored
Remove 'LayoutTests' in testing code, comments, documents, and OWNERS in files other than third_party/blink/web_tests. This CL doesn't change symbol names in source code. This CL doesn't have any behavior changes Bug: 843412 Change-Id: I6eeda7b12ba3e484dff7559d21a9c13a3214795f Reviewed-on: https://chromium-review.googlesource.com/c/1350372Reviewed-by:
-
Shik Chen authored
BUG=b:118418065,b:118415374,b:64996728,b:77833131 TEST=Check the result of getUserMedia() matches the external camera in settings 100 times when Video Capture Service is not running. Change-Id: If83b5b3070724321b3524903505c98e6391a2dea Reviewed-on: https://chromium-review.googlesource.com/c/1347961Reviewed-by:Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#610784}
-
Makoto Shimazu authored
Bug: 906542 Change-Id: I1b33376d5e07ed1725e3a5760d32a2837b4b83b4 Reviewed-on: https://chromium-review.googlesource.com/c/1345702Reviewed-by:
-
Kunihiko Sakamoto authored
This patch renames "srcset" and "imgsizes" attributes on link to "imagesrcset" and "imagesizes" respectively, to match the latest spec PR [1]. Note: this feature is behind experimental-web-platform-features flag. [1] https://github.com/whatwg/html/pull/4048 Bug: 813452 Change-Id: I8eabfbd734e2f29e36b7f7a3c4a32f1237b042b1 Reviewed-on: https://chromium-review.googlesource.com/c/1350414Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0fce137b1e13..c9103e90f6e6 Created with: gclient setdep -r src-internal@c9103e90f6e6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic0e199d7f64daba2fc2c2a4acada35a7d064fe01 Reviewed-on: https://chromium-review.googlesource.com/c/1350571Reviewed-by:
-
Matt Falkenhagen authored
Make callers use UpdateURLs instead. Bug: 908311 Change-Id: I1689c8670dc2c03f325500be24dcdde9a88586a0 Reviewed-on: https://chromium-review.googlesource.com/c/1350419 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Adam Rice authored
Change-Id: Iba151bf31367c06c94311402a9fc550d7bb87a6d Reviewed-on: https://chromium-review.googlesource.com/c/1350550 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Jeremy Roman authored
Bug: 565837 Change-Id: I392128332981dd9d282648f6d4fa8ab3392188b1 Reviewed-on: https://chromium-review.googlesource.com/c/1347045 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#610778}
-
Alan Cutter authored
This CL makes Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnSync and Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnCreate ignore data: URLs which have no HTTP status code. Bug: 901552 Change-Id: I5a7ec6f9300c0b91668e9994b769073a638aff5b Reviewed-on: https://chromium-review.googlesource.com/c/1317213 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#610777}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2871509751ab..bc97432f4f93 git log 2871509751ab..bc97432f4f93 --date=short --no-merges --format='%ad %ae %s' 2018-11-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@bc97432f4f93 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ie065cd646a2323400135b9f54220d1f1eccb0779 Reviewed-on: https://chromium-review.googlesource.com/c/1350570Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610776}
-
Matt Falkenhagen authored
This aligns with ResourceRequest's naming, which is where the value comes from anyway. Note that ResourceRequest documentation states site_for_cookies is "usually" the topmost frame URL. This also allows the getter function to be called for service worker execution contexts. This simplifies some code at the callsite. Bug: 908311 Change-Id: Ief92f49d439e1219a6a33a7bafb03371d514b6e6 Reviewed-on: https://chromium-review.googlesource.com/c/1350415Reviewed-by:
-
Tao Bai authored
Only log package name if app is system app or installed from playstore Bug: 902008 Change-Id: I934cd148a074078516ecc8f64a8b57e76e25ef53 Reviewed-on: https://chromium-review.googlesource.com/c/1343515 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610774}
-
Sam McNally authored
Previously, selected files overlapped the files-toast; they have a adjustable splitter between the directory tree and the files list was also in front of the toast with a z-index: 500. The search autocomplete suggestions have z-index: 550 and the toast should not overlap it so pick a number in between: 520. z-index: 2, but files-toast did not set one. Additionally, the Change-Id: I307730c4287472963f0aa249dfce779f5202e4d3 Reviewed-on: https://chromium-review.googlesource.com/c/1350551Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610773}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b09b5e19aba..0fce137b1e13 Created with: gclient setdep -r src-internal@0fce137b1e13 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I85b02ff723d3f2605308eeac3c21bd8c535eb154 Reviewed-on: https://chromium-review.googlesource.com/c/1350569Reviewed-by:
-
Luciano Pacheco authored
Add RootPaths.DOWNLOADS_PATH which sets the full path to Downloads folder: "" when MyFilesVolume is disabled, which means Downloads is the root; "/Downloads" when MyFilesVolume is enabled, which means that Downloads it's a folder at root. Change tests that uses entry.fullPath to prefix with RootPaths.DOWNLOADS_PATH so the tests passes with/without the flag MyFilesVolume. Enable some tests to run with flag MyFilesVolumeEnabled which were failing before this CL. NOTE: RootPaths.DOWNLOADS_PATH will be removed and the full path with /Downloads will be in-lined when MyFiles as Volume is fully rolled out. --gtest_filter="DirectoryTreeContextMenu/FilesAppBrowserTest*" --gtest_filter="CreateNewFolder/FilesAppBrowserTest*" Test: browser_tests Bug: 873539 Change-Id: I72f6dc314e50103c3cadf2299f582dcf84f4d9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1350019Reviewed-by:
-
Robert Liao authored
Adding support in ui::Accelerator::GetShortcutText fixes this test. BUG= Change-Id: I93dea9bcf2c662a4d63d3d4afab1f9c43fca039c Reviewed-on: https://chromium-review.googlesource.com/c/1345072Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#610770}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2738b58bef32..8b09b5e19aba Created with: gclient setdep -r src-internal@8b09b5e19aba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3338acda288240a0ce776fe234a0e02cfe141723 Reviewed-on: https://chromium-review.googlesource.com/c/1350283Reviewed-by:
-
Sam McNally authored
Bug: 896123 Change-Id: I3b1e7e8d9c189f21ec767958a1d8afb609448c00 Reviewed-on: https://chromium-review.googlesource.com/c/1350385Reviewed-by:
-
Kunihiko Sakamoto authored
As per the Loading Signed Exchanges spec [1], this patch makes SignedExchangeEnvelope::Parse() fail if the exchange's request method is not "GET". [1] https://wicg.github.io/webpackage/loading.html#parse-cbor-headers Bug: 803774 Change-Id: I4729403f3dae5038bae702b0359e1b98f9a11233 Reviewed-on: https://chromium-review.googlesource.com/c/1350017Reviewed-by:
-
