GitLab

https://pdfium.googlesource.com/pdfium.git/+log/d654d7854951..4741b291f462

$ git log d654d7854..4741b291f --date=short --no-merges --format='%ad %ae %s'
2017-01-03 tsepez Add CFX_RetainPtr Leak() and Unleak() methods

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2615553002
Cr-Commit-Position: refs/heads/master@{#441296}

ChooserContentView[Cocoa] class name is too generic for //chrome/browser/ui/views/
and //chrome/browser/ui/cocoa directories. So change them to
DeviceChooserContentView[Cocoa] to be more specific.

BUG=651568

Review-Url: https://codereview.chromium.org/2595083002
Cr-Commit-Position: refs/heads/master@{#441295}

This test is timing dependent. We now allow more time.

BUG=248938

Review-Url: https://codereview.chromium.org/2606133002
Cr-Commit-Position: refs/heads/master@{#441294}

It's no longer used. There is a more cleanup to be done around
renaming files. I'll do that after this.

This also removes what was views_mus_unittests and renames what was views_aura_mus_unittests to views_mus_unittests.

BUG=671363
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2611773002
Cr-Commit-Position: refs/heads/master@{#441293}

I'm starting to run clang-format on things, and it's miraculously
not blowing up on <if> or <include> in .js files.  It IS, however,
changing " to ', as JavaScript generally prefers '.

This helps handle that.

R=thakis@chromium.org
BUG=567770

Review-Url: https://codereview.chromium.org/2598863002
Cr-Commit-Position: refs/heads/master@{#441292}

Changes:
Because now ui_test_utils::BringBrowserWindowToFront now supports activation waiter, let us reopen these tests for Linux_aura.

BUG=163931
TEST=automated tests

Review-Url: https://codereview.chromium.org/2600473003
Cr-Commit-Position: refs/heads/master@{#441291}

This CL-
  - Adds support for multi-line text selection to RenderTextHarfBuzz. To do this
    RenderTextHarfBuzz::FindCursorPosition and
    RenderTextHarfBuzz::GetSubstringBounds are reimplemented.
  - RenderTextHarfBuzz::FindCursorPosition now returns valid grapheme boundaries
    hence fixing issue 673986.
  - RenderTextHarfBuzz::GetSubstringBounds did already support multiline but the
    implementation was flawed. It relied on the text space bounds intersection
    computed from LineSegment's x_range paramater and from TextRunHarfBuzz.
    However these were not in sync if some newline segments were popped or if
    some text was truncated.
  - Enables multi-line text selection for views::Labels.
  - Corrects the behavior for RTL when mouse is dragged above/below the text
    bounds on MacViews.
  - Adds lots of tests.

BUG=650120, 630365, 600166, 673986
TEST= Open views_examples_with_content_exe. Select Labels from the dropdown.
Enter a large string in the "Content" textfield. Enable the Multiline and Text
Selection checkboxes. Ensure text selection works correctly on the Label.

Review-Url: https://codereview.chromium.org/2541313002
Cr-Commit-Position: refs/heads/master@{#441290}

Currently, the Form-Not-Secure warning shows up in the autofill dropdown
when the autofill suggestions are shown, but it should also show up on page
load when a password form is autofilled.

This CL adds a ShowNotSecureWarning method that roughly mirrors the
Fill-On-Account-Select flow. When a password form is autofilled on page load,
and when the PasswordFormFillData indicates that the warning should be shown,
the renderer calls ShowNotSecureWarning() to tell the browser to show the
autofill popup with the form-not-secure warning (and no autofill suggestions).

BUG=672668
TEST=Save a password on http://rsolomakhin.github.io/autofill/ in the
Name/Password form. Load the page again and observe that the field
is autofilled with a "Login not secure" autofill dropdown.

Review-Url: https://codereview.chromium.org/2604453003
Cr-Commit-Position: refs/heads/master@{#441289}

Removes a bunch of dead code that was relevant years ago before Chromium
even had a compositor, including a capture from the "backing store" and
a separate "render thread" for scaling and YUV conversion. Also,
gutted-out and simplified the unit tests.

In addition, BUILD files were modified so that only the platforms that
have implementation build/link the relevant modules.

BUG=159234

Review-Url: https://codereview.chromium.org/2605973002
Cr-Commit-Position: refs/heads/master@{#441288}

When double tapping on Forward navigation button the following happens:
- loadRequest: is called for the first Forward Tap (WKNavigation #1)
- loadRequest: is called for the second Forward Tap (WKNavigation #2)
- didStartProvisionalNavigation: is called for WKNavigation #1
- didFailProvisionalNavigation: is called for WKNavigation #1

CRWWebController used to record WKNavigation #1 as latest navigation
in didStartProvisionalNavigation: overriding WKNavigation #2.

Later inside didFailProvisionalNavigation: CRWWebController cancelled
the load because WKNavigation #1 was determined as latest.

This CL replaces _latestWKNavigation object with CRWWKNavigationStates
object which allows better tracking of latest WKNavigation object.

BUG=677327

Review-Url: https://codereview.chromium.org/2601083003
Cr-Commit-Position: refs/heads/master@{#441287}

Layout tests and blink perf tests will run with SlimmingPaintInvalidation
enabled.

BUG=646176

Review-Url: https://codereview.chromium.org/2595323003
Cr-Commit-Position: refs/heads/master@{#441286}

Note also the change made to CustomFrameView. Seems odd that this issue exists there after all these years. Maybe I should be making that change somewhere else?

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2613613002
Cr-Commit-Position: refs/heads/master@{#441285}

This is a re-land of half of the code in
https://codereview.chromium.org/2605743002
which was reverted because it changed layout test color.

TBR=avi,esprehn
BUG=634102

Review-Url: https://codereview.chromium.org/2615523002
Cr-Commit-Position: refs/heads/master@{#441284}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4ffd54d31cd5..a067dd2f2b17

$ git log 4ffd54d31..a067dd2f2 --date=short --no-merges --format='%ad %ae %s'
2017-01-03 jbudorick [systrace] Stop the browser after each test.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2611893002
Cr-Commit-Position: refs/heads/master@{#441283}

Reported crashes suggest a situation where we may double-free a
BrowserWindowController. Stacks show a UAF while trying to release a
reference to |self| held by an ObjC closure. The free occurs on an
autorelease triggered by a closure.

Most likely these are happening on the same closure. That is
__NSFireDelayedPerform "free()s" and its __delayedPerformCleanup
immediately tries to access to free again.

One hypothetical way this could occur would be if AppKit invoked
-[BrowserWindowController windowWillClose:] multiple times. Each time
would post a delayed autorelease closure. When the second is executed,
it would create the situation described.

Protect against this with an early exit in windowWillClose: if it's
already been called.

BUG=671213

Review-Url: https://codereview.chromium.org/2597023002
Cr-Commit-Position: refs/heads/master@{#441282}

We currently allow AC3/EAC3 codec id variants lower-case OTIs,
i.e. mp4a.a5 and mp4a.a6 in most places (e.g. stream_parser_factory.cc
and mime_util_internal.cc). We also need to support those lower-case
variants in StringToAudioCodec, since otherwise they won't get
recognized when an app adds a source buffer with that codec id and it's
checked in SourceBufferState::Init.

BUG=internal b/33554560

Review-Url: https://codereview.chromium.org/2587413004
Cr-Commit-Position: refs/heads/master@{#441281}

This fix memory corruption crash when app is launched from shelf
shortcut.

TEST=Manually, crash is no longer observed.
BUG=676392

Review-Url: https://codereview.chromium.org/2612453002
Cr-Commit-Position: refs/heads/master@{#441280}

BUG=675987
TEST=realtimeanalyser-basic.html

Review-Url: https://codereview.chromium.org/2598683002
Cr-Commit-Position: refs/heads/master@{#441279}

No need to hardcode to vector as that exposes more implementation
details that needed.  It can easily support all types.

BUG=

Review-Url: https://codereview.chromium.org/2616503002
Cr-Commit-Position: refs/heads/master@{#441278}

Add AudioScheduledSourceNode as a base class of schedulable source nodes to capture
the common features of these source nodes.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Vr6XJNfVAK4/RU3AP19WAQAJ

BUG=661207
TEST=audio-scheduled-source-basic.html

Review-Url: https://codereview.chromium.org/2471353004
Cr-Commit-Position: refs/heads/master@{#441277}

This CL:
* Cleans up the network-proxy HTML and JS files
* Adds a 'Save' button for configuring manual proxy configurations
  since a partial configuration might be invalid.
* Prevents updates from overwriting in-progress manual config changes.
* Fixes the mechanism for saving other proxy configurations also.
* Fixes logic determining when fields are editable.

BUG=677357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2605373002
Cr-Commit-Position: refs/heads/master@{#441276}

In Chrome OS launcher's start page, we recreate the app tile views
if we need to display different numbers of apps compared with the
previous time (e.g., install a new app or uninstall an existing app).
We need to make sure the number of the displayed apps is properly
updated. Otherwise, it might cause browser crash because of retrieving
a stale pointer in StartPageView::StartPageTilesContainer::GetTileItemView().

This simple CL is a temporary fix that meant to merge back to M56. It
will be reverted later on Tot and a better but more complicated fix
will be landed.

BUG=675150

Review-Url: https://codereview.chromium.org/2605463003
Cr-Commit-Position: refs/heads/master@{#441275}

This also includes:
 - removal of the old base_test_runner + test_dispatcher code, since
   the linker tests were the last remaining users.
 - gn changes to make a wrapper script for the linker tests s.t. they
   can be run with <output directory>/bin/run_chromium_linker_test_apk

Review-Url: https://codereview.chromium.org/2605793002
Cr-Commit-Position: refs/heads/master@{#441274}

https://pdfium.googlesource.com/pdfium.git/+log/72f50f2021cd..d654d7854951

$ git log 72f50f202..d654d7854 --date=short --no-merges --format='%ad %ae %s'
2017-01-03 tsepez remove some CFX_ArrayTemplate in xfa_ffdocview.h

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2616523003
Cr-Commit-Position: refs/heads/master@{#441273}

Don't enable VrShell experiment in non-channel builds, since it
turns off overlay support for video playback on Android.  Enabling
tests is blocked on supporting overlay video properly anyway, so
nothing depends on this default.

BUG=678018

Review-Url: https://codereview.chromium.org/2613543002
Cr-Commit-Position: refs/heads/master@{#441272}

Moved writing-mode to be generated in ComputedStyleBase, which uses the
external type platform/text/WritingMode. Also added functionality to
add 'get' to the front of getters that have names that will conflict
with type names once the Blink rename has happened (and all methods
start with a capital letter).

BUG=628043

Review-Url: https://codereview.chromium.org/2609133002
Cr-Commit-Position: refs/heads/master@{#441271}

- Code clean up, refactoring and reordering.
- Add/update the comment. Some of them are irrelevant or out-of-date.

BUG=676386

Review-Url: https://codereview.chromium.org/2590823007
Cr-Commit-Position: refs/heads/master@{#441270}

CompositorFrameSinkHolder lives until resources are released or Buffer is
destroyed.

CompositorFrameSinkHolder no longer holds references to itself in the field
release_callback_.

BUG=675004

Review-Url: https://codereview.chromium.org/2584953002
Cr-Commit-Position: refs/heads/master@{#441269}

Fix for cbiesinger comment:
https://codereview.chromium.org/2568743005#msg16

Tnx to ikilpatrick for making me put these asserts for all code paths,
this bug got caught early.

BUG=635619

[ng_negmargin]

Review-Url: https://codereview.chromium.org/2605093002
Cr-Commit-Position: refs/heads/master@{#441268}

Failures on Windows ATI and NVIDIA:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/6268
https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/6116

R=kbr@chromium.org,jmadill@chromium.org
BUG=676848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2614543002
Cr-Commit-Position: refs/heads/master@{#441267}

When downloading a dangerous download, Chrome should show an infobar in current tab.
However, the java side only checks the filename for dangerous download.
As a result, in some cases it may close a blank tab even if the download is dangerous.
That causes the download to be removed and cause a crash when returning to the caller.

BUG=667215

Review-Url: https://codereview.chromium.org/2609113004
Cr-Commit-Position: refs/heads/master@{#441266}

BUG=675325,579646

Review-Url: https://codereview.chromium.org/2608383002
Cr-Commit-Position: refs/heads/master@{#441265}

Don't enable SurfaceView overlays for video if the metadata says
that the video is rotated, since SurfaceView won't rotate it.
Also switch out of overlay mode if the metadata changes.

This also changes the 'exit full screen' logic to check if an
overlay is in use to decide if it needs to turn them off.

BUG=669081

Review-Url: https://codereview.chromium.org/2611783002
Cr-Commit-Position: refs/heads/master@{#441264}

BUG=612271
TEST=browser_tests --gtest_filter="CrSettingsPeoplePageSetupPinDialogTest*"
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2376293005
Cr-Commit-Position: refs/heads/master@{#441263}

BUG=none

Review-Url: https://codereview.chromium.org/2608003002
Cr-Commit-Position: refs/heads/master@{#441262}

Reland [Mojo Video Capture] Decouple VideoCaptureController from VideoCaptureBufferPool and VideoCaptureDeviceClient

PatchSet 1 is the state as reviewed and landed previously, see
https://codereview.chromium.org/2551193002/

This state caused a regression where video capture would be stuck in a loop of
old frames on Android when moving the browser to the background and bringing it
back to the foreground. This was caused by a new buffer pool instance being
created instead of the existing one being reused, while the renderer side would
still be pointing to buffers of the previous instance.

PatchSet 2 applies a fix for this issue.

Below is the CL description of the original CL:

Decouple VideoCaptureController from VideoCaptureBufferPool and
VideoCaptureDeviceClient. This is needed in order to prepare
VideoCaptureController for working with both the (legacy) in-process video
capture and the new video_capture Mojo service.

List of changes:
* Introduce an abstraction FrameBufferPool for the VideoCaptureController to
  talk to the VideoCaptureBufferPool.
* Move VideoFrameReceiverOnIOThread to separate file.
* Move factory logic for creating and connecting
  VideoCaptureBufferPoolImpl and VideoCaptureDeviceClient out of
  VideoCaptureController and into VideoCaptureManager as well as the tests.
* Update OWNERS to include new file and include chfremer as owner.
* In VideoCaptureDeviceClient: Rename |frame_format| to |foramt|.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.8

BUG=584797
TEST=
  content_unittests,
  video_capture_unittests,
  Apprtc loopback on Debug,
  Desktop Capture Example extension on Release

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2597833002
Cr-Commit-Position: refs/heads/master@{#441261}

BUG=None

Review-Url: https://codereview.chromium.org/2586543003
Cr-Commit-Position: refs/heads/master@{#441260}

Specifically, log the ResourceScheduler throttling a request, and starting
a throttled requests.

This CL  also includes modifying some aspects of URLRequest logging:
* Log priority and url at URLRequest creation time (so if the ResourceScheduler
  blocks it, there will be some identifier for the request).
* Remove priority from URLRequest::StartJob logging (redundant with logging
  in the constructor and SetPriority method).
* Always log SetPriority (it's relevant to the ResourceScheduler even if there's
  no job attached to the URLRequest).

BUG=None
R=mmenke@chromium.org
R=csharrison@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2579933002
Cr-Commit-Position: refs/heads/master@{#441259}

This test also enables WebViewPointerLockInteractiveTests on OOPIF-based
<webview>.

BUG=582562

Review-Url: https://codereview.chromium.org/2591783003
Cr-Commit-Position: refs/heads/master@{#441258}

BUG=

Review-Url: https://codereview.chromium.org/2616523002
Cr-Commit-Position: refs/heads/master@{#441257}