GitLab

The Play Store page contains many WebP images (lossy for movie covers and lossless for Google-created vector art), which is an image rendering category that is currently not well covered.

Bug: 878390
Change-Id: I7298c3e077497e40506a1f6528318a80e5df0221
Reviewed-on: https://chromium-review.googlesource.com/c/1309115
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607317}

Instead of skipping to the new load-progress value as it arrives,
interpolate to it. This results in a smoother animation as the
load-progress callbacks can be fairly sparse (and jump from 20% to 80%
for instance).

Drives animations off of the same timer that is used for the throbbing
state. This will hopefully address a performance regression as the
throbbing timer, progress fade-out animation and favicon fade-in
animation were all scheduling separate high-frequency repainting of the
tab icon.

Bug: chromium:903827, chromium:903147, chromium:902475, chromium:901751

progress

Change-Id: Iad2a24d94206d5871a5cacc5e56d072161407940
Reviewed-on: https://chromium-review.googlesource.com/c/1330345
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607316}

https://chromium.googlesource.com/angle/angle.git/+log/48f63f90f6f3..03d1a5ed6cc8


git log 48f63f90f6f3..03d1a5ed6cc8 --date=short --no-merges --format='%ad %ae %s'
2018-11-12 jmadill@chromium.org Vulkan: Use global buffer barriers.


Created with:
  gclient setdep -r src/third_party/angle@03d1a5ed6cc8

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I58fdbdc51db4c3b24e0b8554d699607cba25de57
Reviewed-on: https://chromium-review.googlesource.com/c/1331570Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607315}

This is necessary in order to be able to call FIDL interfaces from the
GPU thread.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan

Change-Id: I1f7b0f2957a810745a83ce1cf36327467e6ea448

Reviewed-on: https://chromium-review.googlesource.com/c/1330290
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607314}

TBR=martiniss@chromium.org

Bug: 790286,790294,790309
Change-Id: I507b1c98aa2aca9e723db051cc59c0b51ebfb5ad
Reviewed-on: https://chromium-review.googlesource.com/c/1331614Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607313}

Plan-B is deprecated, but some non-trivial work is needed to update to
Unified Plan. Specifying Plan-B explicitly will keep things working
when WebRTC changes the default to Unified Plan.

Bug: 903012
Change-Id: I3afc86c87f79af068f93af384cc20229293be5c5
Reviewed-on: https://chromium-review.googlesource.com/c/1327546Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607312}

Hide the NTP immediately when load an HTTP auth page from the NTP.
|dialogPresenter| should only run when the webState->GetView() is visible.

Bug: 826369
Change-Id: Ic154a4fdd4d52a2ddfec27de3ee80d85dd88cb18
Reviewed-on: https://chromium-review.googlesource.com/c/1323808Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607311}

This reverts commit 6c1f4453.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 607302 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZjMWY0NDUzYjQ1NjdlYmFlNjljYTlmNDJmZDY2MDJlMDZkMWIxZGMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/109736

Sample Failed Step: compile

Original change's description:
> CryptAuth: Remove unused ConnectionFinder.
> 
> Bug: 899324
> Test: none
> Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f
> Reviewed-on: https://chromium-review.googlesource.com/c/1331573
> Reviewed-by: Jeremy Klein <jlklein@chromium.org>
> Commit-Queue: James Hawkins <jhawkins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607302}

Change-Id: I0c821dda827a0daf2a144b60718e370c459abd6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 899324
Reviewed-on: https://chromium-review.googlesource.com/c/1331948
Cr-Commit-Position: refs/heads/master@{#607310}

Previously they would straight up fail. With this cache, such fetches
with specified content-length will "merely" be serialized and re-fetched.
(Which is what we did in <= M63).

Bug: 890973
Change-Id: I1d718cb83caced15d7ea44633a056a3fae0ac936
Reviewed-on: https://chromium-review.googlesource.com/c/1280792Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607309}

Tbr: justincohen@chromium.org
Bug: 903674
No-Try: true
Change-Id: Icc14807608fbd7eac94a129a6c0a6b41b187d34d
Reviewed-on: https://chromium-review.googlesource.com/c/1331828
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607308}

Clears all strikes in a profile's StrikeDatabase when Autofill
data is wiped out from Chrome Settings in iOS
(chrome://settings -> Clear Browsing Data -> Advanced ->
Autofill Form Data).

Bug: 884817
Change-Id: Ic5065176f58d3785b9636c32df150801f583bb7d
Reviewed-on: https://chromium-review.googlesource.com/c/1323795Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#607307}

This reverts commit 1e3d315d.

Reason for revert: Coalescing looks to have helped, no longer need debugging machinery.
Bug: 896880

Original change's description:
> SQLitePersistentCookieStore: Attempt to diagnose occasional heavy memory consumption
>
> From leak reports, it seems like sometimes the pending operations queue
> just keeps growing and growing, but we still don't know why... so
> DumpWithoutCrashing (once per backend lifetime) if it seems ridiculously
> long.
>
> Thanks to mef@ for the idea.
>
> Bug: 809199
> Change-Id: Ia949be30e50ddcd6f800c4c26268966b6e298bc0
> Reviewed-on: https://chromium-review.googlesource.com/1210367
> Commit-Queue: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589236}

Bug: 809199
Change-Id: I1ea0cce2ab6987a3b4afb752a5fa2d463be4c9f0
Reviewed-on: https://chromium-review.googlesource.com/c/1329345Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607306}

This is because the ContentsOpaque property of a cc::Layer can depend
on alpha.

Bug: 896716

Change-Id: Ica063db2860e0a6ba2bc9ffdf45b5cca06e26e84
Reviewed-on: https://chromium-review.googlesource.com/c/1327158
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607305}

We can't bind 2 GLImage to the same textures, and it wouldn't work anyway.
Ensure we don't attempt to create an EGLImage in that case as it will break if
e.g. the image is in UNBOUND state.

Bug: 882513
Change-Id: Iea52d25771a43205a6250b0d354593af98676a86
Reviewed-on: https://chromium-review.googlesource.com/c/1330765Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607304}

Also drops extra/legacy server preview call for server LoFi (just use
use LitePage check for Flywheel CPAT based previews) and drops
is_server_preview parm from ShouldAllow* method.

Also ignores case of blacklist not being loaded if flagged to ignore
blacklist.

Change-Id: I5995a13180a06c592ad5d02a49e54e875faade31
Reviewed-on: https://chromium-review.googlesource.com/c/1331415Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607303}

Bug: 899324
Test: none
Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f
Reviewed-on: https://chromium-review.googlesource.com/c/1331573Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607302}

This reverts commit 8a9302e2.

Reason for revert: Causing flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html

Original change's description:
> Add reprioritization to SSLConnectJobs
>
> This change allows the priority of an SSLConnectJob to be changed. If
> the reprioritization occurs while the job is establishing its underlying
> connection, the priority change is also passed down to the lower-level
> socket pool.
>
> Bug: 166689
> Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a
> Reviewed-on: https://chromium-review.googlesource.com/c/1327423
> Commit-Queue: Lily Chen <chlily@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606876}

TBR=mmenke@chromium.org,chlily@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 166689, 904345
Change-Id: I6458798e11d210258f2a26330548f1ca33eb6c90
Reviewed-on: https://chromium-review.googlesource.com/c/1331139Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607301}

Specifically ash::mojom::UserInfo. I'm going to need this to have ash call
into wallpaper code, which needs the gaia account.

BUG=756085
TEST=none

Change-Id: I9a9c1970bd3cd28ce36cca3d5ff919225dee8084
Reviewed-on: https://chromium-review.googlesource.com/c/1328564Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607300}

Changes:
Change the color of the folder title to be Grey 700.

Bug: 901286
Change-Id: Ie2e4603a6b248976fbdb114533e1c6e90485bd01
Reviewed-on: https://chromium-review.googlesource.com/c/1330833Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607299}

This patch removes the paint offset parameter for RecordHitTestData
which is now baked into the paint_rect parameter.

Change-Id: Idecbde110b50db2d62e3cec720861a1f39aecd88
Reviewed-on: https://chromium-review.googlesource.com/c/1329855
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607298}

If a sink is DISCONNECTING, change the icon to a throbber and change the
status text to "Disconnecting...", but don't grey out the title text.

If a sink is AVAILABLE but does not support the selected source, change
the status text to "Source not supported".

The hashes for the screenshots are per the instructions here:
https://docs.google.com/document/d/1nwYWDny20icMSpLUuV_LgrlbWKrYpbXOERUIZNH636o/edit
And the screenshots are uploaded here:
https://storage.googleapis.com/chromium-translation-screenshots/7f85b1d7787495adf8153366ecc39cdd43762144
https://storage.googleapis.com/chromium-translation-screenshots/7f3bb4aeb5b577e98ab1415b31f967311af8747a

Bug: 902493, 899998, 883392
Change-Id: Ib556de3e5407500a63c729c7bd02001572fa91e8
Reviewed-on: https://chromium-review.googlesource.com/c/1325070Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607297}

For Query in Omnibox, we want to avoid the URL flicker while the page
is navigating and the TLS security state has not been initialized.

This currently works on Android implementation by toggling a boolean
flag on navigation and TLS state update.

However, this duplicates a piece of state that's already
authoritatively stored within the VisibleSecurityState.

This CL:

 1. Exposes an IsSecurityInfoInitialized() method on LocationBarModel

 2. Updates the security_state::SecurityInfo struct to add a
    connection_info_initialized flag that's already present in
    security_state::VisibleSecurityState.

 3. Updates LocationBarModelDelegate to provide a general
    GetSecurityInfo method.

Planned followup work:

 1. Make Query in Omnibox actually use the IsSecurityInfoInitialized
    flag.

 2. Use LocationBarModelDelegate::GetSecurityInfo to remove some
    now-redundant methods such as FailsBillingCheck and
    FailsMalwareCheck.

Bug: 874592
Change-Id: I648b30859ec40bb741de1c31378e0a6cd8baeeaa
Reviewed-on: https://chromium-review.googlesource.com/c/1324879Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607296}

See bug for more context.

Bug: 903895
Change-Id: I86c029059a2896084f36af46df56a70a91620838
Reviewed-on: https://chromium-review.googlesource.com/c/1330202Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607295}

This reverts commit 5148d1fe.

Reason for revert: Speculative reland, root cause should be fixed with r607193.

Original change's description:
> Revert "Remove menu_marker from MenuButton."
>
> This reverts commit 32758758.
>
> Reason for revert: causes compile failures on windows similar to the ones that appeared in the CQ runs, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder/58688
>
> Original change's description:
> > Remove menu_marker from MenuButton.
> >
> > This is always false except for in tests and menu_example.cc which is
> > not used. This helps simplify MenuButton for the Button cleanup task.
> >
> > Bug: 901183
> > Change-Id: If5a3cf7b6ba1ce5618548d112df1c4404b2ae181
> > Reviewed-on: https://chromium-review.googlesource.com/c/1324375
> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> > Reviewed-by: Robert Flack <flackr@chromium.org>
> > Reviewed-by: Trent Apted <tapted@chromium.org>
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Commit-Queue: Charlene Yan <cyan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#607061}
>
> TBR=msw@chromium.org,flackr@chromium.org,oshima@chromium.org,tapted@chromium.org,cyan@chromium.org
>
> Change-Id: I9c311a3c8cea56c7670b2dace3e0410618151034
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 901183
> Reviewed-on: https://chromium-review.googlesource.com/c/1330841
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607072}

TBR=msw@chromium.org,flackr@chromium.org,oshima@chromium.org,tapted@chromium.org,jbudorick@chromium.org,cyan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 901183
Change-Id: I8a54361c857ac0a18acfc41dedb9537180aae4ce
Reviewed-on: https://chromium-review.googlesource.com/c/1331137
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607294}

Also moved some mojom service registration to later stage during
initialization.  This prevented crash during autotest because the tests
are much faster than human when enabling the service which caused the UI
to call into Assistant service before the libassistant components are
ready.

Bug: b:79879622
Test: run a localy autotest that invokes this new api
Change-Id: I643d0388115fa2690fa059b73b83748f8d06c335
Reviewed-on: https://chromium-review.googlesource.com/c/1330751Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607293}

https://skia.googlesource.com/skia.git/+log/0243949545eb..49e1239f94fe


git log 0243949545eb..49e1239f94fe --date=short --no-merges --format='%ad %ae %s'
2018-11-12 mtklein@google.com put kNone back too
2018-11-12 brianosman@google.com Guard GrOp::dumpInfo with SK_DEBUG
2018-11-12 reed@google.com use SkFontMetrics so we can deprecated the typedef
2018-11-12 egdaniel@google.com Require vulkan 1.1 headers when compiling skia.
2018-11-12 reed@google.com re-add guard to flutter for fuchsia build -- until newer flutter lands
2018-11-12 reed@google.com add guard for fuchsia build
2018-11-12 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset


Created with:
  gclient setdep -r src/third_party/skia@49e1239f94fe

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@chromium.org

Change-Id: I7ac123b610407fe6d7bb65f888c4e00ec49a7149
Reviewed-on: https://chromium-review.googlesource.com/c/1331222Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607292}

https://chromium.googlesource.com/chromium/deps/nasm.git/+log/20920a85609b..a0a6951e259b

This is a manual roll to integrate MSVC warnings suppressions.
It makes Chromium->WebRTC autoroller happy.
It doesn't matter for Chromium itself which uses clang even on Windows.

Bug: webrtc:9530
Change-Id: I7b0358e16b243b2bb400a1cf3d89c5a14cec14de
Reviewed-on: https://chromium-review.googlesource.com/c/1329966Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#607291}

This is a reland of b8e27a0d

Original change's description:
> [skia][libFuzzer] Allow building targets from OSS-Fuzz on Windows
> 
> Chrome ClusterFuzz has support for Windows while OSS-Fuzz does not.
> Enable low hanging fruit that can easily be built in a Chromium build.
> 
> Bug: 903632
> Change-Id: I9b6c9bf883271d33135a4fea31a05be3d13648df
> Reviewed-on: https://chromium-review.googlesource.com/c/1328225
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Jonathan Metzman <metzman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606938}

Bug: 903632
Change-Id: I35d49d83e589e04cf11215f63bbe2c2f13fab01c
Reviewed-on: https://chromium-review.googlesource.com/c/1330326Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607290}

Bug: 850098

Change-Id: Ic1d51dda680bcc6c24fab1c17099a1d558285528
Reviewed-on: https://chromium-review.googlesource.com/c/1313670
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607289}

Added OWNERS for fuchsia dirs in //chromecast and //media. Also added
per-files OWNER rules in //net/base/OWNERS for *fuchsia*.

Change-Id: I8fbd409b6cc429dcd636c9a388e095381adaed54
Reviewed-on: https://chromium-review.googlesource.com/c/1330701Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607288}

See https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/eKS6bOz9a_o
for Intent to Ship and lgtms.

Bug: 326740
Change-Id: I2d8cec26bae32281e50137dfd1616926b66e61a8
Reviewed-on: https://chromium-review.googlesource.com/c/1292439
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607287}

Introducing SessionRouter - a common router on top of raw connection
which routes messages between multiple sessions based on sessionId.

A couple of cleanups along the way.

Bug: 775132
Change-Id: I3f773f7ead4d1729d9b936c69b4cdda2d6d20996
Reviewed-on: https://chromium-review.googlesource.com/c/1321854
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607286}

This CL introduces GetEnableFlags to the mojo API so that
GetKeyboardLayout can be moved from keyboard_util.cc/h to
chrome_virtual_keyboard_delegate.cc (the only place it was used).

It also moves the implementaiton of GetKeyboardWindow to
ChromeKeyboardControllerClient.

BUG=876138

Change-Id: I83bca47c9a038f9be2bb3322c5500996d898f21b
Reviewed-on: https://chromium-review.googlesource.com/c/1330327
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607285}

This patch changes tests in the following directories to use
Element.innerText for text dump:

fast/s* - g*/

Most of this patch is mechanical rebaseline, except that some
LayoutNG-specific baselines become redundant and are removed.

Bug: 887148
Change-Id: Ifb325fbeb0b8f18f4f54978ddc1b3626c08a2e2e
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1328721
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607284}

We can't have gn check look through all of blink because it's
a messy monolithic pile of internal dependencies, but the
public API layer has strict rules that should be enforced by
gn check.

Also removing a mojo header from a build target since it's supposedly
already in a mojo build target and listing it here as well
makes gn check unhappy.

Bug: 898837
Change-Id: Id46485ffa4ffeb0c897f6d22e684f6d45d4804e6
Reviewed-on: https://chromium-review.googlesource.com/c/1307373
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607283}

This CL creates the first integration tests for the autofill wallet
metadata model type.

Bug: 894001
Change-Id: Ie756264fe6b22d863a6965456ec0d7b627774c23
Reviewed-on: https://chromium-review.googlesource.com/c/1306357
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607282}

This adds an UMA metric to track loadDataWithBaseURL's baseUrl scheme.
This logs if the URL is empty, if the scheme is one of several
well-known values, or if the scheme is some unknown value (possibly a
custom URL scheme).

This also adds integration tests to verify we record metrics.

R=isherman@chromium.org, torne@chromium.org

Bug: 901581
Test: run_webview_instrumentation_test_apk \
Test: --gtest_filter=LoadDataWithBaseUrlTest#testBaseUrlMetrics_*
Change-Id: Iaedf6836daeb185da7b1b26145d30fb46a363d21
Reviewed-on: https://chromium-review.googlesource.com/c/1321868
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607281}

Bug: 740715
Change-Id: I58fa13fb81eee6ef6c288026397223eb73659025
Reviewed-on: https://chromium-review.googlesource.com/c/1329545Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607280}

SyncUserSettings is a new class that encapsulates all the
user-configurable knobs for Sync. It replaces a bunch of setters
and getters directly on the SyncService.

Bug: 884159
Change-Id: I876c39d3f69f7d5e8ed3ead1f07660279e283eb0
Reviewed-on: https://chromium-review.googlesource.com/c/1286455Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607279}

Change-Id: Ia56a9b605860cb8911bc3e94791760e1ad2b7664
Reviewed-on: https://chromium-review.googlesource.com/c/1303396Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607278}