- 07 Dec, 2020 40 commits
-
-
Alexis Hetu authored
This cl changes the software backend used for running viz_unittests and cc_unittests from SwiftShader GL to SwANGLE (ANGLE on SwiftShader Vulkan). Other tests suites may be affected. From this cl, performance expectations for test runs will likely change. For example, cc_unittests appears to run faster, while viz_unittests and views_unittests appear to run slower. Note that this is still using the validating command decoder, and once the OOP Raster tests can run on the passthrough command decoder, we'll be able to use it and gain some performance on all these test runs. Bug: chromium:1060139 Change-Id: Ia243f05f3e9f54dc6f6dfaa3041021fc28818b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532042 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#834246}
-
Morten Stenshorne authored
Unless block-size constraints prevent it, attempt to make a multicol container at least as tall as its tallest piece of unbreakable content. This almost worked correctly, but not if the multicol container was nested inside another fragmentation context. It would then be constrained by the space left in the outer fragmentainer (in the case of the tests now fixed that was 0 space left). Don't attempt to make it shorter than the tallest piece of unbrekable content here, as that would actually make it (the multicol container fragment itself) fit in the current outer fragmentainer (while its contents would overflow), rather than breaking before the inner multicol container and retrying in the next outer fragmentainer. Bug: 829028 Change-Id: I94942832d6ac15ed2cfa96719810db702fea84a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576254Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#834245}
-
Xianzhu Wang authored
Previously empty viewport triggered DCHECK failure in user environments. Bug: 1155943, 1153428 Change-Id: I15f784a3196d412621a2ab7a4e9bf99f2efe133a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576777 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834244}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdb2247e82e..c56ea91f6bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I542d5f2d15e2765c4b47088d4a3d74dff334c919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577539Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834243}
-
Liviu Tinta authored
With an OOPIF, if the compositor cannot find a scroll node at all, then just ack the scrolls to the browser so they can be bubbled up to the parent frame. Taking this opportunity to do some cleanup (see comments on this CL for details): - Use ScrollThread::SCROLL_IGNORED for bubbling scrolls - Stop using ScrollThread::SCROLL_UNKNOWN, and instead use ScrollThread::SCROLL_ON_MAIN_THREAD or ScrollThread::SCROLL_IGNORED - Remove EventDisposition::DID_HANDLE_SHOULD_BUBBLE - Remove InputEventResultState::kConsumedShouldBubble (use InputEventResultState::kNotConsumed instead) - Rename ScrollStatus.bubble to ScrollStatus.viewport_cannot_scroll (use ScrollThread::DROP_EVENT if this is set to true) Bug: 1086625 Change-Id: I9aef88ed8fb7e8fb2aff8e1a478e10c402553b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562796Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#834242}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/698d1c0a0acb..3a59f15a6efc 2020-12-07 kimanh@chromium.org [LMI] Prettify buttons in LinearMemoryNavigator 2020-12-07 kimanh@chromium.org [LMI] Use arraybuffer-based types when opening the LMI 2020-12-07 tvanderlippe@chromium.org Report warnings instead of errors for missing method implementations 2020-12-07 mathias@chromium.org Clean up front_end/host/InspectorFrontendHost.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If114822611853340c0478ed3b4726ca6b5b6f48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575734Reviewed-by:
-
Jaeyong Bae authored
Currently, flex with CSS-wide keyword is serialized by shorthands. We should serialize into longhands per spec. So that it should include flex-basis, flex-grow, and flex-shrink properties. Bug: 1149779 Change-Id: I2431f89ac878d6d50686ce9faa75f9f4dd13f6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550331 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#834240}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/00b77a80ab13..b8a3078bbec9 2020-12-07 bclayton@google.com Remove DAWN_USE_NEW_TINT_TRANSFORM_API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Iad6a03005bead9363d8d796b28e1db979bcd1924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577516Reviewed-by:
-
Jordan Oroshiba authored
Bug: 1152891 Change-Id: I7286e35769fb66f3cc6792d9ae7dc0bfd460b35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537774Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Cr-Commit-Position: refs/heads/master@{#834238}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012070600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/fVqrzqnejoxXKgP8Q1x8KnBeyt9BgTlveT3nQam6WDsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021 Tbr: help-app@grotations.appspotmail.com Change-Id: If279a3cf6f01fdadbf9f6ce195fd96b8066ec904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577521Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834237}
-
Stephen McGruer authored
Bug: 997202 Change-Id: I45beb9e0ea3b0a905295e312664d010078306119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575452 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#834236}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdb2247e82e..c56ea91f6bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6835b8c264aac27bb990bb2a2a365ac539b0a58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575955Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8295f4267ab3..7bdee1ac459a 2020-12-05 drinkcat@chromium.org Revert "licensing: add ISC as notice-required" 2020-12-05 nerv@google.com usergroup_baseline: Add ap-process-manager to gwifi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ib51a0b9fa97c3563d40753796dcb2d92999ff4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577518Reviewed-by:
-
Stephen McGruer authored
Now that blinkpy has basic support for fuzzy reftests, we can enable a bunch of tests. Most of them had slightly incorrect metadata, likely because reftests confusing interpret a single value N as a range of N-N rather than 0-N. Bug: 997202,1076121 Change-Id: Ic0bf778cde8996089ef48a4c4307a56f56ee8ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575206Reviewed-by:
-
Christian Dullweber authored
The test failed with security exception which seems to be a rare issue that has not occurred on other tests for a while. This also fixes potential flakiness in two other tests where we try to click the lock icon before a page is fully loaded. Bug: 1133770 Change-Id: I5d4c31746ff2b080ca348cdc57056a445e1db9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562669Reviewed-by:
-
Thiabaud Engelbrecht authored
This a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2551847, which moved RWBuffer from skia to blink. This CL includes the following: - Remove `ROBufferStreamAsset` and associated code, since it was unused. - use `scoped_refptr` instead of `sk_sp`. - use `BufferMalloc`/`BufferFree` instead of skia versions. - use `AtomicRefCount` instead of doing it manually. - Rename tests. Bug: 1154426 Change-Id: I1faafe98dc1123457974644ee9eb358f57ba9786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569102 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#834231}
-
Xi Han authored
The crash was caused by onTabCreated() which is called before the |mStacks| is initialized. The missing of initialization might be caused by setTabModelSelector() which is called before the TabModel is initialized. In this CL, we add a TabModelSelectorObserver, and it will set the tab lists after the TabModel is ready if it wasn't when the setTabModelSelector() was called. Bug: 1142858 Change-Id: I8f452195b7342a5d1a185517b5f6b58e1d1cd327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570131 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834230}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdb2247e82e..c56ea91f6bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I639f3663718998372dbf3afa7a1e5f80a78c2bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575954Reviewed-by:
-
Dylan Cutler authored
CanonicalCookie::FromStorage. This is part of a larger effort to make the constructor of CanonicalCookie private. the user agent cookie store. The factory returns nullptr if the cookie is not Canonical. CanonicalCookie: :FromStorage loads a pointer to a cookie already entered Bug: 1102874 Change-Id: I4d5ea1e8577f3d2bcc4050ba7498d61c66151fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566963Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#834228}
-
Aaron Leventhal authored
GetLayoutObject() is a getter on the AXObject, and will be null in the case of display locking, because any AXObject inside display locking will always be an AXNodeObject and return nullptr for GetLayoutObject(). There is no concern about dangling pointers as there theoretically can be with node->GetLayoutObject(). TBR=aboxhall@chromium.org NOTRY=true Bug: None Change-Id: I3319b1cd3f71d8af345d75dea868a7f0c23487bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575829Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834227}
-
Denis Kuznetsov authored
Bug: 1106341 Change-Id: Ice17e0d2d4bee5d3c1fad84460e3d63cc7d94467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565714Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#834226}
-
Xinghui Lu authored
The actual study name is SafeBrowsingPerProfileNetworkContexts, so finch still shows a warning on missing field trial config: http://cl/345754952 Bug: None Change-Id: Ia01ceb12f0a08102363c6439d626631d5b9fe6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575880 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iad10f9a60a51b13a0f6a778b4e18c7f57cc0249f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577428Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d63d562d1b26..f0a0c38623ed 2020-12-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 00b77a80ab13 to b8a3078bbec9 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Id1f501c8abc51b89d2bb07564633f129a7b258e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577520Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012070600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/4E0Kat64Xt3-kQkf_9Z8eXNVVOdY-Dm0TKYMn0bV9SEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/164161478,b/174637068 Tbr: media-app@grotations.appspotmail.com Change-Id: I7f26cb39c7428d79e7f8c755251263f2c071af52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575735Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7c84426d2abe..7bcd79eccf28 2020-12-07 sugoi@google.com Fix some minor tracing mistakes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I110124463bc7ec59f04b9feedfbeeba0fe2e4b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577432Reviewed-by:
-
Leo Lai authored
We are deprecating tpm-related APIs by cryptohome. BUG=b:172748724 TEST=build ok. Change-Id: Ieda901dfcc6908e83e4e694ad77cfe83de8cae9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569197Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#834220}
-
Leo Lai authored
There are several places where error is put as "erorr" by mistake. Bug: None Change-Id: I871710965f2162e8ed678b6cd1463b1b88382e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570832Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#834219}
-
Czirkos Zoltan authored
When printing, the footer template for showing page number is: <span class='pageNumber'></span>/<span class='totalPages'></span> When the footer intersects the bottom margin, it is hidden. However, previously only the two spans were hidden, and the slash character stayed at the bottom of the page. This patch fixes that by hiding the div.text containers instead, whenever they intersect the margins. Bug: 1069445 Change-Id: Ia41d58fe146188ad4819075319f0655240e65908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144141Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#834218}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Also add a new std::move() call in this file, to optimize passing one of the arguments. Bug: 1122844 Change-Id: I0526ff7b4b8b4e9c080cb56b54b020c31f240492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563824 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#834217}
-
Rune Lillesveen authored
We have three instances of using AllowMarkStyleDirtyFromRecalcScope to allow marking elements style-dirty during style recalc. One of them is for text input elements where we mark the InnerEditor() element dirty when the input element gets new style. We typically don't mark style during UpdateStyleAndLayoutTreeForContainer(), which is called for container query updates during layout. This CL adds a test to check that it still works. Bug: 1146097 Change-Id: I432308bc96cd938e22ea424975a7c19a35aaf6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573139 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#834216}
-
Vasiliy Telezhnikov authored
This CL adds support for --tint-composited-content command line flag that helps to see what content was composited and what went to overlays. Change-Id: I71e2d72b87be9d37ae0787482a20b531483802f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575827Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#834215}
-
Hans Wennborg authored
See http://lists.llvm.org/pipermail/llvm-dev/2020-December/147175.html Bug: none Change-Id: Ifd6abe11b833961d9ff25bdd6e9d3315523cd95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577360Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#834214}
-
Greg Thompson authored
BUG=1156091 TBR=shimazu@chromium.org Change-Id: I35d67c44693c0e3e9da3371a1b1a657f978c3d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574950Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#834213}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/9f94d8533cef..272ae5ee2ab1 2020-12-07 wl@gnu.org * src/*: More fixes for using a '\n' in `FT_TRACE` and `FT_ERROR`. 2020-12-07 wl@gnu.org */*: s/FT_LOGGING/FT_DEBUG_LOGGING/. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I64ad85f729dd9849ba2d9988c129eb53b2d99cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575505Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#834212}
-
Jan Krcal authored
This CL changes the way profile picker layout changes when moving between the WebUI screens and the Gaia sign-in screen. Instead of destroying everything and creating new WebViews, we just swap the WebContents and swap the visibility of the native toolbar. This results in a much smoother UX, especially when moving back and forth between the first profile creation screen and the Gaia sign-in screen. The performance cost for this is keeping two WebContents in memory for the lifetime of the signed-in profile creation, which is acceptable on desktop. This CL does not actually create any content for the toolbar, this will come in the next CL. The actual toolbar view is created in this CL and its visibility is toggled in order to allow browser tests to properly detect the layout change (the previous way does not work after this change). Bug: 1126913 Change-Id: I5db63f4e73d37797d3b59c27f3454130ed12babc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571096 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Leo Lai authored
We are deprecating GetTpmStatus by cryptohome. Also, dropping the status of boot lockbox because it isn't supported by cryptohome anymore. BUG=b:172748724 TEST=browser_tests. Change-Id: Iefe7060ba64aec11f12fce188cb0f1c146124b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569431 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Justin DeWitt authored
Bug: 1155360 Change-Id: Iaf0af878775f72b305fcd5c6fa0cbabcbab9cd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575425Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Auto-Submit: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834209}
-
Dominik Röttsches authored
Upgrade underline to non-simple when a thickness is set. Without this change, only modifying the text-decoration-thickness property was disregarded when no other properties are set, as the hasSimpleUnderline() optimization was used in this case in ComputedStyle. Add a non-match type WPT test to ensure that a difference is seen when two different thicknesses are set. Fixed: 1154537 Change-Id: Id0413fc3f44e154b509e21b5f857f13f8d80a8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577457Reviewed-by:
-
Leo Lai authored
we are migrating tpm status calls to TpmManagerClient. BUG=b:172748724 TEST=build ok. Change-Id: I83e32ab20bf367d4934e7b96fc30ab4c2fc5d4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569196Reviewed-by:
-
