GitLab

NOTRY=true
NOTREECHECKS=true
BUG=367600
TBR=bartfab@chromium.org, jianli@chromium.org

Review URL: https://codereview.chromium.org/251093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266423 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266421 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Set kCanMaximizeKey/kCanResizeKey before adding to parent. (https://codereview.chromium.org/251733004/)

Reason for revert:
NativeWidgetAuraTest.TestPropertiesWhenAddedToLayout triggering lsan errors
link: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1042

errors like 
Direct leak of 24 byte(s) in 1 object(s) allocated from:
..
    #1 0x97042a in views::(anonymous namespace)::NativeWidgetAuraTest_TestPropertiesWhenAddedToLayout_Test::TestBody() ui/views/widget/native_widget_aura_unittest.cc:238


Original issue's description:
> Set kCanMaximizeKey/kCanResizeKey before adding to parent.
> 
> BUG=None
> TEST=NativeWidgetAuraTest.TestPropertiesWhenAddedToLayout
> R=ben@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266386

TBR=ben@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/257823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266419 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Stop passing chrome.test.fail as ErrorCallback (https://codereview.chromium.org/258523004/)

Reason for revert:
Suspected for making OpenAudioFiles/FileManagerBrowserTest.Test/{0,1} flaky/racy since http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10706

Errors like: 

[26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined: Displayed data of 1st file is wrong.
Actual: Beautiful Song.ogg
Expected: Beautiful Song
...
    at chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/open_audio_files.js:90:21", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined: chrome.test.failure

Original issue's description:
> Stop passing chrome.test.fail as ErrorCallback
> 
> chrome.test.fail cannot be used as ErrorCallback because it throws exception when the number of arguments doesn't match.
> This wrong use of chrome.test.fail makes the error output useless when something goes wrong.
> 
> BUG=None
> TEST=browser_tests
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266271

TBR=hirono@chromium.org,hashimoto@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/254943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266416 0039d316-1c4b-4281-b951-d872f2087c98

It is failing and I suspect the problem is in the unittest not in the code
under test, so I'm disabling rather than reverting the other change.

File "E:\b\build\slave\XP_Tests__2_\build\src\tools\telemetry\telemetry\page\page_runner_unittest.py", line 240, in testPagesetRepeat
os.remove(output_file)
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\docume~1\\chrome~2\\locals~1\\temp\\tmpiwpnmk'

TBR=dalecurtis@chromium.org
NOTRY=True
NOTREECHECKS=True
BUG=

Review URL: https://codereview.chromium.org/257983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254066

Review URL: https://codereview.chromium.org/255903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266403 0039d316-1c4b-4281-b951-d872f2087c98

CC touch hit testing now (as of http://crrev.com/264395 does a ray cast
through all layers under the touched point.  We included an optimization
to stop searching once you reach a layer we know is opaque to hit testing.
This breaks the common case of sites with a touch handler on the document
because blink has an optimization to effectively disable touch hit testing
in that scenario (since there's no benefit to be had to expensive rect
computation) by marking just the entire root layer with a handler region.

This change removes this opaque-to-hit-testing optimization.  There's some
risk that we'll block on main more often, but it should be rare (you'd
need a scrolling layer without a handler over top of a layer with a
handler).

This also fixes the case where a layer has a region that is supposed to
be transparent to hit-testing with the CSS pointer-events: none property.

BUG=366034, 269598

Review URL: https://codereview.chromium.org/250663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266402 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/254803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110814

Review URL: https://codereview.chromium.org/251833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266400 0039d316-1c4b-4281-b951-d872f2087c98

This functionality does not exist on aura or android anymore, and is
going away soon on Mac. RWHViews are always composited now on all
platforms, so the active tab is always able to be copied in the
browser process with CopyFromBackingStore().

This removes the ViewMsg_Snapshot and ViewHostMsg_Snapshot IPCs.

R=piman, thestig
BUG=251966, 251960

Review URL: https://codereview.chromium.org/259523008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266399 0039d316-1c4b-4281-b951-d872f2087c98

In ForeignSessionHelper class, there were two places
we allocate ScopedJavaLocalRef<jstring> inside a loop and
doesn't delete. The Java local references are cleaned upon
returning to Java, but there is 512 local reference hard-limit 
so we should delete it every loop to avoid hitting the limit.

BUG=366659

Review URL: https://codereview.chromium.org/257513007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266398 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365822
R=oshima@chromium.org, ben@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/246073009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266397 0039d316-1c4b-4281-b951-d872f2087c98

We cannot guarantee that urls will not be redirected when android mediaplayer requests video streams.
Always treat media urls as cross-origin for now.

BUG=334204

Review URL: https://codereview.chromium.org/247573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266396 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen@chromium.org for chrome/browser/chrome_notification_types.h (*removing* a notification type).
BUG=358710

Review URL: https://codereview.chromium.org/252593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266395 0039d316-1c4b-4281-b951-d872f2087c98

On the chromium.perf waterfall, we have some devices that are not going offline
(N4 + N5) and some that are (N7, N10, GN). Diffing the results of the
provision_device step pointed out some configuration differences between the
working and non-working devices. Most notably, wifi_on was set on all the
devices that are going offline and not on the ones that are staying on.

I hope making these settings deterministic will get these devices into better
shape.

BUG=366697

Review URL: https://codereview.chromium.org/251793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266394 0039d316-1c4b-4281-b951-d872f2087c98

Also update channel to stable.

BUG=348085

Review URL: https://codereview.chromium.org/184483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266393 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333078

Review URL: https://codereview.chromium.org/247283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362271
TEST=AutofillDialogControllerTest
NOTRY=True

Review URL: https://codereview.chromium.org/258543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266391 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes the anchor text no bold in 'Port forwarding' dialog.

BUG=366576

Review URL: https://codereview.chromium.org/250433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266390 0039d316-1c4b-4281-b951-d872f2087c98

I add the followings to histograms.xml.
  SharedWorker.RendererSurviveForWorkerTime
  SharedWorker.TimeToDeleted
  SharedWorker.TimeToScriptLoaded
  SharedWorker.TimeToScriptLoadFailed

They were introduced in http://crrev.com/259790 and http://crrev.com/260376.

BUG=327256

Review URL: https://codereview.chromium.org/245963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359672
TEST=WindowSelectorTest.DisplayOrientationChanged
TEST=While overview is active, rotate or resize the display. Windows should reposition / relayout in response.

Review URL: https://codereview.chromium.org/256413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266388 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/250833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=NativeWidgetAuraTest.TestPropertiesWhenAddedToLayout
R=ben@chromium.org

Review URL: https://codereview.chromium.org/251733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266386 0039d316-1c4b-4281-b951-d872f2087c98

Failing to do so confuses the omnibox_edit_model. A visible bug appears when using ctrl+enter after having switched tab, which can cause the text of the previous tab to be used.

BUG=338448

Review URL: https://codereview.chromium.org/232023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266385 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/255833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266384 0039d316-1c4b-4281-b951-d872f2087c98

Software delegated rendering uses one fd per tile, so with a bunch of tiles that means it can run out of fds. If it seems close to hitting the limit the browser should throw away old frames to avoid this from happening.

BUG=362603

Review URL: https://codereview.chromium.org/248193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363623
TEST=Quickly drag tab from a browser with 2 tabs immediately releasing the mouse

Review URL: https://codereview.chromium.org/254573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266382 0039d316-1c4b-4281-b951-d872f2087c98

R=cdn@chromium.org, piman@chromium.org
BUG=269808

Review URL: https://codereview.chromium.org/250803010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266381 0039d316-1c4b-4281-b951-d872f2087c98

VideoCaptureDeviceFactory is owned by VideoCaptureManager.

VideoCaptureManager gets a VCDF on construction. This
can be a real devices factory or a test one (Fake/File).
All VCM operations previously static are now made
through the Factory API regardless of the type.

The previous MSM::UseFakeDevice() disappears and
unittests MediaStreamDispatcherHostTest, 
MediaStreamManagerTest,  VideoCaptureHostTest,
add the --use-fake-device-for-media-stream flag
to command line and depend on MSM reacting to it
via injecting a fake factory to VCM on creation.

Those tests also retrieve a weak reference to the
 Fake Factory to manipulate it.

FakeVideoCapture::SetFailNextCreate() and associated
member are removed, unused.


BUG= 323913

Review URL: https://codereview.chromium.org/235353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266380 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302437, 364904, 329878

Review URL: https://codereview.chromium.org/253593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266379 0039d316-1c4b-4281-b951-d872f2087c98

xhr.abort() and sourceBuffer.abort() were transitively included
via onPlaybackStarted().  It's not relevant to the recorded
metrics so measure end time before the onPlaybackStarted()
calls.

BUG=367228
TEST=ran telemetry tests.

Review URL: https://codereview.chromium.org/251593008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266378 0039d316-1c4b-4281-b951-d872f2087c98

This method can be used in layout tests to produce log output and end a
test when the WebFrameClient receives a loadURLExternally() call. This
happens if the content attempts to download a resource explicitly.

Required by Blink CL: https://codereview.chromium.org/197033005/

BUG=346744

Review URL: https://codereview.chromium.org/200663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266377 0039d316-1c4b-4281-b951-d872f2087c98

The BookmarkClient interface abstracts the embedder. Once bookmarks is
componentized, the code will have to go through BookmarkClient methods
instead of accessing methods from chrome/browser or chrome/content (as
they are not accessible from iOS).

Wrapped methods from chrome/browser/:
- FaviconService::GetFaviconImageForURL
- HistoryService::InMemoryDatabase

BookmarkClient also wraps content::RecordAction, as it is a simple
wrapper around base::RecordAction and can easily be reimplemented in the
client without dependency on the content/ API.

Port all the client code to pass the BookmarkClient interface to the
method that need it (mostly bookmark_utils::AddIfNotBookmarked and
functions in bookmark_stats.cc, the rest are internal to the component).

BUG=364433
R=sky@chromium.org,tfarina@chromium.org,droger@chromium.org

Review URL: https://codereview.chromium.org/242693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266376 0039d316-1c4b-4281-b951-d872f2087c98

In Non-SFI mode, we close the low-level kSandboxIPCChannel channel.

BUG=367263, 358719
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/255903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266375 0039d316-1c4b-4281-b951-d872f2087c98

> Disable TabCaptureApiPixelTest::EndToEnd - failing in mac builders
> 
> BUG=367349
> 
> Review URL: https://codereview.chromium.org/259873003

TBR=rmsousa@chromium.org

Review URL: https://codereview.chromium.org/258733010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266371 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266369 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266367 0039d316-1c4b-4281-b951-d872f2087c98

> Roll webrtc 5963 -> 5979
> 
> R=ronghuawu@chromium.org
> 
> Review URL: https://codereview.chromium.org/256633003

TBR=wjia@chromium.org

Review URL: https://codereview.chromium.org/252753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266366 0039d316-1c4b-4281-b951-d872f2087c98

It is failing on the trybots (but not on the main waterfall for some reason).

File "E:\b\build\slave\win\build\src\tools\perf\measurements\rasterize_and_record_micro_unittest.py", line 47, in testRasterizeAndRecordMicro
self.assertGreater(record_time[0].GetRepresentativeNumber(), 0)
AssertionError: 0 not greater than 0

NOTRY=True
TBR=skyostil@chromium.org
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/258933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/253593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266364 0039d316-1c4b-4281-b951-d872f2087c98