- 26 Mar, 2018 40 commits
-
-
Finnur Thorarinsson authored
Bug: 734095 Change-Id: Ic65f138b41d76ffddec97eb6ec229e64f612a880 Reviewed-on: https://chromium-review.googlesource.com/970474Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#545780}
-
Geoff Lang authored
BUG=815092 Change-Id: I1da2cbdabe5a3352d3653f8eed78ff9739db63b6 Reviewed-on: https://chromium-review.googlesource.com/971468Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#545779}
-
Dominic Battre authored
See crbug.com/825540 for details. TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org notry=true Bug: 825540,796395 Change-Id: I70e628fd0b5f7fc98358be225ef0fd856a155359 Reviewed-on: https://chromium-review.googlesource.com/980256Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#545778}
-
Morten Stenshorne authored
Edge and Firefox seem to let table flex items use the sizing algorithm of the table extensively, and are therefore generally broken when it comes to flexing tables. We, on the other hand, let the flex sizing algorithm be in charge of sizing tables, so that flexing actually works. However, this causes tables with a specified main size of less than the minimum intrinsic logical width of the table to shrink below their minimum intrinsic logical width, a situation that's generally unwanted for tables. Amend by ignoring the specified main size when resolving min-width:auto on table items. Also ignore max-width/max-height. Just use the preferred minimum logical width. Bug: 821832 Change-Id: I78ca0c8e0041ea69bb606ff72d340bb3f5f9bb96 Reviewed-on: https://chromium-review.googlesource.com/964203Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#545777}
-
Illia Martyniuk authored
Avoiding unnecessary complexity in FrameSinkObserver. We are interested in events like creating and destroying FrameSinks which are handled in "OnCreated...FrameSink" and "OnDestroyed...FrameSink", so we don't need to use events "OnRegistered...Support" and "OnUnregistered...Support". These two just give us the unnecessary overhead of handling more events. Sorry for missing this in previous CL. Bug: 816802 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I53eba6a103834cc9d48ced14e013825c3b49027a Reviewed-on: https://chromium-review.googlesource.com/978374 Commit-Queue: Illia Martyniuk <illiam@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#545776}
-
Matt Falkenhagen authored
* |browser_provider_id| was misnamed and should always be valid. * Also rearrange some code around CreateForNavigation. Change-Id: I9842292ca73e1b6c2ca3e4d64b7ca086a611b9d8 Reviewed-on: https://chromium-review.googlesource.com/979882Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545775}
-
Dominic Battre authored
TBR=yhirano@chromium.org,ricea@chromium.org notry=true Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I783bbf75592236dd33b168ccf7b3cb958ec4cbc2 Reviewed-on: https://chromium-review.googlesource.com/980315 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#545774}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Change-Id: I9505403cc81e67d02286a3bfb107cb8efb19ba52 Reviewed-on: https://chromium-review.googlesource.com/975502 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#545773}
-
https://skia.googlesource.com/skia.git/+log/9b67c565cc7b..103e7243718a $ git log 9b67c565c..103e72437 --date=short --no-merges --format='%ad %ae %s' 2018-03-26 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 26ed93d7d..822a84b19 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Ib39288d433cee302f82a569df63647947d4b1827 Reviewed-on: https://chromium-review.googlesource.com/979778Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545772}
-
Daniel Bratell authored
In some extreme jumbo configurations the newly added TestPrerendererClient class in Source/core/html/parser/HTMLDocumentParserTest.cpp compiled in the same translation unit as TestPrerendererClient in Source/core/exported/PrerenderingTest.cpp and then it didn't compile. This patch renames TestPre* to MockPre*/MockWebPre* which also matches a common pattern when creating mock classes. Change-Id: Ib800e5e65756bf3c3709d8f570982aaa46dc7cd4 Reviewed-on: https://chromium-review.googlesource.com/980332Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#545771}
-
Raphael Kubo da Costa authored
Stop referencing http://crbug.com/497616; the bug was fixed years ago and since e56d75ce ("bindings: Supports inheritance of [Unforgeable] attributes as accessor-type properties") it does not look like unforgeable attributes are turned into data properties. Bug: 497616 Change-Id: I79835434ad1a7955f3a0a76ae0a0e07e3d102555 Reviewed-on: https://chromium-review.googlesource.com/980333Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#545770}
-
Yutaka Hirano authored
They were needed but are no longer needed because we moved the class. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia461eede4c2549651e5e2b8a2da897c06afca592 Reviewed-on: https://chromium-review.googlesource.com/979879 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#545769}
-
https://webrtc.googlesource.com/src.git/+log/b0ba558c966c..dc4737bbdacc $ git log b0ba558c9..dc4737bbd --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I944a3841230d077463b38ecc6300ce26da8404ee Reviewed-on: https://chromium-review.googlesource.com/980132 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545768}
-
https://chromium.googlesource.com/angle/angle.git/+log/26ed93d7db23..822a84b1959f $ git log 26ed93d7d..822a84b19 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 oetuaho Get builtin symbol info from the node in CollectVariables Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I6ff2a1bd8bc151a05a2c56fd34ceaeb16e3ce257 Reviewed-on: https://chromium-review.googlesource.com/979218Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545767}
-
Yutaka Hirano authored
This CL introduces WebSocket throttling on network::WebSocketFactory by moving some logic from content/browser/websockets to services/network. Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie007765411d95d1854fc0271652d599e5ccbcd0c Reviewed-on: https://chromium-review.googlesource.com/979872 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#545766}
-
Yuki Shiino authored
Allows to throw a stackoverflow exception in ScriptForbiddenScope. Bug: 813493 Change-Id: I75ebd44533b559369032fc750140bb22cb0c272a Reviewed-on: https://chromium-review.googlesource.com/980013Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#545765}
-
Keishi Hattori authored
Introducing the GCPhase enum. In the future, this will be used to simplify the GCState into just handling the next scheduled GC. Right now this isn't connected to anything yet. Bug: 757440 Change-Id: If91c6d11c2ee0f53e50633b9c74475f8dc256952 Reviewed-on: https://chromium-review.googlesource.com/979374Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545764}
-
Elad Alon authored
Bug: 775415 Change-Id: I334dda306d5844784fd13f9e046cbe7b6722e92b Reviewed-on: https://chromium-review.googlesource.com/973166Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#545763}
-
Eric Seckler authored
Makes HeadlessRenderTest use CompositorController to render pages and adds a way to capture and compare screenshots against golden files. Also adds a custom font rendering test. Because of the dependency on BeginFrameControl, these tests can now only run on linux. Bug: 787197 Change-Id: If0feaffb6d47cde624851c37db33e598b313668f TBR: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/978217 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#545762}
-
Mostyn Bramley-Moore authored
Speculative mac jumbo fix after this CL: https://chromium-review.googlesource.com/c/chromium/src/+/978860/ TBR=palmer@chromium.org Bug: 766882 Change-Id: I673edfd250987cd654e45c13b749f800438e2313 Reviewed-on: https://chromium-review.googlesource.com/979806 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545761}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Iee9d21bdeaa207d445f16f0bb72ceb2d657e354a Reviewed-on: https://chromium-review.googlesource.com/979741Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#545760}
-
Yoshifumi Inoue authored
Rename HonorEditingBoundaryAtOr{Before,After}() to Adjust{Back,Forward}PositionToAvoidCrossingEditingBoundaries() This patch renames |HonorEditingBoundaryAtOr{Before,After}()| to |Adjust{Back,Forward}PositionToAvoidCrossingEditingBoundaries()| to follow |SelectionAfjuster::AdjustSelecitonToAvoidCrossingEditingBoundaries()| for improving readability. Bug: 824687 Change-Id: I156c09e884ea8ff805e920cdef928e473f7cb420 Reviewed-on: https://chromium-review.googlesource.com/977343Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545759}
-
Yuta Kitamura authored
This patch drops "Web" from WebFrameScheduler and other classes having the same name for consistency with other Web classes. This patch touches a lot of files, but the changes in those files are basically simple renames. No behavior change is expected. LocalFrame::FrameScheduler() was renamed to GetFrameScheduler() because of the name conflict. Bug: 825094 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1c90ac0020c57382bbcb636ba58b9a0d6f1c849b Reviewed-on: https://chromium-review.googlesource.com/977246 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545758}
-
Dominick Ng authored
This CL applies the Touchable Chrome color spec for the location bar and omnibox drop down. The selected keyword icon was not updated to the Touchable Chrome version in a previous CL; that icon is also updated here along with its color. BUG=801583 Change-Id: Ia8a6ab56ef02852d407a0dd1501f2d10422f9455 Reviewed-on: https://chromium-review.googlesource.com/972702 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#545757}
-
Hans Wennborg authored
The script is called run-swarmed.py, not run_swarmed.py. TBR=thakis Bug: 495204 Change-Id: I43953019fe4884fac9c7491e87845ef7476091fa Reviewed-on: https://chromium-review.googlesource.com/980053Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#545756}
-
Luciano Pacheco authored
content/common/cache_storage/cache_storage_messages.h has been converted to Mojo thus should be removed on crrev.com/c/612287 Bug: 612287 Change-Id: I88db5d0798891d218c5f1bfdd312a758a45152ff Reviewed-on: https://chromium-review.googlesource.com/907769 Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#545755}
-
Tsuyoshi Horo authored
This reverts commit 35cc2b25 and removes "completed_event_->Signal()" from SyncLoadContext::OnReceivedRedirect(). https://chromium-review.googlesource.com/c/chromium/src/+/657787/23/content/renderer/loader/sync_load_context.cc#81 "completed_event_->Signal()" was called twice when SyncLoadContext receives a cross origin redirect response and caused crashes (crbug.com/797374). Bug: 706331, 797374 Change-Id: I0562752b4be305a83ac4a0997c50687189d7f6cb Original change's description: > Revert "Use DocumentThreadableLoader for sync loading from worker thread." > > This reverts commit 86859669. > > Reason for revert: threading related crashes in sync XHR code > > Original change's description: > > Use DocumentThreadableLoader for sync loading from worker thread. > > > > This change makes the sync loading on worker thread off the main thread. > > > > I will create another CL to: > > - Rename DocumentThreadableLoader. > > - Remove WorkerThreadableLoader. > > > > > > Bug: 706331 > > Change-Id: Ia625c667eb1367d44976478dd0272317b52e60ea > > Reviewed-on: https://chromium-review.googlesource.com/657787 > > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#525696} > > TBR=horo@chromium.org,kinuko@chromium.org,haraken@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 706331, 797374 > Change-Id: Ibd2be711ed693084c45d45fda7c51a2d3170361a > Reviewed-on: https://chromium-review.googlesource.com/843145 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526111} Change-Id: I0562752b4be305a83ac4a0997c50687189d7f6cb Reviewed-on: https://chromium-review.googlesource.com/974989 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545754}
-
Max Morin authored
It shouldn't be possible to have an infinite number of these bugs, so I'll just keep fixing them and hope the Clusterfuzz reports come to an end :). Bug: 825679 Change-Id: I899c87b7849cdf7cefc50976b247bce4307b89d2 Reviewed-on: https://chromium-review.googlesource.com/979801Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545753}
-
Noel Gordon authored
Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idaaf4fbc6d0217b5e0e817f8953095ae5d45e707 Reviewed-on: https://chromium-review.googlesource.com/979744Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#545752}
-
Robin Raymond authored
This is required to support building Microsoft's WinUWP store application version of WebRTC. vs_toolchain.py - needed to perform environment variable expansion for "Program Files(x86)" to correctly identify Visual Studio installation location config/BUILD.gn - remove delayimp.lib, kernel32.lib and ole32.lib from store applications (instead requires dloadhelper.lib/WindowsApp.lib must be used) BUILDCONFIG.gn - Do not use clang when compiling Windows UWP targets; - Added declare_args for is_target_winuwp rather and stripped multi defined variations of the host_os/current_os == "winrt_10", "winrt_81", "winrt_81_phone" that heavily polluted the platform / target selections (as the current targeting methodology is incorrect anyway). The host_os/current_os is always be "win" and only the target should be Windows UWP / store applications based on the target_os == "winuwp" rather than all the flavors of UWP. - Added filter for _winuwp source files (separate from just windows) - Added default configs for desktop vs store applications to correctly set the defines according to the desktop vs store targets config/win/BUILD.gn - The Windows UWP versioning assumes to be Windows 10 / store app now although a updated GN allows for targeting older Windows UWP versions/SDKs/device families. This allows the definitions for the various application support versioning and application families required for UWP to be set. - The linker calls vsvarsall.bat to be executed via toolchain/win/setup_toolchain.py in order to correctly identify the correct linker library path information for Windows store SDK targets. The hard coded and assumed library paths are fixed in all cases to be discovered from the tooling for forward future platform support in all cases. - Added ARM linkage definitions for the Windows ARM CPU required for properly targeting all three CPUs (x86, x64, arm) for universal store binaries. - Added the proper family C++/C defines required to target the various Windows store application types currently offered for Windows UWP store applications. toolchain/win/BUILD.gn - The name to support the storage of the environment variables now is passed into the setup script to allow for easier extension of the CPUs and target combinations (arm, x64, x86 in the desktop vs store variations) - "desktop" vs "store" is now specified the setup for the correct toolchain targeting - Sets true/false for is_target_winuwp is dependent on the toolchain activated (so configurations will be set correctly when the toolchain is specified for host tool targets required for build tools vs finalized application targets) - Cleaned up the Windows RT section to properly support Windows UWP toolchains toolchain/win/setup_toolchain.py - the setup was missing the arm CPU for universal binaries required for the UWP platform - The calling of vcvarsall.bat was missing the "store" option for store applications and all the CPU offered - Added returning of linker paths by searching the library environments for well-known library files expected in each of the 3 library paths required "lib", "um" and "atlmfc" R=phoglund@google.com Bug: 812814 Change-Id: If1a6b1b1bc3ed940fc8e2ce726ac016e2491e61d Reviewed-on: https://chromium-review.googlesource.com/923161 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#545751}
-
Chandan Padhi authored
This CL adds support for autoGainControl and noiseSuppression properties to MediaStreamTrack.getCapabilities() and InputDeviceInfo.getCapabilities(). Bug: 823831, 817769 Change-Id: Ifdc0e560001e000b12c8d04634d3c52de0a34cc7 Reviewed-on: https://chromium-review.googlesource.com/977251Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#545750}
-
Andrey Kraynov authored
Looks like that scoped FeatureList object doesn't affect ShellBrowserMainParts::SetupFieldTrials() execution and can be removed. Change-Id: If6c7b3433492ffdde1b1a44762bfed28f5e95824 Reviewed-on: https://chromium-review.googlesource.com/978216Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#545749}
-
Hiroki Nakagawa authored
This CL allows dynamic import() on DedicatedWorkerGlobalScope and adds WPT tests. Note that ES Modules on DedicatedWorker is an experimental feature behind the runtime flag. Design doc: https://docs.google.com/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit#heading=h.637avx8i5qtn Bug: 680046 Change-Id: I1f8fed5c319aab634f96bcfabeb3c95f5dc7d9a7 Reviewed-on: https://chromium-review.googlesource.com/970127 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545748}
-
Marc Treib authored
I was mostly looking for components/signin/-related things, but discovered a bunch more stuff along the way, mostly in ProfileSyncComponentsFactoryImpl. Bug: 825190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1b17d00db3cbefa50a7fabaf0b3e55e7ea567610 Reviewed-on: https://chromium-review.googlesource.com/978211Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#545747}
-
Zhuoyu Qian authored
This CL introduces "InsertCommands.h", move the declarations of some static functions related to insert commands to the header file. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I4fc744dc58da885071760ba691baa03e8015d63c Reviewed-on: https://chromium-review.googlesource.com/977365Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545746}
-
Sergei Datsenko authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/72bfdd343136..a0f6142f5733 $ git log 72bfdd343..a0f6142f5 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 dats Add constants for DriveFS D-Bus service. 2018-03-15 emaxx cryptohome: Constants for challenge-response methods 2018-03-15 ejcaruso cryptohome: remove MigrateToDircryptoEx constant Created with: roll-dep src/third_party/cros_system_api R=sammc@chromium.org Bug: 823603 Change-Id: I718b17c6ddb00bdeca9a8fb11a097faaecb67500 Reviewed-on: https://chromium-review.googlesource.com/979740Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#545745}
-
tzik authored
This converts the type of callback parameters on AsyncFileUtil methods from const-ref to value, and adds std::move() around them for smaller number of copies. TBR=baileyberro@chromium.org Change-Id: I07ef5fa991bcfb2e0d07ef739b4ecad4c89c39ff Reviewed-on: https://chromium-review.googlesource.com/936345 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#545744}
-
Kinuko Yasuda authored
From an offline conversation. Rationale: reflect the fact that this interface is: - somewhat specific to navigations - basically to intercept requests/responses We plan to define content::URLLoaderRequestInterceptor in //content/public separately, which only intercepts requests (and not necessarily specific to navigations) Note: This does NOT rename subclasses (e.g. FooRequestHandler). R=jam@chromium.org,jianli@chromium.org Change-Id: Ie6321d4e9ec8be626a505f242f3aace5d1c45eea Reviewed-on: https://chromium-review.googlesource.com/977642 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#545743}
-
Balazs Engedy authored
Rename the last holdout that is using the old name. Bug: 821215 Change-Id: I45cafaab27f7ef42eaef748088910d8d28f5260c Reviewed-on: https://chromium-review.googlesource.com/979450Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545742}
-
Ben Wells authored
This reverts commit d03adf5a. Reason for revert: This has caused some tests to fail flakily and reflect a crash that could happen in the wild. See http://crbug.com/825448 Original change's description: > RDH: Ensure there's at most one LoadInfoList in flight. > > ResourceDispatcherHost pushes pending load state of all frames to the UI > thread once every 250 milliseconds when there's a pending load. This > happens even when the UI thread is blocked. Apparently it's causing an > OOM when the UI thread is blocked. Whatever is blocking the UI thread > is another issue entirely, but we shouldn't use unbounded memory in the > browser process. This CL prevents load state updates from being sent > until the previous set was ACKed by the UI thread. > > Bug: 824869 > TBR: jam@chromium.org > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I3b68522c5281d477d3a621ac02e5df1f75153d99 > Reviewed-on: https://chromium-review.googlesource.com/978383 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545616} TBR=jam@chromium.org,mmenke@chromium.org,csharrison@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 824869 Change-Id: I350dd7b357c32ffc7fb85a2417afaf779552ff77 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/979674Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#545741}
-