GitLab

This CL tests against regressions of http://crbug.com/402347

BUG=402347

Review URL: https://codereview.chromium.org/652573002

Cr-Commit-Position: refs/heads/master@{#299997}

Previously this file could not be formatted because of all the shader
code in magic macros to make it less irritating to edit.  It turns out
"clang-format off" and "clang-format on" in comments make it possible to
selectively apply formatting, so do this for all the shaders.

R=danakj@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/658153003

Cr-Commit-Position: refs/heads/master@{#299996}

The problem: In various cases we have seen that the user setting to ignore the restore option (nothing / all) gets ignored.
Examples: Per user command line changes enforce a restart of chrome after login. After update, ...

On ChromeOS we need only to overwrite the user setting when chrome crashed - which would be identified by the commandline option.

I run all browser tests and changed some tests to respect this behavior.

BUG=395925
TEST=existing unit tests

Review URL: https://codereview.chromium.org/653773003

Cr-Commit-Position: refs/heads/master@{#299995}

This is a revival of [1], which was reverted [2] due to triggering
huge crash. Now the cause of the crash is fixed by [3].
This CHECK() aims to prevent similar bug in the future.

[1] crrev.com/d3e91b36
[2] crrev.com/9a04b3c3
[3] crrev.com/dcdb02fa

R=nasko@chromium.org, kareng@chromium.org
BUG=381990

Review URL: https://codereview.chromium.org/640223005

Cr-Commit-Position: refs/heads/master@{#299994}

He's no longer working on the project so shouldn't be asked for reviews.

Review URL: https://codereview.chromium.org/662513002

Cr-Commit-Position: refs/heads/master@{#299993}

Currently there's only a limited test for the new type. More complete testing to come in a followup patch.

BUG=423017

Review URL: https://codereview.chromium.org/654843005

Cr-Commit-Position: refs/heads/master@{#299992}

BUG=422953
TEST=base_unittests --gtest_filter=DiscardableMemoryTests*
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/659143002

Cr-Commit-Position: refs/heads/master@{#299991}

Review URL: https://codereview.chromium.org/638053003

Cr-Commit-Position: refs/heads/master@{#299990}

... instead of naming them just so that arraysize can be used (instead
of ARRAYSIZE_UNSAFE), since C++11 removes this restriction. Also remove
some comments about this.

(Note that the change was automatically formatted, as required by the
presubmit check. Arguably, the entire file should be reformatted for
consistency, but that should be done separately.)

R=ajuma@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/660103002

Cr-Commit-Position: refs/heads/master@{#299989}

BUG=365528

Review URL: https://codereview.chromium.org/646943005

Cr-Commit-Position: refs/heads/master@{#299988}

BUG=424229, 223859
NOTRY=true

Review URL: https://codereview.chromium.org/663593002

Cr-Commit-Position: refs/heads/master@{#299987}

BUG=224786

Review URL: https://codereview.chromium.org/616113002

Cr-Commit-Position: refs/heads/master@{#299986}

to 3-45-1/2 and I don't want this to interfere with it.

TBR=rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/661863002

Cr-Commit-Position: refs/heads/master@{#299985}

On windows the timer resolution on battery power is quite low (15 ms).
The scheduler should take this into account while posting it's
deadline task - otherwise it risks giving way too much time to the
main thread which means frame rate is reduced by half in the worst
case.

BUG=407182

Review URL: https://codereview.chromium.org/554973002

Cr-Commit-Position: refs/heads/master@{#299984}

extensions::DevicePermissionsPrompt may be implemented by an embedder
of the extensions system to provide a way to prompt the user for
permission to access a set of USB devices. This is expandable to other
device types. Implementations for Chrome using the Views framework
(for Chrome OS, Linux and Windows) and Cocoa (for OS X) are provided
in this change.

Screenshots are attached to bug 420317.

BUG=352720,420317

Review URL: https://codereview.chromium.org/633793002

Cr-Commit-Position: refs/heads/master@{#299983}

R=sky@chromium.org

Review URL: https://codereview.chromium.org/665523002

Cr-Commit-Position: refs/heads/master@{#299982}

BUG=424147
TEST=Start Chrome with --enable-new-avatar-menu. In the avatar menu, edit
the profile name and try to press Alt+Enter to get a new line. This
shouldn't work.

Review URL: https://codereview.chromium.org/638133004

Cr-Commit-Position: refs/heads/master@{#299981}

Cache results from FontRenderParams queries that request
font families. Previously, only family-less queries were
cached.

BUG=chromium:424082

Review URL: https://codereview.chromium.org/639123005

Cr-Commit-Position: refs/heads/master@{#299980}

This is required for Blink to track the synchronized starting of groups of
animations.

Blink side plumbing: https://codereview.chromium.org/652593003
Blink usage: https://codereview.chromium.org/651103002

BUG=423265

Review URL: https://codereview.chromium.org/653563003

Cr-Commit-Position: refs/heads/master@{#299979}

BUG=423621

Review URL: https://codereview.chromium.org/657783002

Cr-Commit-Position: refs/heads/master@{#299978}

Revert 543be095 and always use C++11
variadic template.

Also add mdempsky@ and jln@ as owners.

Review URL: https://codereview.chromium.org/665483002

Cr-Commit-Position: refs/heads/master@{#299977}

BUG=None
R=rogerta@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/660043002

Cr-Commit-Position: refs/heads/master@{#299976}

Fix indentation issues to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/663573002

Cr-Commit-Position: refs/heads/master@{#299975}

After we changed the PNaCl toolchain layout, this library was being installed
to the wrong location. Actually, it was worse -- the directory didn't exist, so
the library was being copied into a file called linux_pnacl/lib-<arch>.

The correct location is now linux_pnacl/translator/<arch>/lib.

BUG=423373
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/655353002

Cr-Commit-Position: refs/heads/master@{#299974}

This is probably the main source of Docserver slowness. Doing so
also leads to some nice cleanups, like removing the odd samples
getter and making samples resolution asynchronous.

R=rockot@chromium.org
BUG=415309

Review URL: https://codereview.chromium.org/656673003

Cr-Commit-Position: refs/heads/master@{#299973}

At the moment it stays on the right hand side, unflipped, overlapping
the other flipped buttons. >_<

BUG=NONE

Review URL: https://codereview.chromium.org/660803003

Cr-Commit-Position: refs/heads/master@{#299972}

This reverts commit e850894b.

TBR=jrummell@chromium.org

Review URL: https://codereview.chromium.org/653533006

Cr-Commit-Position: refs/heads/master@{#299971}

If site A embeds a frame for site B, the process for B needs to create a remote frame to represent the top-level frame A.  Currently, this is done when RenderFrameHostManager::CreateRenderFrame sends a ViewMsg_New to process B to create a swapped-out RenderView.  However, after initializing the new view, CreateRenderFrame also sends a NewFrameProxy message, which isn't necessary because the remote frame has already been created.  Note that nothing actually happens on the renderer side due to another bug with sending NewFrameProxy (crbug.com/423538).

This CL removes the call to InitRenderFrameProxy which sends the extra NewFrameProxy.  We only need to send NewFrameProxy messages for subframes, and we should never hit this path for subframes with swapped_out being true (there's a CHECK on top of RFHM::CreateRenderFrame that ensures this).

BUG=423567

Review URL: https://codereview.chromium.org/645363006

Cr-Commit-Position: refs/heads/master@{#299970}

MailboxSynchronizer which is used by Android WebView depends on them for
correct synchronization.

BUG=424293

Review URL: https://codereview.chromium.org/653533005

Cr-Commit-Position: refs/heads/master@{#299969}

R=dtu@chromium.org,nednguyen@chromium.org,tonyg@chromium.org
BUG=423563

Review URL: https://codereview.chromium.org/655563007

Cr-Commit-Position: refs/heads/master@{#299968}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

BUG=423948
TBR=mmenke@chromium.org, kinaba@chromium.org, kinuko@chromium.org

Review URL: https://codereview.chromium.org/641223004

Cr-Commit-Position: refs/heads/master@{#299967}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2f912f3..5bb9700

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/660733004

Cr-Commit-Position: refs/heads/master@{#299966}

The discussion at [1] gives some background on the root cause of the failure.

[1] https://codereview.chromium.org/610493002/

BUG=323093

Review URL: https://codereview.chromium.org/657253003

Cr-Commit-Position: refs/heads/master@{#299965}

- Keep record of a bad signature in VariationsSeedStore::LoadSeed.
- Register VerifyVariationsSeedSignature in SafeBrowsingService::RegisterAllDelayedAnalysis to send an incident report, if a bad signature is encountered.

BUG=423467

Review URL: https://codereview.chromium.org/646733002

Cr-Commit-Position: refs/heads/master@{#299964}

Not sure what was broken before, but it seems to work now. I also added the
configure flags from debian/rules.

BUG=424313
TBR=glider@chromium.org
NOTRY=true
TEST=MSan

Review URL: https://codereview.chromium.org/660863005

Cr-Commit-Position: refs/heads/master@{#299963}

TBR=keybuk@chromium.org
BUG=417463

Review URL: https://codereview.chromium.org/652663002

Cr-Commit-Position: refs/heads/master@{#299962}

This behavior matches what we do in renderer_main.cc.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/658113003

Cr-Commit-Position: refs/heads/master@{#299961}

BUG=338830
TEST=new EME tests pass

Review URL: https://codereview.chromium.org/641443002

Cr-Commit-Position: refs/heads/master@{#299960}

Prior to https://codereview.chromium.org/462813002 the resource
scheduler would exit the critical loading phase as soon as the main
parser parsed the body tag:
- Blocking JS in the head would keep it in the critical phase
- CSS in the head would not (this is the bug that was fixed)
- Non-blocking JS or JS discovered by the preload scanner would NOT
  keep it in the critical phase.

After the fix:
- Blocking JS in the head still kept it in the critical phase
- CSS in the head kept it in the critical phase (fix worked)
- Any JS that was started before the body tag was parsed would keep
  it in the critical phase until that JS finished loading. This inclues
  non-blocking JS (script-injected while in the head) as well as JS
  discovered by the preload scanner.

This change keeps the CSS fix but also restores the JS behavior so
that non-blocking or preload-scanned JS no longer keep the loader
in the critical resources phase.

The fix was really simple since CSS loads at a higher priority
than JS (net::Medium), I just changed the logic to only count
Medium+ as render-blocking (waiting for them to finish regardless of
the state of the body tag) and returned the logic that unblocks
non-render-blocking resources as soon as the body tag was parsed (which
now includes JS). Any blocking JS still keeps the main parser blocked
so only non-blocking and preloaded JS would be pending or loading when
the body tag is parsed.

You can see it working here:
http://www.webpagetest.org/video/compare.php?tests=141016_WH_e488a05d7b224d7fc362dfa91b7c5ec6,141016_H1_2ecb3d397b3c218ff26dc7bdb9cb0858

Request #13 is a non-blocking script that in teh baseline case keeps
images from being loaded but in the fixed case no longer blocks images.

The canonical test page for the CSS bug also shows the critical phase
still being honored when only css is parsed in the head:
http://www.webpagetest.org/video/compare.php?tests=141016_VM_1d25c3ff22f132b4ded97d7d72e5e558,141016_PM_17a2f0282c39f299425ba57c5c5118bf

BUG=423853

Review URL: https://codereview.chromium.org/658163002

Cr-Commit-Position: refs/heads/master@{#299959}

BUG=424093

Review URL: https://codereview.chromium.org/664543002

Cr-Commit-Position: refs/heads/master@{#299958}