- 17 Jul, 2019 40 commits
-
-
Danan S authored
It's now part of the People section. Bug: 927957 Change-Id: I3ee88d4fce66896613806d74ad4787670e658eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702167Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#678482}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It moves to inherit from OAuth2AccessTokenManager::Delegate and |token_manager_| from O2TS to PO2TS. PO2TS creates |token_manager_| with adding itself as a OAuth2AccessTokenManager::Delegate. It also cleans up unused members and macros from O2TS. Bug: 967598 Change-Id: Id2f574a59b6e002513bdb4edf3041379477d6d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703324 Commit-Queue: Julie Jeongeun Kim(OoO til July 21) <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#678481}
-
Lin Sun authored
Update the expectations file of WebGL/WebGL2 conformance test: - Add driver tags to Intel-specific issues. - Put Intel-specific issues together. Change-Id: I2765d45153716377c9b773c8a234a6bbef9a1d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687387Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#678480}
-
Tim Song authored
BUG=980861 Change-Id: I1b9ac25070c20bcddda93f0c6c9e7f1fdebe1936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703280Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#678479}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/483d4365..faec9ebf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75ef55df2b2bdf5804e8398f69fa01af2a18dfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706725Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678478}
-
Yuly Novikov authored
TBR=kbr Bug: 981736 Change-Id: Idc05ad4da8e07742e9110b1a8c2c74d10f6f6e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707568Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#678477}
-
Ahmed Fakhry authored
When the keyboard shortcut is used to move the active window from current desk to desk on left/right, we animate it towards the direction of the target desk until it goes offscreen. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=977434#c4 BUG=977434, 866622 TEST=Manually Change-Id: Ia86f493afe997ca640f923acc24fcb5bc3b3027c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705516 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#678476}
-
Navid Zolghadr authored
Add callback supports to the RenderWidgetTargeter and use the async targeting in drag and drop code and register a callback to send drag events using the callback. Note that since drag and drop events aren't WebInputEvent it is not possible to use FindTargetAndDispatch function of RenderWidgetTargeter at this time. This is exactly the same as the CL before: https://chromium-review.googlesource.com/c/chromium/src/+/1641383 but rebased on top of another change that moves the drop operations to take ownership of the OSExchangeData: https://chromium-review.googlesource.com/c/chromium/src/+/1666910 TBR=sadrul@chromium.org Bug: 804633, 967801 Change-Id: If4f53e880bb805c87d13869348a57cd857adee5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693442Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678475}
-
Pavol Marko authored
Add a base::Feature UseBuiltinCertVerifier to be able to control built-in cert verifier rollout through experiments on Chrome OS. Add a policy to fall back to the legacy certificate verifier. Evaluate the feature and policy state in ProfileNetworkContextService and request the built-in cert verifier accordingly. Sign-in screen profile: Built-in cert verifier is active iff the UseBuiltinCertVerifier feature is enabled. User profile: Built-in cert verifier is active if (*) the UseBuiltinCertVerifier feature is enabled and (*) the UseLegacyCertificateVerifier policy is not set to true (*) the RequireOnlineRevocationChecksForLocalAnchors policy is not set to true. Bug: 939344, 978069 Test: browser_tests --gtest_filter=ProfileNetworkContextService* Change-Id: I14d769ef30e9a6f0e65d11150b761f9b85a1f8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679689 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#678474}
-
Mitsuru Oshima authored
* Make browser auto managed so that it behaves like chrome when created. * Install event rewriter so that function keys are properly mapped. * Install new window delegate that creates browser and SKV Bug:979440 Test: None Change-Id: Ib672693d61ad6b0d2ca339ee6259f1514b38e894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706641 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#678473}
-
Robert Sesek authored
This is unnecessary now that the Channel implementation can natively send Mach ports. Bug: 973882 Change-Id: I7fb708353e4a53e6c606b7badf6222c45533b5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701639Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#678472}
-
Daniel Campello authored
Update notification strings and help articles linked from LEARN MORE button BUG=b:126320709,b:135125356,b:135126154,b:135127177,b:131430497,b:131430518,b:131430439,chromium:976788 Change-Id: I3d11e5f865715fc6f656f03a59744889536feb21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706545 Auto-Submit: Daniel Campello <campello@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#678471}
-
Sergey Ulanov authored
After crrev.com/677743 in-process Viz thread was started with TYPE_DEFAULT instead of TYPE_IO that is needed to be able to use FIDL APIs on Fuchsia. Updated it to use message type returned from OzonePlatform::GetMessageLoopTypeForGpu(). Bug: 985084 Change-Id: I7c9cbcc0ec3d1f751f18937660c8891ed14df49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706621Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678470}
-
Karan Bhatia authored
The default RequestParams constructor is only used in tests. However currently tests using it may not initialize all the member variables, leading to some variables remaining uninitialized and causing unexpected results. Fix this by providing default values. BUG=696822 Change-Id: I682bb7157a4f1d6bef715840ef8f974be090df68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706915 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#678469}
-
Reid Kleckner authored
PreviewsProberBrowserTest.NetworkChange reliably times out for me locally and on the ToTLinux buildbot with these gn args: is_debug = false symbol_level = 1 is_component_build=true Disable the test until it can be fixed. TBR=robertogden@chromium.org Bug: 985099 Change-Id: Icd67ae1c7babc0d7aebdbd72b3bb30a4754e2bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706544Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#678468}
-
Maks Orlovich authored
Bug: 984646 Change-Id: Icb9721646d0c93ee06b049656b777e86acd05299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704356 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#678467}
-
Ian Vollick authored
The tests appear to be flaking. TBR=chiniforooshan,nuskos Bug: 985062,983509 Change-Id: I6de77f109e639a8917e624d8a8fdee28d755143d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707396 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#678466}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3a51b0e9d143..b04e2561be34 git log 3a51b0e9d143..b04e2561be34 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b5dcfdfc..5f1aeb93 (678230:678364) 2019-07-17 crodbro@webrtc.org Add config to specify raw audio priority bitrate including overhead. Created with: gclient setdep -r src/third_party/webrtc@b04e2561be34 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I72e67edcd5a7661f2b30b29a143c2fe3a64abbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678465}
-
Matthew Mourgos authored
- Add new constants used for dense shelf changes and put the usage of these constants behind the dense shelf flag. Bug: 973483 Change-Id: I54fdba8cfb34f8bc72d2220f59c360e29adc5d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682250 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#678464}
-
Erik Chen authored
Previously, Chromium used a hermetic toolchain. This was basically a full install of Xcode, which has OS version dependencies. This CL keeps the hermetic toolchain, since it's necessary for clang + code coverage. Compilation of Chrome now uses a separate package of binaries from Xcode. This consists of a whitelist of the OS-version agnostic binaries from Xcode. These binaries do not have [relevant] OS version dependencies. Change-Id: Ie6f30b4b6b3ccd4a7538feb73d6828cfa4a02891 Bug: 965663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673572Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678463}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/223c459965a8..49b659419343 Created with: gclient setdep -r src-internal@49b659419343 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: Ie6bd4f6e05f2cd95e2933f601fdf79005f79e127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678462}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fad9fbc3c4da..d7639aff1001 git log fad9fbc3c4da..d7639aff1001 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 halcanary@google.com Samples: clean up cruft 2019-07-17 fmalita@chromium.org [skottie] Remove deprecated loadImageAsset API 2019-07-17 mtklein@google.com split deaths() out of other analysis 2019-07-17 reed@google.com search for 'main' explicitly Created with: gclient setdep -r src/third_party/skia@d7639aff1001 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: I3c76f1800f230d6fb782178b50629e9186da7554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707064Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678461}
-
Eric Karl authored
Now that viz is required, remove non-viz code from CompositorImpl and DelegatedFrameHostAndroid. Bug: 978640 Change-Id: Ia18074ea6d43baaaa0129cd48593db9a93db27c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677233 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#678460}
-
Alex Cooper authored
Adds deprecation warnings to both the flag description and the console when accessing getVRDisplays (the first entry point into WebVR), which point towards using WebXR which will be favored once it has shipped. Bug: 982472,982474 Change-Id: I4acf2dd91b20f31e67529f3f5c687ad0c5f964c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704037 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#678459}
-
Kristi Park authored
Remove the 1 second delay before the reorder flow starts, which was not a good user experience. Screencast: https://drive.google.com/open?id=1qgzQ13d1_eZ95Wj1p7LkFeX2jt1Yhkai Bug: 963561 Change-Id: I4b9896855ef73d7b85b46e1d92eaa166666ca6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706913Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#678458}
-
Becky Zhou authored
+ Don't run animation when the checked state is first initialized + Add a workaround to fix an issue that clearing image tint list on L doesn't refresh the drawable state Bug: 895866, 983686 Change-Id: Id5be04a2877439aafc4da61d15bec0ca486bf26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700466Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#678457}
-
Albert Chaulk authored
The client will use GRPC to talk to cast_shell to create and manage webviews. One RPC corresponds to a given webview and input and commands and send over this channel. Presentation is handled by wayland/exo and associating a wayland surface with a webview TEST=local test w/ desktop cast_shell & wayland_fullscreen_client BUG=b/132811925 Change-Id: I8f0da747805973174c46f1d824758c6c2ee04674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678288 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#678456}
-
Michael Giuffrida authored
Remove Demo Mode feature flags that have been default-enabled on Stable for 2+ milestones. Bug: None Change-Id: Ic3dd93fd3e1dfb44ba51139e3a90baf707f9e818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699308 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#678455}
-
Alexei Svitkine authored
MockInputApi was returning MockFile objects instead of strings from LocalPaths() API, which apparently trips up Windows Python APIs, but not Unix ones. Bug: 984360 Change-Id: I0a14cc07a9406d84d6b20d104d002fe67cc4ae86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706577Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#678454}
-
Michael Giuffrida authored
Add Germany and Japan to country selector during Demo Mode setup and enroll the device into the corresponding OU. I've already created the corresponding admin-de and admin-jp users and OUs in the admin console and verified that enrolling into either of these countries works. Bug: 983278 Test: Start Demo Mode setup at Welcome screen; set up using Germany or Japan Change-Id: Ie2dbef900546fc5efb3638556c069c92d9d6f045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699195Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678453}
-
Sam Fortiner authored
This change introduces the following histogram. Compositing.Renderer.PercentPictureLayersWithTextButLCDTextDisabled.<suffix> The percentage of picture layers that include a DrawTextBlobOp but do not allow LCD-text to be used. The suffix is LessThan10, 10To30, or MoreThan30. This will be used to understand how composition decisions affect text quality. Change-Id: I8f1c2a76705d07b833631a0c8717a089eb71bb65 Bug: 984346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693804Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#678452}
-
Alex Cooper authored
Purely mechanical changes to swap the order of params from the helpers in xr-test-utils.js to match those from webxr_util.js so that porting tests can be more straightforward. Does not address the potentially more complicated work of only one sessionMode or the test harness handling the baseLayer yet. Bug: 981003 Change-Id: I5a57b814582b88297a98c64c1fa452fe22736ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704697 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#678451}
-
Mario Sanchez Prada authored
Convert the implementation and clients in the browser and renderer processes (i.e. blink::FindInPage, content::FindInPageClient) to the new types, as well as the signature of the FindInPage::SetClient() method as defined in the find_in_page.mojom file. Bug: 955171, 978694 Change-Id: I4511bb238333fe846e0e681c225dbceaa05dcf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701849Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#678450}
-
Nate Fischer authored
This modifies several scripts to call devil_chromium.Initialize() correctly, rather than to call script_common.InitializeEnvironment(), to use the better environment defaults provided by devil_chromium. This should reduce adb server restarts by using a consistent adb binary across all scripts. Bug: 978697 Test: Run each script with -vv, verify it defaults to the correct adb binary Test: Run each script with -vv and --adb-path, verify it uses the specified adb Change-Id: Ib792dbeacec36f5fc6cd68593d27dc947fcfc2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705314Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678449}
-
Harry Cutts authored
See go/cros-gesture-properties-dbus-design (Google internal only, sorry) for more details about the full design. Bug: 952054 Test: call the `GetProperty` method with this command (substituting a valid device ID): dbus-send --print-reply --system \ --dest=org.chromium.GesturePropertiesService \ /org/chromium/GesturePropertiesService \ org.chromium.GesturePropertiesServiceInterface.GetProperty \ int32:"$DEVICE_ID" string:"Log Path" Change-Id: I4b663486cf22a50f9e46611e50d35da287099fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589449 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#678448}
-
Istiaque Ahmed authored
This CL also runs the same test in SW based extension and non SW based extension (event page). Bug: None Test: Test only change, no changes expected. Change-Id: Iea29ddcc672b6045353a20bd0e4012e40f35abc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700650Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#678447}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c44d2c7919d7..0efe516eeaef git log c44d2c7919d7..0efe516eeaef --date=short --no-merges --format='%ad %ae %s' 2019-07-17 jmadill@chromium.org Fix egl.h compatiblity. 2019-07-17 geofflang@chromium.org Update the documentation on ANGLE's two reviewer policy. 2019-07-17 hao.x.li@intel.com Rename data_dir to angle_data_dir in GN files Created with: gclient setdep -r src/third_party/angle@0efe516eeaef The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Ib4ba5643b4f6ca0d9de9de701309a2bcf81cbd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678446}
-
chrome-bot authored
Updated to this build from today: https://ci.chromium.org/p/celab/builders/ci/Windows/b8907660573818690112 Mostly reliability improvements (around RunCommand & logging). The only significant functionality change is RunCommand's default shell is powershell, which doesn't change anything most of the time except in one test where we were using cmd.exe's if syntax. Change-Id: I3aa3eb72cb14710db7b06c423fb398f110aa613b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707060Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#678445}
-
Wei-Yin Chen (陳威尹) authored
Add a Finch parameter "max-duty-cycle" (default 0.2) as a rate limit for the DynamicResource RecyclerView used in Grid Tab Switcher. When getBitmap() takes 10ms, max-duty-cycle = 0.2 means the refresh would be suppressed for the following 40ms so that the duty cycle (= 10 / (10 + 40)) wouldn't exceed 20%. The RecyclerView is invalidated too frequently for few visual changes. Rate-limiting the capturing reduces wasting processing power, and makes Tab-to-GTS transition animation more smooth. Bug: 964406 Change-Id: Ie3d395260c8f018f608c41b56fdcb2aff3da1c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703805 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#678444}
-
Steve Becker authored
content::PushMessagingService is a "push service-agnostic interface that the Push API uses for talking to push messaging services like GCM." This change updates the PushMessagingService interface to improve compatibility with other push services by removing GetEndpoint(). The change also updates the PushMessagingService callbacks for subscribe() and getSubscription() to include the endpoint URL. The new callbacks provide the endpoint URL without using GetEndpoint(). Before this change, PushMessagingService::GetEndpoint() returned the absolute URL of the push service. content::PushMessagingManager created a subscription's endpoint URL by appending the subscription ID to the return value from PushMessagingService::GetEndpoint(). This scheme does not work for all push services. For example, Microsoft's push service may use a different domain for each subscription. Additionally, Microsoft's push service endpoints do not include the subscription ID. This change moves endpoint URL construction from endpoint URL construction from the content layer to the chrome layer enables Chromium embedders to replace GCM with another push service without updating the content layer. content: :PushMessagingManager to PushMessagingServiceImpl. Moving Change-Id: Ifb5ee1dc8455d1dcbc34c52c29bc40de7e97476a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704989Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#678443}
-