GitLab

Review URL: https://codereview.chromium.org/377293002

Cr-Commit-Position: refs/heads/master@{#291701}

This was generated by the following command line:

$ for f in $(g grep -l '"grit/ui_strings.h"' -- '*.cc' '*.mm' '*.h'); do
    sed -i -e 's/"grit\/ui_strings.h"/"ui\/strings\/grit\/ui_strings.h"/' $f;
  done
$ python ./tools/git/for-all-touched-files.py -c "./tools/sort-headers.py -f [[FILENAME]]"

BUG=401588
TEST=None
R=thestig@chromium.org,thakis@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/499163002

Cr-Commit-Position: refs/heads/master@{#291700}

R=jamesr@chromium.org, jamesr

Review URL: https://codereview.chromium.org/502493004

Cr-Commit-Position: refs/heads/master@{#291699}

Fixed various bugs, including exception on stacktrace and unnamed variable in git parser.
Changed the algorithm to use file_path only instead of file_name.
Removed URL links from the result.
Added commit message to the final result.
Updated OWNERS.

NOTRY=true

Review URL: https://codereview.chromium.org/478763003

Cr-Commit-Position: refs/heads/master@{#291698}

BUG=239656
TBR=asargent@chromium.org for app_view_browsertest.cc, app_view.js. I'm going to add myself to OWNERs in next patch.

Review URL: https://codereview.chromium.org/464213005

Cr-Commit-Position: refs/heads/master@{#291697}

BUG=none
R= mkearney@chromium.org, smain@chromium.org, binji@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Priority list copied here for reference:
P1 But written by different engineers, very uneven quality and voice.
P2 Some documentation could be expanded.
P0 The ramp-in for new users could be improved.
P0 The landing page isn't "cool", it doesn't make developers want to jump in and use it.
    Could we have a more github-like thing that gets people started quickly?
    Could we have a narrative intro?
    We just bought the pna.cl domain, we should use it!
P3 We think it's pretty important to keep the deep-dive in there (e.g. sandbox internals, bitcode reference).

Review URL: https://codereview.chromium.org/476793002

Cr-Commit-Position: refs/heads/master@{#291696}

Previously it would open the item then immediately minimize it. This caused
user confusion because they tried a double-click and didn't see anything
open on the screen.

BUG=404060
TEST=ash_unittests ShelfViewTest.ClickingTwiceActivatesOnce

Review URL: https://codereview.chromium.org/492963008

Cr-Commit-Position: refs/heads/master@{#291695}

NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/504443003

Cr-Commit-Position: refs/heads/master@{#291694}

BUG=406974
TBR=cmp
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/505813002

Cr-Commit-Position: refs/heads/master@{#291693}

These tests were originally made to cover http://crbug.com/398157.
Alas, that bug turned out to be very difficult to test since it does
not affect energy levels. That's what we use as a lightweight way to
detect whether audio is playing, but the bug managed to make audio stop
playing without affecting the levels. Still, I think the tests are
useful.

BUG=402860
R=perkj@chromium.org

Review URL: https://codereview.chromium.org/468243003

Cr-Commit-Position: refs/heads/master@{#291692}

The ARB needs updating to use git commit numbers rather than SVN revisions so trying to manually change DEPS.

BUG=
TBR=gavinp

Review URL: https://codereview.chromium.org/487363005

Cr-Commit-Position: refs/heads/master@{#291691}

Revert of DevTools: Removed refcounting from AndroidWebSocket (patchset #12 of https://codereview.chromium.org/449883002/)

Reason for revert:
There is a crash when port forwarding is turned off while there is at least one connected device.

BUG=407137

Original issue's description:
> DevTools: Removed refcounting from AndroidWebSocket
>
> Issue 387067 can be resolved by having port forwarding socket dependent on all other references to AndroidDeviceManager::Device.
>
> This requires for lifetime of AWS to be manageable in the first place.
>
> BUG=387067
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289306

Review URL: https://codereview.chromium.org/505783002

Cr-Commit-Position: refs/heads/master@{#291690}

git cl upload uses the tracking branch to diff against unless otherwise
specified. This change specifies the origin/master branch should be
used.

BUG=401180

Review URL: https://codereview.chromium.org/487433005

Cr-Commit-Position: refs/heads/master@{#291689}

This CL depends on the following CL to be landed first:
https://webrtc-codereview.appspot.com/15989004
with the addition that that WebRTC revision of it needs to be
be rolled into Chromium DEPS first.

BUG=webrtc:3441
TEST=See https://webrtc-codereview.appspot.com/15989004 for details.

Review URL: https://codereview.chromium.org/321313006

Cr-Commit-Position: refs/heads/master@{#291688}

BUG=

Review URL: https://codereview.chromium.org/465363003

Cr-Commit-Position: refs/heads/master@{#291687}

This CL is one part of the effort to change chrome to use gaiaid instead of
email address as the unique id for an account.

BUG=341408

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291263

Review URL: https://codereview.chromium.org/425823002

Cr-Commit-Position: refs/heads/master@{#291686}

BUG=none

Review URL: https://codereview.chromium.org/502023002

Cr-Commit-Position: refs/heads/master@{#291685}

This reverts commit 94c1ddb7.
The CL is making bots fail in a non consistent way.

BUG=None
TBR=pauljensen@chromium.org
NOTRY=TRUE

Review URL: https://codereview.chromium.org/506593002

Cr-Commit-Position: refs/heads/master@{#291684}

Test WebRTC - Peerconnection_manual.js: throw new Error line prevented rest of function from being executed.

BUG=None

Review URL: https://codereview.chromium.org/504753002

Cr-Commit-Position: refs/heads/master@{#291683}

Revert of Implement unit test specific test launcher timeout (patchset #6 of https://codereview.chromium.org/476543004/)

Reason for revert:
Multiple tests are timing out on dbg bots.

Original issue's description:
> Implement unit test specific test launcher timeout
>
> BUG=402213

TBR=jam@chromium.org,dalecurtis@chromium.org,rileya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402213

Review URL: https://codereview.chromium.org/504813003

Cr-Commit-Position: refs/heads/master@{#291682}

The CL changes most compile-time checks to be runtime-checks so that
an iossim binary built agains Xcode 6 will still work against Xcode 5.

BUG=None

Review URL: https://codereview.chromium.org/494583004

Cr-Commit-Position: refs/heads/master@{#291681}

For non-CrOS, compiler gives warning regarding unused functions.

BUG=NONE

Review URL: https://codereview.chromium.org/504723003

Cr-Commit-Position: refs/heads/master@{#291680}

I think the older order could result in incorrect behavior if Chrome
crashed during startup. This might help with the bug as well.

BUG=406475

Review URL: https://codereview.chromium.org/500563002

Cr-Commit-Position: refs/heads/master@{#291679}

BUG=404340

Review URL: https://codereview.chromium.org/487253003

Cr-Commit-Position: refs/heads/master@{#291678}

BUG=294431
TBR=miu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/488743003

Cr-Commit-Position: refs/heads/master@{#291677}

This one contains the required API changes to include service workers in remote debugging.
For now service workers will show up as "untitled" as they do not have a title to speak of.

Split off https://codereview.chromium.org/349033009/

BUG=389454
TBR= mnaganov@chromium.org (android_webview/native/aw_dev_tools_server.cc)

Review URL: https://codereview.chromium.org/459403002

Cr-Commit-Position: refs/heads/master@{#291676}

BUG=394303

Review URL: https://codereview.chromium.org/479123003

Cr-Commit-Position: refs/heads/master@{#291675}

Cr-Commit-Position: refs/heads/master@{#291674}

BUG=402213
R=dalecurtis@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/476543004

Cr-Commit-Position: refs/heads/master@{#291673}

The HTTP POST |agent| parameter sent with a DeviceManagementRequest is
limited to 64 characters. After the git migration, Chrome includes its
git revision in the |agent|, making it longer than 64 characters.

This CL removes the arbitrary 64 character limit. This solution should be
considered temporary, until we have verified that the DMServer can handle
|agents| longer than 64 characters. If not, we will restore this limit and
change the construction of the string so that it never exceeds 64
characters.

BUG=406948
TEST=Browser tests no longer fail when the |agent| string is too long

Review URL: https://codereview.chromium.org/500013002

Cr-Commit-Position: refs/heads/master@{#291672}

Revert of Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again. (patchset #2 of https://codereview.chromium.org/254713004/)

Reason for revert:
Still failing:

http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/52254/steps/content_browsertests/logs/CanMakeEmptyCallThenAddStreamsAndRenegotiate

Original issue's description:
> Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again.
> The underalying problem is now fixed. See http://crbug/293125 and  https://code.google.com/p/webrtc/source/detail?r=5870
>
> BUG=293125, 362431
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b9a00c2caf679dfd2e97a3d6bbfd5e214609e1fc
TBR=perkj
NOTRY=true

Review URL: https://codereview.chromium.org/500963002

Cr-Commit-Position: refs/heads/master@{#291671}

BUG=317998
TEST=manually

Review URL: https://codereview.chromium.org/476913003

Cr-Commit-Position: refs/heads/master@{#291670}

TBR=rsesek

BUG=407066

Review URL: https://codereview.chromium.org/498193002

Cr-Commit-Position: refs/heads/master@{#291669}

ProcessSingletonPosixTest.NotifyOtherProcessDifferingHost
ProcessSingletonPosixTest.NotifyOtherProcessFailure
ProcessSingletonPosixTest.NotifyOtherProcessOrCreate_DifferingHost

TBR=mattm

BUG=407065

Review URL: https://codereview.chromium.org/504783002

Cr-Commit-Position: refs/heads/master@{#291668}

BUG=328847

Review URL: https://codereview.chromium.org/441683002

Cr-Commit-Position: refs/heads/master@{#291667}

BUG=chromium:404093

Review URL: https://codereview.chromium.org/492343003

Cr-Commit-Position: refs/heads/master@{#291666}

BUG=chromium:404093

Review URL: https://codereview.chromium.org/497063002

Cr-Commit-Position: refs/heads/master@{#291665}

TBR=haruki

BUG=407063

Review URL: https://codereview.chromium.org/501953002

Cr-Commit-Position: refs/heads/master@{#291664}

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/494213003

Cr-Commit-Position: refs/heads/master@{#291663}

Review URL: https://codereview.chromium.org/377293002

Cr-Commit-Position: refs/heads/master@{#291662}