GitLab

Before this CL, we don't check required member field when 'null' is
passed as a dictionary. Add the checks.

BUG=580531

Review URL: https://codereview.chromium.org/1631333003

Cr-Commit-Position: refs/heads/master@{#371743}

Step 7 in

https://html.spec.whatwg.org/multipage/embedded-content.html#processing-model

BUG=578125

Review URL: https://codereview.chromium.org/1631303002

Cr-Commit-Position: refs/heads/master@{#371742}

https://chromium.googlesource.com/chromium/src/+/a9c81551f

BUG=570611
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1641533002 .

Cr-Commit-Position: refs/heads/master@{#371741}

Classes outside of core/layout/ that need a reference to an InlineBox's
layoutObject must currently use the API-busting shim we've set up to
get a reference to a LineLayoutItem's underlying layoutObject.

Some references can simply be changed to lineLayoutItem() directly, where
the line layout API already provides access to the methods used.

There are no functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1629643002

Cr-Commit-Position: refs/heads/master@{#371740}

BUG=581131
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1634343002

Cr-Commit-Position: refs/heads/master@{#371739}

This is part of the ongoing refactoring to make clients use the line
layout API instead of poking at LayoutObjects directly.

No functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1624593003

Cr-Commit-Position: refs/heads/master@{#371738}

We weren't zeroing the allocated memory before filling
the buffer. Due to padding this means there could be
uninitialized bytes. Bad news. Fixed.

Should fix failures on memory bots:

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/7154

BUG=None
TBR=thestig@chromium.org,darin@chromium.org

Review URL: https://codereview.chromium.org/1641493002

Cr-Commit-Position: refs/heads/master@{#371737}

This adds a new AddServiceOverride method to ServiceRegistryImpl.
The purpose of this is to allow testing code to intercept remote
service connections and opaquely provide a mock implementation of
any service.

The new interface is also added to the ServiceRegistry's JS
bindings.

Review URL: https://codereview.chromium.org/1470153002

Cr-Commit-Position: refs/heads/master@{#371736}

Update the test resource to the golden file [1] and rebaseline the
test result.

[1] https://code.google.com/p/chromium/issues/detail?id=570150#c25

TBR=radu.velea@intel.com
BUG=537077,570150
NOTRY=true

Review URL: https://codereview.chromium.org/1638253002

Cr-Commit-Position: refs/heads/master@{#371735}

BUG=540864

Review URL: https://codereview.chromium.org/1638953002

Cr-Commit-Position: refs/heads/master@{#371734}

- ash::Shell::GetScreen()
- DisplayInfoProvider::GetActiveScreen()

Followup to https://codereview.chromium.org/1608733002/.

R=oshima@chromium.org, sky@chromium.org
BUG=558054

Review URL: https://codereview.chromium.org/1608053002

Cr-Commit-Position: refs/heads/master@{#371733}

https://chromium.googlesource.com/chromium/src/+/4f439fec8

BUG=579151
TBR=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1633403003 .

Cr-Commit-Position: refs/heads/master@{#371732}

There is no invalid value default, so the missing value default will
apply in that case too.
The 'Unknown' HTMLAreaElement::Shape enumeration value is no longer
needed, so remove it.

Also add support for the non-conforming <area shape> values:

 * 'circ'     (alias for 'circle')
 * 'polygon'  (alias for 'poly')
 * 'rectangle (alias for 'rect')

Because 'rect' (and hence 'rectangle') is the same as the missing
value default we don't need any explicit checks for these values.

https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape

BUG=578125

Review URL: https://codereview.chromium.org/1632133007

Cr-Commit-Position: refs/heads/master@{#371731}

https://chromium.googlesource.com/chromium/src/+/3e32a8e50

BUG=579365
TBR=samli@chromium.org

Review URL: https://codereview.chromium.org/1638243002 .

Cr-Commit-Position: refs/heads/master@{#371730}

https://chromium.googlesource.com/chromium/src/+/9dd810a16

BUG=516751
TBR=vmpstr@chromium.org

Review URL: https://codereview.chromium.org/1635423002 .

Cr-Commit-Position: refs/heads/master@{#371729}

Several android bots are failing v8.infinite_scrolling almost
consistently.

R=nednguyen,eakuefner,sullivan
BUG=579546
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect

Review URL: https://codereview.chromium.org/1638063002

Cr-Commit-Position: refs/heads/master@{#371728}

https://chromium.googlesource.com/chromium/src/+/5a4c04591

BUG=530095
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1637343002 .

Cr-Commit-Position: refs/heads/master@{#371727}

 - Stop passing the 'cr.webUIResponse' string from JS to C++ and again back to JS.
 - Restricting C++ response to JS to a single argument, since Promises
   can only be resolved with a single argument (this is also more consistent
   with Mojo-based communication).
 - Adding additional test cases.

BUG=580633

Review URL: https://codereview.chromium.org/1635673003

Cr-Commit-Position: refs/heads/master@{#371726}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e314e3752a98..5c7b38de6fd5

$ git log e314e3752..5c7b38de6 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1635383002

Cr-Commit-Position: refs/heads/master@{#371725}

Revert of Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes (patchset #2 id:20001 of https://codereview.chromium.org/1626163002/ )

Reason for revert:
Broke compile:
../../ui/accelerated_widget_mac/display_link_mac.cc:94:69: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
      CVDisplayLinkSetOutputCallback(display_link_, nullptr, nullptr);
                                                    ~~~~~~~         ^

Original issue's description:
> Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes
>
> The CVDisplayLink is tied to a ScopedTypeRef data member of DisplayLinkMac.
> However, there may be other references. Since there's no guarantee that
> ~DisplayLinkMac() will invoke the last CVDisplayLinkRelease(..) and clear
> the callback automatically, clear it explicitly in ~DisplayLinkMac.
>
> BUG=564780
>
> Committed: https://crrev.com/2286ddf0119516f7a93feaff4f8ce2edff8c4543
> Cr-Commit-Position: refs/heads/master@{#371648}

TBR=ccameron@chromium.org,tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=564780

Review URL: https://codereview.chromium.org/1637313002

Cr-Commit-Position: refs/heads/master@{#371724}

https://chromium.googlesource.com/chromium/src/+/38858c577

BUG=568196
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1641513002 .

Cr-Commit-Position: refs/heads/master@{#371723}

https://chromium.googlesource.com/chromium/src/+/4c58d12a8

BUG=570611
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1640603002 .

Cr-Commit-Position: refs/heads/master@{#371722}

This change ensures we don't add when we should be replacing
composited "points" animations when list lengths are mismatched.

BUG=530436

Review URL: https://codereview.chromium.org/1635363002

Cr-Commit-Position: refs/heads/master@{#371721}

BUG=n/a
TEST=n/a; no behavior change

Review URL: https://codereview.chromium.org/1634603003

Cr-Commit-Position: refs/heads/master@{#371720}

https://chromium.googlesource.com/chromium/src/+/99aaed809

BUG=569950
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1640593002 .

Cr-Commit-Position: refs/heads/master@{#371719}

Common practice is to call Handle{Open/Read/Write}Result() when
using the leveldb database. Those functions will close the db
upon error - invalidating any open iterators. These calling
functions use scoped_ptr's for iterators which, upon error,
would delete an invalid leveldb::Iterator instance.

ServiceWorkerDatabase::DeleteResourceRecords()
ServiceWorkerDatabase::DeleteUserDataForRegistration()
ServiceWorkerDatabase::GetAllRegistrations()
ServiceWorkerDatabase::GetOriginsWithForeignFetchRegistrations()
ServiceWorkerDatabase::GetOriginsWithRegistrations()
ServiceWorkerDatabase::GetRegistrationsForOrigin()
ServiceWorkerDatabase::ReadResourceIds()
ServiceWorkerDatabase::ReadResourceRecords()
ServiceWorkerDatabase::ReadUserDataForAllRegistrations()

BUG=579624

Review URL: https://codereview.chromium.org/1635223002

Cr-Commit-Position: refs/heads/master@{#371718}

https://chromium.googlesource.com/chromium/src/+/7003bed16

BUG=453040
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1638223002 .

Cr-Commit-Position: refs/heads/master@{#371717}

https://chromium.googlesource.com/chromium/src/+/19dc3bf7a

BUG=568559
TBR=yjaeseok@gmail.com

Review URL: https://codereview.chromium.org/1640073002 .

Cr-Commit-Position: refs/heads/master@{#371716}

Cr-Commit-Position: refs/heads/master@{#371715}

This CL updates the site engagement service's score value for user input
events. In order to maintain compatibility with current tests, old score
values that are used for testing have been hard coded into
SiteEngagementService.

BUG=464234

Review URL: https://codereview.chromium.org/1622413002

Cr-Commit-Position: refs/heads/master@{#371714}

https://chromium.googlesource.com/chromium/src/+/eec72142e

BUG=524134
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/1640063002 .

Cr-Commit-Position: refs/heads/master@{#371713}

leveldb iterators must be deleted before closing the database or
else a crash will ensue.

BUG=581474

Review URL: https://codereview.chromium.org/1639043002

Cr-Commit-Position: refs/heads/master@{#371712}

We do it in command buffer so it's duplicated validation.

BUG=570453
TEST=webgl_conformance
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/1639103002

Cr-Commit-Position: refs/heads/master@{#371711}

This allows <style> tags in HTML files to be checked for style guide
errors.

BUG=None

Review URL: https://codereview.chromium.org/1639863004

Cr-Commit-Position: refs/heads/master@{#371710}

This is part of my (apparently neverending) goal to get the battor agent
unit tests on the waterfall.

TBR=zhenw@chromium.org,nednguyen@google.com

Review URL: https://codereview.chromium.org/1634263004

Cr-Commit-Position: refs/heads/master@{#371709}

Having deprecated stylesheet links with unsupported MIME types in
https://codereview.chromium.org/1501393003, this patch removes the
capability, updates the affected tests, and removes the UseCounter and
deprecation warning.

This patch also updates the preload scanner to ensure that the resources
are not preloaded, and adds a test to check for this.

BUG=286682

Review URL: https://codereview.chromium.org/1623403002

Cr-Commit-Position: refs/heads/master@{#371708}

The only caller ResourceLoader::willFollowRedirect() has ASSERT on
redirectResponse. So, we can assert that it's not null here too.

BUG=none
R=mkwst

Review URL: https://codereview.chromium.org/1634943003

Cr-Commit-Position: refs/heads/master@{#371707}

These macros are defined such that trailing semicolons (or inner
semicolons) have no effect, and they are overwhealmingly used without
semicolons, as per the documentation in ipc_message_macros.h.

Review URL: https://codereview.chromium.org/1639713002

Cr-Commit-Position: refs/heads/master@{#371706}

BUG=576864
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1640483003

Cr-Commit-Position: refs/heads/master@{#371705}

process_->GetProcess() will fail in this case, so don't bother with these checks. In this case they don't matter because the GPU isn't being sandboxed anyway.

BUG=580921

Review URL: https://codereview.chromium.org/1638623002

Cr-Commit-Position: refs/heads/master@{#371704}