- 12 Sep, 2019 40 commits
-
-
Sorin Jianu authored
This reverts commit f4d9d461. Reason for revert: Breaks the linker tool chain on both Android build bots: [14630/20253] SOLINK ./libchrome__combined.so FAILED: libchrome__combined.so libchrome__combined.so.TOC lib.unstripped/libchrome__combined.so python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="../../third_party/android_ndk/toolch...(too long) Stack dump: 0. Program arguments: /b/s/w/ir/cache/builder/src/out/Debug/../../third_party/llvm-build/Release+Asserts/bin/ld.lld @/b/s/w/ir/tmp/t/response-0b11b7.txt #0 0x0000000000f77cdd (/b/s/w/ir/cache/builder/src/out/Debug/../../third_party/llvm-build/Release+Asserts/bin/ld.lld+0xf77cdd) clang: error: unable to execute command: Segmentation fault (core dumped) clang: error: linker command failed due to signal (use -v to see invocation) https://ci.chromium.org/p/chromium/builders/ci/Android%20arm%20Builder%20%28dbg%29/45400 https://ci.chromium.org/p/chromium/builders/ci/Android%20arm64%20Builder%20%28dbg%29/39610 Original change's description: > Modules: Add native library coverage to bundle smoke test > > - Add a new test case to exercise a native library. > > - Generalize the display of the result dialog for multiple test cases. > > - Specify a "pass" or "fail" in the results dialog text, to be parsed by > the test, and also aid in manual testing (where the test activity may > be spawned manually). > > - Component build coverage is stubbed out; it will be added once the > component build places feature libs in DFMs. > > Bug: 989646 > Change-Id: I724d0725f71ad7897ceb7b81d9fe7d22183889ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796308 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696035} TBR=cjgrant@chromium.org,tiborg@chromium.org,fredmello@chromium.org Change-Id: Iac48461564dac006d57e2fff7c4c705e21022149 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802083Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#696176}
-
Stephen Chenney authored
The new implementation of this feature does not cause tests to fail. Remove the flag preventing the feature from applying in tests. Specifically, input is only suppressed when main frame updates are deferred, and most tests do not defer main frame updates. Also remove the flag from WebView, though it does not enable the feature in WebView because WebView does not defer main frame updates. Leave the flag for Chrome Headless because there is no danger associated with early renderer input there. Bug: 987626 Change-Id: I1e7f348e022125fe69f26dd4687f20dda6a65dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789922Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#696175}
-
Xianzhu Wang authored
The down cast from FakePictureLayerImpl to FakePictureLayerImplWithRasterSource was bad. Now just use FakeLayerLayerImpl::Create with optional raster_source parameter. (Another way which may better conform to style guide is to define a constructor in FakePictureLayerImplWithRasterSource and call it from its Create(), but optional parameter seems fine in unit tests.) Bug: 1003448 Change-Id: Iedc63012aed446fc1901151f39149a458a17d35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800739Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696174}
-
Tarun Bansal authored
Remove usage of minimum site engagement threshold in hints fetcher only if the data saver top host blocklist was generated long time back. If the blocklist was generated long time back, we expect the hosts that did not make it to blocklist would be either navigated to or would be dropped off by the site engagement service. Change-Id: I97d19fb0c9a621e286b94a5e266ad0edb5238133 Bug: 1003432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800740Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#696173}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5bd596e325f5..65028a6d85f2 git log 5bd596e325f5..65028a6d85f2 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 rsavitski@google.com tmux & //tools fixups after build refactorings Created with: gclient setdep -r src/third_party/perfetto@65028a6d85f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2333398b8792fc2ebe2012af31aac5b5b1bae1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801926Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696172}
-
Daniel Rubery authored
base::Value expects string values to be valid UTF-8, but the SHA256 was being passed as raw bytes. Other reporting events hex encode before reporting to avoid this problem. Bug: 1003411 Change-Id: I71de40b009d5abf1c364842dad16273fd6b7213b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801058Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#696171}
-
Saman Sami authored
The condition used in the binary search was wrong. Fixed it and added a unit test. Bug: 1000868 Change-Id: Iaf4af1bdfdb88db1082bfae89a3783faed860934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800743 Auto-Submit: Saman Sami <samans@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#696170}
-
Gayane Petrosyan authored
Use currentTarget instead of target so get the element that the event listener is attached to. Bug: 1002802 Change-Id: I69fc6d73b70cdeb96a2668c00ec0df9a6b3f0450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799029Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#696169}
-
Sean Gilhuly authored
Bug: 972621, 954328 Change-Id: I53e4b31c0c3c29bba30c1508ed17ea3b0227f801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801922 Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits in //device/gamepad that still use the old mojo types for device::mojom::Gamepad{Monitor,GamepadHapticsManager} to the new mojo types. Bug: 955171 Change-Id: I49002d8012e6c26859e984049a443f0a1683a554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789540Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#696167}
-
Yao Xiao authored
Bug: 986780 Change-Id: I6389305a86801d16a31f5cde41d6feb4cc5c5052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797704Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#696166}
-
Maksim Ivanov authored
Remove from //google_apis the dead code related to Gaia V1 APIs. That code became clearly unused after after r658531 which deleted the V1-specific code from the OOBE/Login code. Bug: 961290 Change-Id: I2646ff9db8f02e56fac753e83a1079035f97a7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787505Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#696165}
-
Gayane Petrosyan authored
When users apply color but without confirming the selection, reload or navigate away from NTP by typing URL then we should revert to the last confirmed state. Bug: 1002431 Change-Id: I3fd61458e803e81e4ad7f9c5ca83ca7e302d83b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795493 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#696164}
-
Jenny Zhang authored
Bug: 999892 Change-Id: I71d579995c6fbd7177bf4730d94a9c4faa18290f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799309Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#696163}
-
kylechar authored
Ensure that browser process raster context has the same logic for when to use OOP-R if viz is enabled or disabled. This copies the logic from VizProcessTransportFactory into SharedWorkerContextProviderFactory. This change will only impact Chrome OS as it's the only platform that still uses the viz disabled path. Bug: 995885 Change-Id: I2d78052e4d515967496a054545b83e24c23592d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800308 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#696162}
-
Dale Curtis authored
We're still seeing a lot of flakiness on Linux browser tests. User bugs are showing some issues with the sandbox as well. Temporarily disable the sandbox on linux to see if flakiness improves, revert tomorrow otherwise. BUG=986021 Change-Id: Ifb06d9a0be52ef46dfb747a83c8c2830d74b1ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801248 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#696161}
-
Nico Weber authored
We've been shipping this for a long time and the referenced gyp file no longer exists, so things are probably ok as they are :) Bug: 622415 Change-Id: I738889d1f6cdbc8ac9391c6f55cee1038d4c82db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801894 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696160}
-
Owen Min authored
This also includes the requests that are discarded due to their size. Also update the way of calculating the estimated report size. Using incremental size for better result. Bug: 956237 Change-Id: I873cd5a0f5463e111da12fab98a50b8f1640ed0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799343Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#696159}
-
danakj authored
The CHECK no longer guards a use of the screen, so can go away. R=halliwell@chromium.org Bug: 998273 Change-Id: I24bba7b87d5bbf8fc872eb7bf35c4f78b9c664ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801740Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#696158}
-
Khushal authored
The currently committed expected file actually marks the test as failing while switching to CanvasResourceProviderSharedImage fixes this test. Temporarily marking this test as failing to allow the skia change which enables shared images to roll in. After that a new baselines for the passing test will be committed. R=fserb@chromium.org Bug: 900706 Change-Id: Ica8dd394d01e30ce51256ea036f77847d8691730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802018 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#696157}
-
Sorin Jianu authored
This reverts commit 1102f12d. Reason for revert: it is breaking stuff on several Mac bots. [E2019-09-12T12:28:01.848585-07:00 31162 0 annotate.go:241] goroutine 1: [E2019-09-12T12:28:01.848653-07:00 31162 0 annotate.go:241] #0 go.chromium.org/luci/vpython/python/find.go:93 - python.Find() [E2019-09-12T12:28:01.848672-07:00 31162 0 annotate.go:241] annotation #0: [E2019-09-12T12:28:01.848683-07:00 31162 0 annotate.go:241] reason: no Python found [E2019-09-12T12:28:01.848692-07:00 31162 0 annotate.go:241] annotation #1: [E2019-09-12T12:28:01.848701-07:00 31162 0 annotate.go:241] reason: could not find appropriate executable for: "python3.8" [E2019-09-12T12:28:01.848709-07:00 31162 0 annotate.go:241] annotation #2: [E2019-09-12T12:28:01.848725-07:00 31162 0 annotate.go:241] reason: could not find target in system [E2019-09-12T12:28:01.848739-07:00 31162 0 annotate.go:241] internal reason: target(python3.8)/dirs([/b/s/w/ir/.swarming_module /b/s/w/ir/.swarming_module/cpython/bin /b/s/w/ir/.swarming_module/cpython3/bin /b/s/cipd_cache/bin /opt/local/bin /opt/local/sbin /usr/local/sbin /usr/local/git/bin /usr/local/bin /usr/sbin /usr/bin /sbin /bin]) [E2019-09-12T12:28:01.848764-07:00 31162 0 annotate.go:241] [E2019-09-12T12:28:01.848774-07:00 31162 0 annotate.go:241] #1 go.chromium.org/luci/vpython/venv/config.go:272 - venv.(*Config).resolvePythonInterpreter() [E2019-09-12T12:28:01.848785-07:00 31162 0 annotate.go:241] reason: could not find Python for: 3.8.0 [E2019-09-12T12:28:01.848799-07:00 31162 0 annotate.go:241] [E2019-09-12T12:28:01.848808-07:00 31162 0 annotate.go:241] #2 go.chromium.org/luci/vpython/venv/config.go:187 - venv.(*Config).makeEnv() [E2019-09-12T12:28:01.848822-07:00 31162 0 annotate.go:241] reason: failed to resolve system Python interpreter Original change's description: > Make test_env.py compatible w/ Python 3 > > Makes test_env.py compatible with both Python 2 and 3. Also adds a very > simple test to ensure that it remains compatible until some other test > switches to Python 3. > > As a side effect of adding the test, also makes > testing/scripts/common.py compatible with Python 3 since it's > necessary for running isolated scripts. > > Bug: 898348 > Change-Id: Ib58cf4c4f85df60a432764d7f744bc3fee09ae3a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796525 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695825} TBR=dpranke@chromium.org,bsheedy@chromium.org Change-Id: I80fb04b1a224db48b53865e871f39b6364a785b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802095Reviewed-by:
-
Robert Sesek authored
This is to have the fieldtrial_testing_config.json study name match the Finch trial name. Bug: 915910 Change-Id: I994e5cc877c3eed6ddf2c94a58086b209103274a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801270Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#696155}
-
Katie Dillon authored
Bug: 986526 Change-Id: Ie564436b2a1b36e2bffccb10f6c909a67e5e34c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800742Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/60f970aa1987..08fcdc74f15c git log 60f970aa1987..08fcdc74f15c --date=short --no-merges --format='%ad %ae %s' 2019-09-12 dburger@chromium.org Temporarily disable BinhostTest in master-paladin. Created with: gclient setdep -r src/third_party/chromite@08fcdc74f15c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I86d5594da4ee6a73cb1dcde7f50def2f82b1685f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801465Reviewed-by:
-
Maksim Ivanov authored
Make sure that there's an accessible title that is read when the security token PIN dialog appears during challenge-response user authentication via SAML (a.k.a. smart card user login). Implementation details: 1. Provide Aria labels for the <oobe-dialog> that point to the DOM elements containing the dialog title and subtitle. 2. Autofocus the PIN input field. (For some reason, without that the Aria labels are ignored by ChromeVox. Also autofocusing is a UX improvement anyway.) Bug: 1001612 Test: enable ChromeVox on a test Chromebook, start SAML user sign-in using a smart card, check that when the PIN dialog appears the dialog title is read Change-Id: If1fa93484965e5db6ef4cbd438a6f1af709bdc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789148Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#696152}
-
Lei Zhang authored
chrome_pdf::InitializeSDK() always returns true. So remove code that assume otherwise. Change-Id: I2585e006e87b906795b0b1f201be78106871d9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801249Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#696151}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4fdeb8d28d9c..1439b6d5dc24 git log 4fdeb8d28d9c..1439b6d5dc24 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 laurie.hedge@imgtec.com Vulkan: Fix integer overflow for max per stage and combined uniform buffers. Created with: gclient setdep -r src/third_party/angle@1439b6d5dc24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I4fb5ec43206bc7c01c41be2fae8d9d6958f13bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801794Reviewed-by:
-
Zhenyao Mo authored
They are: conformance/extensions/oes-texture-half-float-with-video.html conformance/extensions/oes-texture-float-with-video.html Before they were marked as flaky, now they fail consistently on Nexus 9. BUG=891456,1003489 TEST=bot TBR=kbr@chromium.org NOTRY=true Change-Id: Idef038977f8a6739f50139da676ea92109e4b086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801501 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#696149}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 236a9cdc. With Chromium commits locally applied on WPT: 20133397 "[sensor] Upstream sensor layout tests to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I8bd051b5c75952b8d2dbc1ba24a52fad590d58b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801453Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696148}
-
Robert Ogden authored
The server team is making a couple of changes, reflected here: * changes path from /sr to /i * removes t query param Change-Id: Ia7c79cf2f6b8cec7192566b9ee3d9fc1674efa0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799468Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#696147}
-
liberato@chromium.org authored
MaybeRenderEarlyManager tried to remove images from the wrong codec group in some cases, leaving the right group with a raw pointer to the CodecImage, and no way to remove it. This can be simplified, but this is a small text change to permit merge back to beta. Bug: 986783 Change-Id: I3643cd0b847250157b0ce2162c176f0113975bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801330Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#696146}
-
Ahmed Fakhry authored
https://dawn.googlesource.com/dawn.git/+log/f35dcfe60a62..785ec66b66a3 $ git log f35dcfe60..785ec66b6 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 cwallez BUILD.gn: Correctly skip GLFW on ChromeOS 2019-09-12 digit [fuchsia]: Fix Fuchsia build. 2019-09-11 natlee Use clear loadop to lazy clear depth stencil attachments 2019-09-11 cwallez BUILD.gn: Only expose the GLFW target on platforms that support it 2019-09-11 hao.x.li Set point size value for vertex shader in OptionalVertexInputTest 2019-09-11 hao.x.li Skip some end2end tests for Vulkan validation layers enable on Windows 2019-09-11 rafael.cintron Cleanup d3d12::Device::ExecuteCommandLists Created with: roll-dep src/third_party/dawn R=oshima@chromium.org, cwallez@chromium.org, vapier@chromium.org BUG=1002895 Change-Id: I4f222ae847775d23a90ec5a901fa1345bc34f995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800738Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#696145}
-
Daksh Idnani authored
This change makes backgrounded WebGL contexts release use of the high-performance GPU. In particular, the context notifies the DualGPUState object that it no longer needs a discrete pixelformat object to ensure that the discrete GPU is active. Bug: 681341 Change-Id: Ic7978841161a72a2dbc9c3cb01cbe763acb950ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794263Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daksh Idnani <dakshidnani@google.com> Cr-Commit-Position: refs/heads/master@{#696144}
-
Ilia Samsonov authored
Tests flake due to RunLoop().RunUntilIdle() exiting before preferences are set. Using TaskEnvironment seems to resolve this issue. Bug: 1003178 Change-Id: Ifd84dcc2f36e8d7e19c6170aa74046e11c873e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799127 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#696143}
-
Emircan Uysaler authored
This CL aligns Chrome code with Fuchsia's updated vulkan swapchain extension that now requires ImagePipe2 interface. This should land along with https://fuchsia-review.googlesource.com/c/fuchsia/+/315288. Bug: 982922 Change-Id: Icbe0fc4d947c5ba52e769136e1f2a7b9605d8f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789851Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#696142}
-
Zhenyao Mo authored
This is replaced by disbaling them on Linux in: https://chromium-review.googlesource.com/c/chromium/src/+/1798984 Disabling on Linux is reverted in: https://chromium-review.googlesource.com/c/chromium/src/+/1801053 However, we still need to add back Linux ASAN BUG=771119,1003176 TEST=bots TBR=kbr@chromium.org Change-Id: I89383f22def3ac234acec68dd046c7d5b148cac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801919Reviewed-by:
-
Andrii Shyshkalov authored
TEST: $ git cl try -B luci.chromium.try -b linux_upload_clang -b mac_upload_clang -b win_upload_clang -r 001fe5f6 Tried jobs on: Bucket: luci.chromium.try linux_upload_clang: [] mac_upload_clang: [] win_upload_clang: [] To see results here, run: git cl try-results To see results in browser, run: git cl web $ git cl try-results Scheduled: linux_upload_clang id=8902494487098015248 mac_upload_clang id=8902494452269498288 win_upload_clang id=8902494452269498272 Bug: 1001522 Change-Id: Ifb37d81b883575e8575f6cdc7cb5f8b8c6a0dda7 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801923 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696140}
-
khmel@chromium.org authored
This is required to support: http://crrev.com/i/1697948. TEST=In context of that tast test, unit-test added. BUG=b:139956117 Change-Id: Ief15939ac1b0fcd3bd8617e947d6ab65f7fbea18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773322 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#696139}
-
Adam Langley authored
A caBLE v2 device won't have to scan a QR code _every_ time its used. Rather, a subsequent change will add a handshake mode based on saved secrets. Therefore this change alters the v2 handshake to accommodate this. v2 EIDs are now generated by encrypting an 8-byte nonce with 8 zero bytes using AES-256. The Noise PSK is generated by deriving a per-handshake PSK from a PSK generating key using HKDF and that same nonce. In a non-QR handshake, those generating keys will be known by the browser. In a QR handshake, they are derived from the secret in the QR code using HKDF. Bug: 1002262 Change-Id: Iaddfe0bf16053f53867d20f772d5080e54926793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786004Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#696138}
-
Peter Kasting authored
Bug: 23697 Change-Id: I5219d261192b9428aaf93b9994ca865950c3584a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793721 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#696137}
-
