- 21 Sep, 2016 19 commits
-
-
chrishtr authored
Previously, the layout tree and pixel dump could happen while the lifecycle was dirty. Review-Url: https://codereview.chromium.org/2352813004 Cr-Commit-Position: refs/heads/master@{#419919}
-
donnd authored
Decodes the results from the Contextual Cards section of the response to set caption and thumbnail. BUG=647041 Review-Url: https://codereview.chromium.org/2351283002 Cr-Commit-Position: refs/heads/master@{#419918}
-
ssid authored
The trace event filters for each category were stored as a list and the objects were destroyed when tracing ends. But, when destroying these filters the trace events on other thread which have checked the ENABLED_FOR_FILTERING flag will try to access the filters list at the same time. This CL: 1. Makes the filters enabled for categories a bitmap and restricts the number of filters that can be added in Chrome to 32 across all tracing sessions in a single browsing session. This removes the need for creation for filters for each category group. 2. Keeps all the filters alive till next tracing session starts since it is not possible to determine when the trace events have finished accessing the filter and it gives enough time for all the threads to complete acessing the filter. 3. Stores a global vector of all filters with max size 32 to access all the enabled filters for a trace category (corresponding to the bitmap flag) quickly. This CL also fixes another issue where the trace events from V8 and Skia were not recorded by EndEvent calls in filters. This is because the EndFilter was called by trace_event.h. This call is now moved to UpdateDuration, and end of all the events will now be recorded in filters. BUG=625170 Review-Url: https://codereview.chromium.org/2316403002 Cr-Commit-Position: refs/heads/master@{#419917}
-
tommycli authored
Detects (and suprresses) Flash downloads initiated via clicks to links with target=_blank and JavaScript window.open(). This also suppresses the new window from appearing. Middle-click and context-menu-open-in-new-window remain unaffected. BUG=641619 Review-Url: https://codereview.chromium.org/2344293002 Cr-Commit-Position: refs/heads/master@{#419916}
-
mcasas authored
This CL implements VideoCaptureDevice::TakePhoto() for Windows DirectShow (which is essentially used for all Windows re. video capture). For that, the V4L2CaptureDelegate::GetPhotoBlob() is factored out into media/capture/video/blob_utils.{cc,h}, and renamed to Blobify(). BUG=648490 TEST=Enabled VideoCaptureDeviceTest::TakePhoto in Win. All other ImageCapture related tests still passing. Review-Url: https://codereview.chromium.org/2354783002 Cr-Commit-Position: refs/heads/master@{#419915} -
luoe authored
Currently, a ConsoleViewMessage's element() returns a wrapper whose only children are nesting level marker div's and a contentElement() with the actual message. This CL extracts the repeatCountElement, shown for repeated messages, out of the contentElement(). By doing so, we isolate the actual message content. BUG= Review-Url: https://codereview.chromium.org/2349973005 Cr-Commit-Position: refs/heads/master@{#419914}
-
luoe authored
Adds a new section to the user agent override preset list. Sources for user agents: https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/browser-name/uc-browser-user-agents http://www.webapps-online.com/online-tools/user-agent-strings/dv/browser212364/uc-browser BUG=646360 Review-Url: https://codereview.chromium.org/2356593002 Cr-Commit-Position: refs/heads/master@{#419913}
-
watk authored
These have been disabled for a long time. Now that the unified media pipeline is enabled, they should be much more reliable. BUG=582293 Review-Url: https://codereview.chromium.org/2346963004 Cr-Commit-Position: refs/heads/master@{#419912}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/87d7635e7c15..9f0befafcd15 $ git log 87d7635e7..9f0befafc --date=short --no-merges --format='%ad %ae %s' 2016-09-20 sullivan Revert of Add request-level caching for privileged queries. (patchset #5 id:80001 of https://codereview.chromium.org/2350113002/ ) 2016-09-20 benjhayden Move value-set-table.organizeValues() to ValueSet.groupHistogramsRecursively CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2356063002 Cr-Commit-Position: refs/heads/master@{#419911}
-
luoe authored
Some inspector LayoutTests were using ConsoleViewMessage.toString() to check that a message included a substring. Most of the function logic was not necessary and some cases could be replaced with the .text getter. BUG= Review-Url: https://codereview.chromium.org/2348583004 Cr-Commit-Position: refs/heads/master@{#419910}
-
sky authored
Chrome may end up using ScreenDimmer in such a way that the ScreenDimmer is destroyed after the shell. This change makes ~ScreenDimmer deal with the shell having been destroyed so that it doesn't crash. BUG=648723 TEST=covered by test R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2359633003 Cr-Commit-Position: refs/heads/master@{#419909}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/acf3233d..f9a47d47 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2352133002 Cr-Commit-Position: refs/heads/master@{#419908}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/65b8cb05a756..e918417dc34c $ git log 65b8cb05a..e918417dc --date=short --no-merges --format='%ad %ae %s' 2016-09-20 fmalita Revert of Stop closing filled paths in GrShape (patchset #1 id:1 of https://codereview.chromium.org/2355833002/ ) 2016-09-20 borenet Revert of [SVGDom] Opacity optimization (patchset #4 id:60001 of https://codereview.chromium.org/2353503005/ ) 2016-09-20 mtklein GN: add skia_use_mesa for OSMesa in tools. 2016-09-20 borenet Attempt to fix nanobench upload 2016-09-20 stani Revert of Clear stencil buffer before using it for drawing (patchset #2 id:20001 of https://codereview.chromium.org/2342873004/ ) CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=borenet@google.com Review-Url: https://codereview.chromium.org/2354873005 Cr-Commit-Position: refs/heads/master@{#419907}
-
fgorski authored
BUG=645522 Review-Url: https://codereview.chromium.org/2352073003 Cr-Commit-Position: refs/heads/master@{#419906}
-
dpranke authored
In order to roll GN 6a1c8d41..65f3a42b (r419720:r419871) and pick up the following changes: 385a310b Fix an issue in `gn analyze` when building all. TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2354123002 Cr-Commit-Position: refs/heads/master@{#419905}
-
skvlad authored
https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/4ce5badc8..7f9228152 Includes a fix for a possible cause of a WebRTC crash. $ git log 4ce5badc8..7f9228152 --date=short --no-merges --format='%ad %ae %s' 2016-08-26 tuexen Sync with sctp-idata. 2016-08-24 tuexen Sync FBSDID. 2016-08-23 tuexen When aborting, send the ABORT before the notif. 2016-08-23 tuexen Try to silence a warning. 2016-08-22 tuexen Sync with SCTP El Capitan. 2016-08-22 tuexen Sync with sctp-idata. 2016-08-20 tuexen Sync with ElCaptian. 2016-08-15 tuexen Ensure that sctp_it_ctl.cur_it does not point to a free object (during a small time window). Thanks to Byron Campen for reporting the issue and suggesting a fix. It is managed in https://bugzilla.mozilla.org/show_bug.cgi?id=1293347 BUG=b/29509732 Review-Url: https://codereview.chromium.org/2352673005 Cr-Commit-Position: refs/heads/master@{#419904}
-
alph authored
BUG=406277 Review-Url: https://codereview.chromium.org/2349563002 Cr-Commit-Position: refs/heads/master@{#419903}
-
pfeldman authored
BUG=641390 TBR= follow-up to change in the API. Review-Url: https://codereview.chromium.org/2356883002 Cr-Commit-Position: refs/heads/master@{#419902}
-
gogerald authored
BUG=646612 Review-Url: https://codereview.chromium.org/2348983002 Cr-Commit-Position: refs/heads/master@{#419901}
-
- 20 Sep, 2016 21 commits
-
-
yusukes authored
to prevent the disambig window from being shown when it shouldn't be. BUG=640393 TEST=see repro steps in b/31043273 TEST=try Review-Url: https://codereview.chromium.org/2277533002 Cr-Commit-Position: refs/heads/master@{#419900}
-
alexmos authored
The intent of the fallback to top()->document().url() in GetOriginOrURL() is to support file path matching for content setting exceptions in pages loaded from a file: scheme. This fallback can cause crashes in OOPIF modes when the top frame is remote, even in cases that have nothing to do with file: exceptions, such as a sandboxed main frame (which has a "null" origin) embedding an OOPIF. Longer-term, local and remote frames should be treated the same way for content settings exceptions for the file: scheme; and content settings will be refactored to be based on origins rather than GURLs in issue 621724. In the short term though, avoid the crash by falling back to document->url() only for local top frames. This shouldn't actually affect file exceptions, as --isolate-extensions, which is the only OOPIF mode currently enabled by default on trunk, won't put subframes inside file: pages into a separate process. BUG=628759, 466297 Review-Url: https://codereview.chromium.org/2354083002 Cr-Commit-Position: refs/heads/master@{#419899}
-
rickyz authored
BUG=None Review-Url: https://codereview.chromium.org/2349353004 Cr-Commit-Position: refs/heads/master@{#419898}
-
wangxianzhu authored
Previously blink's trace_event was implemented in the way to make blink a standalone library: TRACE_EVENT macros -> TRACE_EVENT internal macros -> EventTracer -> Chromium's trace event C++ API Now blink is no longer a standalone library, so we can use chromium's trace_event macros directly. This CL - removes blink's trace_event implementation - lets blink's TraceEvent.h include chromium's trace_event.h, - lets blink's TracedValue implement ConvertableToTraceFormat, - keeps support of blink CString type as trace values. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2341333003 Cr-Commit-Position: refs/heads/master@{#419897}
-
bsheedy authored
CL containing tests is at https://codereview.chromium.org/2335643002/ BUG= Review-Url: https://codereview.chromium.org/2356983002 Cr-Commit-Position: refs/heads/master@{#419896}
-
jinsukkim authored
Ensure container is attached to Window when acquiring an anchor view. BUG=646320 Review-Url: https://codereview.chromium.org/2346183002 Cr-Commit-Position: refs/heads/master@{#419895}
-
brettw authored
This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2353463003 Cr-Commit-Position: refs/heads/master@{#419894}
-
donnd authored
Updates unit tests for FieldTrial (which were misspelled FieldTrail). BUG= Review-Url: https://codereview.chromium.org/2351903004 Cr-Commit-Position: refs/heads/master@{#419893}
-
skym authored
BUG=634388 Review-Url: https://codereview.chromium.org/2342353004 Cr-Commit-Position: refs/heads/master@{#419892}
-
sadrul authored
Turn on sandbox for mojo apps by default. Apps that need to run without a sandbox need to include 'shell:unsandboxed' in their capabilities in manifest for mojo:shell. Update manifests for mojo:ui, mojo:font_service, mojo:file_system, and mojo:leveldb services to include 'shell:unsandboxed'. BUG=645602, 646376 Review-Url: https://codereview.chromium.org/2338793003 Cr-Commit-Position: refs/heads/master@{#419891}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/f5ff44ae7 BUG=644059 TBR=bsep@chromium.org Review URL: https://codereview.chromium.org/2355973003 . Cr-Commit-Position: refs/heads/master@{#419890}
-
manzagop authored
BUG=648185 Review-Url: https://codereview.chromium.org/2351533004 Cr-Commit-Position: refs/heads/master@{#419889}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cc78bd596aa7..87d7635e7c15 $ git log cc78bd596..87d7635e7 --date=short --no-merges --format='%ad %ae %s' 2016-09-20 alexandermont Add in power metric for video playback. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2352113003 Cr-Commit-Position: refs/heads/master@{#419888}
-
finnur authored
The |category| sent down will never be ALL_SITES, but it should also be notified of changes. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2351153002 Cr-Commit-Position: refs/heads/master@{#419887}
-
sammc authored
BUG=634568, 637174 Review-Url: https://codereview.chromium.org/2217813003 Cr-Commit-Position: refs/heads/master@{#419886}
-
kylechar authored
Adds a builder for FakeDisplaySnapshot to allow us to easily construct the display snapshots. Will update more tests to use this functionality in a follow up CL. Update platform_screen_ozone_unittests.cc to use FakeDisplaySnapshot instead of DisplaySnapshotVirtual. Update --screen-config to take display DPI and able to start without any initial displays. BUG=611475 Review-Url: https://codereview.chromium.org/2340383002 Cr-Commit-Position: refs/heads/master@{#419885}
-
dmazzoni authored
BUG=644758 Review-Url: https://codereview.chromium.org/2352213002 Cr-Commit-Position: refs/heads/master@{#419884}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/cee7475ca3ab8eba9c9760cdf086cc7c703df15c [Bisect] Account for tir_label-level summaries in parse_metric (eakuefner@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=644865 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2354113002 Cr-Commit-Position: refs/heads/master@{#419883}
-
jwd authored
This DCHECK is very easy to trigger by developers, googlers specifically, without actually violating the intent of the DCHECK. BUG=648594 Review-Url: https://codereview.chromium.org/2353133003 Cr-Commit-Position: refs/heads/master@{#419882}
-
grt authored
We can't have chrome.exe depending on browser code since doing so can unexpectedly cause the size of chrome.exe to bloat. This change accomplishes the breakage by passing the main exe entry TimeTicks through to chrome.dll directly by way of ChromeMain and ChromeMainDelegate rather than via an environment variable. BUG=647223 R=brucedawson@chromium.org Review-Url: https://codereview.chromium.org/2345933002 Cr-Commit-Position: refs/heads/master@{#419881}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/5a399de2945d..60e903c33480 $ git log 5a399de29..60e903c33 --date=short --no-merges --format='%ad %ae %s' 2016-09-20 npm Change protected to private in CPDF_CID2UnicodeMap and CPDF_ToUnicodeMap 2016-09-20 npm Delete unused methods and variables in CPDF_CMapManager and in CPDF_CMapParser 2016-09-20 npm Delete unused GetBitMap() in fx_agg_driver TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2359633002 Cr-Commit-Position: refs/heads/master@{#419880}
-