- 24 Apr, 2018 40 commits
-
-
Hans Wennborg authored
The test fails in official builds (see bug). Probably this is due to fieldtrial_testing_config.json not affecting official builds, and so the feature needs to be explicitly enabled in the test fixture, perhaps similarly to https://crrev.com/452026 Bug: 834010 Change-Id: If0909e90d03f05596cc44f3a1022a0f5eca66762 Reviewed-on: https://chromium-review.googlesource.com/1026113Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#553173}
-
arthursonzogni authored
Removes usages of the stream for loading the main resource response in the renderer process. Other CLs: 1) https://chromium-review.googlesource.com/c/chromium/src/+/1015005 * 2) https://chromium-review.googlesource.com/c/chromium/src/+/1021631 3) https://chromium-review.googlesource.com/c/chromium/src/+/1022790 4) https://chromium-review.googlesource.com/c/chromium/src/+/1024038 Bug: 705744 Change-Id: I2fa52775d24f12d16c71f615f0c9d7618d1edb1e Reviewed-on: https://chromium-review.googlesource.com/1021631 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553172}
-
Elly Fong-Jones authored
The listed test suites appear most frequently in the immediate history of bots prior to windowserver deaths. See the linked bug for details. Bug: 828031 Change-Id: I0f8a4937fff23a94a628493331dc51191de5b072 Reviewed-on: https://chromium-review.googlesource.com/1025638 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#553171}
-
Greg Daniel authored
In skia, getTextureHandle is deprecated and this change moves to using the new API. Change-Id: I69b507744e21187cfa9da74a960e5394acb2b524 Reviewed-on: https://chromium-review.googlesource.com/1024370Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553170}
-
Xida Chen authored
TBR=thestig@chromium.org NOTRY=true Bug: 836295 Change-Id: Ie96425b623849d7ca24bfba40b472605be01903f Reviewed-on: https://chromium-review.googlesource.com/1026158Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553169}
-
Jan Krcal authored
This CL splits the part of the Bridge's interface that is used by ModelTypeController into a separate Delegate interface. For the reasons of a smooth transition for follow-up CLs, the Bridge inherits from this new Delegate. In the future, we will make the Processor extend this new interface instead of the Bridge. Bug: 819993 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ieacafd872a16f2f587965c1710c6abacb3517efc Reviewed-on: https://chromium-review.googlesource.com/1007134Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#553168}
-
Greg Daniel authored
In skia, getTextureHandle is deprecated and this change moves to using the new API. TBR=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8885909baff92c6c4e68a2ad859604e4928a2255 Reviewed-on: https://chromium-review.googlesource.com/1024291Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553167}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=olka@chromium.org Bug: 825327 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I296b69513d2205d1cba2d75d6a89891ec60a5b38 Reviewed-on: https://chromium-review.googlesource.com/1024249Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553166}
-
Xida Chen authored
TBR=thestig@chromium.org NOTRY=true Bug: 836289 Change-Id: I669edb4d3ec8af8e144e5fac812ed0b1422e5e55 Reviewed-on: https://chromium-review.googlesource.com/1026155 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553165}
-
Erik Chen authored
Previously, we checked that at least 1 renderer exists and that all renderers are being profiled. This recently started causing the tests to flake. I suspect this is related to warm-up/spare renderers. So instead, we check that at least 1 renderer exists and is being profiled. Bug: 835826, 833590 Change-Id: I45ef8e1ad9ba1689ae3f0292ab80306b9d7a731f Reviewed-on: https://chromium-review.googlesource.com/1023716Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553164}
-
Edward Jung authored
Makes the string consistent with other Google products. Bug: 836214 Change-Id: I28a3fa35be8c29960b93eed208acd934a4eb4787 Reviewed-on: https://chromium-review.googlesource.com/1025098Reviewed-by:
Edward Jung <edwardjung@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#553163}
-
Fernando Serboncini authored
Lazily init CompositorFrameSink on BeginFrameProvider, execute RAF callbacks when requested. Bug: 833902 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I757e8731c9e39d6900109a383630bc1b59ddfead Reviewed-on: https://chromium-review.googlesource.com/1024376 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553162}
-
https://pdfium.googlesource.com/pdfium.git/+log/2dca1cbf5956..90e03b9b3f45 $ git log 2dca1cbf5..90e03b9b3 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 dsinclair Remove duplicate data extraction from CFX_XMLParser Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0a9a161c7f07b1235a85a2654154e441c78041b8 Reviewed-on: https://chromium-review.googlesource.com/1026041Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553161}
-
Sergey Berezin authored
ios-* builders may run on a mix of VMs with cores:8 and Mac Mini's with cores:4. Bug: 731546 Change-Id: I056fbb5bd80ca50ef8005aa8bb99643853acd923 Reviewed-on: https://chromium-review.googlesource.com/1024729Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553160}
-
Vaclav Brozek authored
On some places in the autofill code, IsWebElementVisible is used, on other that function is "inlined". This CL changes one such inlined call to call IsWebElementVisible explicitly. There should be no visible behaviour changes caused by this CL. Bug: 833838 Change-Id: Ia0efb92d1a2b781467af929848c8999d8bb72d34 Reviewed-on: https://chromium-review.googlesource.com/1017202Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553159}
-
Gauthier Ambard authored
This CL shows the 'Add to Bookmark' action in the activity menu even if the bookmark model isn't loaded yet. If the model isn't loaded and the user tries to add the page to the bookmarks, the action will silently fails. Bug: 834723 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id4ae21e3c20cdfad5487d95a928b52103614807d Reviewed-on: https://chromium-review.googlesource.com/1025101 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#553158}
-
Xida Chen authored
TBR=thestig@chromium.org NOTRY=true Bug: 836275 Change-Id: Idff1c4a5a600193bb8b3803ce4bcbbf205e5ccb7 Reviewed-on: https://chromium-review.googlesource.com/1026083Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553157}
-
Xida Chen authored
TBR=thestig@chromium.org, xlai@chromium.org NOTRY=true Bug: 836278 Change-Id: I4fba063d1782c9d623a2c57ba8bfaf1fa52abadd Reviewed-on: https://chromium-review.googlesource.com/1026088Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553156}
-
Noel Gordon authored
Fixed on issue 831074 issue 804413 issue 829310. Tbr: yamaguchi-san Bug: 836254 Change-Id: I71fc9416f0459810ed64d2d96dc033e52087d93f Reviewed-on: https://chromium-review.googlesource.com/1025453Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553155}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=lhchavez@chromium.org Bug: 825327 Change-Id: I40de071dcef2e6356ce03a851a36e85722b4f00a Reviewed-on: https://chromium-review.googlesource.com/1024317 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#553154}
-
Mike Meade authored
These flags are needed in multiple locations. Rather than duplicate these they are now able to be retrieved from test_installer. Change-Id: I569dbe9b004fc2a91a055c57370f1433429abbd5 Reviewed-on: https://chromium-review.googlesource.com/1025210Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: James Meade <mmeade@chromium.org> Cr-Commit-Position: refs/heads/master@{#553153}
-
Noel Gordon authored
Comment only change. Tbr: slangley Bug: 833834 Change-Id: I3e554d4fc2dd55811453601947016b49df2f63f7 Reviewed-on: https://chromium-review.googlesource.com/1025500Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553152}
-
arthursonzogni authored
Removes the following classes: - NavigationURLLoaderImpl - NavigationURLLoaderImplCore - NavigationResourceHandler Other CLs: * 1) https://chromium-review.googlesource.com/c/chromium/src/+/1015005 2) https://chromium-review.googlesource.com/c/chromium/src/+/1021631 3) https://chromium-review.googlesource.com/c/chromium/src/+/1022790 4) https://chromium-review.googlesource.com/c/chromium/src/+/1024038 Bug: 705744 Change-Id: Icc74aa1e6adfd42a2018a3b96aa8d5cb9d8daeb9 Reviewed-on: https://chromium-review.googlesource.com/1015005 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553151}
-
John Chen authored
When elements are inside iframe with padding, ChromeDriver didn't take into account the padding while calculating element locations, and end up getting wrong the wrong locations. Fixing by adding the padding value. Bug: chromedriver:2259 Change-Id: If3b37a6f891636df7b22679ea91e00e31fa66a83 Reviewed-on: https://chromium-review.googlesource.com/1010886Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553150}
-
Gauthier Ambard authored
This CL updates the bottom inset of the WebView to match the disappearance of the bottom toolbar. Bug: 823712 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idb71c1e780e5ab1949e39122b303aeddd787385e Reviewed-on: https://chromium-review.googlesource.com/1016561Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#553149}
-
Max Moroz authored
Bug: 790747, 759794 Change-Id: Ic95c5217c6781ed5a8628200397a128f418d1a0d Reviewed-on: https://chromium-review.googlesource.com/1024444Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553148}
-
Noel Gordon authored
Enabled in RELEASE. Run these tests again on remaining chrome-os bots: DEBUG/MSAN/ASAN. FolderShortcuts/FileManagerBrowserTest.Test* Traverse/FileManagerBrowserTest.Test* Tbr: slangley Bug: 836254 Change-Id: I901cd286fdc25147e17656bb54e423756c2486f9 Reviewed-on: https://chromium-review.googlesource.com/1025499Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553147}
-
https://webrtc.googlesource.com/src.git/+log/29e865a5d8a5..7741b7ac499b $ git log 29e865a5d..7741b7ac4 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I198cc4c961589cdec09566b1740f42854d67cd7b Reviewed-on: https://chromium-review.googlesource.com/1025958Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553146}
-
Minh X. Nguyen authored
Bug: 722942, 727861, 835936 Change-Id: I256f5b1c54143a0c4ec5dccea668eb669673cc3d Reviewed-on: https://chromium-review.googlesource.com/1025073Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553145}
-
Antonio Gomes authored
Driven by preparation CL for migrating ProfileDownloader from using URLFetcher to SimpleURLLoader. CL basically removes a parameter being unused, and a bogus include (gurl.h). TBR=xiyuan@chromium.org BUG=None Change-Id: Ia8b5d78042d1166537487b926d7479eefdecc9e2 Reviewed-on: https://chromium-review.googlesource.com/1025910Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#553144}
-
Abhishek Arya authored
TBR=glider@chromium.org Bug: 794920 Change-Id: I46fd3e886acb2db047655c055f0b887971a8c09b Reviewed-on: https://chromium-review.googlesource.com/1025968Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#553143}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rsleevi@chromium.org Bug: 825327 Change-Id: I145bea58989dc37d67a2d37ce4b14581363ac647 Reviewed-on: https://chromium-review.googlesource.com/1024474 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#553142}
-
Mohamed Heikal authored
WebappSplashScreenController is just using 0 for the async trace event ids. This is not a proper id and has been changed to hashCode(). Bug: 822816 Change-Id: I4e0bb42f76e920d3a57a2f1c13d7edb349390c33 Reviewed-on: https://chromium-review.googlesource.com/1024774Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#553141}
-
Jeremy Roman authored
This replaces all uses of WTF::Optional and its helpers with direct uses of base/optional.h. Generated by: git grep -l Optional third_party/blink/renderer | xargs perl -pi -e 's/\b(WTF::|(?<!::))Optional\b(?=<)/base::Optional/g' git grep -El 'nullopt|in_place|make_optional|OptionalOrNullptr' third_party/blink/renderer | xargs perl -pi -e 's/\bWTF(?=::(nullopt|in_place|make_optional|OptionalOrNullptr))\b/base/g' git grep -l wtf/optional.h third_party/blink/renderer | xargs perl -pi -e 's|third_party/blink/renderer/platform/wtf/optional.h|base/optional.h|' git grep -l an\ base::Optional third_party/blink/renderer | xargs perl -pi -e 's/an(?= base::Optional)/a/g' git checkout third_party/blink/renderer/platform/wtf/{README.md,optional.h,optional_test.cc} git cl format with a manual change to audit_non_blink_usage.py. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id344582fd52ac72d0c9c65bfa83063c9c19d295f Reviewed-on: https://chromium-review.googlesource.com/1023015 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#553140}
-
erikchen authored
This CL fixes layering for the heap profiling end to end tests. //components/heap_profiling now exposes two targets: heap_profiling_java_test_support and test_support. Instrumentation tests for both Chrome and Android WebView must include heap_profiling_java_test_support as a dependency in the apk being tested, and test_support as a dependency of the C++ shared library in the apk being tested. Bug: 827545 Change-Id: I02e12ff1a435ecd4529108e07dc9c00ede1af64b Reviewed-on: https://chromium-review.googlesource.com/1024698Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553139}
-
Gauthier Ambard authored
When you focus the omnibox, the scroll of the NTP should be stopped. If it is not stopped, the focus is immediately lost as scrolling the NTP unfocuses the omnibox. Bug: 834277 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I452c459d7c9b009afabd487003a3826f304191f5 Reviewed-on: https://chromium-review.googlesource.com/1025695Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#553138}
-
Justin Donnelly authored
This feature was approved for launch in M65. Bug: 787067 Change-Id: I1327a793206748537d4efeecf706c967635f17af Reviewed-on: https://chromium-review.googlesource.com/1017901Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#553137}
-
Simon authored
This was originally used for the first iteration of the bisect script, which was turned down in 2015. Looks like the chromium side was cleaned up but not the WebKit side. Bug: 835724 Change-Id: I45c862a967cb32fd522be01d162af54cb2ea8ee2 Reviewed-on: https://chromium-review.googlesource.com/1024200Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#553136}
-
Douglas Creager authored
The NEL spec recently changed the spelling of the `includeSubdomains` header field to `include-subdomains`, to better match all of the other header fields. This patch updates Chrome's NEL reporter implementation to look for the new spelling in response headers. No one had started including NEL headers yet (using the previous spelling), so there's no need for any backwards-compatibility logic to look for both spellings. Bug: 834791 Change-Id: I13449aa324eb80f0978f2649b44721022617383f Reviewed-on: https://chromium-review.googlesource.com/1019842Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Douglas Creager <dcreager@google.com> Cr-Commit-Position: refs/heads/master@{#553135}
-
Gabriel Charette authored
Changes in patch set 1 were scripted as part of the effort to restrict exposure of the raw MessageLoop*. In the latest patch set I manually cleaned it up further to get rid of raw MessageLoop* and deprecated MessageLoop::QuitWhenIdleClosure() usage altogether. This CL was uploaded by git cl split (initially). R=mastiz@chromium.org Bug: 825327 Change-Id: Ide7ce6794797611d47cebf7a1d448f0a464ac295 Reviewed-on: https://chromium-review.googlesource.com/1024442 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553134}
-