GitLab

This reverts commit 5c434bb2.

Reason for revert: Likely breaks WebView CTS builders. See http://crbug.com/725115

Original change's description:
> Remove obsolete Blink popup blocker.
> 
> Instead, use the same machinery that chrome uses also for layout tests.
> 
> BUG=318365
> R=​mkwst@chromium.org,torne@chromium.org
> 
> Change-Id: I62df62cb035c666b03331f7384df6c49e0dfc9fa
> Reviewed-on: https://chromium-review.googlesource.com/507288
> Commit-Queue: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#473420}

TBR=torne@chromium.org,mkwst@chromium.org,jochen@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=318365

Change-Id: I28308271b5eed0a2c48fc756847c3ba2a2178f69
Reviewed-on: https://chromium-review.googlesource.com/509259Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473653}

BUG=635619
TEST=This patch fixes 74 tests

Review-Url: https://codereview.chromium.org/2892293002
Cr-Commit-Position: refs/heads/master@{#473652}

TouchDeviceServer is necessary for hooking up AshTouchTransformController in mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901563002
Cr-Commit-Position: refs/heads/master@{#473651}

Network traffic annotation is added to network request of
components/safe_browsing/password_protection/password_protection_request.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2802643002
Cr-Commit-Position: refs/heads/master@{#473650}

Initial draft spec is here: https://cdn.rawgit.com/WICG/netinfo/ect/index.html

The API is runtime enabled feature, and is currently set to
"experimental".

This CL only implements "rtt" and "downlink" attributes. "ect" and
callback (when there is a change in network quality) will be
implemented in forthcoming CLs.

BUG=719108

Review-Url: https://codereview.chromium.org/2863973003
Cr-Commit-Position: refs/heads/master@{#473649}

Ideally, we should simply remove this throttling logic altogether, as it was
used to work around some Bluetooth classic bugs. These bugs should no longer be
relevant for BLE.

However, to be safe, we'll simply reduce the throttling time first and see if
this causes insability.

BUG=724719

Review-Url: https://codereview.chromium.org/2896733002
Cr-Commit-Position: refs/heads/master@{#473648}

- Update the ink drop ripple behavior on the omnibox icons so that they use the
   flood behavior instead
- Implement hover/active states for the page actions icon and popup blocker

Previously, ink drops were not enabled for IconLabelBubbleView when the the
label was visible since the ink drop would make the text blurry. To fix this, an
InkDropContainerView is now added to contain the ink drop. The separator
needs to fade out when the ink drop fades in, so a new view containing the
separator is now created.

IconLabelBubbleView, ContentSettingImageView and LocationIconView are also
refactored so that IconLabelBubbleView handles all of the logic for the ink drop
and suppressing mouse release events when the bubble is already opened.

BUG=588377

Review-Url: https://codereview.chromium.org/2720183002
Cr-Commit-Position: refs/heads/master@{#473647}

BUG=724713

Review-Url: https://codereview.chromium.org/2899593002
Cr-Commit-Position: refs/heads/master@{#473646}

ImageDecodeBench has a mode where it fills the buffer with data of a
given packet size. It then decodes as much as it can for each data
packet received. I believe the point of this mode is to test a more
real-world decoding scenario (using network-sized packets).

However, ImageDecodeBench fetches already-decoded frames from animated
images when a new packet arrives, rather than continuing to decode the
next frame. For example, if we decoded the first 3 frames with packet
1, upon packet 2 coming in, we fetch those first 3 frames again before
decoding frame 4. This does not cause an expensive decode, but still
deviates from the real-world decoding scenario.

In this change, make ImageDecodeBench resume where it left off when in
packet timing mode.

BUG=721260

Review-Url: https://codereview.chromium.org/2880533002
Cr-Commit-Position: refs/heads/master@{#473645}

Currently, the service converts one or multiple pages encapsulated in a
SkMultiPictureDocument to a PDF file. It runs in a sandboxed utility process.

This allows Chromium to move PDF generation code into a separate
process, and eventually can support compositing content generated from
multiple processes.

BUG=455764

Review-Url: https://codereview.chromium.org/2832633002
Cr-Commit-Position: refs/heads/master@{#473644}

The new list was autogenerated as described in
https://bugs.chromium.org/p/chromium/issues/detail?id=674712#c2.

A number of TLDs were recently removed from our DNS configuration.

BUG=674712

Review-Url: https://codereview.chromium.org/2895223002
Cr-Commit-Position: refs/heads/master@{#473643}

The style guide does not allow passing arguments by non-const reference.
This CL changes a few occurrences (found by git cl lint) to const ref
where the instance is not mutated, and to pointer where it is.

Review-Url: https://codereview.chromium.org/2889273003
Cr-Commit-Position: refs/heads/master@{#473642}

This cl changed "MasterCard" to "Mastercard" in the UI and related tests, since the brand is switched to lowercase 'c' last year, Payments side also had such an effort done.

Files touched are based on this filter:
"MasterCard" package:^chromium$ case:yes exact:yes -f:xtb -f:.dic -f:.heuristics -f:.js -f:third_party -f:.html
and
"Master Card" package:^chromium$ case:yes exact:yes -f:xtb -f:.dic -f:.heuristics -f:.js -f:third_party -f:.html

TEST=components:components_unittests

Review-Url: https://codereview.chromium.org/2819183004
Cr-Commit-Position: refs/heads/master@{#473641}

Revert of Don't access DisplayItemClient::VisualRect() for cached display items. (patchset #3 id:40001 of https://codereview.chromium.org/2894093002/ )

Reason for revert:
BUG=724920,724263,725041,724936

Original issue's description:
> Don't access DisplayItemClient::VisualRect() for cached display items.
>
> - Access DisplayItemClient::VisualRect() when a new DisplayItem is
>   created, and save it in the new DisplayItem.
> - When a cached display item is copied, don't access DisplayItemClient::
>   VisualRect() but fetch from the cached DisplayItem.
> - Remove DisplayItemList::visual_rects_.
> - Save original visual rects (LayoutRect) and apply GraphicsLayer offset
>   with EnclosingIntRect() when the display items are added into
>   WebDisplayItemList.
>
> Please see the bug for the reason.
>
> BUG=724263
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2894093002
> Cr-Commit-Position: refs/heads/master@{#473371}
> Committed: https://chromium.googlesource.com/chromium/src/+/3c7f1c4ecd1421d074daa5a103ea3f895c1c8724

TBR=chrishtr@chromium.org,wkorman@chromium.org,pdr@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=724263

Review-Url: https://codereview.chromium.org/2899793002
Cr-Commit-Position: refs/heads/master@{#473640}

It leaks memory. Disabling until the code is fixed.

BUG=721932
R=kojii@chromium.org, thakis@chromium.org
TBR=kojii
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2896743003 .
Cr-Commit-Position: refs/heads/master@{#473639}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4f4da28e..01bb145a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2893263003
Cr-Commit-Position: refs/heads/master@{#473638}

LayerTreeImpl used a multimap to track two scrollbar layer ids
(horizontal and vertical, both optional) which is inefficient. This
patch refactors this map to be a flat_map of ElementId to a pair of
layer ids.

Although not necessary for this patch, ScrollbarLayerImplBase has
been refactored to use a flat_set instead of an std::set for similar
reasons.

BUG=723263
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2894673008
Cr-Commit-Position: refs/heads/master@{#473637}

There is a top crasher in proxy resolution. This CL is to revert the
proxy refactoring CL (c9a99378) so we
can see if the crash goes away. To have a clean revert, this CL also
reverted five additional changes.

Revert "Extract Proxy Resolution out of HttpStreamFactoryImpl::Job"
crrev.com/c9a99378.

Revert "Fix SpdySessionKey for HTTP/2 alternative Jobs."
crrev.com/1fc76912.

Revert "Convert some DCHECKs to CHECKs to help track down a proxy bug."
crrev.com/89ca16bc.

Revert "Return Job as unique_ptr from factory methods."
crrev.com/6b86d7c8.

Revert "Return Request as unique_ptr from JobController::Start()."
crrev.com/f4bdc5a3.

Revert "Fix HttpStreamFactoryImpl::JobController::GetLoadState()"
crrev.com/b6270d12.

BUG=723589,475060

Review-Url: https://codereview.chromium.org/2895263003
Cr-Commit-Position: refs/heads/master@{#473636}

BUG=706118

Review-Url: https://codereview.chromium.org/2893433005
Cr-Commit-Position: refs/heads/master@{#473635}

Removes TRACE_EVENT0 invocations from generated per-message dispatch
code, in favor of a less granular TRACE_EVENT0 inside the internal
Connector which has only the master interface name for the relevant
message pipe.

This should substantially reduce binary size (expected ~250 kB
decrease) at the risk of making Mojom tracing slightly less useful.

BUG=689690
R=yzshen@chromium.org

Change-Id: Iceb72137c8b4711dad6eb344409c4c156d7bf8ea
Reviewed-on: https://chromium-review.googlesource.com/510703Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473634}

We don't have 'mp2t/audio' for audio streams. For video streams, stream
parser supports encrypted AVC stream. The patch adds the supporting for
mp2t avc.

BUG=708261
TEST=Test on chromecast and Android.

Review-Url: https://codereview.chromium.org/2881443002
Cr-Commit-Position: refs/heads/master@{#473633}

BUG=719552
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2893433004
Cr-Commit-Position: refs/heads/master@{#473632}

BUG=548423

Review-Url: https://codereview.chromium.org/2874973002
Cr-Commit-Position: refs/heads/master@{#473631}

Bot results from 221 to 228 are included.

New imports for CSS Shapes and CSS Writing Modes adds ~500 failures.

BUG=591099
TBR=eae@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2896703002
Cr-Commit-Position: refs/heads/master@{#473630}

Removing http/tests/dom/script-module-load-incomplete-no-crash.html
because it is not related to PlzNavigate.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel
BUG=724989

Review-Url: https://codereview.chromium.org/2897933003
Cr-Commit-Position: refs/heads/master@{#473629}

My recent changes to add StoryExpectations broke a tool. By adding an import this problem can be resolved.

Traceback (most recent call last):
  <module> at
/usr/local/google/code/clankium/src/tools/perf/generate_system_health_csv:13
    import page_sets
  <module> at
/usr/local/google/code/clankium/src/tools/perf/page_sets/__init__.py:18
    base_classes = [story.StorySet, story.expectations.StoryExpectations]
AttributeError: 'module' object has no attribute 'expectations'

BUG=723783

Review-Url: https://codereview.chromium.org/2898013002
Cr-Commit-Position: refs/heads/master@{#473628}

Starting M60, ARC will be enabled by default for all Chromad accounts on
supported devices.

Bug: 724117
Change-Id: Ib04bea1c64954e54c4c21863d6f42ffea04b4ac9
Reviewed-on: https://chromium-review.googlesource.com/506129Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473627}

R=sugoi@chromium.org
TBR=scottmg@chromium.org
BUG=722349

Review-Url: https://codereview.chromium.org/2895763002
Cr-Commit-Position: refs/heads/master@{#473626}

>Save pdf file instead of web page through context menu for embedded pdf file

>When user clicks 'Save as...' in the context menu over an embedded pdf file,
>we should save the pdf file instead of the entire web page. We fix this by showing
>the correct context menu for embedded pdf versus full page pdf: only full page
>pdf's context menu shows page navigation items such as 'Reload',
>but embedded pdf's context menu doesn't show them.

>BUG=chromium:591071

>Review-Url: https://codereview.chromium.org/2862583010
>Cr-Commit-Position: refs/heads/master@{#473105}
>Committed: >https://chromium.googlesource.com/chromium/src/+/fd0e534843ac5926c1b26c7e1e7a7229fcb3aeee

Review-Url: https://codereview.chromium.org/2862583010
Cr-Commit-Position: refs/heads/master@{#473625}

https://skia.googlesource.com/skia.git/+log/b35cb3143e1f..929bfeb17c4d

$ git log b35cb3143..929bfeb17 --date=short --no-merges --format='%ad %ae %s'
2017-05-22 msarett Blacklist memory intensive tests on 32-bit bots

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ie62815f4e8e7035510f31df64203572ae97b9425
Reviewed-on: https://chromium-review.googlesource.com/510543Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473624}

Addressing comments on the CL that previously landed regarding not sending hit reports when the user is in incognito mode.

This is a follow up of https://codereview.chromium.org/2886043002.

BUG=689149

Review-Url: https://codereview.chromium.org/2896893002
Cr-Commit-Position: refs/heads/master@{#473623}

Some layout cleanup of the internet detail subpage in preparation for
adding a configuration subpage.

BUG=380937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889073002
Cr-Commit-Position: refs/heads/master@{#473622}

Previously, when the stack was too large, we'd keep the top part of the stack
[closer to main()]. This proves to be less useful than the the bottom part of
the stack. This CL changes the logic to keep the bottom part of the stack.

BUG=

Review-Url: https://codereview.chromium.org/2892273003
Cr-Commit-Position: refs/heads/master@{#473621}

Quick design tl;dr:

* ProcessCoordinationUnitImpl
  Specific implementation of CoordinationUnitImpl for tracking
  processes within GRC of which it is derived from

* CoordinationUnitFactory
  Currently supports making ProcessCoordinationUnitImpl for
  CoordinationUnitType:kProcess and then a vanilla
  CoordinationUnitImpl for any ohter CoordinationUnitType

* CoordinationUnitImplBaseTest
  A base class for unit testing CoordinationUnitImpl and
  its derived classes

R=oysteine@chromium.org, rockot@chromium.org
BUG=724306

Review-Url: https://codereview.chromium.org/2892443002
Cr-Commit-Position: refs/heads/master@{#473620}

When PaymentAppInvocation test runs in single-process mode, the following
problem occurs in local environment:
  content_browsertests --gtest_filter=PaymentAppBrowserTest.* --single-process

  ../../content/browser/payments/payment_app_browsertest.cc:127: Failure
      Expected: 1U
      Which is: 1
  To be equal to: ids.size()
      Which is: 2

We can resolve this issue by clearing storage partition similar to what we do
in the background sync or the push messaging.
Please see: https://bugs.chromium.org/p/chromium/issues/detail?id=482083

BUG=661608

Review-Url: https://codereview.chromium.org/2895583002
Cr-Commit-Position: refs/heads/master@{#473619}

This allows the sessions setup for fetching the warmup URL to be
reused for fetching the user initiated requests.

Currently, with cookies disabled, the warmup URL is fetched over a
connection that has privacy mode enabled. This prevents the connection
to be reused for fetching the user initiated requests later.

BUG=725119

Review-Url: https://codereview.chromium.org/2897813002
Cr-Commit-Position: refs/heads/master@{#473618}

This CL changes the video stabilization mode to only configure 
CameraMetadata.CONTROL_VIDEO_STABILIZATION_MODE_ON where supported, after
reports from the field (see bug) where this is not the case, and the setting
of cameraSession upsets the underlying logic.

Bug: 718387
Change-Id: I3992e371a6d733d804d427c88a7b149abd70cf4b
Reviewed-on: https://chromium-review.googlesource.com/510005Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473617}

It is no longer necessary to manually define a C++ class for
PrintPreviewWebUITest as it can be autogenerated, so
chrome/test/data/webui/print_preview.cc and .h are no longer needed.
Remove these extra files and references to them.

BUG=None

Review-Url: https://codereview.chromium.org/2894243004
Cr-Commit-Position: refs/heads/master@{#473616}

Revert of [scheduler] Move task alignment into WakeUpBudgetPool. (patchset #5 id:80001 of https://codereview.chromium.org/2896603002/ )

Reason for revert:
Regresses sizes on https://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=40173 (due to include of iostream)

Original issue's description:
> [scheduler] Move task alignment into WakeUpBudgetPool.
>
> This fixes the regression where real-world throttling regressed to
> two-seconds task alignment instead of one-second alignment.
> This patch also improves test coverage for background throttling.
>
> BUG=722410
>
> Review-Url: https://codereview.chromium.org/2896603002
> Cr-Commit-Position: refs/heads/master@{#473609}
> Committed: https://chromium.googlesource.com/chromium/src/+/188fc72030f13187af5cff7e9802f3abebdea017

TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722410

Review-Url: https://codereview.chromium.org/2893363002
Cr-Commit-Position: refs/heads/master@{#473615}

- Show an update available icon in system tray upon receiving
NEED_PERMISSION_TO_UPDATE state from update engine.

- This icon brings user to the about Chrome OS page and prompts update
warning window with update size.

- Design doc: go/cros-cellular-updates

BUG=chromium:691108
TEST=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2882933002
Cr-Commit-Position: refs/heads/master@{#473614}