GitLab

Ran into this when trying to add support for android_aar() template.
The existing logic did not play nice with the filtering done by
_FilterUnwantedDepsPaths.

It now just resolves groups at the same time as _FilterUnwantedDepsPaths
so that no other logic within the file should need to know about them.

BUG=611171

Review-Url: https://codereview.chromium.org/2141153002
Cr-Commit-Position: refs/heads/master@{#405536}

https://chromium.googlesource.com/skia.git/+log/abda35d2b77f..7cf36ccb4419

$ git log abda35d2b..7cf36ccb4 --date=short --no-merges --format='%ad %ae %s'
2016-07-14 bsalomon Stop testing texture-backed bitmaps in drawbitmaprect GM
2016-07-14 bsalomon Rewrite GrTextureMipMapInvalidationTest using SkImage
2016-07-14 dvonbeck Added premulFourChannelColor to GrInvariantOutput
2016-07-14 bsalomon Remove SkGrTexturePixelRef and SkGrRenderTargetPixelRef aliases for SkGrPixelRef GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151873002
2016-07-14 fmenozzi Add verb field in scraping scripts
2016-07-14 bsalomon Remove unit test that tests subsetting texture backed bitmaps.
2016-07-14 bsalomon Fix leak when DFPR fails to draw path

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2144323002
Cr-Commit-Position: refs/heads/master@{#405535}

Revert of [Devtools] Improved URL parser for console (patchset #6 id:100001 of https://codereview.chromium.org/2125143002/ )

Reason for revert:
Regex can lockup on some console messages.

Original issue's description:
> [Devtools] Improved URL parser for console
>
> URL linkifier in console will now match a bit smarter. It
> will now allow things in double quotes single quotes and tick
> characters with something that beings to look like a url and
> continue to match (ie: allow spaces and punctuation). If
> there is no quote characters it will require punctuation or
> space before and after something that looks like a url.
>
> BUG=535463
>
> Committed: https://crrev.com/33b11974ba7343fbf2ad6673447488a1563cc8e3
> Cr-Commit-Position: refs/heads/master@{#404724}

TBR=lushnikov@chromium.org,luoe@chromium.org,dgozman@chromium.org,allada@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=535463

Review-Url: https://codereview.chromium.org/2151943002
Cr-Commit-Position: refs/heads/master@{#405534}

BUG=618140

Review-Url: https://codereview.chromium.org/2150953002
Cr-Commit-Position: refs/heads/master@{#405533}

Change the "Low Severity" color to Green. Update the icons to the MD
ones.

BUG=624643, 626775

Review-Url: https://codereview.chromium.org/2139573003
Cr-Commit-Position: refs/heads/master@{#405532}

Blink should only use the blink variant of mojo bindings. Unfortunately,
this means we can no longer use the same enum across content/renderer and
blink.

To get around this, the embedder interface (WebBluetooth) uses int32 instead of
the enums and we cast to enum where appropriate.

Also removes unnecessary dependencies on mojo bindings.

BUG=610415

Review-Url: https://codereview.chromium.org/2142813003
Cr-Commit-Position: refs/heads/master@{#405531}

As defined in [1], this CSP directive allows developers to block resource
requests that do not contain integrity metadata. This includes contexts
like external scripts, workers, shared workers, service workers, external
stylesheets, preload requests, and requests originated by CSS @import.

[1]: https://w3c.github.io/webappsec-subresource-integrity/#opt-in-require-sri-for

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/jyCdW1dHyYA/YefRSKs1AQAJ

BUG=618924
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2056183002
Cr-Commit-Position: refs/heads/master@{#405530}

The computeAutoRepeatTracksCount() call needs to know the available size in
order to compute a number of repetitions. When computing the preferred
logical widths that size is indefinite so it should just return 1. The
problem is that instead it was directly calling another methods that were
reentering the preferred size computation. That lead to a situation of never
ending recursive calls to the preferred widths code.

As we know whether we're computing the intrinsic sizes or not, we can
leverage that knowledge and do not call the method in that case (the number
of repetitions would be 0 or 1 depending on whether auto-fit|fill was
specified or not).

Made some of the attributes mutable as they are modified by the intrinsic size
computation. Moved the clean up of those attributes to a new method. We'll
eventually need to change the current code so that we could call the track
sizing algorithm without affecting the internal state of the layout object.

BUG=621517

Review-Url: https://codereview.chromium.org/2135703002
Cr-Commit-Position: refs/heads/master@{#405529}

Because devtools_debug_resources is an action, it runs if building all,
regardless of whether //chrome depends on it.

BUG=628167
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/2148333002 .

Cr-Commit-Position: refs/heads/master@{#405528}

... as opposed to just when the stream is finalized.

Review-Url: https://codereview.chromium.org/2150783002
Cr-Commit-Position: refs/heads/master@{#405527}

It has no aura dependencies, and that's where the code under test lives.

BUG=none
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2148243003
Cr-Commit-Position: refs/heads/master@{#405526}

Revert of ash: Refactor touch hud drawing to ash/touch_hud. (patchset #13 id:240001 of https://codereview.chromium.org/2118223004/ )

Reason for revert:
Missing dependency, broke build

Original issue's description:
> ash: Refactor touch hud drawing to ash/touch_hud.
>
> This is part of the touch hud app for mustash (https://codereview.chromium.org/2092343002/).
>
> BUG=588311
> TEST=ash_unittests
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win8_chromium_gyp_dbg;master.tryserver.chromium.win:win8_chromium_gyp_rel
>
> Committed: https://crrev.com/98caac0fdcd637a95eb27e72c9a4c0a487e72d25
> Committed: https://crrev.com/fd4123fd2d8efaa85d0b2f1550ca6e70ddc7cb55
> Cr-Original-Commit-Position: refs/heads/master@{#405296}
> Cr-Commit-Position: refs/heads/master@{#405506}

TBR=sadrul@chromium.org,sky@chromium.org,jamescook@chromium.org,dbeam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=588311

Review-Url: https://codereview.chromium.org/2153493002
Cr-Commit-Position: refs/heads/master@{#405525}

Revert of roll libyuv from r1579 to r1607 (patchset #19 id:350001 of https://codereview.chromium.org/2126333002/ )

Reason for revert:
Causing compile failures on:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN

Original issue's description:
> roll libyuv from r1579 to r1607
>
> roll libyuv for GN fix to chromium internal settings, enabling more warnings
> and consistant with gyp build options.
>
> Add ARGBExtractAlpha function.
> Fix YUV bilinear filter improved filter accuracy; uses 128-f instead of 127-f.
> unittest fixes for Arm scaler - use J420 for J422 pointing to same row,
> improving performance and accuracy.
> Fix ios jpeg build error.
> Fix BlendPlaneRow_SSSE3 impossible constraints on android full debug
> Fix unittests to avoid private row.h header.
> Fix vector_size(32) build error on yuv conversion for intel on gcc 4.4.
>
> BUG=libyuv:572,chromium:592745,libyuv:575,libyuv:579,libyuv:573,libyuv:583,chromium:601140,libyuv:582,libyuv:581,chromium:601140,libyuv:578,libyuv:581,libyuv:580,libyuv:586,libyuv:590,webrtc:5006,libyuv:593,libyuv:592,libyuv:594,libyuv:595,libyuv:597,libyuv:599,libyuv:598,libyuv:600,libyuv:602,libyuv:605,libyuv:610,libyuv:612, libyuv:618, libyuv:620, webrtc:6091, webrtc:6094, libyuv:616, libyuv:623
> TEST=try bots
> R=rsesek@chromium.org
>
> Committed: https://crrev.com/053185feb2645e1628e6b25fbf1e21f309c26776
> Cr-Commit-Position: refs/heads/master@{#405512}

TBR=rsesek@chromium.org,fbarchard@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=libyuv:572,chromium:592745,libyuv:575,libyuv:579,libyuv:573,libyuv:583,chromium:601140,libyuv:582,libyuv:581,chromium:601140,libyuv:578,libyuv:581,libyuv:580,libyuv:586,libyuv:590,webrtc:5006,libyuv:593,libyuv:592,libyuv:594,libyuv:595,libyuv:597,libyuv:599,libyuv:598,libyuv:600,libyuv:602,libyuv:605,libyuv:610,libyuv:612, libyuv:618, libyuv:620, webrtc:6091, webrtc:6094, libyuv:616, libyuv:623

Review-Url: https://codereview.chromium.org/2153503002
Cr-Commit-Position: refs/heads/master@{#405524}

Based on crbug.com/178296, the test was disabled for WinXP.
Since WinXP is no longer maintained, we can enable the test.

BUG=178296
Test=None

Review-Url: https://codereview.chromium.org/2145343002
Cr-Commit-Position: refs/heads/master@{#405523}

This test adds a new test assertion in GetZippedTest to check the contents of
decoded response body.

BUG=474859

Review-Url: https://codereview.chromium.org/2150913002
Cr-Commit-Position: refs/heads/master@{#405522}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/4623c4f8a10b..0ea1fef9391b

$ git log 4623c4f8a..0ea1fef93 --date=short --no-merges --format='%ad %ae %s'
2016-07-14 aheejin Add Wasm build support for spec2k.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review-Url: https://codereview.chromium.org/2152863002
Cr-Commit-Position: refs/heads/master@{#405521}

BUG=546019

Review-Url: https://codereview.chromium.org/2145173003
Cr-Commit-Position: refs/heads/master@{#405520}

After we fixed the WebContentsObserver::TitleWasSet() events not being emitted in some cases
including the interstitial pages in this CL: https://codereview.chromium.org/2086423005/,
we now make sure that the favicon is also updated when the title changes.
We also use the DidFinishNavigation() instead of DidNavigateMainFrame().

Screen recording: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LX0VtUnNWaEd6cUU/view?usp=sharing

BUG=607074

Review-Url: https://codereview.chromium.org/2148083002
Cr-Commit-Position: refs/heads/master@{#405519}

This CL will disable the buttons in the clear browsing data dialog
if clear browsing data is in progress.

Based largely on https://crrev.com/2118503005/ by
Dave Schuyler <dschuyler@chromium.org>

BUG=622998
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2133893002
Cr-Commit-Position: refs/heads/master@{#405518}

BUG=628143

Review-Url: https://codereview.chromium.org/2151883003
Cr-Commit-Position: refs/heads/master@{#405517}

TBR=zmo@chromium.org
BUG=586033
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2144293002
Cr-Commit-Position: refs/heads/master@{#405516}

Instead, uses the save path from Download preferences.

This initializes to the path set by the user in Settings, then
updates with each Download or Save to PDF.

BUG=136331

Review-Url: https://codereview.chromium.org/2139303003
Cr-Commit-Position: refs/heads/master@{#405515}

Revert of Always apply UniformMatrix4fvStreamTextureMatrixCHROMIUM matrix argument. (patchset #11 id:220001 of https://codereview.chromium.org/1818073002/ )

Reason for revert:
Broke the build on Mac GYP (dbg):

https://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20(dbg)

Original issue's description:
> Always apply UniformMatrix4fvStreamTextureMatrixCHROMIUM matrix argument.
>
> Regardless of whether we have a stream texture matrix, we should apply
> the transformation matrix held by the StreamTextureDrawQuad instance.
>
> Change the implementation of the extension to always premultiply either
> the stream texture matrix or the identity matrix by the passed
> transformation matrix.
>
> BUG=597681
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/5897d75b89294c388df2ec16b7519ecd635cc148
> Cr-Commit-Position: refs/heads/master@{#405507}

TBR=enne@chromium.org,ccameron@chromium.org,liberato@chromium.org,sievers@chromium.org,tobiasjs@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=597681

Review-Url: https://codereview.chromium.org/2150993002
Cr-Commit-Position: refs/heads/master@{#405514}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ad257201962e..b1baa103267a

$ git log ad2572019..b1baa1032 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2146553008
Cr-Commit-Position: refs/heads/master@{#405513}

roll libyuv for GN fix to chromium internal settings, enabling more warnings
and consistant with gyp build options.

Add ARGBExtractAlpha function.
Fix YUV bilinear filter improved filter accuracy; uses 128-f instead of 127-f.
unittest fixes for Arm scaler - use J420 for J422 pointing to same row,
improving performance and accuracy.
Fix ios jpeg build error.
Fix BlendPlaneRow_SSSE3 impossible constraints on android full debug
Fix unittests to avoid private row.h header.
Fix vector_size(32) build error on yuv conversion for intel on gcc 4.4.

BUG=libyuv:572,chromium:592745,libyuv:575,libyuv:579,libyuv:573,libyuv:583,chromium:601140,libyuv:582,libyuv:581,chromium:601140,libyuv:578,libyuv:581,libyuv:580,libyuv:586,libyuv:590,webrtc:5006,libyuv:593,libyuv:592,libyuv:594,libyuv:595,libyuv:597,libyuv:599,libyuv:598,libyuv:600,libyuv:602,libyuv:605,libyuv:610,libyuv:612, libyuv:618, libyuv:620, webrtc:6091, webrtc:6094, libyuv:616, libyuv:623
TEST=try bots
R=rsesek@chromium.org

Review-Url: https://codereview.chromium.org/2126333002
Cr-Commit-Position: refs/heads/master@{#405512}

CopyTexImage2D accepts unsized internal formats, but the code didn't properly
handle all possible cases, resulting in us storing 0 as format/type in the level
info. This can be problematic later on, e.g. triggering asserts if the texture
is used as a FBO to copy from.
This CL makes sure we're at the very least consistent, but doesn't fully
implement the spec which has specific rules to pick an effective internal format
depending on the framebuffer format.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2146603005
Cr-Commit-Position: refs/heads/master@{#405511}

Avoided rentry to EventSender::FinishDragAndDrop to fix
a ClusterFuzz crash. The test uses an EventSender sequence
to drag from one div to another. The sequence ends with a
mouseup, but the drag target also fires a mouseup on
dragend. While the first mouseup was still processing a
drag-drop at EventSender::FinishDragAndDrop, the second
mouseup triggered another call to
EventSender::FinishDragAndDrop, causing a premature call
to WebViewImpl::dragTargetDragEnterOrOver with the crash.

See the bug for a minimal test case.

BUG=627340

Review-Url: https://codereview.chromium.org/2148733003
Cr-Commit-Position: refs/heads/master@{#405510}

If we wish to turn on optimizations for our main code base, we need to
first make sure that these optimizations don't break our instrumentation
tests when inlining functions. To do this, we make a gn arg which will guard
our instrumentation tests and only allow them to run without this
flag. This flag will then be the thing that turns on these Proguard
optimizations.

BUG=625704

Review-Url: https://codereview.chromium.org/2123753005
Cr-Commit-Position: refs/heads/master@{#405509}

We had multiple instances of |optionToListIndex(selectedIndex())|, which causes
two iterations over OPTIONs. selectedListIndex() returns the same value, but is
more efficient.

Review-Url: https://codereview.chromium.org/2149763003
Cr-Commit-Position: refs/heads/master@{#405508}

Regardless of whether we have a stream texture matrix, we should apply
the transformation matrix held by the StreamTextureDrawQuad instance.

Change the implementation of the extension to always premultiply either
the stream texture matrix or the identity matrix by the passed
transformation matrix.

BUG=597681
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1818073002
Cr-Commit-Position: refs/heads/master@{#405507}

This is part of the touch hud app for mustash (https://codereview.chromium.org/2092343002/).

BUG=588311
TEST=ash_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win8_chromium_gyp_dbg;master.tryserver.chromium.win:win8_chromium_gyp_rel

Committed: https://crrev.com/98caac0fdcd637a95eb27e72c9a4c0a487e72d25
Review-Url: https://codereview.chromium.org/2118223004
Cr-Original-Commit-Position: refs/heads/master@{#405296}
Cr-Commit-Position: refs/heads/master@{#405506}

sippingAddresses -> shippingAddresses

BUG=None

Review-Url: https://codereview.chromium.org/2151853002
Cr-Commit-Position: refs/heads/master@{#405505}

This exposes a way for ChannelProxy users to associate interface
factories with a ChannelProxy, allowing requests to be bound either
on the proxy thread or directly on the IPC thread.

BUG=612500

Review-Url: https://codereview.chromium.org/2147493006
Cr-Commit-Position: refs/heads/master@{#405504}

https://chromium.googlesource.com/skia.git/+log/614d8f9a3c44..abda35d2b77f

$ git log 614d8f9a3..abda35d2b --date=short --no-merges --format='%ad %ae %s'
2016-07-14 mtklein GrBufferAllocPool: use _throw calloc() if unchecked.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2147233002
Cr-Commit-Position: refs/heads/master@{#405503}

Consists of:

 1.) RulesetIndexer - the class used to construct flat data structures
 representing the set of URL filtering rules.

 2.) IndexedRulesetMatcher - the class that matches URLs against the FlatBuffer
 representation of an indexed ruleset.

The indexes are primarily based on N-grams in URL patterns of the rules.

BUG=609747
TBR=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2148753002
Cr-Commit-Position: refs/heads/master@{#405502}

This eliminates several near-identical copies of this function.

BUG=none
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2144003003
Cr-Commit-Position: refs/heads/master@{#405501}

* AXListBoxOption::isSelectedOptionActive()
  We don't need to compare indices. We can compare node pointers.

* AXListBoxOption::setSelected()
  We don't need to compute an optionIndex.  We can pass an HTMLOptionElement
  pointer directly by changing the argument type of accessKeySetSelectedIndex().
  This CL renames accessKeySetSelectedIndex() to selectOptionByAccessKey().

Now, we can remove AXListBoxOption::listBoxOptionIndex() and
HTMLSelectElement::listToOptionIndex().

Review-Url: https://codereview.chromium.org/2147963004
Cr-Commit-Position: refs/heads/master@{#405500}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/94d2faa8c3fb..ad257201962e

$ git log 94d2faa8c..ad2572019 --date=short --no-merges --format='%ad %ae %s'

BUG=628156

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2151883002
Cr-Commit-Position: refs/heads/master@{#405499}

Including a blink variant binding in content/renderer means that
content/renderer includes all of wtf/. Sadly this means that we can
no longer use the same enum in content/renderer and blink so we
static cast at the boundary.

Review-Url: https://codereview.chromium.org/2145993003
Cr-Commit-Position: refs/heads/master@{#405498}

BUG=627079

Review-Url: https://codereview.chromium.org/2145983002
Cr-Commit-Position: refs/heads/master@{#405497}