GitLab

For menus in chrome-in-mus, we attempt to create a Widget hosted in a native
window. For desktop builds, this means we attempt to host in a HWND or an
X11 window created by DesktopNativeWidgetAura. But for mus, we want to use
NativeWidgetMus. To do this, use the native-widget factory first if it's
available.

BUG=none

Review URL: https://codereview.chromium.org/1460003004

Cr-Commit-Position: refs/heads/master@{#361151}

I'm going to need more than one object to detect focus changes.

BUG=548424
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1465143004

Cr-Commit-Position: refs/heads/master@{#361150}

Fix the missing "data_store.pb.h" error when building extensions gn target on a clean output directory.

data_reduction_proxy_api.cc includes data_store.pb.h directly and indirectly (via data_reduction_proxy_compression_stats.h). This CL adds //components/data_reduction_proxy/proto:data_reduction_proxy_proto to the dependencies of extensions to solve this problem.

BUG=560321

Review URL: https://codereview.chromium.org/1460313004

Cr-Commit-Position: refs/heads/master@{#361149}

BUG=547246

Review URL: https://codereview.chromium.org/1460133002

Cr-Commit-Position: refs/heads/master@{#361148}

Improperly-formatted WAV data causes this class to attempt to divide by
zero in the constructor. Check for this condition, and invalidate
internal state if the WAV data does not parse properly. It should be able
to accept any data without crashing. Add unittests to verify.

Bug: b/21759728

BUG=
TEST=wav_audio_handler_unittest.cc

Review URL: https://codereview.chromium.org/1453233002

Cr-Commit-Position: refs/heads/master@{#361147}

1) Set the enable status of icon and label before it's being added as a
child of HoverHighlightView

2) Refuse SetHoverHightlight to true when disabled, and SetHoverHightlight
to false when OnEnabledChanged triggered and enabled() changed to false.

BUG=560013, 560027

Review URL: https://codereview.chromium.org/1470783002

Cr-Commit-Position: refs/heads/master@{#361146}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a40b4f5c..2280bfa0

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1468093002

Cr-Commit-Position: refs/heads/master@{#361145}

BUG=208378

Review URL: https://codereview.chromium.org/1465133002

Cr-Commit-Position: refs/heads/master@{#361144}

Putative fix for crbug.com/545479. If WebUIManager is created but
navigation occurs before the WebUI URL starts loading, provisional
navigation for a non-WebUI URL could be observed by WebUIManager, and
WebUI should not be loaded in that case.

BUG=545479

Review URL: https://codereview.chromium.org/1464383002

Cr-Commit-Position: refs/heads/master@{#361143}

This used to work because the accessibility audit library pulls in parts
of the closure libray. Since it doesn't leak its internals in a newer
version, this dependency problem was exposed. The underlying issue is that
GEN_INCLUDES in the js test are included before closureModuleDeps, so
declarations from the latter are not available when evaluating the former.

Needed for https://codereview.chromium.org/1447693002/

BUG=555753
R=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/1472763002

Cr-Commit-Position: refs/heads/master@{#361142}

Cr-Commit-Position: refs/heads/master@{#361141}

BUG=295792, 483282, 559359, 559362, 559342
NOTRY=true

Review URL: https://codereview.chromium.org/1463983002

Cr-Commit-Position: refs/heads/master@{#361140}

IOSChromeIOThread initialises, holds and clean up data primarily used
on the IO thread. It is based on chrome/browser/io_thread.{cc,h} with
only the portion relevant to iOS kept.

BUG=556566

Review URL: https://codereview.chromium.org/1464083002

Cr-Commit-Position: refs/heads/master@{#361139}

This CL plumbs four QUIC experimental params (
quic_store_server_configs_in_properties,
quic_delay_tcp_race,
quic_max_number_of_lossy_connections,
quic_packet_loss_threshold) from Cronet's
setExperimentalOptions API to net::HttpNetworkSession.

This CL also adds a unittests target to run the unittests.
A followup CL will enable the unittests on the cronet bots.

BUG=545118

Committed: https://crrev.com/fde0b72c603cd111c36ca4cc416d82a7395bcf6c
Cr-Commit-Position: refs/heads/master@{#360454}

Committed: https://crrev.com/8ece3aa6845350c1971a3e824bf148f3e8de3253
Cr-Commit-Position: refs/heads/master@{#360875}

Review URL: https://codereview.chromium.org/1448583003

Cr-Commit-Position: refs/heads/master@{#361138}

https://chromium.googlesource.com/skia.git/+log/8e8eda9d4d2e..93c69fff5350

$ git log 8e8eda9d4..93c69fff5 --date=short --no-merges --format='%ad %ae %s'
2015-11-23 scroggo Revert of Add SkPngChunkReader. (patchset #9 id:160001 of https://codereview.chromium.org/1040453002/ )
2015-11-23 msarett Revert of Switch Skia's libjpeg-turbo to 1.4.2 (patchset #2 id:160001 of https://codereview.chromium.org/1469553002/ )
2015-11-23 scroggo Add SkPngChunkReader.
2015-11-23 bsalomon Review URL: https://codereview.chromium.org/1464593004

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1471803002

Cr-Commit-Position: refs/heads/master@{#361137}

BUG=477049

Review URL: https://codereview.chromium.org/1419083012

Cr-Commit-Position: refs/heads/master@{#361136}

The change was landed through the CL 1408923003

R=fmalita@chromium.org
BUG=546538

Review URL: https://codereview.chromium.org/1471003002

Cr-Commit-Position: refs/heads/master@{#361135}

The media playback test was recently added:
https://codereview.chromium.org/1431193005/

and requires specific switches:
* local file access required to load test media
* cma pipeline explicitly enabled in order to test that
* cast ozone platform enabled in order to test overlay frames

These tests have been failing on internal infrastructure (tot build)
because the switches were only configured in testing/buildbot (for
running on Chromium bots).

BUG=

Review URL: https://codereview.chromium.org/1466633004

Cr-Commit-Position: refs/heads/master@{#361134}

BUG=557285

Review URL: https://codereview.chromium.org/1465953003

Cr-Commit-Position: refs/heads/master@{#361133}

This CL:
- Removes weird OnFaviconAvailable() behavior if gfx::Image is empty.
- Merges: FaviconDriver::SetActiveFaviconValidity()
          FaviconDriver::SetActiveFaviconURL()
          FaviconDriver::SetActiveFaviconImage()
- Merges FaviconDriverObserver::OnFaviconAvailable() and
         FaviconDriverObserver::OnFaviconUpdated().

BUG=542057

Review URL: https://codereview.chromium.org/1407353012

Cr-Commit-Position: refs/heads/master@{#361132}

BUG=475442

Review URL: https://codereview.chromium.org/1471783002

Cr-Commit-Position: refs/heads/master@{#361131}

TEST=CronetUrlRequestTest.testMockClientCertificateRequested
BUG=558420

Review URL: https://codereview.chromium.org/1459993003

Cr-Commit-Position: refs/heads/master@{#361130}

This adds libffi-dev and libdrm-dev to the image
which were recently added with:
https://codereview.chromium.org/1464123002

R=thestig@chromium.org
BUG=559062

Review URL: https://codereview.chromium.org/1466383002

Cr-Commit-Position: refs/heads/master@{#361129}

Move addToSVGPathByteStream to SVGPath.cpp (the only place using it),
rename it to addPathByteStreams. Move the "regular" blending out into a
helper(blendPathByteStreams), and eliminate the redundant copy. Make the
functions more "functional" (return the result.)

Add a (private) setter for byte-stream data and use that to ensure
invalidation of the cached path. Also add an SVGPath::create(...)
accepting a SVGPathByteStream and use that in PathSVGInterpolation.

Inline mutableByteStream into the remaining user.

Review URL: https://codereview.chromium.org/1460253002

Cr-Commit-Position: refs/heads/master@{#361128}

BUG=559322

Review URL: https://codereview.chromium.org/1470503002

Cr-Commit-Position: refs/heads/master@{#361127}

crrev.com/1427963002 introduced a new memory-infra thread which runs
after all dump providers are finished. This measures the process total
memory usages. This was previously running at the start of a memory
dump. This means that the memory used while taking memory dump of other
providers will be included in the totals now and this metric has
regressed. This CL is a temporary change that reverts this behaviour so
that the perf bots are happy. Better fix for the problem will follow up
soon.

BUG=555584

Review URL: https://codereview.chromium.org/1466293002

Cr-Commit-Position: refs/heads/master@{#361126}

The race was fixed with https://codereview.chromium.org/355573006 ,
committed as
https://skia.googlesource.com/skia/+/e438ddbc7451ec80f953266409fea4695e78c8c2

This is effectively a revert of https://codereview.chromium.org/273523002 .

BUG=chromium:369257

Review URL: https://codereview.chromium.org/1467313002

Cr-Commit-Position: refs/heads/master@{#361125}

This CL including a layout test that does 2 things:
1. transfer an ImageBitmap to the worker and let worker transfer back to
   main, the main thread exam the transfered-back ImageBitmap to make
   sure the data is the same as the original ImageBitmap.
2. When worker receives the ImageBitmap from main, worker calls
   createImageBitmap() to create a new ImageBitmap and send it back to
   main

BUG=532142

Review URL: https://codereview.chromium.org/1423513005

Cr-Commit-Position: refs/heads/master@{#361124}

Validation already takes care of :valid/:invalid changes through
invalidation sets. This reduces the number of elements being recalculated
and gets rid of a SubtreeStyleChange which relies on sibling tree recalcs.

R=tkent@chromium.org
BUG=557440

Review URL: https://codereview.chromium.org/1458363003

Cr-Commit-Position: refs/heads/master@{#361123}

BUG=None

Review URL: https://codereview.chromium.org/1472853004

Cr-Commit-Position: refs/heads/master@{#361122}

We did use invalidation sets when adding/removing href from an anchor tag,
while the code that notifies that the visited state of a given url has
changed, use SubtreeStyleChange. This change gets rid of SubtreeStyleChange
which relies on sibling tree recalcs.

R=tkent@chromium.org
BUG=557440

Review URL: https://codereview.chromium.org/1459063004

Cr-Commit-Position: refs/heads/master@{#361121}

BUG=None

Review URL: https://codereview.chromium.org/1472863002

Cr-Commit-Position: refs/heads/master@{#361120}

Add new boolean to know if a GridSpan is definite or indefinite.
That way we don't need to use pointers and we can always have two
GridSpans in GridCoordinate, if the position is "auto" the GridSpan will
be marked as indefinite. This will allow in a follow-up patch to avoid
repeated calls to methods that resolve positions.

Most operations in GridSpan are restricted to definite GridSpans (access
to positions, iterator, etc.). For indefinite GridSpans we only need to
know that they're indefinite we shouldn't use the rest of the data.

No new tests, no change of behavior.

BUG=444011

Review URL: https://codereview.chromium.org/1459373002

Cr-Commit-Position: refs/heads/master@{#361119}

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.

BUG=554291
TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/1468013002

Cr-Commit-Position: refs/heads/master@{#361118}

Fixes the clang/win build after https://codereview.chromium.org/1439443002/
clang rightfully complains that UiThreadHelper has virtual methods, is
deleted polymorphically, and doesn't have a virtual destructor:

..\..\base/sequenced_task_runner_helpers.h(40,5) :  error: delete called on 'const device::SerialIoHandlerWin::UiThreadHelper' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete reinterpret_cast<const T*>(object);
    ^
..\..\base/sequenced_task_runner_helpers.h(86,38) :  note: in instantiation of member function 'base::DeleteHelper<device::SerialIoHandlerWin::UiThreadHelper>::DoDelete' requested here
        from_here, &DeleteHelper<T>::DoDelete, object);
                                     ^
..\..\base/sequenced_task_runner.h(126,48) :  note: in instantiation of function template specialization 'base::subtle::DeleteHelperInternal<device::SerialIoHandlerWin::UiThreadHelper, bool>::DeleteViaSequencedTaskRunner<base::SequencedTaskRunner>' requested here
        subtle::DeleteHelperInternal<T, bool>::DeleteViaSequencedTaskRunner(
                                               ^
..\..\device\serial\serial_io_handler_win.cc(374,28) :  note: in instantiation of function template specialization 'base::SequencedTaskRunner::DeleteSoon<device::SerialIoHandlerWin::UiThreadHelper>' requested here
  ui_thread_task_runner()->DeleteSoon(FROM_HERE, helper_);
                           ^

Making the class final fixes this as it makes sure that nobody adds
a subclass of UiThreadHelper.

Also don't mix initializer styles for the different fields of this
class.

No intended behavior change.

BUG=82385
TBR=juncai

Review URL: https://codereview.chromium.org/1470983002 .

Cr-Commit-Position: refs/heads/master@{#361117}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/76efc8f2..a40b4f5c

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1472873002

Cr-Commit-Position: refs/heads/master@{#361116}

BUG=514767

Review URL: https://codereview.chromium.org/1423333006

Cr-Commit-Position: refs/heads/master@{#361115}

and when --use-gl=egl then the browser is showing garbage.

Indeed in GpuCommandBufferStub::OnInitialize the call to
context->Initialize(surface_.get(), gpu_preference_)" fails.
The error actually comes from eglMakeContext which returns
EGL_BAD_MATCH. Because surface config is not compatible with
context config.

Problem is that EGL_BUFFER_SIZE is always 32 for off screen
surfaces (see gl_surface_egl.cc::InitializeOneOff). Whereas
for on screen surfaces EGL_BUFFER_SIZE is the window depth.
This depth is by default 24 unless --enable-transparent-visuals
is passed to the command line.

When using mesa the error is raised here:
/* If the context has a config then it must match that of the two
* surfaces */
if (ctx->Config) {
if ((draw && draw->Config != ctx->Config) ||
  (read && read->Config != ctx->Config))
return _eglError(EGL_BAD_MATCH, "eglMakeCurrent");
from:
cgit.freedesktop.org/mesa/mesa/tree/src/egl/main/eglcontext.c#n630

This patch pass the main window depth from browser to gpu process
though a new switch kWindowDepth.
This allow GLSurfaceEGL::InitializeOneOff to select an EGLConfig
that matches with future ON screen surfaces's EGLConfig.

Also note that long term plan is to always enable transparent visual,
see http://crbug.com/369209.

This patch also move the kEnableTransparentVisuals switch from view
to x11 switches as it is defined to x11 only.

BUG=557389

R=jbauman@chromium.org, hendrikw@chromium.org, piman@chromium.org, sadrul@chromium.org, cwallez1@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/1429083002

TEST= chrome --use-gl=egl --use_virtualized_gl_contexts

Review URL: https://codereview.chromium.org/1429083002

Cr-Commit-Position: refs/heads/master@{#361114}

BUG=None

Review URL: https://codereview.chromium.org/1466343002

Cr-Commit-Position: refs/heads/master@{#361113}

https://chromium.googlesource.com/skia.git/+log/5931922997b8..8e8eda9d4d2e

$ git log 593192299..8e8eda9d4 --date=short --no-merges --format='%ad %ae %s'
2015-11-23 msarett Switch Skia's libjpeg-turbo to 1.4.2
2015-11-23 kkinnunen Fix GLInterfaceValidation test after "Remove GrContextFactory::getGLContext"

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1470953002

Cr-Commit-Position: refs/heads/master@{#361112}