- 17 Sep, 2019 40 commits
-
-
Sam Maier authored
Bug: 1003433 Change-Id: Ia9269aa8c8bcf2aad69c57fa5746d9e26c21cc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802391Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#697390}
-
Andrew Luo authored
Change-Id: I25ecb9da049bb69f3f19c325a102d14eaaa438a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799314Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697389}
-
Tiancong Wang authored
This is one of the efforts to move AFDO-related stuff from Chrome OS ebuild to Chromium tree. This patch adds three files to specify latest profile for each architecture. The files will be updated by skia autoroller. Add calls to download the profiles to DEPS file. Bug: chromium:1001227 Test: gclient sync Change-Id: I4d5fecf6089a8f43b0c3a5b030e8e8daa9ca9ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809664Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#697388}
-
Jamie Walch authored
We've had some reports that killall cannot locate the host process if it is specified by name, which might explain why some users are still running old versions of the host. This CL specifies the full binary path instead, which is more reliable. It also removes a TODO that's no longer relevant. Change-Id: I50611ed43431a6790010c66d90ddfd05a3519789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808488Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#697387}
-
Jérôme Lebel authored
Adding into ios/third_party/material_components_ios/BUILD.gn: - src/components/private/Color/src/UIColor+MaterialBlending.h - src/components/private/Color/src/UIColor+MaterialBlending.m Bug: 1004348 Change-Id: I6cf8ef9317fd61ca9bb0cf47e391ffb3df471279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808868 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#697386}
-
Fabrice de Gans-Riberi authored
This is a reland of bbd8d150, now that the peer-component's implementation of the UrlRequestRewriteRulesProvider works correctly. Original change's description: > [fuchsia] Handle UrlRequestRewriteRulesProvider in CastRunner. > > * Implement handling of the > chromium.cast.UrlRequestRewriteRulesProvider API in CastRunner. > * Remove handling of the fuchsia.web.AdditionalHeadersProvider API in > CastRunner as it is deprecated. > * Adapt the integration test to use the new API. > > Bug: 976975 > Change-Id: If1e97c474f79a4b6f3f0c03428b85557e3e73460 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770434 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695766} TBR=fdegans Bug: 976975 Change-Id: Iac657c5431056f94744767506432956eb09cfdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809808Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#697385}
-
Joel Hockey authored
Note, this should only be submitted once tremplin changes in crrev.com/c/1795682 are in prod. Bug: 995649 Change-Id: I8306d67ceca64f2c54a6e85af94fc1c14724bff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797510Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#697384}
-
Andrew Grieve authored
Reland "Disable monochrome_public_apk when !public_android_sdk. Add @CheckDiscard to LifetimeAssert" This reverts commit f15999f7. Reason for reland: Missed one dep (fixed in PS2) > > The APK when built in this mode is not configured correctly since > > system_webview_apk does not exist when !public_android_sdk. TBR=dtrainor@chromium.org,torne@chromium.org,agrieve@chromium.org,smaier@chromium.org Bug: 1000763 Change-Id: I8147cc85cc8efbc147a72e829d45f2dc990be666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808112 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#697383}
-
Henrique Nakashima authored
This is an identical reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1774268 Extra deps in clank/javatests will fix the build error that caused the revert: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1804387/ TBR=dtrainor@chromium.org,twellington@chromium.org Bug: 995916,1004913 Change-Id: I99b48aae909cbda69b10786faf4ffe1cbc42d0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809782Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697382}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b18323b096a7..7fd753567d3c git log b18323b096a7..7fd753567d3c --date=short --no-merges --format='%ad %ae %s' 2019-09-17 mmortensen@google.com Update generated proto api for sysroot_pb2.py and test_pb2.py . 2019-09-17 tcwang@google.com afdo: Fix a bug that to check existing profiles in Chrome verification builder. Created with: gclient setdep -r src/third_party/chromite@7fd753567d3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic34066a484bf207564361650667f3d8a250bf8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697381}
-
jonross authored
We had duplicate expectations in use-vulkan=native and enable-gpu-rsterization. This removes the duplicates, and has vulkan_native_blink_web_tests use the additional expectation file. This also re-enables some tests which have since been fixed. TEST=vulkan_native_blink_web_tests Bug: 972096, 978628 Change-Id: I0a354b1e0dd911b4a6912e2d6e685738e4e034af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804377Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#697380}
-
wutao authored
Previous result sorting was based on score only, therefore it could happen that the results with specified location are sorted at the end of the results list in the provider group and is truncated. This patch modifies the sorting criteria to include the result display index as well to ensure those results will be at the beginning of the sorted results and return to the UI. Bug: 1003471 Test: new unittest MixerTest.ResultsWithDisplayIndex Change-Id: I3a5d57b55ac2b08a3b00a8f3d89b87b51a41be66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808705 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697379}
-
Willie Koomson authored
This change, in preparation for addition of crostini throttling, moves the ArcThrottleObserver class to chrome/browser/chromeos/ and renames it (and all usages) to ThrottleObserver. This is because the class is no longer ARC++-specific. Additionally, moves WindowThrottleObserverBase to chrome/browser/chromeos/ Bug: 997397 Test: Run unit tests of affected classes (ArcInstanceThrottle,ThrottleObserver,ArcActiveWindowThrottleObserver,ArcBootPhaseThrottleObserver) Change-Id: Ib3a7cc82d77d120149a90c7b3ca8559ce8b84ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809780 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Anushruth authored
This reverts commit cd4d366b. Reason for revert: Compile failure. See crbug.com/1004964 for details Original change's description: > Convert SimpleURLLoader to use mojom types. > > This CL Converts the SimpleURLLoader to use the mojom URLResponseHead > struct instead of the native ResourceResponseHead struct. > > Change-Id: I016b0731930b4589ba6169aa2e24ad45dc6675cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790273 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Charles . <charleszhao@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697317} TBR=avi@chromium.org,hashimoto@chromium.org,kinuko@chromium.org,khorimoto@chromium.org,rkaplow@chromium.org,dtrainor@chromium.org,hajimehoshi@chromium.org,mmenke@chromium.org,sorin@chromium.org,tbansal@chromium.org,zmin@chromium.org,danyao@chromium.org,bsazonov@chromium.org,lfg@chromium.org,charleszhao@chromium.org Change-Id: Ibdbe0af4cd38b0a09954c81c989f9f3a3afe8e70 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809099Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#697377}
-
Sammie Quon authored
1) Remove extra PositionWindows call when rotated since SetBoundsAndUpdatePositions calls it already. 2) Allow SetBoundsAndUpdatePositions to not animate and use no animation when rotation. 3) Pause the occlusion tracker when rotating. Ash.Rotation.Smoothness has around 70~80 before, 80~90 after. always using 8 windows and NTP page Test: interactive_ui_tests ScreenRotationTest.RotateInTabletOverview, Bug: 1004820 Change-Id: Ie7bb137185d34ceb1b0c0e42f7aba021a673ecee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809502 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Ken Rockot authored
Properly handles CallStackProfiler interface binding requests from the GPU process. This was broken by https://chromium-review.googlesource.com/c/chromium/src/+/1763226 which changed all child processes to no longer acquire this interface through the Service Manager, but failed to update GPU process host code in conjunction with render process host code. Bug: 1000663 Change-Id: I8070453417651d46331298d02fe2e796ebb318a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808114Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#697375}
-
Pavol Marko authored
Map the BuiltinCertificateVerifierEnabled policy to a local_state pref, relying on ChromeOS on the proxying of primary user policies to the device-wide PolicyService. This has not been possible previously due to https://crbug.com/982936. This will make it easier to expand the scope of the policy to other platforms in a consistent way. Bug: 978069 Test: browser_tests --gtest_filter=*ProfileNetworkContextService* Change-Id: Ifc0032e81c78a99d4686bc18693aef72fd97e38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807225Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#697374}
-
Patrick Noland authored
Preconnection, the lighter weight alternative to pre-rendering, was un-implemented for Clank, so this CL implements it. Change-Id: Ib48ec3569a0422762d1c4b41d4e2db4b85b2cbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808165 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#697373}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/860369fc431e..61a2765940a7 git log 860369fc431e..61a2765940a7 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 swiftshader.regress@gmail.com Regres: Update test lists @ 860369fc Created with: gclient setdep -r src/third_party/swiftshader@61a2765940a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I7ec4852a3a2bfb1f48905f7c2cc663e5eed12d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808109Reviewed-by:
-
John Budorick authored
Requires crrev.com/c/1808257 Bug: 922145 Change-Id: I0fba9fae3161740ba212af7c4f018160c2d573cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809737 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#697371}
-
Juanmi Huertas authored
We are now using SharedImage to hold the image for the video renderer, https://chromium-review.googlesource.com/c/chromium/src/+/1616978. That change, together with the change that made the video be deferred, and therefore, use the paintRecorder, let us safely remove the workaround. There was nevertheless the issue of texture lifetime to extend the texture. If the backend texture is the same in the SkImage and the one contained in the cache, we will let skia release it. If they are different, cache has to destroy their own texture, and the one in skia will survive the delete. Bug: 974656, 991792, 993774, 994516, 996083, 1004780 Change-Id: I3bf8c1037b77434a1cf0385872fc7d994886cd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789883Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#697370}
-
Nico Weber authored
See https://reviews.llvm.org/D67456 Makes the build a bit more hermetic, and should have no behavior change. Bug: none Change-Id: I90080aa7f8ec814e6ec9b1a4fbcad464e12a450d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807154 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697369}
-
Etienne Bergeron authored
This CL is removing unused header files due to from the previous cleanup: https://chromium-review.googlesource.com/c/chromium/src/+/1663504 R=drott@chromium.org,asvitkine@chromium.org Bug: 947059 Change-Id: I45517878d0bfd16f563b69da399aed30114a4583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808703Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697368}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9fa8ef1f4f9a..368d002e489e git log 9fa8ef1f4f9a..368d002e489e --date=short --no-merges --format='%ad %ae %s' 2019-09-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision dbd15694..31d9542a (697157:697288) Created with: gclient setdep -r src/third_party/webrtc@368d002e489e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If8de9b3c7979228699b5e28e37827795d165c330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809740Reviewed-by:
-
Owen Min authored
Each enterprise report may have multiple request and each request creates one data point. This includes retry. Bug: 956237 Change-Id: If07e115a735f33e99d981c0b054bfcff3e525508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803803Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697366}
-
Brian Sheedy authored
We've historically had several issues with VR being added to x86/x64 Android builds when it shouldn't be and breaking compilation, so run the optional Android x86/x64 compile bots on VR changes. Bug: 969104 Change-Id: I318edc70bee2c4f86c7c9b1991f24c3bbb223f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809797 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/932a2c0e3bb6..0033008d95ac git log 932a2c0e3bb6..0033008d95ac --date=short --no-merges --format='%ad %ae %s' 2019-09-17 bungeman@google.com Properly subset the run in ShapeThenWrap. 2019-09-17 csmartdalton@google.com Reland "Use "clamp" when reexpanding gaussian blurs" 2019-09-17 ethannicholas@google.com Additional SkSL swizzle optimizations 2019-09-17 brianosman@google.com Update SkParticleEffect comments based on review feedback 2019-09-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-17 bsalomon@google.com Respect ImageSetEntry alpha in one-at-a-time code path 2019-09-17 brianosman@google.com Fix standalone SkSL build after adding SkOnce to SkSLByteCode 2019-09-17 herb@google.com A fix and unit test for jagged characters 2019-09-17 brianosman@google.com Move raster hack for color type on layers with image filters to device Created with: gclient setdep -r src/third_party/skia@0033008d95ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Id260b3cf63511618866e26a05d1c422f287f63b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809676Reviewed-by:
-
Henrique Nakashima authored
These methods were added for crbug.com/358708 but the usage was reverted shortly after and they were not cleaned up. Bug: 995916 Change-Id: I63a4ec3756e34b56e1cccb54cbc7cf1bb9c312ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808082Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697363}
-
Jonah Ryan-Davis authored
With EGL on X11 it was necessary to create an extra child window due to https://crbug.com/326995. However, ANGLE already creates an extra child window so this is not necessary on top of ANGLE. Bug: 991577 Change-Id: I8e2d8ed1d11d7252877a48ac33296d2705038862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808340 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697362}
-
Justin Cohen authored
Since crrev.com/c/1540371 it's been safe to trigger a clear browsing data restore during a slimnav restore. This is because we DetachFromWebView during clear browsing data, and reset the |is_restore_session_in_progress| flag. DetachFromWebView already supports extracting restore urls from history, so there shouldn't be any data loss. Additionally, the delay implementation is wrong, since it's valid for a webstate to be suspended in the tab grid while in a slimnav restore state. In fact, on a restart, most tabs are in that state. So triggering clear browsing data when that suspended tab is the 'active' tab, will hang forever. Bug: 961726 TEST= 1.) Open a few tabs and create some navigation history for each (at least 10 navigation items) 2.) Quit the app 3.) Launch the app and quickly clear browsing data Change-Id: Ic0a67523f5a0e2a63f31061735c12a2a27abb09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807025Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697361}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/99f23d6ff220..04ebb2a000ee git log 99f23d6ff220..04ebb2a000ee --date=short --no-merges --format='%ad %ae %s' 2019-09-17 wl@gnu.org * src/otvalid/otvcommon.c (otv_Coverage_get_last): Guard `count'. Created with: gclient setdep -r src/third_party/freetype/src@04ebb2a000ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I7a43630e18ccc37336e3c54b294a424e508d4c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809662Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697360}
-
Anubha Mathur authored
Gif: https://imgur.com/a/eP7Irdr Bug: 963183 Change-Id: I8dd5a9a5abc4d1404385b924cbfe110e4bb62132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804522Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697359}
-
Matt Menke authored
The test depends on the specific format of the dictionary HttpServerPropertiesManager creates. This CL keeps that behavior, but reduces how tightly the expectations are coupled with the exact format used by HttpServerPropertiesManager. Bug: 1004604 Change-Id: I212976386dbd3cdecb8d0b892ecb993562386829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809498Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697358}
-
Allen Bauer authored
Bug: 651682 Bug: 651681 Change-Id: I571a9b503e066e58f6daa9713f85a7458c0f70e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808803 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#697357}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d73796b0f7d..5b12fdd2a7ac git log 0d73796b0f7d..5b12fdd2a7ac --date=short --no-merges --format='%ad %ae %s' 2019-09-17 hjd@google.com Merge "Update perfetto_config.descriptor.h" 2019-09-17 taylori@google.com Merge "perfetto-ui: Add beta search tooltip" Created with: gclient setdep -r src/third_party/perfetto@5b12fdd2a7ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id468636fbb5d49fed2cac6f35c3f5ea803a67a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809665Reviewed-by:
-
Takuto Ikuta authored
This reverts commit b3373919. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/81914 Original change's description: > Convert ui/ARIAUtils.js to an ES module > > ES modules allow files to explicitly import and export symbols [1]. > This patch migrates ARIAUtils.js to an ES module, while maintaining > backwards compatibility with existing usages of `window.UI.ARIAUtils`. > > The build system is updated to copy these modules verbatim, as it no > longer require pre-processing to be loaded. The `module.json` no longer > includes this file as a script, to make sure it is not double-bundled > into `shell.js`. Instead, it is added to the new field `modules`, which > contains all modules. By doing so, it becomes clear which files are > converted to modules already and which require the legacy references > to the global scope. > > This module and future modules will be imported from `root.js`, which is > added to all existing HTML application files. > > Design Doc: https://docs.google.com/document/d/1h9dOy3nNPNfZ2AtZXzB-DwJqG4Oo37WWvKLCuzCcPzo/edit?usp=sharing > > [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import > > TBR=jochen@chromium.org > > Change-Id: Ie79c8f2fce3aff96fa28af0b575eae39bfe8e1a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748949 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> > Cr-Commit-Position: refs/heads/master@{#697238} TBR=yangguo@chromium.org,jochen@chromium.org,aerotwist@chromium.org,mathias@chromium.org,tvanderlippe@google.com Change-Id: I550f1082755ef4b9e7bc778e3afdaef324dae03a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808954Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#697355}
-
James Forshaw authored
This CL modifies the DACL for the primary LowBox token to allow the initial privileged impersonation token to open a handle to it. This is necessary as the Windows kernel implements a feature which prevents Low IL tokens accessing any securable resource which has a package SID as part of the DACL. Without the change opening the primary process token fails during warmup which causes numerous unexpected behaviors such as the process crashing. Bug: 1000447 Change-Id: I76ac6eecae08d8de6f2130e5841b50a17b3739e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783728Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#697354}
-
Natalie Chouinard authored
HyperlinkPreference's imitateWebLink styleable attribute is not currently used. Change-Id: I03acc2edbc9c0f42ae4471148918711a99f7263d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807436Reviewed-by:
-
Aran Gilman authored
Change-Id: I67a6aed61625f45968dd717e25e563ce86aa22c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809504 Auto-Submit: Aran Gilman <gilmanmh@google.com> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697352}
-
Haiyang Pan authored
* CI builder: fuchsia-x64-dbg * CQ builder (Experimental): fuchsia-compile-x64-dbg Related CL: crrev.com/c/1796483 Bug: 1001643 Change-Id: If7da449efc2e4426f0c57ab7eb3b9e1796efa3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796885 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#697351}
-
