- 11 Aug, 2020 40 commits
-
-
chrome://signin-reauthAlex Ilin authored
The reauth dialog CSS overrides the background illustration in dark mode using the `background` shorthand CSS property which sets all background style properties at once. In this case, `background-size` attribute gets implicitly overridden with a default value. This behavior isn't desired, so this CL uses `background-image` CSS property instead of the `background` shortcut. Bug: 1114701 Change-Id: I32232b540b7feb3d76c524af589497382d6f12f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346293Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796999}
-
about://flagsEric Seckler authored
Adds an entry for the kCpuAffinityRestrictToLittleCores feature and moves its entry to chrome_features.h/cc to accomplish that. Bug: 1111789 Change-Id: I1a99b4eaf5e07111a0bcc7725081e3871edfe5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348774 Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#796998}
-
Andres Calderon Jaramillo authored
Problem: In the new direct VD, we create a SharedImage for the decoded video frame using the visible size. This is (mostly, see solution below) correct because we don't want the GPU to sample outside that area (otherwise, we might get artifacts). However, the coded size of the VideoFrame sent to the client still contains the non-visible area. This can cause PaintCanvasVideoRenderer to issue GL commands with incorrect dimensions thus failing command buffer validation which results in some videos not being drawn at all on a canvas. Solution: The solution implemented by this CL is simple: the coded size of the VideoFrame that goes out to the client should only include the "usable area." For most videos, this is simply the size of the visible rectangle. However, some H.264 videos specify a visible rectangle that doesn't start at (0, 0). For these videos, the usable area needs to include everything from (0, 0) to the bottom-right corner of the visible rectangle: the client will calculate the UV coordinates to exclude the non-visible area on the left and on the top of the visible area. Note that this usable area should also be used to create the SharedImage because this size is used to import the frame into a graphics API. Bug: 1092806 Test: tast.video.DrawOnCanvas.* on nami Change-Id: I25f70a1b21fc9b4ff7037d6fb3b4575ad3dd66e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242834 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796997}
-
Miguel Casas authored
AFAICT this code is untested and unused, since VideoDecoderPipeline doesn't create ImageProcessors for VA-API. Left a NOTIMPLEMENTED() as in-code documentation. Bug: b:162962069 Change-Id: Icdd0e15749d58b98d91143d6d4cf1eec8a993b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346908Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796996}
-
rajendrant authored
Enabling the redirection by default simplifies enabling the feature in chrome-flags. Change-Id: I9b4b0bd870ac431d4579c59c1b1d95331a57472c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349972Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#796995}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie8b34e9e69969ee28cb79def717be865af2d1e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796994}
-
Sebastien Lalancette authored
Also added a new Sharing histogram value. Will consolidate into histograms.xml once at the end, with all the other histograms to be added. Bug: 1093302 Change-Id: Idb89e0ae14b4cc9ed21f7dcb083e0a4fbbf7baa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348534 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#796993}
-
Dylan Cutler authored
Bug: 973801 Change-Id: I769682b943c3beb5d3f67b88068d6924d24e37e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346844Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#796992}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597147084-8c4cc9658838494b8781316d2fe64028822c8b91.profdata to chrome-mac-master-1597168794-5b254c70fb11ba814efe16d5fff8c307263d75ab.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I8cf4b5e4eb88157424717b784ef87192bcbe64c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796991}
-
Joel Hockey authored
Change-Id: I562a224fec4ab042baa6a2e035eb970560bf6fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350399 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796990}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9385eb35f507..398a874c9b85 2020-08-11 ynovikov@chromium.org Add tools/clang/dsymutil to roll_chromium_deps.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I6e468c9e86994c59b50b13bafae4ed268936bfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796989}
-
Dale Curtis authored
Creates a vpcc box based on the configuration info. Reland now uses a forward declaration for the kCMVideoCodecType_VP9 which is in the 11.0/10.16 SDK. This version doesn't use MAC_OS_X_VERSION_MAX_ALLOWED which isn't currently setup correctly in the SDK. Bug: 1103432, 1105187 Test: Updated unittests. Change-Id: I2df8f77e910e23a673ed538e5e475901bc4524e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349915Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#796988}
-
David Bokan authored
This is a follow-up to https://crrev.com/c/2347371 which is a mechanical move of ThreadedInputHandler into its own separate file. There are no changes from the previous CL. Bug: 915926 Change-Id: I58e6a82271cb81cd5e9dd906a61808d8486b6cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347924 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796987}
-
Alex Turner authored
This should improve performance when fonts are quickly cycled as the repeated calls to Time::Now() were (somewhat) slow. Bug: 1110204 Change-Id: I861288f9470157cc349e41a0e124c95cba6a381a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333378 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#796986}
-
Stephen Roe authored
The standard chrome-fuchsia test scripts use "system_log" instead of "system.log". Bug: 1113982 Change-Id: I8ff7a8f1310010751c573bd452253d2d86848d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347969Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#796985}
-
Caroline Rising authored
This is hidden behind a feature flag. This change adds a new button to the bookmarks bar which opens an empty bubble containing a WebView. Create a ReadingListModelFactory for desktop use. Bug: 1109316 Change-Id: I028bf4e584b32fb532980ccfb7c5ca42d7093092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335641 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#796984}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: Icf1f7733b29d90c056435b649284c35f5a6c25f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348770 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#796983}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/21e5b4554a5f..0376edf14e58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I36cae4135135e0ba1370f399b35c657e415c0806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796982}
-
Xiqi Ruan authored
Report metrics of session engagement started event and session engagement hours, which helps us understand users' usage on chromeos, and improve family users' experience. Metrics from abnormally terminated sessions will be skipped. Bug: 1103081 Change-Id: I62a0f5f245a660e01ced68a7b6af627a18e64edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297703 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796981}
-
bttk authored
With this change StatusView.getEndPaddingPixelSizeForFocusState() can now be private. Bug: 1109369 Change-Id: Ied30cd7cadbf1d06bfd2fa1a80b01379ddff2929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335642Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#796980}
-
Livvie Lin authored
Update RecordSingleDecisionToMetrics and RecordSingleInteractionToMetrics to use a simpler API, which now supports non-constant histogram names. Change-Id: Iae63351d0ce6915841f48b614aad7a22f12839ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347319Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796979}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/49983ef4e7de..a70445f40898 2020-08-11 jmbetancourt@google.com reland: configure attributes for SkottieView to be initialized from XML layout 2020-08-11 herb@google.com use SkIPoint for positions in GrTextBlob 2020-08-11 bsalomon@google.com Remove Adreno must-do-copies-from-origin workaround 2020-08-11 robertphillips@google.com Non-substantive changes to small path rendering classes 2020-08-11 bsalomon@google.com Remove incorrect 1 pixel opt. in GrInterpretFilterQuality. 2020-08-11 johnstiles@google.com Fix implementation of SkDEBUGFAILF in SkSL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1112139,chromium:1113233 Tbr: fmalita@google.com Change-Id: Icd1cf8798ac213a6d444d66e786d1fc7a3e502ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349400Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796978}
-
Gary Tong authored
This reverts commit 4421e3c9. Reason for revert: Going to try to make arm64 compile on 10.13 Original change's description: > Infra: Use Mac 10.15 machines for mac-arm64-rel tryjob > > Bug: 1106950 > Change-Id: I69a3a8df07f40d0cc24de3f85212e51d5945bd46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350149 > Auto-Submit: Gary Tong <gatong@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796959} TBR=estaab@chromium.org,gbeaty@chromium.org,gatong@chromium.org Change-Id: I3a6e9f78e3990113d3bfb059c0d2977e9d04fbac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350141Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Cr-Commit-Position: refs/heads/master@{#796977}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/21e5b4554a5f..0376edf14e58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ica1ba55888d56eece5a7d4672afce451a696a7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349910Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796976}
-
Sammie Quon authored
We try to update visibility in constructor which then checks for widget in GetEffectiveVisibility. The initialize local state code looks like it can be done after the shelf pod is added to a widget so move it there. Test: manual Change-Id: Ic7c2e7856ed76dce9008a6ad9f9c735ce1a05d81 Fixed: 1115191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349403Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#796975}
-
Peter Kotwicz authored
This CL: - Makes WebappLauncherActivity set the correct URI on the launch intent for WebAPKs - Renames WebappIntentUtils#getId() to make it clear that it only applies to homescreen shortcuts - Moves WebappRegistry#webApkIdForPackage() to WebappIntentUtils alongside WebappIntentUtils#getIdForHomescreenShortcut() - Adds a boolean parameter to WebApkValidator#disableValidationForTesting() for the sake of tests which need to keep validation enabled. BUG=1114560 TEST=WebappLauncherActivityTest.* R=peconn TBR=sky (For trivial change to MapsGoFirstRunTest.java ) Change-Id: I615b1aca48b4a0c626a1e02613c58e9bdebc44ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348050 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#796974}
-
Kevin Ellis authored
Per spec (https://drafts.csswg.org/css-transitions-2/#event-dispatch) a transitioncancel should be fired on the following phase change not idle and not after --> idle Previously we were only test for not idle --> idle, meaning that a finished transition could erroneously trip a transitioncancel. Bug: 979556 Change-Id: Iecd6c8d2a7ca4564925910f092fca4c78b6d79da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348416 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796973}
-
Choongwoo Han authored
This fixes build failure of `autoninja all` Bug: 1076336 Change-Id: I7c073acb2fb98a4b608768e8a862246721acbb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346649Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Choongwoo Han <choongwoo.han@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796972}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Idc48b0654294a1bd044bbfe204b9d70e5aea6f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349470Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#796971}
-
David Bokan authored
This CL begins the process of splitting input handling out of LayerTreeHostImpl. To keep things simple and easy to review, this CL is a mostly mechanical disentangling of input code into a new class, ThreadedInputHandler. The class still lives in layer_tree_host_impl.cc and is still tightly coupled with it. Future CLs will move this into a separate file and put up proper interfaces between compositing and input. For now there is no behavioral changes, the two classes delegate calls to each other as appropriate. The ThreadedInputHandler has methods shadowing the InputHandler interface, and LayerTreeHostImpl now delegates to it, but ThreadedInputHandler doesn't yet implement the interface. A future CL will make it implement InputHandler and pass it around instead of LTHI. The end state is to have ThreadedInputHandler be a standalone object used by InputHandlerProxy to affect input-related changes. This split deliberately leaves anything graphics or animation related in LTHI. Bug: 915926 Change-Id: Iabc08c03fb618b1f7e9406b5ab7fa7ab64d60913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347371Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796970}
-
Becca Hughes authored
Adds empty Chrome Kaleidoscope NTP module as a placeholder. BUG=1114862 Change-Id: Iee00259b9848394ead7d6b80cb1d311f07a5abcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347909 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#796969}
-
Jesse McKenna authored
This change makes the "Open" option in the downloads bar act like "Show in Folder" for files without file extensions on Windows. This fixes an issue where Chrome could unexpectedly open the wrong file when attempting to open an extensionless file while an executable of the same name was present in the Downloads folder. For example, downloading and opening "somefile" while "somefile.exe" was already present in Downloads would result in "somefile.exe" being run. This behavior is due to Windows' shell open functionality, which appears to have special logic to interpret extensionless commands as potential executables. Prior to this change, if an extensionless file was opened without an executable of the same name present (the more common scenario), Windows would display error "No application is associated with the specified file for this operation", so this change does not remove any functionality apart from the ability to trigger this error popup. Showing the extensionless file in folder sets the user up nicely to open the file however they want from Windows Explorer via right-click > Open With. Bug: 1092518 Change-Id: I1a3bb519867548c916070cbfebd64d0017f5937b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321528 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796968}
-
Ryan Hansberry authored
Change-Id: I06270079771302e8d9542e012078e0f844d32896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349287 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#796967}
-
Dan Sanders authored
Previously we set the limit to zero, meaning no limit, but FFmpeg 4.3 will not allocate at all with that setting. Changed to std::numeric_limits<size_t>::max(). Bug: 1095962 Change-Id: I96820c21f794f2814e955ee75ff22dfd31804c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349405Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#796966}
-
Victor Costan authored
Bug: 1068710 Change-Id: Id150b86cb4532ab0d51e4a314573641d8ba2fef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348334 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#796965}
-
Sebastien Lalancette authored
Fixes the bad behavior in three components: - History - Reading List - Bookmarks Bug: 1093302 Change-Id: Ia81bfd270e898c3061eb7ad061cc5aea338dc947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349270Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#796964}
-
Liviu Tinta authored
On Mac, tiltY is positive when the pen is tilted away from the user. Based on Pointer Event spec, tiltY should be positive when the pen is tilted towards the user. On Mac, by default Y increases going up, while in Chromium Y increases going down. NSView has isFlipped property which controls if Y increases going up (false) or going down (true). In order to fix the bug, we check NSView's isFlipped flag and if it is false we reverse the sign of tiltY to accommodate the difference in the direction of Y. Bug: 1111347 Change-Id: I108ba496adc6f951277e1c9ddb7eaf6483e522f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348544Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#796963}
-
Lukasz Anforowicz authored
This CL adds a DCHECK to RenderFrameHostManager::GetFrameHostForNavigation to make sure that the |dest_site_instance| computed earlier is in the same BrowsingInstance as the frame's parent: DCHECK(!parent || dest_site_instance->IsRelatedSiteInstance( parent->GetSiteInstance())); Bug: 1107269 Change-Id: I89b79e93e8435f12a51bf3e49472a44ce7ddb47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347074 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#796962}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0376edf14e58..f07b5182eeda 2020-08-11 hjd@google.com Merge "Add cpuhp ftrace events" 2020-08-11 simonmacm@google.com We're in a for loop so don't return. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:163530191 Tbr: perfetto-bugs@google.com Change-Id: I490535d91bf44e7e31681c4dddcd9083e3def10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796961}
-
James Cook authored
Also move it and AshChromeServiceImpl into namespace crosapi. This is consistent with our plan for interface names from go/lacros-main-dd. Bug: none Change-Id: Ice369bd8da4ebdc9de4de2a69ce7a457ed13968a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349888 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796960}
-