GitLab

This forces autoplay on for all main frames, and turns on the autoplay
delegation mechanism via <iframe allow="autoplay" />. This turns off the
previous behavior of unconditionally allowing autoplay on all pages and
frames.

Bug: internal b/160651728
Test: Launch AMP Viewer via web sender, verify only the screen reader is
      active while videos/ads remain paused.

Change-Id: If570ca3911596bf27bcceb56360fad674a9236c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296360Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789315}

R=sclittle@chromium.org

Bug: 1047909
Change-Id: Ic5e1ef207e8483ae1a56a4ee090d7ad6317a3a3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303859
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789314}

This CL converts base::Callback and base::Closure to Once/Repeating
in //chrome/browser/task_manager/. With this CL, there should be no
base::Callback, base::Closure and base::Bind anymore.

Bug: 1007635
Change-Id: I2bbe393b8e76b861a000d4c58d99ed1e0f63d90b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290051Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Minggang Wang <minggang.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#789313}

Previously was set at the default size of 24px, this change
reduces its size to 20px.

Bug: 1106551
Change-Id: I34f2faff0799b6125c05a683d9619b2c59579534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303231Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789312}

Adds SetHighlight calls to BrowserAppMenuButton::UpdateIcon(), as the
colors used depend on theme and severity as well.

Bug: 1001731
Change-Id: Id5cd21e74affbcc7fbb5570dac49eaba08d95f59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302944Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789311}

Exposes existing feature flags for mixed forms interstitials and
disabling autofill on mixed forms in chrome://flags.

Bug: 1093102, 1093103
Change-Id: I5d8fef15579b9321148fb893e9881cdc3a68f22b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303990
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789310}

There is code to resolve variables in this function, but we should
not reach it with CSSCascade enabled.

Change-Id: I39580db63b1f48114210b2ac59d3d29253a8eb1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302056
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789309}

... instead of content/renderer/media.

Today, content/renderer/media/media_factory.cc calls out to
blink::CreateWebMediaStreamRendererFactory() (from
t_p/blink/public/web/modules/mediastream/web_media_stream_renderer_factory.h)
and passes the object to Blink.

This CL moves this call within WebMediaPlayerMS's ctor, in webmediaplayer_ms.cc
(blink). For tests, it adds an override method.

This will allow:
- merged of WebMediaStreamRendererFactory and
MediaStreamRendererFactoryImpl classes.
- removal of web_media_stream_renderer_factory.h.

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I368f9063cfa9a361b603d35f9c9b30d31b488837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302711
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789308}

Using wpt-import in Chromium e79c319a.
With Chromium commits locally applied on WPT:
1adfdd4d "[COOP] Fix typo in test name"
f19f3404 "[Sheriff] Revert "Deflake preservesPitch tests""
6afc7d8c "Make sure all methods have a correct name."
9334a341 "Add image loading=lazy data: and Blob URL WPTs"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I9d4c405c675f8d6dd9cf462388d51a8769104eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303570Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789307}

Adds 2 params to restrict title and non-prefix autocompletion
respectively.

RichAutocompletionAutocompleteTitlesMinChar
RichAutocompletionAutocompleteNonPrefixMinChar

Bug: 1062446
Change-Id: I9df7c8138d0586a2b2e4d3506f951c9ecd134f77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300928
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789306}

Bug: 1099376
Change-Id: I8d88e6ef7d4e0911ea85715c334915a11d7aa3eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303971
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789305}

This reverts commit 02303ee2.

Reason for revert: Original CL did not cause the test failure

Original change's description:
> Revert "fido: make AuthenticatorTestBase set the MOCK_TIME TaskEnvironment trait"
> 
> This reverts commit f55cd37e.
> 
> Reason for revert: The tests testAuthenticatorImplGetAssertionBridge_resultCanceled and testAuthenticatorImplGetAssertionBridgeWithUvmRequestedWithUvmResponded_success in org.chromium.chrome.browser.webauth.Fido2CredentialRequestTest consistently fail on android-pie-x86-rel since https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1498.
> This CL is the only one that touches authenticator_impl around that time. Revert it to see if it can fix the failure
> 
> Original change's description:
> > fido: make AuthenticatorTestBase set the MOCK_TIME TaskEnvironment trait
> > 
> > This allows us to get rid of base::Timer injection into
> > AuthenticatorCommon, which tests used to wait for requests to time out.
> > 
> > Also get remove a number of superfluous RunUntilIdle() calls, and of
> > calls to OverrideLastCommittedOrigin() where SimulateNavigation() would
> > suffice.
> > 
> > Change-Id: I8cb4980d51efe43f59d828cde5f34ce67d38d928
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299630
> > Auto-Submit: Martin Kreichgauer <martinkr@google.com>
> > Reviewed-by: Jared Saul <jsaul@google.com>
> > Reviewed-by: Adam Langley <agl@chromium.org>
> > Commit-Queue: Martin Kreichgauer <martinkr@google.com>
> > Cr-Commit-Position: refs/heads/master@{#788885}
> 
> TBR=agl@chromium.org,jsaul@google.com,martinkr@google.com
> 
> Change-Id: I47c8796582f40f1946811b5eca4ae3cdfe5aac0f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303030
> Reviewed-by: Haiyang Pan <hypan@google.com>
> Commit-Queue: Haiyang Pan <hypan@google.com>
> Cr-Commit-Position: refs/heads/master@{#789079}

TBR=agl@chromium.org,jsaul@google.com,martinkr@google.com,hypan@google.com

# Not skipping CQ checks because this is a reland.

Change-Id: I0a07662127df43624d7fa69c165d2503107514aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303567Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#789304}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I04e1a6ac9005b9f6220d6801a85f1be3c838cefd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303454Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789303}

<dialog> instances by default are absolutely positioned with
respect to the <html> element. Moreover, it seems that setting
"position: relative" on any of its parents does not have any effect.

Using "position: fixed" fixes both issues (scroll position flashing
and action menu scrolling away after opening).

Fixed: 1105643
Change-Id: I1b0a5ca653b37b5455c237b2917ca79e4556af1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302747
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789302}

Client is responsible for closing the menu when it system-back is
pressed, but our configuration of the bottom sheet swallows the back
event and does nothing.

Bug: 1106425, b/161381371
Change-Id: Ide491bd1f59cfd15e148ee9454e93a0785b33e07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300882
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789301}

Currently, the AdsPageLoadMetricObserver only records the FCP of the
root ad frame in FrameData and ignores FCP of any child frames except
for an ephemeral check while computing the Creative Origin Status.

This can lead to an situation where a child frame receives an
First Eligible to Paint and then an FCP, allowing calculation of
the Creative Origin Status, but the root ad frame has not yet
received an FCP, so the FrameData's timing object still
holds a null value for the FCP. Then, if a request to nullify the
First Eligible to Paint value for the frame tree arrives, under the
current setup it will succeed, and then a DCHECK for a non-null FEtP
will subsequently fail.

Further changes to fix the related bug in the FCP ads metric will be
in a follow-up CL.

Bug: 1103610,1103782
Change-Id: I4234ada8a6d0d98e2cf153522bd15e0d86efd8dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290775
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789300}

We can't use GPU compositing without a GPU process. This fixes a problem
in cast_shell_internal_browsertests that's occurring after 966e62f6
("[scheduler] Enable prioritize until begin main frame by default.").

Change-Id: I36eb9f615775e19f81fe24f8a532085fb9483ed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303874
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789299}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ia028635352bd4b9893718049b659fcb669d1bc8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303870Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789298}

Adds the DocumentScan.SaneBackend enum, as well as the
DocumentScan.{ScanRequested,ScanSucceeded,ScanFailed} metrics. These are
used to track which SANE backend a user requested when a scan is
started, as well as the backend used when a scan finished successfully
or unsuccessfully.

Metrics are added by https://crrev.com/c/2281282

Obsoletes the ScanResult metrics since it is superseded by the new
metrics.

Bug: b:160472550
Change-Id: I5eae8fb99ee7d09ce39688648a6b6828d9122190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281207
Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789297}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Ifbf63c8eb210128226b78c64e569e28c8f64732b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303776Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789296}

This CL[1] removed the logic that allowed screen readers to focus into
menus. This[2] other CL re-added functionality for generic menu items.
However, buttons within menu items (like those in the Zoom MenuItemView)
weren't fixed.

This CL fixes hot button focus with screen readers. This only fixes the
issue with keyboard navigation, and not with mouse navigation. If you
use your mouse to navigate to a button, it will still select the entire
container.

Bug: 1105917
Change-Id: I3ab23364f2e63f8429e4bc8eba2ace4467a0dd91

[1] c22c3a2a
[2] 7750c6d5

Change-Id: I3ab23364f2e63f8429e4bc8eba2ace4467a0dd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295787Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789295}

Change-Id: I8587d4d75a36b83c8fd38ec43d5f3cbcbc15ed90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297715
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789294}

This is the 2nd reland of 8f372d5f

Reason for reland:
 - Fixed yet-another DEPS-parser in crbug.com/1106435
 - No changes in this CL.

Original change's description:
> Split the cros_boards gclient var into two for fetching QEMU images.
>
> This will help with the TODO at:
> https://source.chromium.org/chromium/chromium/src/+/master:build/config/chromeos/rules.gni;drc=ded9eb5153bb13b3f8821a6fa6fac6b3f0f590fd;l=22
>
> It will also remove the need for hard-coding the names of all these
> QEMU-compatible boards.
>
> Bug: 937821
> Change-Id: Iab180fc012bd694b4908ba0654da93d42e2274fa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265498
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#786005}

Bug: 937821, 1106435
Change-Id: Ia1d47740c4061739f4ad4dfe403f755fd68fdc4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303377Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789293}

Remove //{base,remoting,third_party,ui,weblayer}* from allowlist.

Allow depending on androidx_media_media_java.

LICENSE updates are from upstream, automated by fetch_all.py.

Bug: 1080903,1082904
Change-Id: I20240ab7f065670eb283e16dd32e278750729105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303022
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789292}

This adds a row in the Nearby Share settings subpage for the "Device
name" setting, as well as the dialog which appears when the user clicks
the row. The dialog will be wired up to load and save the device name
in a future CL.

Screenshot of the row in the subpage:
  https://screenshot.googleplex.com/nvHGBot2bWr
Screenshot of the dialog:
  https://screenshot.googleplex.com/p8esPTUpQ5p

Spec in Carbon: https://goto.google.com/czcfm

Bug: b:154863679
Change-Id: I1c79f6059fe926ed945ec77754088e07af783a54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292789
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789291}

A bunch of other components now need explicitly include the dependency.

Bug: 1104380
Change-Id: Ia272d1cae50fdc13f4a38c3448e3abf71bb9cceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298724Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789290}

Targets Mac 10.15.5 in addition to 10.14.6 for the GPU Mac Intel Stable
mixin in preparation for the OS upgrade.

Submitting with no-try due to crbug.com/1106559 blocking submission
otherwise.

TBR=ynovikov@chromium.org

No-Try: true
Bug: 1078489
Change-Id: I4d0dd92d805a2a2cf6e5355012b6f4b4e83884ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302923
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789289}

X11 cursor handling is annoyingly all handled client-side, so we need
to reimplement libxcursor, including reading and parsing the cursor
images from disk.

Since new usages of base::ReadFile() are added, cursor reading cannot
be done on the UI thread like it was previously.  This means every
cursor needs to be async, which adds quite a bit of complexity.

BUG=1066670
R=nickdiego,sky

Change-Id: If63be11bda34c04c56c52085453abbda0ef553bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293616Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789288}

BUG=1066670
R=sunnyps

Change-Id: Icc189028b7d7630d398b1efe7ff55110913d0e48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302735
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789287}

This CL applies a special rule on Files Manager to ensure that its
first context menu item is "New window". A browser test is created to
protect this feature.

Bug: 1102781
Change-Id: I5de587e6d15f377d2b43fffd8d963437f8f41640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295931Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789286}

The third CL in implementing origin-/site-keying of SiteInstances.
https://crbug.com/1085275/#c2 lists the sequence of CLs and what each
will accomplish.

This CL replaces uses of site URL as map keys with SiteInfo in
BrowsingInstance and RenderProcessHostImpl. As a result, maps will be
able to distinguish SiteInfos based on additional criteria, such as
site vs origin keying.

Bug: 1067389, 1085275
Change-Id: Iae821dfb6314968fbe059732ff3c97e84add4212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261216
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789285}

Also fix the section title style in theme_aware.md to be consistent.

Original Author: tluk@

Bug: none
Change-Id: I54b113efb27ec2e98026765c2b11c0bb6e3d2385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297736
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789284}

The BrowserList::CloseCallback is potentially called multiple times (for
each browser window that is closed), and thus it is explicitly converted
to a RepeatingCallback.

Note that this change is working towards cleaning up the files at the
root of chrome/browser, and as such it does *not* fully convert either
BrowserList nor other items that pass in CloseCallbacks, except for
unload_browsertest which is at the root of chrome/browser.

Bug: 1007635
Change-Id: I81525c00814c59db6b0aceee0e31588062b2775c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302937
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789283}

Bug: 1060399
Change-Id: I05e41fa3b48352ddc37b7ccb39d73ac481cf1c47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302917
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789282}

Change-Id: I7abee88a5214a4e7a0a0680e4e46f80ece3f9182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298174
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789281}

This test is still mildly flaky. The issue is that while it waits
for a non-empty paint, this is not always enough. This makes the
test additionally wait for loading to complete and more importantly,
waits for a visual update. The latter is a good signal the renderer
will actually process events.

BUG=1091129
TEST=test only change

Change-Id: Iabc6d2dce83985086c56db916c8cc273e3ed65f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303554Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789280}

Update both metadata-exporter and linux_chromium_component_updater
builders to NOT be tree closers.

Update metadata-exporter builder to be triggered by commits
(contiuously), as opposed to periodically.

Remove all default notifications from these builders because these
are very specific builders and the people notified by default don't have
the context.

Bug: 1106554
Change-Id: Ib5068ff16b6be2c3f00e354b7c9b2dda6162e8b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303600
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789279}

This enum value is not set anywhere (I believe since r414750) except in
some tests.

Bug: 1100977
Change-Id: Ib643ca350704ba240057b097379b415b299a0afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274168Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789278}

This CL fixed an issue in download location prompt status metrics, also
adds a metrics for download later prompt status.

Bug: 1106094,1078454
Change-Id: I17af189721e840a5e29ee7fc89e02506b2b9b689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300806
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789277}

Bug: b/160753530
Test: manual
Change-Id: I4edae4b329f17919ad25aca3800adf79861e6f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287273Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789276}