GitLab

> Partially revert "Don't include web apps with empty names into autocomplete search."
> 
> This reverts commit http://src.chromium.org/viewvc/chrome?view=rev&revision=154070.
> Changing manifest was unnecessary to fix Omnibox issue.
> But change introduced unexpected issue with cloud print dialog hosted under www.google.com/cloudprint/
> 
> If dialog needs to "Sign in" and app's urls list includes dialog url, then "Sign in" is opened in new windows instead of current one. It completely breaks cloud print flow.
> 
> 
> BUG=170301
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12030002

BUG=170301,175696
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/12223111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182041 0039d316-1c4b-4281-b951-d872f2087c98

> Make base compile with no "using base::FilePath".
> 
> For base .cc files not using the base namespace, I added a using since theses
> files should be moved to the base namespace, and then explicit qualification
> will no longer be necessary.
> 
> Review URL: https://codereview.chromium.org/12226121

TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/12207132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182040 0039d316-1c4b-4281-b951-d872f2087c98

* Remove related methods in Extension: Set/GetCachedImage
* Remove related unit tests
* Update all comments mentioning ImageLoadingTracker to mention ImageLoader instead

BUG=163929
TBR=sky@chromium.org (for mechanical changes in chrome/.)

Review URL: https://chromiumcodereview.appspot.com/12213093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182039 0039d316-1c4b-4281-b951-d872f2087c98

Added a unit-test to BookmarkBarViewTest. It opens a context menu. The menu
is dismissed by clicking the mouse outside of it. The underlying view gets
the mouse event after the context menu has exited.

See also: https://chromiumcodereview.appspot.com/11761027

BUG=171891
TEST=manual
Run: 
out/Debug/interactive_ui_tests --gtest_filter='BookmarkBarViewTest20.*'

Review URL: https://chromiumcodereview.appspot.com/12087075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182037 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we were asynchronously reading the manifest at start-up and using
chrome.runtime.getDetails when logging the version string. The latter is more
complicated than it needs to be, and the former doesn't work in Apps v2.

Review URL: https://codereview.chromium.org/12250011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182036 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12224106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182035 0039d316-1c4b-4281-b951-d872f2087c98

It passes locally but fails on the bots. Disabling for now.

BUG=175753

Review URL: https://chromiumcodereview.appspot.com/12217139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175838
TBR=cpu

Review URL: https://codereview.chromium.org/12224122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182033 0039d316-1c4b-4281-b951-d872f2087c98

For base .cc files not using the base namespace, I added a using since theses
files should be moved to the base namespace, and then explicit qualification
will no longer be necessary.

Review URL: https://codereview.chromium.org/12226121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182032 0039d316-1c4b-4281-b951-d872f2087c98

> [cc] Add gl-matrix to cc-frame-viewer 3rd party
> 
> R=vmpstr
> 
> Review URL: https://codereview.chromium.org/12250012

TBR=nduca@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182031 0039d316-1c4b-4281-b951-d872f2087c98

So we confirmed the random crashes have nothing to do with the tests: the cause must be in the content browsertests harness.

BUG=165269
TES=win gpu bots
TBR=kbr
Review URL: https://codereview.chromium.org/12221151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167114
TBR=dimich,dpolukhin

Review URL: https://chromiumcodereview.appspot.com/12220125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182029 0039d316-1c4b-4281-b951-d872f2087c98

Use "GetProtectedFileContents" for obtaining memory usage and fetch perf test data from instrumentation tests.

BUG=175127


Review URL: https://chromiumcodereview.appspot.com/12212137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182028 0039d316-1c4b-4281-b951-d872f2087c98

In WebAudio this can lead to oob reads.  In HTML5 this will cause
garbled audio or oob reads depending on the sample format.  The
guards in place just ensure channel count nor sample format change
between demux and decode.

Video already has similar guards in place via the checks done in
VideoFrame::IsValidConfig during buffer allocation.

BUG=166565
TEST=unit tests pass under ASAN.


Review URL: https://chromiumcodereview.appspot.com/12224114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182027 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=155525


Review URL: https://chromiumcodereview.appspot.com/12223091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182026 0039d316-1c4b-4281-b951-d872f2087c98

Main uninstall should be done in parent process. Child process should only delete program directory. Otherwise Windows sees that uninstall reg path still exists and shows error.


Review URL: https://chromiumcodereview.appspot.com/12211125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182025 0039d316-1c4b-4281-b951-d872f2087c98

bauerb is such a perfectionist.

BUG=175629
TBR=bauerb

Review URL: https://codereview.chromium.org/12218124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174873, 170629


Review URL: https://chromiumcodereview.appspot.com/12220089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182023 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175538

Review URL: https://codereview.chromium.org/12250010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182021 0039d316-1c4b-4281-b951-d872f2087c98

Adds to WalletClient:
- bool HasRequestInProgress(): whether a request is in flight.

Adds to AutofillDialogController:
- bool CanPayWithWallet(): whether not we've had a wallet error.
- string16 AccountChooserText(): the text that the account chooser displays.
- bool AccountChooserEnabled(): whether the account chooser should be underlined/clickable.

Adds to AutofillDialogControllerImpl:
- an implementation of newly added AutofillDialogController methods.
- a way to safely refresh wallet items from the server.

Adds to AutofillDialogViews:
- NotificationArea arrow points at a views::View* above it
- UpdateAccountChooser() accounts for wallet being unavailable.
- padding between |notification_area_| and |account_chooser_link_|.

BUG=163504,168669

Review URL: https://codereview.chromium.org/12221040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182020 0039d316-1c4b-4281-b951-d872f2087c98

Add customize-sync as the associatedControl of the sync setup overlay, enabling
the search page to check its contents.

BUG=174043


Review URL: https://chromiumcodereview.appspot.com/12209076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182019 0039d316-1c4b-4281-b951-d872f2087c98

The idea is simple. Use Autocomplete dynamic field trial group names to indicate which providers should be disabled. This information, due to limitations in field trial design, is passed in the group name in a string form of "DisabledProviders_<bitmask>".

For instance, in order to run a SHORTCUTS ablation, one need to create a field trial with a group name that contains "DisabledProviders_512" (1<<9).

BUG=174694
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12220004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182018 0039d316-1c4b-4281-b951-d872f2087c98

R=vmpstr

Review URL: https://codereview.chromium.org/12250012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182017 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly the Interceptor logic which is now unused.
Also switch DebugDevToolsInterceptor (the last remaining
Interceptor) to a ProtocolHandler.

BUG=146602,161529

Review URL: https://chromiumcodereview.appspot.com/12217095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182016 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182015 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=142637&stop_rev=142593&verbose=on

TBR=

BUG=

Review URL: https://codereview.chromium.org/12225138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182013 0039d316-1c4b-4281-b951-d872f2087c98

and unit test to test yielding + async during Read.

A test that crashes when scoped_refptr to SpdySession deleted
from DoLoop.

Added the following test per rch to test interactions of
yielding + async during Read.

Do the following MockReads and verify all the data is consumed
and SpdySession has yielded during Read.
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 2K
  ASYNC 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 2K

R=rch@chromium.org
BUG=175574,166958
TEST=net unit tests

Review URL: https://chromiumcodereview.appspot.com/12207122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182012 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:175463
TEST=policy_ui_browsertest.cc, see bug.


Review URL: https://chromiumcodereview.appspot.com/12221141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182011 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12218112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182010 0039d316-1c4b-4281-b951-d872f2087c98

In theory it should be disabled when can_lose_context is set to true on XP.  However, this happens in GPU process and we need it in renderer process earlier.

BUG=175149
TEST=content_unittests
TBR=senorblanco
Review URL: https://codereview.chromium.org/12212146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182009 0039d316-1c4b-4281-b951-d872f2087c98

Defend against a compromised renderer sending junk to the browser.

BUG=174895


Review URL: https://chromiumcodereview.appspot.com/12208119

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182008 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bauerb@chromium.org
BUG=175815
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/12226123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182007 0039d316-1c4b-4281-b951-d872f2087c98

Skip policy registration if the user is already signed in.

BUG=175473


Review URL: https://chromiumcodereview.appspot.com/12217135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182006 0039d316-1c4b-4281-b951-d872f2087c98

Preview can update page count, so PageNumberSet may represent page ranges incorrectly. Now PageNumberSet is used as temporarily objects which never stored.

PreviewGenerator stores PageRange which can be compared with other independently of current document size.

Removed code duplication in page ranges parsing code and parse directly to page ranges.

BUG=173822

Review URL: https://chromiumcodereview.appspot.com/12209086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182005 0039d316-1c4b-4281-b951-d872f2087c98

Syzygy is unable to instrument some of the Chrome tests (browser_tests and unit_tests) due to interactions with RTC. Disable them so that we can collect full coverage stats.

BUG=


Review URL: https://chromiumcodereview.appspot.com/12207129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182004 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175665


Review URL: https://chromiumcodereview.appspot.com/12220122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182003 0039d316-1c4b-4281-b951-d872f2087c98

Getting rid of some more native desktop only BrowserList::const_iterator.

BUG=129187


Review URL: https://chromiumcodereview.appspot.com/12213053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175629

Review URL: https://codereview.chromium.org/12209110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182001 0039d316-1c4b-4281-b951-d872f2087c98

Added UMA records for:
* portal detection result
* portal detection duration
* discrepancy with shill's result

BUG=174047
TEST=Manual tests on Lumpy


Review URL: https://chromiumcodereview.appspot.com/12211111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181999 0039d316-1c4b-4281-b951-d872f2087c98