- 07 Mar, 2019 40 commits
-
-
Stephane Zermatten authored
With this change, TouchEventFilterView sets a clip rectangle that avoids the top and bottom bars when drawing. This avoids ever drawing on top of either bars and is also more efficient than the previous implementation, which would draw then clear out some section. Additionally, it uses the top visible offset for drawing, instead of the top content offset. There's a difference of a few pixel, which is visible now because of the presence of the blue border. This change also address the CanvasSize lint warning and stops using canvas.getWidth(), as recommended. Bug: b/125245127 Change-Id: I0ced7df06f1ace285525f9b7328204cc79bbad3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505944 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#638533}
-
Hiroshige Hayashizaki authored
This CL also implements "most-specific wins" rule. https://github.com/WICG/import-maps/issues/102 Bug: 928149 Change-Id: I484266086bbe244de8b43ceeddacc8552307b7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475049 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#638532}
-
Michael Hablich authored
This reverts commit 1bda93b7. Reason for revert: Blocks roll of V8 https://chromium-review.googlesource.com/c/chromium/src/+/1508095/1 Original change's description: > Adopt to new MicrotasksCompletedCallback signature > > V8 updated the signature of MicrotasksCompletedCallback to take a void > pointer user data, and is deprecating the old signature. > This CL updates its user to use the new one. > > Change-Id: I24990f68b2964fa80554689947746636958f59cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504660 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638471} TBR=peria@chromium.org,haraken@chromium.org,tzik@chromium.org Change-Id: I7a5134b417be5c8b2e189e30a488ce09929d5e6e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507875Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#638531}
-
Gauthier Ambard authored
This CL groups the helpers methods for WKNavigationDelegate and WebView. Bug: 938255 Change-Id: Ie8b2142ca16a0d3b07b0eb42bfe6d7046d914150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505507 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#638530}
-
Roman Aleksandrov authored
Hide feature using feature flag. Bug: 927331 Change-Id: I76edb713c491c75d89484c345b763615c22133b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505948 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638529}
-
Gauthier Ambard authored
This CL merge the -setWebView: method to its readonly property. It moves loadHTML: close to its public declaration as it is only here for testing purpose. It also remove +webControllerCanShow, putting its code in its call site. Bug: 938255 Change-Id: If8970a58a5eb99b8be5e67eb1006b088d0dd05d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505444 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df42f3b1d646..cc1308550f58 git log df42f3b1d646..cc1308550f58 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 fmayer@google.com Merge "Use the SharedRingBuffer for sending payload from client to service." Created with: gclient setdep -r src/third_party/perfetto@cc1308550f58 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ifcf2991cd2029a304c91e7e010e9619a692b49f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638527}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b3e27ce9a43..dcb547de1a5c Created with: gclient setdep -r src-internal@dcb547de1a5c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: I799aff9eb20a524fb27c6bcd74a719fb1304f70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507933Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638526}
-
Jérôme Lebel authored
https://drive.google.com/open?id=1942lUZ9_kpjOzIvlrk0I9OBfYpa-pO8A https://drive.google.com/open?id=1atZHLclvCjd3xajAuJW7GCF5N4gtaTVX Bug: 939056 Change-Id: If9480112f5b1174ffa11de35e63f9c719d8fcd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506772Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#638525}
-
Jia authored
AlsReaderImpl previously checked number of ALS config steps to determine if a device should be supported. We now use ModelConfigLoader to load model config that will tell us if a device is supported, hence this cl removes config verification from AlsReaderImpl. Bug: 881215 Change-Id: I273a1b1b518970ae49632622acb25a8cfd69c5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505747 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638524}
-
Jérôme Lebel authored
Few last minute upates on the icon. Signed out: https://drive.google.com/open?id=1aZ0zKE8j04pqDtj7fHKOR_IRT421GXZg Sync error: https://drive.google.com/open?id=10ugnfgeh5wBT2mKweRSVA0UQ-z-_mdx_ Bug: 889470 Change-Id: Ie22e8af005729841a78517e733b55e4acedbe14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505451Reviewed-by:
-
Arthur Hemery authored
A corner case was not supported yet with the NavigationClient, only running interface callbacks with FrameNavigationControl, which caused a connection DCHECK. Bug: 784904 Change-Id: I9dbec944b47584c737c14d4e604d999ca19d50c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503735 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638522}
-
Alexander Dunaev authored
The visual shape of a pointer cursor is rendered at a surface attached to the wl_pointer object and backed by a wl_buffer. The WaylandCursor class tried to reuse the buffer regardless of whether the compositor released it, which resulted in that the cursor shape didn't change when a new bitmap had been submitted. This CL simplifies the process: a new buffer is created and attached each time the new bitmap is submitted, and the old ones are held until the compositor releases them. R=msisov@igalia.com Bug: 928260 Change-Id: I54cf679568276eddbd5c8042d05fe05de25f61d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503374 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#638521}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c71ea170. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 682affef "Implemented setPlaybackRate for scroll-linked Worklet Animations." 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" ab40da96 "Isolation: Remove isolation if we have non-svg replaced content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8c9249b62d687e0aa8040e3fd65af9b65431ad75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507208Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638520}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4499d87dd57a9c6f379328e5dd4246e5abfcb198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507695Reviewed-by:
-
Lowell Manners authored
This is part of a multi-step refactor to remove IndentityAccessor's dependencies on identity internals, replacing them with IdentityManager. Change-Id: Iaaf0e865a220e58f15e09167138b12a21ff2eec7 Bug: 933109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503580 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638518}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45209e43f286..8b3e27ce9a43 Created with: gclient setdep -r src-internal@8b3e27ce9a43 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: I2cf34cf6afbef606e6e252c0f1bfb44a48f51424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506838Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a7a6252..aa2533a5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie56feb956f0de72af962b3349bf9e44ba1cb69b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507553Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638516}
-
Marc Treib authored
It turns out that this needs some more thought, see linked bugs. This also reverts SyncAuthTest.SyncPausedState back to its state from before https://crrev.com/c/1478878. Bug: 906995, 938819 Change-Id: I681c8568b4d31f83ca347b9d45bdd9ff40ed49f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507652 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638515}
-
Miyoung Shin authored
- unsigned long long -> uint64_t - long long -> uint64_t for making the code consistency with the type of BlobDataHandle::size(). - Use std::numeric_limits instead of -1 - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: Icf66ee7d8a4199fe5ceaa5f9f776bfe315ce0bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506914Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638514}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52e620ffd0bd..8e9850cc9584 git log 52e620ffd0bd..8e9850cc9584 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2995dc2a67c7..952d27384a7e (1 commits) Created with: gclient setdep -r src/third_party/skia@8e9850cc9584 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I69508603ee3c302d6ab235390f2e06902665429a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507692Reviewed-by:
-
John Budorick authored
Bug: 938487 No-Try: true Change-Id: I887735faee58cfe04e74359107ed4ab8d15a8ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507196 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638512}
-
Leo Zhang authored
These interfaces is used to load shared library and base classes dynamically into the IME Mojo service at runtime. Bug: 837156 Change-Id: I6da2aba6227ecb0ac91c552783ddf0c6c56e25c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478651 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#638511}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2995dc2a67c7..952d27384a7e git log 2995dc2a67c7..952d27384a7e --date=short --no-merges --format='%ad %ae %s' 2019-03-07 bclayton@google.com Fix windows build Created with: gclient setdep -r src/third_party/swiftshader@952d27384a7e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ic130cdd215a1cbdb3c42eaefe788318b7ca166c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506644Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: 829084 Change-Id: I699e5e8ac655f1b305fff5985a107d29f2200fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506825Reviewed-by:
-
Sylvain Defresne authored
Bug: 936211 Change-Id: If7bef8b0cd9256c961102773478a4afd6da7887c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505510 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638508}
-
Anton Permyakov authored
For unknown key codes presenting in an accelerator 0 is added to the shortcut text. This results in unprintable character to be used on extensions shortcuts settings page. Bug: 936812 Change-Id: I5301660d8110defd908146862a230666af09a07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497072 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#638507}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/79d25ea0ce18..40c16ec0b3ad git log 79d25ea0ce18..40c16ec0b3ad --date=short --no-merges --format='%ad %ae %s' 2019-03-07 johnkslang@users.noreply.github.com Merge pull request #1717 from jeffbolznv/getBufferReferenceAlignment 2019-03-07 johnkslang@users.noreply.github.com Merge pull request #1716 from jeffbolznv/buffer_reference_fold2 Created with: gclient setdep -r src/third_party/glslang/src@40c16ec0b3ad The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibc2f1c00445188fe66ed46e4cf259dc9853ce850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506666Reviewed-by:
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/weborigin with the macros of Allocator. After some analyzes, it was concluded that for the case of ReportingServiceProxyPtrHolder, URLSchemesRegistry, and SecurityOrigin classes, it makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. Bug: 919389 Change-Id: Ibff778b830c479908df8ba454e289f8d604b365a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506057Reviewed-by:
-
Sylvain Defresne authored
Replace usage to instead use JSONReader::ReadAndReturnValueWithError that returns a base::JSONReader::ValueWithError. Bug: 925165 Change-Id: Ifdcc83a2612e4baed32d8c133dbb2f2b2c8640e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505632Reviewed-by:
-
Ioana Pandele authored
This ensures that the feature check is performed only if all prerequisites for the feature are met. Bug: 903249 Change-Id: I0af5bbecff66e2c660b4d6b89cf64dc92fc8d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499517Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#638503}
-
Richard Knoll authored
This properly implements notification sync with the currently displayed notifications if supported by the platform. Bug: 891339 Change-Id: I467931abb54af94dc53f3981492487e5818a45f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505633 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638502}
-
Kazuki Takise authored
Android tells Chrome to activate windows through onTaskMovedToFront, which is called by ActivityStack#moveTaskToFront. For PIP tasks, we reparent them with reparent() and the function inserts them on top without using moveTaskToFront, so we seem to activate them explicitly. confirmed the browser was properly activated. Bug: b/123259430 Test: Exited PIP, pressed the shelf icon of the browser, and Test: atest android.server.am.ActivityManagerPinnedStackTests Change-Id: I7532e4b2c66a28b83168abcf3207266961c9a3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485625 Commit-Queue: Kazuki Takise <takise@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#638501}
-
Richard Knoll authored
This is required for the first version of Notification Triggers until we support scheduling notifications and storing the data in a more general way. Bug: 891339 Change-Id: I614c7279a3a065d6c261ea96d12b6d866f2db6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472695 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638500}
-
Jia authored
This cl contains the following changes 1. Use ModelConfigLoader to provide Adapter with some params. 2. Simplify params used by Adapter. The major changes are (i). We now change brightness as soon as average ambient light changes by more than a threshold. (ii). The ambient threshold is now an absolute value and not a ratio. It is also measured in the log space. 3. Log metrics explicitly for Atlas and Eve Bug: 881215 Change-Id: I45486e4e2cb12083c763a2f0db8b0efd077695af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501895 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#638499}
-
Andrew MacPherson authored
Optional sampleRate parameter to AudioContextOptions, if provided then the AudioContext will run at this sampleRate, otherwise it will run at the hardware rate. Running the AudioContext at a lower sample rate can allow running a heavier graph on low-end devices, for example if a given device is able to run with X nodes at a sample rate of 48k, it can support roughly 2X nodes at 24k or 4X nodes at 12k. Bug: 432248 Change-Id: I835f28b4625763bd6a6ddbee9b89636ef8a8a066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482957Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#638498}
-
danakj authored
WebViewHelper is a WebWidgetClient even though WebViewPlugin's WebView is not composited. So set it up as the WebWidgetClient after attaching the main frame. R=dcheng@chromium.org, tommycli@chromium.org Bug: 920952, 912193 Change-Id: I8391bde1d0452cf78d23a8b855a45497bac02d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504142 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#638497}
-
Andrew Moylan authored
These were added in http://crrev.com/c/1352824 (model_impl.h) but we didn't add them to enum.xml yet. Bug: 933200 Change-Id: If18be5107be2124797f72f0f290c0666e61a3c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496122Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638496}
-
vitaliii authored
Enable using Scrypt to derive the key when encrypting data with a new custom passphrase in Chrome Sync (starting from M74). I manually tested the functionality locally. We have a kill switch, which we can use if we decide not to launch in M73/M74. Bug: 875901 Change-Id: I37dee9a66e0f519e963a6b3a13887c3bf8b2e049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497141Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#638495}
-
Miyoung Shin authored
- unsigned long long / long long -> uint64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: I24e97b5d2c3068e092d2f40a45920991468a06bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507294Reviewed-by:
-
