GitLab

WebContentsView::Focus() is supposed to update the first responder of the
Window, not make the window focused. The latter should go through
WebContentsDelegate::ActivateContents().

This logic is usually a no-op because the window receiving the call is the
active window. But in the case where the user quickly switches windows, this can
cause the old window to re-take focus.

This logic was added in 2009 not because it had the right semantics, but to
match the behavior of Windows: http://codereview.chromium.org/165492.

Bug: 859614
Change-Id: I2bc44a825d93159d774c632da17cc2f2d151fc3a
Reviewed-on: https://chromium-review.googlesource.com/1124772Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573344}

Implemented grid control patterns in GetPatternProvider, allowing for grid operations through UI Automation

R=nektar@chromium.org,dmazzoni@chromium.org

Bug: 855153
Change-Id: Ibe0934768b57e8c8601fbcd88d2b687ea6486293
Reviewed-on: https://chromium-review.googlesource.com/1112568
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573343}

The Generic Sensors API has already been shipped however in
runtime_enabled_features.json5 it was still set to "experimental"
because it was shipped by setting the default value of the
device::kGenericSensors flag to enabled. This change reflects that in
Blink and reverses the logic in runtime_features.cc so that disabling
the Chrome flag will disable the Blink flag.

Bug: 750018
Change-Id: If11794bc915f6e73e82c55efcda50c5f58859a0a
Reviewed-on: https://chromium-review.googlesource.com/1128396Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573342}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f4422e27..a7788c48

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5f43dd25cc1587588eb2e5b28ce935d0e507acf5
Reviewed-on: https://chromium-review.googlesource.com/1129199Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573341}

https://skia.googlesource.com/skia.git/+log/373224c9ab3a..1354048c8fa8


git log 373224c9ab3a..1354048c8fa8 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 bsalomon@google.com Add genIDs from all contributing elements to GrReducedClip's mask key.


Created with:
  gclient setdep -r src/third_party/skia@1354048c8fa8

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: Ibc2eb7485295ed15d65bbef01dfaf6d4e2babf02
Reviewed-on: https://chromium-review.googlesource.com/1129081Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573340}

Bug: 860549
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I33498b8cfa4a94a762b351e4968ca1b6b95c71d9
Reviewed-on: https://chromium-review.googlesource.com/1127850
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573339}

This is a prerequisite for switching WindowedNotificationObserver to use
base::RunLoop instead of deprecated MessageLoopRunner.

This CL is split out from https://crrev.com/c/982612.

This CL was uploaded by git cl split.

R=skuhne@chromium.org

Bug: 668707
Change-Id: I3bd19577a68a77d450b8c3bfaff5dda39813b66d
Reviewed-on: https://chromium-review.googlesource.com/1120497
Commit-Queue: Alexander Semashko <ahest@yandex-team.ru>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573338}

Also cleanup some includes to make sure that we don't include
tab_manager.h on Android.

Bug: 773383
Change-Id: I3f7c5492e3815f5f9033163c8ef422b278de369a
Reviewed-on: https://chromium-review.googlesource.com/1126484
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573337}

http_auth_handler_negotiate.cc is only included if use_kerberos is set,
so its tests should only be included then too.

Since the existing USE_KERBEROS define was internal to net, use the
BUILDFLAG system to make it accessible outside of net.

use_kerberos is true on Android but the test used to not run on Android.
Maybe used should be false on Android, but for now this preserves behavior.

This makes services_unittests link on the Cast bots, enabling
https://chromium-review.googlesource.com/c/chromium/src/+/1128939

No behavior change.

Bug: 843511
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic363bcd7cac928bc323f3872d7beaa827fc9a1cc
Reviewed-on: https://chromium-review.googlesource.com/1129259Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573336}

Change-Id: I9f1929070b2b76af66e94e91de94935eb3945558
Reviewed-on: https://chromium-review.googlesource.com/1128568Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573335}

This CL changes the order to check flags in LockManager::request
to be conformant with its spec[1], and adds comments to show
which step each part works for.

This is a follow-up CL for https://crrev.com/572244


[1]: https://inexorabletash.github.io/web-locks/#api-lock-manager

Bug: 855968
Change-Id: Ie47013eb77df91fe6ad1b42858f17cc4777f3638
Reviewed-on: https://chromium-review.googlesource.com/1126745Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573334}

GetAllPolicyValues function requires SchemaRegistryService for the unknown
policy error. SchemaRegistryService is not avaiable for the offTheRecord
BrowserContext. Original profile is needed for the error message.

Bug: 860741
Change-Id: I6bf7cbf10d03c4c71b75d9a9b01264f5a2d6fcc5
Reviewed-on: https://chromium-review.googlesource.com/1128173Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573333}

For android emulator.

On android emulator /proc/cpuinfo starts with 'processor'
Use case insensitive compare to cover this case and
simplify logic.

Change-Id: I06b880df4b2fcd01a7f2717b535727d7560140e4
Reviewed-on: https://chromium-review.googlesource.com/1124851Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573332}

Bug: 833482
Change-Id: I359fd5b64701fd9e960ad380231206e8b268efeb
Reviewed-on: https://chromium-review.googlesource.com/1116245
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573331}

Bug: 841735
Change-Id: I5a38422269e6635c6cc7b4880c1a9108b0bd3761
Reviewed-on: https://chromium-review.googlesource.com/1129231Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573330}

https://chromium.googlesource.com/catapult.git/+log/45198367e90a..27380b171e3f


git log 45198367e90a..27380b171e3f --date=short --no-merges --format='%ad %ae %s'
2018-07-09 perezju@chromium.org [Telemetry] Flush tracing on browser close


Created with:
  gclient setdep -r src/third_party/catapult@27380b171e3f

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:854212
TBR=sullivan@chromium.org

Change-Id: I3be00888706587ebe35ec5275b598388cb095acc
Reviewed-on: https://chromium-review.googlesource.com/1129079Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573329}

The only difference that required per platform expectation files was
the fact that 'hyphens: auto' is only supported in Chromium on Mac.

These tests don't care about the actual css property value but how one
value is animated to another in web animation interpolation model. So instead of
using 'auto' for hyphens, we use 'none' which is supported on all platforms.
This help remove three 500+ lines per platform expectation files and reduce
unnecessary maintenance burden.

Change-Id: I5f3b716ce11a72a5235e7899d2e90f4bbea77ebc
Bug: 860359
Reviewed-on: https://chromium-review.googlesource.com/1129201Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573328}

Bug: 832054
Change-Id: Ic5ed8f68855ab9cbc5b49aad6fd214cd943e1eb1
Reviewed-on: https://chromium-review.googlesource.com/1125072
Commit-Queue: Tove Petersson <tovep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573327}

When a tree node is hovered over, an information card displays breaking down
the contents of that node. This is based on the hover effect from the old UI.

For symbols, this is a card with its full name, byte size, and type, showing
information similar to what is currently represented by the "title" attribute.

For containers, this is a card that also includes a breakdown of the symbol
types within that container. A table listing the sizes and percentags is
displayed, as well as a pie chart rendered with the Canvas API.

Demo:
https://notwoods.github.io/chrome-supersize-reports/monochrome-2018-07-06/

Bug: 847599
Change-Id: Ie33ea09bc3476e260d70391c5b2e88597f09a69d
Reviewed-on: https://chromium-review.googlesource.com/1127857
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573326}

The new GetState replaces calls to CanSyncStart, IsSyncActive, and
ConfigurationDone. (Unfortunately GetAuthError is still required to
distinguish transient from persistent errors.)

One change in behavior is that transient auth errors now map to
INITIALIZING instead of ACTIVE. That's because with GetState, we can't
tell if sync was actually active before the auth error happened. But
this change seems like an improvement anyway.

Bug: 839834, 856081
Change-Id: I2ccee268ffe226817289950f4db5c7f98ea69487
Reviewed-on: https://chromium-review.googlesource.com/1124567Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573325}

Bug: 861639
Change-Id: Ibe5c66c644be5ce61d9d817d14f24ab5988d1f9c
Reviewed-on: https://chromium-review.googlesource.com/1128887Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573324}

Historical console tests should be re-enabled after deprecated console
methods are removed.

Bug: 706804
Change-Id: I4e4ae9c98a95a142168f2eaf45724ee172408766
Reviewed-on: https://chromium-review.googlesource.com/1123773Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#573323}

Change-Id: I1e14b3451a221931ad5dd55576e0cd476121e6cc
Reviewed-on: https://chromium-review.googlesource.com/1127855Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573322}

Bug: 859585
Test: An active chrome window with one tab should have a white titlebar with a separator between the tab close X and trailing new tab button.
Change-Id: I35c61f0a19f16f9020e4416efe735c2af0978219
Reviewed-on: https://chromium-review.googlesource.com/1128276Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573321}

This makes it consistent with all other trace probes in the component.

TBR=jkarlin@chromium.org

Bug: None
Change-Id: Id4d8d628bdfb9c066290f3a3c7a6b2ea99d3918b
Reviewed-on: https://chromium-review.googlesource.com/1129043Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573320}

Cleanups are:
 - WMPI: drops the usage of the callback for delayed Picture-in-Picture;
 - WMPI: drops pip_surface_id_ and request it from the bridge_ instead;
 - SurfaceLayerBridge: no longer set primary surface id when surface is created;
 - SurfaceLayerBridge: no longer sets size when surface is activated.

Bug: 858826
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7ed0490207aa3966e5dc8d04e796558e8965232f
Reviewed-on: https://chromium-review.googlesource.com/1126450Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573319}

This allows the user to interact with the omnibox with mouse
events while the results pane is showing.

BUG=836829

Change-Id: Iec6eee4bf55ca82efdfdb5654f2fee86bd5975f5
Reviewed-on: https://chromium-review.googlesource.com/1128198Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573318}

There is 22em space instead of 15em. Related to http://b/110768130

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7a7100db1b07e72ebb41104fbfbfec6b9433ff5a
Reviewed-on: https://chromium-review.googlesource.com/1126243Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573317}

Change-Id: Iba199e52bb978ad12e4ecfc4cd5ea61151b780af
Reviewed-on: https://chromium-review.googlesource.com/1118282Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573316}

Since Autofill does not fill field by field anymore, this simplifying
and deduping of suggestions is not useful anymore.

Bug: 858820
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I36f7cfe425a0bdbf5ba7503a3d96773b405cc19b
Reviewed-on: https://chromium-review.googlesource.com/1128255Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573315}

base::EscapeJSONString appends to the given output string. Since the
fuzzer used a global string, it eventually runs out of memory.

BUG=None
TEST=Fuzzer runs for a long time without OOM.
     OOM error should eventually vanish here:
     https://clusterfuzz.com/v2/testcases?fuzzer=libFuzzer_base_json_string_escape_fuzzer&open=yes&project=chromium

Change-Id: Idb75cb00b437e6e42aa69d847b58f69040b4bde9
Reviewed-on: https://chromium-review.googlesource.com/1125078
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573314}

This is basically a dumping ground of everything still of value in my original
giant tab layout CL.  I could probably split this into a couple CLs, but it's
late, and I figure it's not so huge you can't just review it :P

* Add a function to get drag insets for a tab.  Tab dragging is kind of wonky,
  but for now this is an expedient change that makes it so it's possible to drag
  a tab to become the leftmost tab when tabs are narrower than 32 DIP.
* Use this new function in TabDragController and TabScrubber.  In TabScrubber,
  the old code used half the pinned width as a drag inset; in tracing the blame
  history of the old code, I suspect the origins (many years ago) were "try to
  use half the width of the smallest tab".
* Move Tab::FrameColorsChanged() to be by the other XYZChanged() functions.
* Rename kRefreshExtraLeftFavIconPadding because, now that close buttons are
  back on inactive tabs, it really is supposed to function like the pre-refresh
  constant did, and balance the whitespace inside the tab close button.
* Eliminate some uses of the showing_xyz_ members in hopes of eventually
  eliminating them altogether and doing icon visibility calculations in
  Layout().
* Resolve some TODOs in stacked tab dragging: I _think_ the answer to my TODOs
  was "yes".
* A few other small simplifications.

Bug: none
Change-Id: I760fa0dafd935dfcb1b2173812d93f40bc0fa0b1
Reviewed-on: https://chromium-review.googlesource.com/1123882
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573313}

We can use corresponding mojo structs directly.

Change-Id: Ie61da1d14c5abf1cdd94c90f115273818a2b0b5c
Reviewed-on: https://chromium-review.googlesource.com/1124669Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573312}

Filtering options have been added to the side of the tree view, bringing the
tree view UI to feature parity with the old UI. Filtering selectively hides
nodes from the tree view, and was previously avaliable as a dialog.

Added filters:
- Select which symbol types to show
- Set the minimum symbol byte size
- Only show symbols that match a certain regex
- Hide symbols that match a certain regex

Demo: https://notwoods.github.io/chrome-supersize-reports/monochrome-2018-07-05/

Bug: 847599
Change-Id: If13d8f8de973b114a49a44268c63e8b033530806
Reviewed-on: https://chromium-review.googlesource.com/1127145Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#573311}

Experimental implementation of ThreadController which
uses MessagePump directly. The goal is to drop SequenceManager
dependency on MessageLoop. Some SequenceManagerImpl unittests
now run this new implementation and eventually all the tests
will get ported.

Change-Id: Ib945c76375f8abfbabc6b1f9c5d27900696c9208
Reviewed-on: https://chromium-review.googlesource.com/1127049Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573310}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values:

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Additionally there are done some other trivial cleanups.

Change-Id: I2bab90a73c779e8fac3c8d62d2090f6bd0888800
Reviewed-on: https://chromium-review.googlesource.com/1128091Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573309}

https://webrtc.googlesource.com/src.git/+log/d497e6bd6b65..1208cbb3ec07


git log d497e6bd6b65..1208cbb3ec07 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 buildbot@webrtc.org Roll chromium_revision 53ed5722..a9fbefaa (573145:573255)


Created with:
  gclient setdep -r src/third_party/webrtc@1208cbb3ec07

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I3ecf7840f2e57437038f56c20fb0c06e690f707f
Reviewed-on: https://chromium-review.googlesource.com/1128802Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573308}

GaiaCookieManagerService::ListAccounts() takes in out-params to
populate with the current cached state of the accounts and returns a
bool indicating whether the cached state is valid. Its contract
specifies that if the returned bool is false, the out-params should be
ignored.

This CL changes the semantics of GaiaCookieManagerService::ListAccounts()
to always populate its out-parameters, even if its cached state is
stale. We verified manually that all current clients of this method
guard the usage of the out-params via a check that the returned bool is
true, so this semantic change will not affect any existing clients.

The reason for making this semantic change is that there is an
upcoming consumer that wants to have synchronous access to the
latest cached state of the accounts, regardless of whether that state
is stale.

Bug: 859882
Change-Id: I47fc55bb2fad6caf9a2fc5911c8f60f97e4bc5a6
Reviewed-on: https://chromium-review.googlesource.com/1128892Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573307}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/796e1ea7..f4422e27

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6e6f1fd9a9f7de8e6555747f623c5d01468e3dca
Reviewed-on: https://chromium-review.googlesource.com/1128807Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573306}

Change-Id: I1e2681b3e89e7101684acf5e4e05e6786506879d
Reviewed-on: https://chromium-review.googlesource.com/1120739Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Chris Bentzel <cbentzel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573305}