GitLab

BUG=

Review URL: https://codereview.chromium.org/647053003

Cr-Commit-Position: refs/heads/master@{#299796}

For File URI, some earlier android versions (<JB MR2) cannot handle it correctly
Convert it to absolute path fixes the issue.
For JB MR2 and above devices, we use content URI, so not affected.

BUG=423338

Review URL: https://codereview.chromium.org/655303002

Cr-Commit-Position: refs/heads/master@{#299795}

Revert of Eliminate silently letting errors pass on pak loading. (patchset #18 id:340001 of https://codereview.chromium.org/537063002/)

Reason for revert:
Causing content_browsertests failures due to pak loading failure.

Original issue's description:
> Eliminate silently letting errors pass on pak loading.
>
> BUG=410411
> TEST=no visible change
>
> Committed: https://crrev.com/03c8c9d936594163d43222a3da0268b3dd9af656
> Cr-Commit-Position: refs/heads/master@{#299717}

TBR=bengr@chromium.org,caitkp@chromium.org,tfarina@chromium.org,tony@chromium.org,avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410411

Review URL: https://codereview.chromium.org/661503003

Cr-Commit-Position: refs/heads/master@{#299794}

BUG=405865,417048,419373
NOTRY=true
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/661653005

Cr-Commit-Position: refs/heads/master@{#299793}

One external invariant of RWHVAndroid is that if it has a valid attached
ContentViewCore, its TouchSelectionController will be non-null. However,
there are no guarantees that these lifetimes hold for methods *internal*
to RWHVAndroid. One such violation came when the frame had a non-zero
lock count when the attached ContentViewCore was changed; releasing the
surface lock caused a frame metadata update, in turn accessing the
TouchSelectionController that had already been reset.

As a workaround, guard against this and possible future violations by
always checking the controller for validity before using it.

BUG=419619

Review URL: https://codereview.chromium.org/653883003

Cr-Commit-Position: refs/heads/master@{#299792}

He's no longer working on chromium, so this confuses people
looking for a reviewer.

R=enne

Review URL: https://codereview.chromium.org/654293004

Cr-Commit-Position: refs/heads/master@{#299791}

In r546e2e69 GetSheetParentBoundsForParentView was added to work around
the presense of dev tools in the view hierarchy when calculating the center
of the web contents view. In an app window there is no dev tools view so
this patch falls back to the parent view's normal bounds.

BUG=

Review URL: https://codereview.chromium.org/659823003

Cr-Commit-Position: refs/heads/master@{#299790}

BUG=394895,412547

Review URL: https://codereview.chromium.org/601333002

Cr-Commit-Position: refs/heads/master@{#299789}

This replaces some copy-pasted snippets of code with a centralized
utility for securely initializing a SecureRandom instance (needed for
Android versions <= 4.3).

BUG=402732

Review URL: https://codereview.chromium.org/624183002

Cr-Commit-Position: refs/heads/master@{#299788}

Revert of [src/chrome/browser/] Declaring the weak_ptr_factory in proper order in ui and prerender (patchset #1 id:1 of https://codereview.chromium.org/612783003/)

Reason for revert:
Author ignored review comments from multiple reviewers and failed to fix or revert his change after repeated inquiries as to why.

Original issue's description:
> [src/chrome/browser/] Declaring the weak_ptr_factory in proper order in ui and prerender
>
> Cleaning up weak_ptr_factory destruction order.
> WeakPtrFactory should remain the last member so it'll be destroyed and
> invalidate its weak pointers before any other members are destroyed.
>
> BUG=303818
>
> Committed: https://crrev.com/5c10e8618bb1c326b18395224b46c41f60867b30
> Cr-Commit-Position: refs/heads/master@{#299059}

TBR=cbentzel@chromium.org,dcheng@chromium.org,kulkarni.a@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=303818

Review URL: https://codereview.chromium.org/658943002

Cr-Commit-Position: refs/heads/master@{#299787}

BUG=418375

Review URL: https://codereview.chromium.org/645763004

Cr-Commit-Position: refs/heads/master@{#299786}

BUG=290407,332328,370206
NOTRY=true
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/642513003

Cr-Commit-Position: refs/heads/master@{#299785}

These were flaky because we changed to returning profiles in reverse chronological order: https://codereview.chromium.org/600873002

The tests assumed normal chronological order. It only failed sometimes because frequently two items would get inserted with the same timestamp, so ordering fell back to GUID. Thus by placing sleep(1) in between AddProfile calls, the flaky failures become consistent failures.

BUG=420023

Review URL: https://codereview.chromium.org/652193005

Cr-Commit-Position: refs/heads/master@{#299784}

These will be developed in GN only from now on.

BUG=423889

Review URL: https://codereview.chromium.org/647263005

Cr-Commit-Position: refs/heads/master@{#299783}

R=enne

Review URL: https://codereview.chromium.org/657103003

Cr-Commit-Position: refs/heads/master@{#299782}

BUG=407376
TEST=no change

Review URL: https://codereview.chromium.org/659843002

Cr-Commit-Position: refs/heads/master@{#299781}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0e08fc1..8dfdfff

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/655333002

Cr-Commit-Position: refs/heads/master@{#299780}

Only added in API 17:
http://developer.android.com/reference/android/view/View.html#setTextDirection(int)

BUG=411056

Review URL: https://codereview.chromium.org/644283003

Cr-Commit-Position: refs/heads/master@{#299779}

Review URL: https://codereview.chromium.org/662503002

Cr-Commit-Position: refs/heads/master@{#299778}

Adds a missing type that was introduced in
https://crrev.com/55721c1fd3bb640d29491407572c7dbb56975ca5

Review URL: https://codereview.chromium.org/654323002

Cr-Commit-Position: refs/heads/master@{#299777}

This frees ExtensionDownloader of any remaining
dependencies on //chrome in preparation for its
move to //extensions/browser.

The move is left for a follow-up CL.

BUG=398671

Review URL: https://codereview.chromium.org/651403003

Cr-Commit-Position: refs/heads/master@{#299776}

Fix indentation issues to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/657163004

Cr-Commit-Position: refs/heads/master@{#299775}

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3963
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/657933002

Cr-Commit-Position: refs/heads/master@{#299774}

The base method was removed in https://codereview.chromium.org/646133002/
so this is dead code.

R=enne
BUG=342848

Review URL: https://codereview.chromium.org/638213004

Cr-Commit-Position: refs/heads/master@{#299773}

BUG=

Review URL: https://codereview.chromium.org/657163002

Cr-Commit-Position: refs/heads/master@{#299772}

The extern template class declaration prevents the compiler
from ever inlining methods even when they are in the .h file
and it makes sense to do so.

Stop templating the classes to remove the extern template class
and allow the compiler to make better decisions about inlining.

Performance numbers are at https://crbug.com/407444#c13 This
drops up to 200us off our total thread times per frame.

It also decreases the size of the android binary as shown in
the https://crbug.com/407444#c12 by 3613 bytes before even
removing the RectBase class from the build.

This also makes finding and reading the public API for Rect and
RectF classes much easier for developers.

BUG=407444

Review URL: https://codereview.chromium.org/506803004

Cr-Commit-Position: refs/heads/master@{#299771}

The Nexus 5 throttles CPU clock quickly under load, going from 2.27GHz
down to 1.19GHz.  Current Performance Dashboard results show this,
as they tend to ping-pong between best & worst thermal states.

This CL turns on all 4 cores on N5, and limits CPU to 1.19GHz which matches
scaling under high load.

It also limits GPU from 450MHz down to 200Mhz.

BUG=383566

Review URL: https://codereview.chromium.org/652343002

Cr-Commit-Position: refs/heads/master@{#299770}

The request stats are kept per process, and we were incorrectly transferring
the entire process's stats when only a single request was being transferred.

BUG=423570
TEST=Visit a page with 2 cross-site iframes using --site-per-process.

Review URL: https://codereview.chromium.org/648803002

Cr-Commit-Position: refs/heads/master@{#299769}

BUG=

Review URL: https://codereview.chromium.org/660523004

Cr-Commit-Position: refs/heads/master@{#299768}

BUG=321868
TBR=msw

Review URL: https://codereview.chromium.org/630583002

Cr-Commit-Position: refs/heads/master@{#299767}

Update the plugin cmake files to explicitly depend on Clang. When we moved
to the approach of building tools and plugins inside the LLVM build in
https://codereview.chromium.org/615083006/, that dependency was lost. We should
find a better way to do this eventually.

Also move the code to clear the CHROME_TOOLS_SHIM_DIR earlier in the script
to avoid having it affect the bootstrap build.

BUG=420674
NOTRY=true

Review URL: https://codereview.chromium.org/630163005

Cr-Commit-Position: refs/heads/master@{#299766}

This CL does the following:
1) Re-enables two test cases in sync_errors_test.cc and converts them
   to use FakeServer. ErrorWhileSettingUp and
   BirthdayErrorUsingActionableErrorTest. Note that ErrorWhileSettingUp
   still fails on Chrome OS, so a separate (disabled) case has been
   created.
2) Adds a feature to FakeServer where triggered errors are sent back to
   the client on every other request (as opposed to every request).
3) FakeServer::TriggerError() now returns a bool to indicate success.
4) Removes dead code (unused as a result of the conversion to
   FakeServer) from SyncTest.

BUG=400806,406545

Review URL: https://codereview.chromium.org/650463003

Cr-Commit-Position: refs/heads/master@{#299765}

TBR=raymes

Review URL: https://codereview.chromium.org/659853002

Cr-Commit-Position: refs/heads/master@{#299764}

Dummy change primarily to kick the GPU Mac Builder's timestamps.

BUG=none
R=dcheng@chromium.org

Review URL: https://codereview.chromium.org/646773006

Cr-Commit-Position: refs/heads/master@{#299763}

- Add assets for xxxhdpi
- Add some missing assets for other dpis.

BUG=403506

Review URL: https://codereview.chromium.org/655743003

Cr-Commit-Position: refs/heads/master@{#299762}

BUG=423873
R=erg@chromium.org

Review URL: https://codereview.chromium.org/661593002

Cr-Commit-Position: refs/heads/master@{#299761}

BUG=421695
TEST=gpu win debug bots go green
TBR=kbr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/646313003

Cr-Commit-Position: refs/heads/master@{#299760}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/157f36d..0e08fc1

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/641313004

Cr-Commit-Position: refs/heads/master@{#299759}

They got slower because of http://src.chromium.org/viewvc/chrome?view=rev&revision=292457 which readded --test-launcher-batch-limit=1

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/658893002

Cr-Commit-Position: refs/heads/master@{#299758}

BUG=398671

Review URL: https://codereview.chromium.org/657693002

Cr-Commit-Position: refs/heads/master@{#299757}