- 26 Feb, 2020 40 commits
-
-
Anders Hartvoll Ruud authored
The link_match_type stored on the MatchedProperties object is only relevant and correct if we're inside a link, hence we need to override the effective link_match_type at some point. Previously, we would do this apply-time, and not as part of the rule- collection. This CL instead proposes that ElementRuleCollector take the link-status into account, and perform the adjustment before storing the link_match_type on MatchedProperties, such that no further adjustments are required later. This fixes a bug in the CSSCascade path, where we would incorrectly not apply anything for selectors such as *:not(:link):not(:visited), even for elements that are not inside links. (See AddLinkFilter in cascade_expansion.cc. We would switch on the value 0, and then enter the default case, causing a filter to be added on kProperty, which causes all properties to be rejected. This is correct for elements that are inside links, but not for elements that aren't). Bug: 1055715 Change-Id: I2b63de41753fb0fa7b637a4be5bd009c2f165fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072223Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#744631}
-
Rune Lillesveen authored
System colors used in CSS should per spec depend on the used color-scheme for that element. Since the used color-scheme may not be the same as the preferred color-scheme, we need to provide the system colors for both light and dark at the same time. This CL temporarily sets the appearance to light and dark aqua to retrieve those colors. TEST=StyleEngineTest.InitialColorChange Bug: 929098 Change-Id: I4bb9553cf1b2fc4e98cd1c7c13041adce3e50353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860023 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744630}
-
David Jean authored
Bug: 1049638 Change-Id: Ia577c0ab73a9107c19cbf38b4b21dbab793fcbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074158Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#744629}
-
Hirokazu Honda authored
VideoFrameValidator compares a video frame passed on Process() with the model frame. The model frames are set at Initialize() and VideoFrameValidator keeps them during the test. The memory usage of the model frame can be large if we use VideoFrameValidator for encoder test. We would rather give VideoFrameValidator a callback to get a model frame, so that we can keep model frames needed at that time in the test. Bug: 1044452 Test: image_processor_test on kevin Change-Id: Id3a4a76c8d149bb5e4b349ab67a087bc9bdaf45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024769 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#744628}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I502cdf3c58ea37dc11fe23eeed3de9204f0f5d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073786Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744627}
-
Morten Stenshorne authored
Some tests have started to pass, presumably due to NGFragmentItem improvements. TBR=kojii@chromium.org Bug: 982194, 1043787 Change-Id: I827d10c8f7794b73592a2fe2e436adf6ef5ab123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073883Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#744626}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1c105ca31096..1b146d522e7b git log 1c105ca31096..1b146d522e7b --date=short --first-parent --format='%ad %ae %s' 2020-02-26 mathias@chromium.org Revert "[e2e] Add user metrics tests" Created with: gclient setdep -r src/third_party/devtools-frontend/src@1b146d522e7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1e6d6f4afb108fd2ac9318964fa7d4361a5cf138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073785Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a6db9c8fe927..c310889ec791 git log a6db9c8fe927..c310889ec791 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 sprang@webrtc.org Revert "Reland "Refactors UlpFec and FlexFec to use a common interface."" 2020-02-26 hta@webrtc.org Remove deprecated AddContent function in session_description.h 2020-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e1d61e44..159524df (744256:744393) Created with: gclient setdep -r src/third_party/webrtc@c310889ec791 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052323 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1017db1fb95a2c00fb4eea555813c88fa61c8a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073784Reviewed-by:
-
Anastasiia Nikolaienko authored
The file was moved to chrome/browser/resources/gaia_auth_host/ saml_password_attributes_test.unitjs Change-Id: Ie4763473632202a383a058ed9858a364d779cfac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073765Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#744623}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fb6e3e48d51d..70f888131ede git log fb6e3e48d51d..70f888131ede --date=short --first-parent --format='%ad %ae %s' 2020-02-25 jaebaek@google.com Add validation rules for OpenCL.DebugInfo.100 extension (#3133) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@70f888131ede If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I3555003e0891e9a85f65122d8f2a71833af59a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073605Reviewed-by:
-
Mugdha Lakhani authored
Bug: 1052375 Change-Id: Ie9e503f3f492d35b4dfac92e0b6718d0fcd4e014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066721 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#744621}
-
Sylvain Defresne authored
This method is no longer called nor overridden, thus it can safely be removed. Bug: 1049042 Change-Id: Ifa9fca1b10bea24b7e19afb80a20522b55dc8da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067326 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#744620}
-
Sylvain Defresne authored
The variable is no longer used and the downstream code has been updated to no longer override it. It can be safely removed now. Bug: 1049042 Change-Id: Ib9dae28faa0a182cbb051a04ce1001b1733020cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067459Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6736f968..d188dce4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2782019e717a25fecde2bdde394592835916c68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073702Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744618}
-
Jana Grill authored
With this flag it is possible to enable ADB sideloading for managed devices and/or users. Bug: 1053880 Change-Id: I7d70f79265d5aac60676bc4fb52bb1eb4bff36a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071936Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#744617}
-
Viktor Semeniuk authored
This change adds basic UI for password check page. Change includes number of compromised credentials, last refresh time, and button to run password check manually. Bug: 1047726 Change-Id: If7a9f7ad2c35ccd070e090514d38d313a22d6d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068602Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#744616}
-
Guido Urdaneta authored
We have observed that this list is problematic for some cameras that don't provide their supported video formats, since it includes many resolutions that are not natively supported. This CL reduces the list to include resolutions that are more likely to be supported. Bug: 1050087 Change-Id: I283069403ed99b913462969738df8fd281a0748a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073717Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#744615}
-
Guido Urdaneta authored
This CL adds: * RTCInsertableStreams Blink runtime-enabled flag * IDL files with the API * Implementation of encoded video frames based on webrtc::EncodedFrame * Skeleton implementation of audio frames * Skeleton implementation of methods in RTCRtpSender and RTCRtpReceiver Real implementations will be added in follow-up CLs. Bug: 1052765 Change-Id: I07089c60678c1987a1996bf782aaed1a0f3cc996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066765Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#744614}
-
Rainhard Findling authored
* Adds the safety check collapse for safety check children elements * Adds common styling used by multiple children Bug: 1015841 Change-Id: I8dfb3d325d4134d7804155ee3d1b8af822c44cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070239 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744613}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4af595189fe3..1c105ca31096 git log 4af595189fe3..1c105ca31096 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 szuend@chromium.org Prepare TimelineUIUtils.js for asynchronous source mapping 2020-02-26 pfaffe@chromium.org Fix can-format-sourcecode test: await proper indicator 2020-02-26 aerotwist@chromium.org [e2e] Add user metrics tests 2020-02-26 aerotwist@chromium.org [screenshot] Updates server encoding Created with: gclient setdep -r src/third_party/devtools-frontend/src@1c105ca31096 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f74cda8dddb227c3b1e6749a47545e75537f6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073778Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/651a1d860c99..9b1b5d932a2a git log 651a1d860c99..9b1b5d932a2a --date=short --first-parent --format='%ad %ae %s' 2020-02-26 hjd@google.com Merge "CTS: Increase timeouts to 5s" Created with: gclient setdep -r src/third_party/perfetto@9b1b5d932a2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I32ab09d5a6ed99fc6e88d761270efcf811d69755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073780Reviewed-by:
-
Jose Lopes authored
The MojoSharedBufferDoneCB callback is a once callback because it's executed only once during the class's constructor: * https://cs.chromium.org/chromium/src/media/mojo/common/mojo_shared_buffer_video_frame.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=250 This is also documented in its definition: * https://cs.chromium.org/chromium/src/media/mojo/common/mojo_shared_buffer_video_frame.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=250 The callback is passed in the TransformToVideoFrame method, in: * https://cs.chromium.org/chromium/src/media/mojo/common/mojo_shared_buffer_video_frame.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=250 and this method can only be called once. The evidence of the following statements: * DCHECK(FrameBuffer()): https://cs.chromium.org/chromium/src/media/mojo/services/mojo_cdm_allocator.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=116 * SetFrameBuffer(nullptr): https://cs.chromium.org/chromium/src/media/mojo/services/mojo_cdm_allocator.cc?rcl=8184a68c47988fb128372c9c688f77455dfcb5db&l=116 Together these guarantee that the method can only be called once. This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib4dff4d9c491682b8abd134723ef88bcf5252bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069540 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#744610}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Mac. (The [2] CL enabled it earlier for Windows, Linux, and ChromeOS.) In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/2063530 [2] http://crrev.com/c/1967608 Bug: 1053725 Change-Id: If59ce711ad8baadc4089ec99bdac3510a3e67b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071581 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#744609}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a7f01b6. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 6532b4a4 "WPT: Remove XMLDocument#load test from html/.../query-encoding/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I28c8a6d9a106866e5aa05d74856a8a01ab1dce8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073677Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744608}
-
Nohemi Fernandez authored
This patch adds the authentication flow required to cancel a sign-in operation following a click on the 'Cancel' button in the 'Turn on Sync?' page. This CL is part of a series of refactors to move the existing sign-in architecture to the Coordinator-Mediator design paradigm. Fore more information, see go/chrome-ios-signin-migration. Bug: 971989 Change-Id: I72e8bf3c8fc15338d419dc2d3a888eecc430b807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067076 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744607}
-
Rune Lillesveen authored
We were not checking dirty flags for pseudo elements in AssertLayoutTreeUpdated. Change-Id: Icad8f8fabd45bdb973258c4da9ada440b6952e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073878Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#744606}
-
Mugdha Lakhani authored
This also moves strings from chrome/app/generated_resources.grd to components/components_strings.grd. Bug: 1052375 Change-Id: If11c8922c9faa7e8470744d329b838b528b7c460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062418Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Renato Silva authored
This is a reland of 8411cc66 Original change's description: > OOBE - Improve reset screen confirmation dialog > > - Replace the dialog on the reset screen with the oobe-help-dialog > that complies with UX specs and reuses available code. > > - Refactor the confirmation dialog logic so that it lives in the > main element 'oobe-reset'. > > - Remove the intermediate oobe_reset_screen by using LoginScreenBehavior > > - Add a waiter to test::OobeJS for waiting upon the presence of an > attribute. Such as waiting on the 'open' attribute of dialogs. > > - Add constants and modifications to the browser tests of the reset > screen. > > Fixed: 933310 > Change-Id: I54001745326b60ab5a0a19519923c54dffa5baec > Bug: 933310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041474 > Commit-Queue: Renato Silva <rrsilva@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Auto-Submit: Renato Silva <rrsilva@google.com> > Cr-Commit-Position: refs/heads/master@{#744288} Bug: 933310 Change-Id: I12aca96e98373beda746fc92f3d06cb6d1e86c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072383 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33b4927e0d74..4db5c0713efc Created with: gclient setdep -r src-internal@4db5c0713efc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibf1f318caafd8ef2aeb689b66dcb6123ff0de98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744603}
-
Javier Ernesto Flores Robles authored
Bug: 1052505 Change-Id: Icef96c97f24aecf5eb17dddc24d7d73d1878355f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062973 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
sandromaggi authored
This test has been missing. It's the sibling of the same test for creating a contact. Bug: none Change-Id: I1a7fc847f24ded1148e49b302b2851dbd383b71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071263 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#744601}
-
Kent Tamura authored
- Move HTMLFormControlElementWithState::TypeShouldForceLegacyLayout() to HTMLSelectElement and HTMLTextAreaElement Another subclass, HTMLInputElement, already has it. - Change the default value of InputTypeView::TypeShouldForceLegacyLayout from |true| to |false| Remove TypeShouldForceLegacyLayout() of InputTypeView subclasses returning |false| Add TypeShouldForceLegacyLayout() of InputTypeView subclasses so that it returns |true|. This CL has no behavior changes. Bug: 1040826 Change-Id: If307fcd1b15adfc84bf5a2786bec0569e33827a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073183 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#744600}
-
Maksim Ivanov authored
Make the error handling more sane in the test certificateProvider extension (which is, roughly speaking, used for simulating a smart card driver with a fake smart card in browser tests). Specifically: * In the case the chrome.certificateProvider.requestPin() call from the extension returns an empty result (=="cancellation"): * after the CL: a warning is logged and the crypto operation is aborted; * before the CL: a new PIN request was made (because we were misinterpreting at as an incorrect PIN error). * In the case the requestPin() call fails with a chrome.runtime.lastError error: * after the CL: a warning is logged, with the contents of |lastError|, and the crypto operation is aborted; * before the CL: JS error is raised, due to not checking the state of |lastError|, and a new PIN request was made. This should make the test extension closer to the behavior of real smart card drivers, and also simplify debugging of test flakiness. Bug: 1033936 Change-Id: Id035fa8366cce4a3ff9c404bac8169bd146fefd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072381 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#744599}
-
Victor Costan authored
The feature gated by BlobReadMethods has launched in Chrome 76. At this point, it's safe to assume the feature will remain launched. https://chromestatus.com/feature/6206980857266176 Change-Id: Ibdd53ffda2553495985f6062c86c46336ea88a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073468 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#744598}
-
Victor Costan authored
The features gated by AsyncClipboard have launched in Chrome 66 and Chrome 76. At this point, it's safe to assume the features will remain launched. Relevant chromestatus entries: https://chromestatus.com/feature/5861289330999296 https://chromestatus.com/feature/5074658793619456 Change-Id: I5041570cea17385e72fc40c01b6dab26f69b4a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073467 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a9ec2ef6f2a..908dc2208b7c git log 4a9ec2ef6f2a..908dc2208b7c --date=short --first-parent --format='%ad %ae %s' 2020-02-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src a09ab94aa920..3f4d08da8897 (2 commits) Created with: gclient setdep -r src/third_party/angle@908dc2208b7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I428dd56a524f19966e84ec9f50038be539169e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073609Reviewed-by:
-
Anastasiia Nikolaienko authored
Bug: 1006341 Change-Id: I24886a69ec50d0c1bd464575cdf70e1f36dc4aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071265Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#744595}
-
Anastasiia Nikolaienko authored
Append email to query parameters so it's getting pre-filled on the login page. Bug: 1043108 Change-Id: Ica6284bc525ae9be9498c24cb5756b075c14b2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070202Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/54f0b120..6736f968 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I23ff7486e0a6fd83305184051989c97875b4e766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073619Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4e52bbdf7162..4af595189fe3 git log 4e52bbdf7162..4af595189fe3 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 gabriel.luong@gmail.com Typecheck common/QueryParamHandler.js with TypeScript 2020-02-26 gabriel.luong@gmail.com Typecheck common/App.js with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@4af595189fe3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie28885bf326aea8ede1747a9c8cc29aee76e8645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073610Reviewed-by:
-
