- 12 Sep, 2017 8 commits
-
-
Tom Anderson authored
r499086 switched the Linux packaging staging dirs from /tmp to the out directory. This means it's no longer necessary to serialize package builds. The original CL passed argv[2:] to bash instead of argv[1:]. BUG=758654 R=thestig@chromium.org TBR=rdevlin.cronin@chromium.org Change-Id: If6dc9c35edeb60337b944a2a4350875274241747 Reviewed-on: https://chromium-review.googlesource.com/661780Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501111}
-
Hans Wennborg authored
TBR=thakis Bug: 759794 Change-Id: Ic8561d64ac79d3db342537d182bb8faa95f74b5b Reviewed-on: https://chromium-review.googlesource.com/661948Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#501110}
-
Scott Chen authored
Change the positioning and overlapping of the focus and underline. Bug: 763451, 760331 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib91dfa1e9963e1e280e52f0627b6460516553137 Reviewed-on: https://chromium-review.googlesource.com/657276 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#501109}
-
Daichi Hirono authored
Previously Chrome sends only one URI to the client even if multiple files are being dragged. The CL lets Chrome send multiple URIs for the case. Bug: 758834 Test: Drag and drop multiple files Change-Id: I14d138c45fb06d509c628e3ad773e8848ca77891 Reviewed-on: https://chromium-review.googlesource.com/634775Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#501108}
-
kristipark authored
Added valid origin check before tracking/untracking an origin. Bug: 760353 Change-Id: I1de5cf59b274838f0632b8d8141772d4929cc794 Reviewed-on: https://chromium-review.googlesource.com/648472 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#501107}
-
John Chen authored
ChromeDriver shouldn't use --load-extension switch to load any extensions when this switch has been excluded through Chrome options. Bug: chromedriver:1981 Change-Id: Ibf73fe15fa00eb7e83c8db4185471ec08b3679b8 Reviewed-on: https://chromium-review.googlesource.com/655337 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#501106}
-
Brett Wilson authored
Replace uses of std::deque with base::circular_deque, and std::queue with base::queue. Uses in shared QUIC code are unchanged. We are standardizing on the base implementations to avoid the memory issues and widely varied implementations of the STL deque. Once most uses have been replaced, we will add a presubmit check to disallow the std:: variants. Three instances of deque were left where circular_deque is not appropriate (they required pointer stability across resizes). An implementation of EstimateMemoryUsage is provided for circular_deque which net required. BufferedSlice (quic_stream_send_buffer.h) was converted to be move-only (from being neither movable nor copyable) to support its membership in a circular_deque. When a typedef needed required changing, the typedef (and any adjacent one) was converted to "using" statements. The WebSocketChannel::PendingReceivedFrame declaration was moved to the .cc file since the limitations around its declaration in the header no longer exist (as explained in the removed comment). One include had to be added to a file in Chrome that was depending on net to being in <deque>. Bug: 757232 Change-Id: I8c265044ec2815deae457b299f30bf08938d0b87 Reviewed-on: https://chromium-review.googlesource.com/659317 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501105}
-
Tom Anderson authored
BUG=758654 R=thestig@chromium.org Change-Id: Ib64eb4ace73d7803b083f4d40795193dedc288f7 Reviewed-on: https://chromium-review.googlesource.com/655943 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#501104}
-
- 11 Sep, 2017 32 commits
-
-
Bret Sepulveda authored
I didn't realize the border set in FirstRunBubble was "extra" padding, not the total padding, so I've reverted the change and moved the calls around so the intent is clearer. Bug: 763826 Change-Id: Ieb0ab3d93bfb62f3738e970b9fac2c2a3e129332 Reviewed-on: https://chromium-review.googlesource.com/660684Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#501103}
-
Scott Chen authored
It now also tests whether a valid icon is applied to paper-icon-button-light. Bug: 754446 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6e9cc88c7b20c9a3795f69fc73a72f6c10d94751 Reviewed-on: https://chromium-review.googlesource.com/653658 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501102}
-
Scott Graham authored
Fixed by upstream MG-1062. Bug: 759691 Change-Id: Id4155b1e4a223ead110dad3059676816280c1418 Reviewed-on: https://chromium-review.googlesource.com/661558Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501101}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9194706e8cf1..3261eb219f2c $ git log 9194706e8..3261eb219 --date=short --no-merges --format='%ad %ae %s' 2017-09-11 bsalomon Remove repeated conditional in TextureOp. 2017-09-11 ethannicholas Revert "Revert "Switch to the new SkSL lexer."" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I76363bd8b8398f1cc8739a595edc615c1400f37e Reviewed-on: https://chromium-review.googlesource.com/661390Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501100}
-
Yuke Liao authored
This CL adds unit tests to test the mapping between a PBXObject and its name as a string by calling Name(). Bug: 742258 Change-Id: I8a4b55af84d1270f1c3c8927e4f124ddff0532e9 Reviewed-on: https://chromium-review.googlesource.com/636360 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501099}
-
Matt Wolenetz authored
It looks like https://chromium-review.googlesource.com/c/chromium/src/+/481042 accidentally undid chcunningham@'s additions of all of these tests to SmokeTests. This is surprising, since running those specific tests was the primary reason for the media-gpu-accelerated virtual test suite. BUG=763528,599975,555703 Change-Id: Ia02f8c144dccd8709b6cda854089a166c667a8b9 Reviewed-on: https://chromium-review.googlesource.com/658356 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501098}
-
Reilly Grant authored
This change reverts the following commits, re-enabling these tests on Windows while configuring the same test filters for services_unittests on the Windows 10 GCE bots for the main waterfall as the FYI waterfall so that they remain disabled where they continue to fail, * cc340d93 * ed6c2adb * c2e790da * b53dff92 Bug: 756986 Change-Id: I87bb18189cff4bd67cec0c230fd159eb5dfb3e81 Reviewed-on: https://chromium-review.googlesource.com/660420Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501097}
-
Sergey Ulanov authored
Following issues are fixed in this version: 1. NET-170: MSG_TRUNC support in recvmsg(). 2. NET-120: asynchronous connect(). NOTRY=true Bug: 731302, 707030 Change-Id: I74047a9d86fe4bce6c384658676903b115ed437a Reviewed-on: https://chromium-review.googlesource.com/661298 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501096}
-
rnephew authored
Before it was used to be able to disable specific system health stories. This feature is now done via StoryExpectations for all benchmark types so this special shared page state is no longer required. Bug: 763854, 763029 Change-Id: Ibf77fe68c2ce964eeaf9f8f6ebdb4c7ee41f1029 Reviewed-on: https://chromium-review.googlesource.com/661326Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#501095}
-
Gabriel Charette authored
R=torne@chromium.org Bug: 689520 Change-Id: I782d346026c2af429cad07b2bcb96cf8c822e14b Reviewed-on: https://chromium-review.googlesource.com/657300Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#501094}
-
Erik Chen authored
Create a test that: 1) Starts the memlog process 2) Makes a bunch of allocations 3) Flush the allocations [with more allocations] 4) Performs a heap dump. 5) Checks that the allocations from (2) made it into (4). Bug: 751321 Change-Id: Ic9e2511da06ee436075eb91714616efdae988c4f Reviewed-on: https://chromium-review.googlesource.com/653430 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501093}
-
Brett Wilson authored
This maintains some forward declarations so all >400 uses don't need to be updated at the same time. This patch changes all forward declarations and code that depends on them. BUG=763556 TBR=stevenjb@chromium.org (chromeos/network) Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icabd948fe9e0881fdb60db38b31a9d0763867bc4 Reviewed-on: https://chromium-review.googlesource.com/657249Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501092}
-
Justin Novosad authored
Changes to test results related to: https://skia.googlesource.com/skia.git/+/8b1360dcfab9ae748361268284068049cd3796a7 BUG=760738 TBR=xidachen@chromium.org Change-Id: Ibb5b00df40d4fbd8be2856b561f5b5edfa35f306 Reviewed-on: https://chromium-review.googlesource.com/661617Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#501091}
-
rnephew authored
Previously, benchmarks that were permanently disabled via expectatoins used PermanentlyDisableBenchmark. Those were migrated to SUPPORTED_PLATFORMS (which will still not be scheduled since they are not intended to run on some platforms) and the remaining tests disabled via expectations now use DisableBenchmark which is intended for temporarily disabling failing benchmarks. These should still be scheduled on those platforms though, so that they are considered when sharding tests. Bug: 713222 Change-Id: I6686612d955ac879c9ae8c2d94325d7eb6ab1082 Reviewed-on: https://chromium-review.googlesource.com/660421 Commit-Queue: rnephew <rnephew@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#501090}
-
Jeffrey Kardatzke authored
This prevents us from logging errors on devices where underlying support for arc-oemcrypto isn't there yet. BUG=b:62576736,763824 TEST=Verified logging is as desired Change-Id: I7a4b0888392c6c256de110600863f79405b5b310 Reviewed-on: https://chromium-review.googlesource.com/660782Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#501089}
-
Mike Baxley authored
Matchers should not wait, and have been replaced by methods in ChromeEarlGrey. Bug: 757982 Change-Id: I68b1b5d9eb6f50cf80af3ef514c1ea43d080e926 Reviewed-on: https://chromium-review.googlesource.com/647805Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501088}
-
Vincent Scheib authored
WebUSB shipped in Chrome 61, removing flags entry for Chrome 63. R=reillyg@chromium.org Change-Id: Ib24a6b039624d3c40c57554a22e0df8c756e22d8 Reviewed-on: https://chromium-review.googlesource.com/660661Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#501087}
-
Joy Ming authored
This is part of a larger refactor to make downloads a foreground service for all versions of Android. Before this CL, cancelling a download that is not offline pages would not cancel the notification. This was because the SystemDownloadNotifier was not being informed of a cancelled download. Cancelling a download through DownloadManagerService removes the observer and does not inform it of a cancelled download. This CL circumvents the removal of the observers by calling onDownloadCancelled at the moment the download is cancelled, which in turn informs the SystemDownloadNotifier of the cancelled download and allows for the stopping of the foreground service and removal of the notification. Bug: 747563 Change-Id: I5f1f91834e1ce94f3cdf42e9965035618327df30 Reviewed-on: https://chromium-review.googlesource.com/660996 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501086}
-
Gabriel Charette authored
R=torne@chromium.org Bug: 667892 Change-Id: Ieaf38af83c20f1833423609e32de27365d5b7b6d Reviewed-on: https://chromium-review.googlesource.com/657266 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501085}
-
Vladimir Levin authored
This patch does the following: - Renames render_sandbox_host_linux to sandbox_host_linux - Moves it from content/browser/renderer_host/ to content/browser/ - Moves sandbox_ipc_linux from content/browser/renderer_host/ to content/browser/ - Updates names in those classes to refer to "sandboxed process" instead of "renderer" This patch does not affect any behavior. The motivation for this is the development of out of process rasterization, which will start rasterizing content on the gpu process. This means that similar access will be needed from the gpu process as is now required from the renderer process (specifically font access via FontConfigIPC). Renaming these classes makes it more clear that there are other processes other than the renderer that use it. Change-Id: I4d78f3f186f03cc7ad72dab41a7065cc97827180 Reviewed-on: https://chromium-review.googlesource.com/656063 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501084}
-
Kenichi Ishibashi authored
It seems that there is no definition. Bug: Change-Id: I80acde42ae24438bf1811f1846c8359de3f098c6 Reviewed-on: https://chromium-review.googlesource.com/658163Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501083}
-
Biao She authored
GetViewportAwareElements always return a non empty list because we always have two visible ViewportAwareRoot elements (one for ChromeVR and one for WebVR) in our hierarchy. We should exclude ViewportAwareRoot element from the list returned by the function. It is a no visual element. So it shouldn't trigger code path that is used to draw viewport aware elements. Bug: 763738 Change-Id: I29c14b60e3fc16e224c5e540aa438f25e1c871ef Reviewed-on: https://chromium-review.googlesource.com/661260Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#501082}
-
Alex Moshchuk authored
Previously, if a frame F navigated cross-process from a.com to b.com, and this was the first navigation to the b.com process in that BrowsingInstance, we did the following: 1. Create proxies for all frames in FrameTrees on F's opener chain. 2. Create proxies for all frames in F's FrameTree, except for F and its subtree. 3. If F is a main frame: 3a. Create a new active RenderView, which also creates the main frame, already swapped into the tree even though it's still pending and may never commit. Otherwise, if F is a cross-process subframe: 3b. send a CreateFrame IPC, referencing the parent proxy, which should've been created in step 2. This flow breaks down if, while the navigation in F is still pending, other frames in the same BrowsingInstance also navigate to b.com and then try to interact with F (where the current RFH is still at a.com). For example, if F is a main frame, and a subframe of F at a.com navigates to b.com, the subframe won't find the parent proxy for F, because we didn't create one in step 3a. This crashes on CHECK(parent) in CreateFrame(). Furthermore, if the subframe commits first, it should be able to reference F. For example, if the subframe sends a postMessage to F, that should go to F's proxy in b.com, which should forward it to F's current RenderFrame, which is still in a.com. So there should be a proxy created for F in step 3a. This is especially important if F never commits. The same kind of race is possible with openers: a frame at C might window.open() a new tab, then the opener frame starts a cross-process navigation to D, then the opened tab also starts a cross-process navigation to D. If the opener's navigation never succeeds but the opened tab's does, the opened tab at D should still be able to communicate with its old opener at C. To address these races, this CL changes step 2, so that when a frame navigates cross-process, we pre-create a proxy for that frame in the new SiteInstance for cases where other frames might also navigate to the same new SiteInstance and script this frame. This switches the frame creation/navigation in steps 3a or 3b to instead follow the remote-to-local navigation path, i.e., sending the CreateFrame IPC and using the existing-proxy (CreateProvisional) flow. As part of the fix, RenderViewCreated is changed to also be generated for RVHs created for provisional main frame navigations, and RenderViewHostImpl::GetMainFrame() will also return pending main frame RFH if it exists. This keeps the embedder's assumptions about RenderViewHost valid. Longer-term, these APIs should be deprecated and migrated to use RenderFrameCreated. This followup work will be tracked in issue 763548. Bug: 756790, 626802, 591478, 760403 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I6b85d135ec1e507110a51c9fe1b2a05754633a50 Reviewed-on: https://chromium-review.googlesource.com/636786Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Charlie Reis (slow) <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#501081}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/99ec8187805e..c59db25d8116 $ git log 99ec81878..c59db25d8 --date=short --no-merges --format='%ad %ae %s' 2017-09-11 eakuefner [Tracing] Add add_shared_diagnostics.AddValueDiagnostics 2017-09-11 benjhayden Export {raw,merged} {csv,json} from results.html. 2017-09-11 dtu [pinpoint] Re-layout job page header. 2017-09-11 xunjieli [wpr-go] Use wprgo for test_page_sets data. 2017-09-11 rnephew [Telemetry] Expose disable_stories in StoryExpectations api. Created with: roll-dep src/third_party/catapult BUG=753948,723636 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I759eca1f159ddd866b45992789ab2f39dcf8fbca Reviewed-on: https://chromium-review.googlesource.com/660896 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501080}
-
Antoine Labour authored
Properly calling XInitThreads before creating the main thread Display was causing a particular driver to create threads in the first GLX call, preventing sandbox initialization. So we had a workaround to call XInitThreads after the Display is created, which is against the spec but worked if you squint enough. As this was a non-stable driver, we instead do proper initialization and this particular driver will have the sandboxed disabled. We can monitor GPU.Sandbox.InitializedSuccessfully to check behavior in the wild. Bug: 756885 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0a39f6e3d2e085c2c59ff654a8b1c60b00e45752 Reviewed-on: https://chromium-review.googlesource.com/660811Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501079}
-
Yafei Duan authored
Implementing AddPageTask which will insert a page into metedata store, then invoke the callback with an AddPageResult. This is part of the OfflinePageModel taskification. Also OfflineStoreUtils is introduced, containing the utility methods used in tasks. The unit test will be in another patch, in order to adopt the testing framework which will be landed with GetPageTask. Bug: 753595 Change-Id: I4ef848c24d40217e0e071a72aae49c3fdd9a3f70 Reviewed-on: https://chromium-review.googlesource.com/636725 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#501078}
-
Giovanni Ortuño Urquidi authored
Stops overriding navigations if the source and the target have the same origin. Also removes code that checked if the navigation is in an app because it's no longer relevant. It was used to catch two cases: 1. Opening a new app window, which would result in navigation 2. Navigations inside the app to in-scope URLs (1) results in a AUTO_BOOKMARK transition type, which is caught by an if statement earlier and (2) will be caught by the origin if statement in this patch. Bug: 761246 Change-Id: Ic9c2a909e98da370a884a1d9f6afb129ba957e8c Reviewed-on: https://chromium-review.googlesource.com/646390 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#501077}
-
Darren Shen authored
This patch adds a runtime flag for getMatchedCSSRules and turns it off completely. This will allow us to disable getMatchedCSSRules in M63 whilst making it easier to turn the feature back on again in case anything goes wrong. [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/fd-QLCiLESQ/_mfowSsRR8oJ [2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/-_Al0I5Rm9Q/PDzupcoxAwAJ Bug: 437569 Change-Id: I2d022a3b03d4ec1297248563acd598c9fc7ccf9a Reviewed-on: https://chromium-review.googlesource.com/644831 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#501076}
-
erikchen authored
On Windows, base::Process takes ownership of the input |handle|. On Posix, it does not. Bug: Change-Id: I3d53faba3ec46f23afc89811a7ebec603c2dce7b Reviewed-on: https://chromium-review.googlesource.com/661378Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501075}
-
rbpotter authored
Rectangular DPI is not fully supported in Chrome but some printers use it. On these printers, using the maximum rather than the minimum of the 2 DPI dimensions for computing printable area prevents text printing too small and restores the behavior before https://codereview.chromium.org/2795453002. Bug: 738950 Change-Id: Idf0ae0f32987343fe9100b8a15ad139e431f0570 Reviewed-on: https://chromium-review.googlesource.com/661381Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#501074}
-
Jamie Madill authored
https://chromium.googlesource.com/angle/angle.git/+log/1aa66bc..9d81537 BUG= TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib9023380e39c2a6df45908c249ca47f06a94d464 Reviewed-on: https://chromium-review.googlesource.com/660780Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#501073}
-
Kent Tamura authored
Bug: 578345 Change-Id: Iacc96fcb11c0611addc5fc9a79706856b892cc53 Reviewed-on: https://chromium-review.googlesource.com/661278Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#501072}
-