GitLab

On Android JavascriptAppModalDialog is implemented with a Java class and its
native counterpart.
The Java class holds a pointer to the native instance. When UI events (e.g.
button click) are processed, the Java side calls a native method (e.g.
JavascriptAppModalDialog::DidAcceptAppModalDialog()). When this native method
completes the instance deletes itself.
This is only correct in case it is guaranteed that no further native method
call is performed by the Java side since the pointer was freed.
The problem is that this can happen in some rare circumstances. For instance
the user could manage to click on two buttons before the dialog is closed which
might happen if the first click event is not processed immediately or takes a
long time to be processed.

This CL fixes the crash by invalidating the native pointer on the Java side
when it is deleted so that the Java side can perform a native method call only
if the native instance pointer is still valid.

BUG=167585

Review URL: https://codereview.chromium.org/11728004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175139 0039d316-1c4b-4281-b951-d872f2087c98

The Android NetworkChangeNotifier is initialized with connection_type =
CONNECTION_UNKNOWN.
This means that the result returned by NetworkChangeNotifier::IsOffline() is
inaccurate until the first network change happens.
This can happen for the whole initialization path if the user starts Chrome
after he explicitly disabled WiFi and 3G.

This CL updates NetworkChangeNotifier.java to support multiple native
observers. This can happen in case NetworkChangeNotifierDelegateAndroid is
instantiated multiple times (e.g. when multiple factories are instantiated).

Still on the Java side, NetworkChangeNotifier.java was also changed to fetch
the actual connection type as soon as the auto-detector (interacting with the
Android platform) is enabled.

On the native side, NetworkChangeNotifierDelegateAndroid now fetches at
construction time the current connection type from the Java side singleton
through a direct JNI function call (possible since the delegate is constructed
on the JNI thread).
NetworkChangeNotifierAndroid::GetCurrentConnectionType() is now a simple
wrapper around the delegate's GetCurrentConnectionType() method (which is
thread-safe).

BUG=166883

Review URL: https://codereview.chromium.org/11628008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175138 0039d316-1c4b-4281-b951-d872f2087c98

In README.chromium, BSD license should be written as "BSD N-Clause License".
Also, update Android WebView's license checker to accept BSD 2-Clause.

TBR=torne@chromium.org,bcwhite@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11742039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175137 0039d316-1c4b-4281-b951-d872f2087c98

TBR=torne@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11722029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175136 0039d316-1c4b-4281-b951-d872f2087c98

Introduce the required code to get SW rendering working once RenderView is able
to provide the required picture piles from the compositor.

BUG=167913

Review URL: https://codereview.chromium.org/11727005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175135 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11722028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175133 0039d316-1c4b-4281-b951-d872f2087c98

This limit is defined in the notification product requirement document,
section "Inbox Format for Multiple Messages". The limit only affects
the number of items displayed (to avoid notifications growing too tall).
The back end still handles any number of items. The maximum number is
declared in the public message_center_constants.h file so future code
can use it, for example to output a warning or return an error if
callers to the chrome.experimental.notification API ask for a
notification with more than the maximum number of displayable items.

BUG=161101


Review URL: https://chromiumcodereview.appspot.com/11638035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175132 0039d316-1c4b-4281-b951-d872f2087c98

(This is a reland of r173539, adding early bails to some implementations of OnBeforeWidgetInit so that we don't clobber an already set Widget::InitParams::native_widget.)

There are actual cases where we have to show dialogs with no parent or context,
when there are no browser windows. All of the cases that I can find go through
the CreateWindow() interface.

CreateWindow() now explicitly sets InitParams::top_level to true. The
ViewsDelegate now can do arbitrary manipulations on the InitParams so that when
top_level is true and we have no context, we either create a native_widget or
set the context based on desktop type.

BUG=165759
TBR=ben@chromium.org (who did the original review)

First Review URL: https://chromiumcodereview.appspot.com/11578014

Review URL: https://chromiumcodereview.appspot.com/11758002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175131 0039d316-1c4b-4281-b951-d872f2087c98

In theory the #include could be replaced with a forward declaration.  However, forward declaring string16 is more bother than it's worth, since at least on some platforms it's a typedef rather than a proper class.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11761026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175130 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175125 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168084

Review URL: https://chromiumcodereview.appspot.com/11647050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175123 0039d316-1c4b-4281-b951-d872f2087c98

Notification mock-ups show ellipses at the end of text when there is not
enough room for that text. Previously title text in multi-item
notifications had a trailing fade instead of trailing ellipses. This
changes that to ellipses.

BUG=161101


Review URL: https://chromiumcodereview.appspot.com/11636043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175122 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175121 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pkasting@chromium.org
BUG=165765

Review URL: https://codereview.chromium.org/11747021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175118 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175117 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=138767&stop_rev=138712&verbose=on

TBR=macpherson@chromium.org

BUG=


Review URL: https://chromiumcodereview.appspot.com/11740039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168252


Review URL: https://chromiumcodereview.appspot.com/11753017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175113 0039d316-1c4b-4281-b951-d872f2087c98

Vista Tests (1) is timing out a lot.

TBR=sail@chromium.org
BUG=140882

Review URL: https://codereview.chromium.org/11741031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175112 0039d316-1c4b-4281-b951-d872f2087c98

Test was flaky due to event timing differences between single and
multi-process WebKit ports. The test was made more resilient in
http://wkrev.com/138402 which has now rolled, so re-enabling.

R=dgrogan@chromium.org,alecflett@chromium.org
BUG=163694


Review URL: https://chromiumcodereview.appspot.com/11746026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175111 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=167798,168084
TEST=Install https://chrome.google.com/webstore/detail/slinky-elegant/bmanlajnpdncmhfkiccmbgeocgbncfln?hl=en
Look at new tab button in active and inactive windows. Also check the new tab
button with the default theme. Look at startup perf graphs, should improve by
~1.8ms.


Review URL: https://chromiumcodereview.appspot.com/11748026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175108 0039d316-1c4b-4281-b951-d872f2087c98

There's a race condition between the audio shutdown process and calls to OnMoreData() (in FillBufferQueue()).  During shutdown, or after an error occurs within AudioOutputController, OnMoreData() can return 0 to indicate "no data."  In this case, FillBufferQueue() should not attempt to call simple_buffer_queue_->Enqueue() with a "zero bytes" argument, which is an invalid argument value.

Also changed a DLOG(FATAL) to DLOG(ERROR), per Chromium style guidelines, since there is code that explicitly handles the event after the log statement.

BUG=168260
TEST=build/android/run_tests.py -s media_unittests -f *PlayStateChangeClose*
TBR=tommi@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11744026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153048

Review URL: https://chromiumcodereview.appspot.com/11770002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=green tree
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/11734038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175105 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land of https://codereview.chromium.org/11693010/, which failed on the tree on XP bots. The issue was that ProgramCompare::Evaluate() was parsing its value parameter is a command-line, which meant it was truncating it at the first space. This updated CL adds an EvaluatePath() function that takes a FilePath and doesn't try to parse it as a command-line. 

BUG=146636
TEST=Uninstalling Chrome removes any present profile shortcuts on the desktop.

Review URL: https://chromiumcodereview.appspot.com/11743022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175104 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rsesek@chromium.org
BUG=120996,143773
TEST=tests pass, we still get promos, less crud on profile.

Review URL: https://codereview.chromium.org/11689004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175103 0039d316-1c4b-4281-b951-d872f2087c98

MessageViewMultiple -> NotificationView to reflect its soon-to-be more
general role displaying basic and image notifications in addition to
multiple item notifications.

BUG=164292


Review URL: https://chromiumcodereview.appspot.com/11647031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175102 0039d316-1c4b-4281-b951-d872f2087c98

Make sure that the texture sizes as passed from the untrusted renderer to the
to the VDA on the GPU process match with the texture's size as the GPU
process has tracked it.

BUG=chromium:168293
TEST=local build, run on x86, snow

Review URL: https://chromiumcodereview.appspot.com/11722023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11722020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175099 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11665015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175096 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168280
TEST=https://evssl.turktrust.com.tr/ no longer shows as EV

Review URL: https://chromiumcodereview.appspot.com/11745023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175095 0039d316-1c4b-4281-b951-d872f2087c98

At this point it is always defined.

Review URL: https://chromiumcodereview.appspot.com/11722024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175094 0039d316-1c4b-4281-b951-d872f2087c98

If there is no video frame available, we can see the background page when playing fullscreen video.
Using setZOrderOnTop() so that the video surfaceView will be on top of the window, rather than punching a hole in the window.

BUG=167396


Review URL: https://chromiumcodereview.appspot.com/11741028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175092 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111541
R=estade@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11761008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175091 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11756004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175090 0039d316-1c4b-4281-b951-d872f2087c98

I need this to make base compile on Win64. I'll follow-up with fixes in crbug.com/167707

Review URL: https://chromiumcodereview.appspot.com/11684007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175089 0039d316-1c4b-4281-b951-d872f2087c98

event.

This fixes jobs with a SOCKET_BACKUP_CREATED event as the
second event not having a description.  Also simplifies
the net-internals code slightly (Or will once backward
compatibility can be removed).

This slightly breaks compatibility of old versions of Chrome
with new log files - CONNECT_JOBs and SOCKETS from newer
versions of Chrome will not have descriptions on M25 or
earlier.

Review URL: https://chromiumcodereview.appspot.com/11583027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175088 0039d316-1c4b-4281-b951-d872f2087c98

We have some code that should be moved to src/content which needs to query network state (crbug.com/156428).

While we transition to the new network handlers, we will need to make Cros* calls when the --enable-new-network-handlers flag is not set.
To do that we need cros_network_functions.cc (and its dependencies) moved to src/chromeos, where they belong anyway.


BUG=154852

Review URL: https://chromiumcodereview.appspot.com/11756002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175087 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11740018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157270

Review URL: https://codereview.chromium.org/11742033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175085 0039d316-1c4b-4281-b951-d872f2087c98