- 10 Aug, 2020 40 commits
-
-
Peter Kasting authored
The original CL was landed in one piece and reverted due to apparent perf regressions. Reland in sections to try and determine more precisely whether there is any perf impact. This CL relands the pieces that will be necessary to use callbacks instead of ButtonObserver in ToolbarAccountIconContainer, but does not actually switch to using them yet. If this causes regressions, then something about the memory overhead of the subscription list, or the cost of Button::GetHighlighted(), is the issue. Bug: none Change-Id: I34921876c23579c01ca378ad4fc2ae6fee9042fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347312Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796616}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b70f99dcd334..1553832ddd6c 2020-08-10 tsepez@chromium.org Remove CFWL_WidgetMrg::SetOwner(). 2020-08-10 tsepez@chromium.org Make CFWL_WidgetProperties::m_pParent a const member. 2020-08-10 thestig@chromium.org Limit the input size to pdf_scanlinecompositor_fuzzer. 2020-08-10 tsepez@chromium.org Encapsulate CFWL_Widget. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1113870 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I638590cdb70356cdbb8af2d355d07ea751c65e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796615}
-
Daniel McArdle authored
wav_audio_handler_fuzzer found a fun bug in BigEndianReader. By calling BigEndianReader::ReadPiece with a very large length, we can bypass the internal safety check. BigEndianReader::ReadPiece will abort the operation and return false if |ptr_ + len > end_|. When |len| is a large value, |ptr_ + len| may overflow, spuriously passing the bounds check. All of the BigEndianReader and BigEndianWriter functions that take length values use this vulnerable bounds check. This CL replaces the vulnerable pointer arithmetic with a safe alternative, and adds unit tests to detect regressions. After this CL, it should be safe to hand untrusted lengths to BigEndianReader and BigEndianWriter functions. Bug: 1114803 Change-Id: Ibf1192298dfe37a1aebcf6afaad080d1b5765135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347368 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#796614}
-
Richard Machado authored
I implemented all virtual methods of UsbDeviceHandle, which includes all the types of transfer methods. I also implemented various helper methods to assist with the mac implementation of UsbDeviceHandle. Bug: 1096743 Change-Id: I8f2d0edeb818ef7e80805e51edd3b32e8e038d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300638 Commit-Queue: Ricky Machado <richardmachado@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#796613}
-
Marijn Kruisselbrink authored
This fixes the destructor to not (incorrectly) assert that it can be called on any thread. The class comment correctly documents that this class has to be destroyed on the file task runner all other methods get invoked on as well. Change-Id: I281d9886e8076abc0f77e86a91ad7b79fb140e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346931 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#796612}
-
Scott Violet authored
components/favicon was made to deal with a null CoreFaviconService, so no changes are necessary in the weblayer side. This adds a test to ensure it works. BUG=1076463 TEST=none Change-Id: I52eafced0f77a3d3a764097dcdca4e0b33b6442e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339288 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#796611}
-
Chris Lu authored
Crash Restore Infobar banners display longer than other Infobars. This change adds functionality for this distinction and implements the longer presentation for the crash restore Infobar. Bug: 1071914 Change-Id: Ib71d7961681a06c8728230ce728457421b145f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342142Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#796610}
-
Andrew Comminos authored
Instead of storing a frame element ID on each cc::Layer, store it on the transform tree instead. This makes impl-side attribution possible with CompositeAfterPaint. Bug: 910421 Change-Id: Ica1e68155ffe84d1bb3b747afd644e052286e6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343508Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#796609}
-
Xiaodan Zhu authored
Bug: 1033309 Change-Id: I0a94a67e18a97137588ad27d49288673727eb68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342466 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#796608}
-
Xianzhu Wang authored
This reverts commit 66d8bd2b. Workaround the failure of blink_python_tests step on mac10.10 and mac10.11 waterfall bots. Original change's description: > Revert "Remove retired mac versions from blinkpy." > > This reverts commit 0745b831. > > Reason for revert: We still have 10.10 bots on the waterfall. This breaks the Mac10.10 bot. See https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/56807 and the blink_python_tests . Sample error: > > [1690/1762] blinkpy.web_tests.servers.cli_wrapper_unittest.CliWrapperTest.test_main_server_error_after_start failed unexpectedly: > Traceback (most recent call last): > File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper_unittest.py", line 54, in test_main_server_error_after_start > argv=[]) > File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py", line 87, in main > port_obj = host.port_factory.get(options=options) > File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/factory.py", line 91, in get > self._host, port_name, options=options, **kwargs) > File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/mac.py", line 71, in __init__ > assert self._version in self.SUPPORTED_VERSIONS > AssertionError > > > Original change's description: > > Remove retired mac versions from blinkpy. > > > > This cl removes blinkpy support for Mac10.10, Mac10.11, and Mac Retina. > > blink web tests for these versions has been removed from waterfall. > > > > Bug: 1077312, 1107003, 1114680 > > Change-Id: I819d0bf7316119b2f5bc127f6eda1deaba7e0cd9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343548 > > Commit-Queue: Ilia Samsonov <isamsonov@google.com> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796476} > > Change-Id: I196b5f27ab989ea18e0ebccf2164f578826b6a68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1077312 > Bug: 1107003 > Bug: 1114680 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347326 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796571} # Not skipping CQ checks because this is a reland. TBR=sky@chromium.org,isamsonov@google.com Bug: 1077312 Bug: 1107003 Bug: 1114680 Change-Id: I0cd6a17edb849df1d165b9c4abea9ddb3fb6468c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347315 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796607}
-
Kyle Horimoto authored
When the kPhoneHub flag is enabled, we now set the bluetooth_public_address field of the encrypted metadata during DeviceSync v2 attempts. This CL: (1) Adds the SyncedBluetoothAddressTracker class, which fetches the Bluetooth address using the BluetoothAdapter class. (2) Integrates this class with the rest of the DeviceSync flow. (3) Triggers a DeviceSync whenever the address has changed (e.g., if a user plugs in a USB Bluetooth adapter). (4) Preserves existing functionality (i.e., no synced Bluetooth address) when the flag is disabled. Bug: 1106937 Change-Id: If967f08913f495410323032094fd1f7312061057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342199Reviewed-by:Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Eric Orth authored
Fixed: 596568 Change-Id: I36f4b6c868d8e6cb585cc20c7d3a571cf9d09999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347405 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#796605}
-
David Trainor authored
Looks like this test is flaky today. Bug: 1114818 Change-Id: I53c46cbc5465d97a166b1982ed3aca70fd8e03f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346798Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#796604}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iac6e5b0550ed01748ecb5b75f777002f3c287620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346873 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Chris Harrelson authored
Previously, we did not map into the scrolled space when requested. This was implemented correctly in the non-GeometryMapper case by (*). It was only tested by unittests, and those unittests ran in non-GeometryMapper mode. This CL also implements those unittests in GeometryMapper mode. (*) https://chromium-review.googlesource.com/c/chromium/src/+/961643/ Change-Id: I43fd9907f3dda2a72c4da9bdadd6dc370c0d6874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347073 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8956bfb9c99d..559d54d0807e 2020-08-10 nguyenmh@google.com Update readme with how to run regression testing script 2020-08-10 nguyenmh@google.com Change test result types + add additional logging 2020-08-10 timvp@google.com Disabling failing dEQP-GLES2.functional.fbo.render.recreate_* tests 2020-08-10 jmadill@chromium.org Vulkan: Simpify check for started RenderPass + FB. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: dEQP-GLES2.functional.fbo.render.recreate_* Change-Id: Ied30bf2eba31290ce8ac8d660fddc9f06daeb5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347052Reviewed-by:
-
Lijin Shen authored
Set a min height to reach the min target touch size. Bug: 1096146 Change-Id: I3de7b9d1716ed25464120001a9fa15839ceb867b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337955 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
-
Ken Rockot authored
This is used to satisfy Env::Schedule calls. The implementation lazily spins a new PlatformThread and maintains a queue of tasks for it to run. LevelDB uses this to schedule work which may do file I/O. For the sandboxed Storage Service, this means doing sync Mojo IPCs. Mojo IPC in general requires some basic task scheduling state to be set up on the calling thread though, so the Storage Service will DCHECK when it tries to do compaction within a sandbox. Fortunately this thread doesn't seem to be necessary anymore, and it can be replaced with a much simpler dispatch to the ThreadPool. Env contract does not require scheduled tasks to be serialized, so they can be thrown at the ThreadPool without a sequenced task runner. A test is added to the sandboxed Storage Service in order to provide some (albeit roundabout) coverage of this code path. Incidentally the test also revealed a bug in FilesystemProxy which caused it to completely ignore its given IPC task runner, which can cause deadlocks in certain situations. This is also fixed and effectively covered by the new test. Bug: 1052045 Change-Id: Ic299a4050240c1b52d3669964ff6b65f74de8179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341415Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Fred Mello authored
https://docs.google.com/document/d/1Kvd_Vg4IuL9y3rcxyNVwJm3wfoSwiBduwbFGU3XihP8 Bug: 1112872 Change-Id: Ieba1a0fab0bcfc33ac2c3cf761edfcf5aa7cff12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347367 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/46a324a16c4b..0952991c4275 2020-08-10 egdaniel@google.com Fix vulkan render pass ctor. 2020-08-10 johnstiles@google.com Replace SkSL string macros with inline constexpr char arrays. 2020-08-10 robertphillips@google.com Remove GrStyledShape.h from GrSmallPathShapeData.h 2020-08-10 johnstiles@google.com Update ProcessorCloneTest to use a processor tree depth of 3. 2020-08-10 johnstiles@google.com Update MakeChildFP to allow processor hierarchies to be created. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I65dbd0e87861dd1e8a4f10e23e38f0b0a90ec49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347310Reviewed-by:
-
Gary Tong authored
Bug: 1114251 Change-Id: I59f4fbe6cf6cc96895eb3e2d9bc8b8578009a5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342256 Auto-Submit: Gary Tong <gatong@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Commit-Queue: Gary Tong <gatong@chromium.org> Cr-Commit-Position: refs/heads/master@{#796596}
-
Saagar Sanghavi authored
Rewrote PRESUBMIT.py (and associated tests) to new format. Runs REQUIRE_PRESUBMIT_VERSION at the top so that depot_tools can be made aware of the change and can time/rdb wrap each of the Check... functions separately, while also ensuring that they have the new version of depot_tools. Requires the newer version of presubmit_support.py in depot_tools, which is described in crrev.com/c/2341828 Change-Id: I102e8c75834aff1eccdf4a27ffe6f0953b76ee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341362Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: If0b22ffdf07996b5c97861521bd950e28c74ec34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346731Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#796594}
-
Lei Shi authored
Current boundsForRange will clip the bounds to ancestors. This CL adds an unclippedBoundsForRange method. The method will not clip bounds to the ancestors of the nodes. The previous CL 2335390 (Add an optional boolean parameter in boundsForRange) was reverted considering compatibility (see 2343876). The implementation of this CL is similar to 2335390. Bug: 775659 Change-Id: I189e9f21228e30693b3d89559c20c45afb890593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345681 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796593}
-
Adam Langley authored
These functions allow a limited range of domains to be encoded in 22 bits for inclusion in BLE adverts. BUG=1002262 Change-Id: I122af89cada6e6416d3a647b3ecdc724a8289f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340063 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#796592}
-
Dale Curtis authored
Creates a vpcc box based on the configuration info. R=sandersd Bug: 1103432 Test: Updated unittests. Change-Id: I3d5152b59c6f6ad82da25e699eba2d8bf5ba44ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346607 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#796591}
-
Scott Violet authored
It's flaky. BUG=1114854 TEST=test only change TBR=katie@chromium.org Change-Id: Ia6ccd9a91b654fb3bc36a2da4e37925fd5a13745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347249 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796590}
-
Sara Kato authored
ag/12295631 refines accessible name computation, therefore we should not compute accessible_name in two different places. Bug: b/162193325 Test: None Change-Id: I466e7c32f47e5578eb38015118a5d598c218a7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336000 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#796589}
-
Peter Kasting authored
The original CL was landed in one piece and reverted due to apparent perf regressions. Reland in sections to try and determine more precisely whether there is any perf impact. This CL lands only test changes, which should have no perf impact. Bug: none Change-Id: Iaa9885be7e994328b91da6fa3f24ade20e0ed56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346935 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Devlin Cronin authored
In content scripts, rename match_data_urls to match_origin_as_fallback. The associated bug has the full discussion, but this field better suits matching multiple schemes, and will apply to any frame where we need to compare the initiator/precursor origin. Note: this is a pure rename CL. It does *not* adjust any of the functionality. Bug: 55084 Change-Id: Iec4ba3e8f0bb0559eb800cc3e0d453c7b353598e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340494Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796587}
-
Abhishek Kumar authored
Some of the entries in UMA for NetworkServiceError shows as numbers like 21-25 instead of field names. Extend the NetworkServiceError enum to add new fields BUG=chromium:1108089 Change-Id: Ibcb8561dd7d8cfe0ebcb99d0aa81e713159fc667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335804Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Abhishek Kumar <kuabhs@chromium.org> Cr-Commit-Position: refs/heads/master@{#796586}
-
Andrew Grieve authored
I'd like to still work on a fix that doesn't reduce the size for bots with less RAM, but need something quick'ish to fix bot. Bug: 1098333 Change-Id: Ifdfe8f07712e5073419ea0c0c0eb89092c31a1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347384 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Yuheng Huang authored
Cause of revert: The previous CL tried to add a key to accelerators_cocoa.mm without adding to menu item Solution: remove change in accelerators_cocoa.mm but keep the change in global_keyboard_shortcuts_mac.mm This is a reland of 9b3d32d9 Original change's description: > Tab Search: Setup keyboard shortcut > > Setup ctrl(cmd on Mac) + shift + e as tab search keyboard shortcut > for all desktop platforms > > Bug: 1099917,1112558 > Change-Id: I6c50b26714d678d0f89d2c846909ff0b802e4f0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329944 > Commit-Queue: Yuheng Huang <yuhengh@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795750} Bug: 1099917 Bug: 1112558 Change-Id: I4639649e6b0b839ead06aac1458c058f20db5fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343300Reviewed-by:
-
Yusuke Sato authored
This will prevent Chrome from adding 'import' lines in the future which could cause a infinite import loop (by importing the combined property file itself.) See crbug.com/1114279. This makes our unit tests simpler too. BUG=None TEST=arc.Boot.vm, try Change-Id: I66f58cf4fdce5e2e84de754755e9d90525eb666e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343505Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796583}
-
Xinghui Lu authored
SAFE_BROWSING_STANDARD_PROTECTION_EXTENDED_REPORTING_TITLE is used as a title of Chrome switch preference. It should not be limited to 32 char long. Such limitation makes translation hard to proceed (b/162847586). A string of the same use case is PASSWORDS_LEAK_DETECTION_SWITCH_TITLE, which doesn't have such limitation. Bug: 1097310 Change-Id: Ie566f819446e9fc1949475681c5709e90ad56893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343873Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796582}
-
Fred Mello authored
https://docs.google.com/document/d/1UmT3I_bK-M5nfy--6HcgNAtnfLrG_xN5Fj2WVJgaqlk Bug: 1112872 Change-Id: I99da26b3a553e8771de53696a24e12cfda44638a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346624 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Command to verify they are sorted: cat chrome/common/chrome_features.h | \ gawk '{print gensub(/.*Feature[^ ]* ([0-9a-zA-Z_]*).*/,"\\1","g")}' | \ gawk '/^k/' > out/all \ && cat out/all | LANG=C sort -u > out/sorted \ && diff -u out/all out/sorted chrome/common/chrome_features.cc can be checked similarly. Fixing them was manual. Bug: None Change-Id: Ie5639fa4bedc41024f975ad43b8bf5a5149b322f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345944 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#796580}
-
Stefan Zager authored
This adds a new bit field 'hidden_' to LocalFrame, to track when a frame has been hidden/shown. Hidden state doesn't affect intersection geometry, but it does affect occlusion state as understood by IntersectionObserver V2. Also, refactor bool members in LocalFrame into idiomatic bit fields. No functional change in any of the existing members. BUG=1114395 Change-Id: I2a09a2e9f5940f5f909413f0cf1c545e16aced4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337343Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#796579}
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/f18d737b4e93..bc80805c4b04 $ git log f18d737b4..bc80805c4 --date=short --no-merges --format='%ad %ae %s' 2020-08-09 dneto [spirv-writer] Infer and emit matrix layout 2020-08-07 sarahmashay [validation] v-0021: cannot re-assign constants 2020-08-06 sarahmashay [Validation] v-0006: variables must be defined before use 2020-08-05 dneto [spirv-reader] Remove support for NumWorkgroups builtin variable 2020-08-05 sarahmashay [validator] implement variable_stack_ Created with: roll-dep src/third_party/tint/src Change-Id: I3531ae47e02d7b10f2317d40b85052eeb32ee125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346330 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#796578}
-
Alexander Surkov authored
suitable for nested attribute calls Bug: 1100991 AX-Relnotes: n/a Change-Id: Ib0c4512242bad94abf8a0231e129951172e6b584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274545 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
-
