- 10 Jul, 2017 3 commits
-
-
yhanada authored
Bug: N/A Test: Build passes. Change-Id: I1f0b7788b52a0c15b1fda57ec7a153406ef2676f Reviewed-on: https://chromium-review.googlesource.com/562847Reviewed-by:
Keigo Oka <oka@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#485169}
-
Adam MacBeth authored
R=wez@chromium.org Change-Id: Ibc345f53a4bbe14bb22ff03bfd871cd17443afaf Reviewed-on: https://chromium-review.googlesource.com/559951Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#485168}
-
Jia authored
This cl contains the following changes * Implemented ParseLonghandViaAPI in CSSPropertyParserHelpers. - This function will be used by Consume2Values, Consume4Values and ConsumeShorthandGreedily. These shorthand parsing functions all need to forward parsing ops to component longhands. - At the moment, these functions call CSSPropertyParser's ParseSingleValue. However, as we will later move these shorthand parsing functions to CSSPropertyParserHelpers, we should not continue to call CSSPropertyParser. - Therefore, this cl adds ParseLonghandViaAPI, which contains similar logic to CSSPropertyParser's ParseSingleValue, with the exception that this new method only works on longhands that have API impl. * Moved CountKeywordOnlyPropertyUsage from CSSPropertyParser to CSSPropertyParserHelps. - This function is used by ParseLonghandViaAPI. Note, the next cl will have an impl of ConsumeShorthandVia4LonghandsAPI that will use ParseLonghandViaAPI. Bug: 668012 Change-Id: Ia9211f9eb5d70124536f5ef0e7d44eeafefa69e2 Reviewed-on: https://chromium-review.googlesource.com/557619 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#485167}
-
- 09 Jul, 2017 13 commits
-
-
Fredrik Söderqvist authored
In these tests we want to sample animation values at a certain point in time. We are however sampling the animations at the next frame that is painted - at which point the timeline may have advanced, and hence we sample at t+<framedelay> (or thereabout) instead. Currently this works "fine" because the first animation frame follows special scheduling rules, making sure the timeline won't advance within this time window. Rather than relying on this, just pause the timeline instead. BUG=726362 Change-Id: I2314b435861050fd0163670928318563bd09f271 Reviewed-on: https://chromium-review.googlesource.com/563624 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#485166}
-
martijn authored
This change forces the pins files to use LF line-endings and adds a check to detect CRLF line-endings that outputs a more helpful error message. BUG=729553 Review-Url: https://codereview.chromium.org/2941543002 Cr-Commit-Position: refs/heads/master@{#485165}
-
Sylvain Defresne authored
Change compile_xcassets.py to keep all output in known sections (except com.apple.actool.compilation-results) as some errors do not follow the pattern that was used, discarding the compilation error message. Bug: 739163 Change-Id: Ide40508913e5d32111ad9ba2225745d67465023b Reviewed-on: https://chromium-review.googlesource.com/563298Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485164}
-
Avi Drissman authored
This reverts commit c9e5db84. Reason for revert: The layout test fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html started failing on the WebKit Mac10.9 bot starting with https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/47919 . This was the sole change in that build cycle; reverting. Original change's description: > Remove flag to stop relying on bilerp-hack > > This brings the raster backend into line with ganesh, which never had this hack. > > (moved from https://chromium-review.googlesource.com/c/562677) > > Bug=skia:6835 > TBR=reed@google.com > > Change-Id: I2f0e3a1be03cccc8b1436a290b0b80dde0419aa1 > Reviewed-on: https://chromium-review.googlesource.com/563783 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485153} TBR=fmalita@chromium.org,reed@chromium.org Change-Id: Ifa0002821909548faf7595338e90b19521034e97 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/563984Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485163}
-
Daniel Cheng authored
WebRemoteFrameBase is already disallowed until we devise a concrete plan for splitting out controller functionality. As WebRemoteFrameBase is simply a proxy class for WebRemoteFrameImpl, WebRemoteFrameImpl should similarly be disallowed. Bug: 712963 Change-Id: I1d883e65b958947ee36f7fa50b67dc5a5cf16ecd Reviewed-on: https://chromium-review.googlesource.com/564072Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#485162}
-
ananta authored
Fix a crash in the fullscreen handler on Windows which occurs due to CHECK for success in creating the TaskBarList It looks like assuming this COM object to be available in all cases is incorrect. We have other users in Chrome who use this on a best effort basis. Additionally we need to call the HrInit() method on the ITaskBarList2 interface before using it. BUG=740376 TBR=msw Review-Url: https://codereview.chromium.org/2978453002 Cr-Commit-Position: refs/heads/master@{#485161}
-
kojii authored
Re-land of r485142 due to one crash turned to flaky. This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 Review-Url: https://codereview.chromium.org/2975663002 Cr-Commit-Position: refs/heads/master@{#485160}
-
Jao-ke Chin-Lee authored
Bug: 730783, 728707 Change-Id: I744c73d36ca76d97eff1e202fa20ba5d4a9adb7b Reviewed-on: https://chromium-review.googlesource.com/531804 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485159}
-
Ramin Halavati authored
Network traffic annotation that is given to URLLoaderFactoryImpl::CreateLoaderAndStart is passed to ResourceDispatcherHostImpl::OnRequestResourceWithMojo to be used when network request context is created. The ResourceHostMsg_RequestResource is also updated so that both mojo and non-mojo resource request paths from resource_dispatcher.cc to dresource_dispatcher_host_impl.cc would be annotated (Requested in https://chromium-review.googlesource.com/c/535641). Bug: 656607 Change-Id: I3cc4e5af0f2fc9cbb1391ef9039090df8346179b Reviewed-on: https://chromium-review.googlesource.com/548496Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#485158}
-
yoshiki iguchi authored
This patch fixed the issue of close and settings buttons in arc notifications. Bug: 739620 Change-Id: I0d050d3cec66f0470a7babb9f40833487f0e3071 Reviewed-on: https://chromium-review.googlesource.com/561996Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#485157}
-
Avi Drissman authored
This reverts commit 547fd06b. Reason for revert: This breaks bots. This broke WebRtcGetUserMediaBrowserTest.RenderVideoTrackInMultipleTagsAndPause WebRtcGetUserMediaOldConstraintsBrowserTest.RenderVideoTrackInMultipleTagsAndPause on Mac, Cast, and Win bots. Original change's description: > Roll src/third_party/skia/ 8fe24272f..8d1fc16ba (1 commit) > > https://skia.googlesource.com/skia.git/+log/8fe24272fa6d..8d1fc16ba616 > > $ git log 8fe24272f..8d1fc16ba --date=short --no-merges --format='%ad %ae %s' > 2017-07-07 fmalita More SkColorSpaceXformer caching > > Created with: > roll-dep src/third_party/skia > > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, see: > http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > TBR=csmartdalton@chromium.org > > Change-Id: Ia00a6af7af62f499770090fceafc447a31dd812c > Reviewed-on: https://chromium-review.googlesource.com/564538 > Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> > Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485152} TBR=skia-deps-roller@chromium.org,csmartdalton@chromium.org Change-Id: Ic06e1988d0ba10593dd777b1420f8aa285a15c8d No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/563983Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485156}
-
avi authored
Revert of [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox (patchset #3 id:40001 of https://codereview.chromium.org/2975663002/ ) Reason for revert: WebKit layout bots all started failing after this commit. webkit_tests webkit_tests Total tests: 66971 * Passed: 56304 (56144 expected, 160 unexpected) * Skipped: 9131 (9131 expected, 0 unexpected) * Failed: 1447 (1446 expected, >>>1 unexpected<<<) * Flaky: 89 (89 expected, 0 unexpected) Unexpected Failures: * virtual/layout_ng/fast/block/float/rubybase-children-moved-crash.html Original issue's description: > [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox > > This patch fixes to set InlineBoxWrapper when copying fragments to > LayoutBox. > > To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() > calls LayoutBlockFlow::ConstructLine(), but it does not set > InlineBoxWrapper. > > LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets > InlineBoxWrapper but LayoutNG does not call this function. It does > several other things, but SetInlineBoxWrapper() is the only thing needed > for CopyFragmentDataToLayoutBox(). > > BUG=636993, 739365 > > Review-Url: https://codereview.chromium.org/2975663002 > Cr-Commit-Position: refs/heads/master@{#485142} > Committed: https://chromium.googlesource.com/chromium/src/+/981fa39e2dde70f5933ea2db88123582ab955632 TBR=eae@chromium.org,ikilpatrick@chromium.org,kojii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636993, 739365 Review-Url: https://codereview.chromium.org/2977483002 Cr-Commit-Position: refs/heads/master@{#485155}
-
Jeff Carpenter authored
Bug: 740176 Change-Id: I128f10379ad8deb240f260b139a6a795bb611d76 Reviewed-on: https://chromium-review.googlesource.com/563468 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#485154}
-
- 08 Jul, 2017 24 commits
-
-
Florin Malita authored
This brings the raster backend into line with ganesh, which never had this hack. (moved from https://chromium-review.googlesource.com/c/562677) Bug=skia:6835 TBR=reed@google.com Change-Id: I2f0e3a1be03cccc8b1436a290b0b80dde0419aa1 Reviewed-on: https://chromium-review.googlesource.com/563783Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#485153}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/8fe24272fa6d..8d1fc16ba616 $ git log 8fe24272f..8d1fc16ba --date=short --no-merges --format='%ad %ae %s' 2017-07-07 fmalita More SkColorSpaceXformer caching Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ia00a6af7af62f499770090fceafc447a31dd812c Reviewed-on: https://chromium-review.googlesource.com/564538Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485152}
-
sadrul authored
Make ServerGpuMemoryBufferManager a MemoryDumpProvider, so that it can report the gpu memory usage by various clients. BUG=733482 Review-Url: https://codereview.chromium.org/2971903003 Cr-Commit-Position: refs/heads/master@{#485151}
-
Ned Nguyen authored
TBR=perezju@chromium.org Bug: 728464 Change-Id: Ifb2b77d3f5a8700d7b5d2f9ea45d80ab6a428e50 Reviewed-on: https://chromium-review.googlesource.com/564331Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#485150}
-
Dmitry Torokhov authored
Now that we have dedicated key for the assistant, let's start using it, in addition to Meta-A. BUG=b:36735408 Change-Id: Ide16328acd1725b36e82016eba14a320c83acd3a Reviewed-on: https://chromium-review.googlesource.com/550414 Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#485149}
-
rdsmith authored
The number of cookies deleted will always be zero or a positive number, so should be represented by an unsigned. This is being done to bring the CookieStore interface into alignment with the Mojo cookie service. BUG=721395 R=mmenke@chromium.org TBR=sgurun@chromium.org TBR=mkwst@chromium.org TBR=sky@chromium.org TBR=jam@chromium.org TBR=rohitrao@chromium.org Review-Url: https://codereview.chromium.org/2971733002 Cr-Commit-Position: refs/heads/master@{#485148}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/256098db1e09..00b0c16c9708 $ git log 256098db1..00b0c16c9 --date=short --no-merges --format='%ad %ae %s' 2017-07-08 perezju Revert of [System Health] Extend dump time to 5 seconds (patchset #2 id:20001 of https://codereview.chromium.org/2946013004/ ) Created with: roll-dep src/third_party/catapult BUG=734853 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I767d74467eecdddcc223be036d7ae68a6eb9c1e6 Reviewed-on: https://chromium-review.googlesource.com/564312 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485147}
-
Alexander Timin authored
Make internal::TaskQueueImpl a member of TaskQueue instead of inheriting. This will allow us to easily subclass TaskQueue for different parts of the code. This patch does not change behaviour. Notable changes: * TaskQueue::Observer mechanism changed (we can't issue a callback from the internals of the scheduler due to not having TaskQueue reference. Instead TaskQueueImpl::OnNotification are introduced and TaskQueue passes necessary handlers to underlying TaskQueueImpl). These notifications include queue wake-up changes and completed tasks for metric purposes. Bug: Change-Id: I61ebcdfb45d02bb44e856de3cc3caf25ab26763b Reviewed-on: https://chromium-review.googlesource.com/559148 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#485146}
-
edchin authored
BUG=686770 Review-Url: https://codereview.chromium.org/2971113002 Cr-Commit-Position: refs/heads/master@{#485145}
-
Mounir Lamouri authored
Things are moving out of core/html/shadow and having files consolidated in media/ will help with ownership. Bug: None Change-Id: I0b9cbced78f3a3a0ba1501e2a242a3c2f17ef3bd Reviewed-on: https://chromium-review.googlesource.com/563213Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#485144}
-
Mounir Lamouri authored
This is moving the remaining three classes and enum to modules as none of these are now used outside of modules/media_controls/ and modules/accessibility/. Bug: 662761 Change-Id: I6e89ae252e6f6a10c25a7650cb8a88f90d798880 Reviewed-on: https://chromium-review.googlesource.com/563300Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#485143}
-
kojii authored
This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 Review-Url: https://codereview.chromium.org/2975663002 Cr-Commit-Position: refs/heads/master@{#485142}
-
Koji Ishii authored
Following bot results are included. 675 The InlineBoxWrapper fix[1] changes the result too much for Rietveld to handle, and thus moving to Gerrit. 3848 new passes, and 964 crashes turn to failures/timeouts. [1] https://codereview.chromium.org/2975663002 BUG=591099 TBR=eae@chromium.org NOTRY=true Change-Id: I9cce7a01bdacb6bb0f21542344bee1800e7a62ff Reviewed-on: https://chromium-review.googlesource.com/563768 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#485141}
-
Jay Civelli authored
Extracting the launching code that will go to base from ChildProcessLauncherHelper (CPLH) to ChildProcessLauncher (CPL). CPLH now creates a CPL that takes care of creating the connection and setting it up and delegates back to the CPLH for content specific behavior. Adding tests to validate the CPL API and moving some existing tests to use CPL instead of CPLH. The new tests use a new test service (TestChildProcessService) that echoes back the delegate calls called on it. Also removing the CPLH tests validating strong binding connections as this is already tested in ChildConnectionAllocatorTest. Bug: 702316 Change-Id: Ic2bda3f621530616cacc60e22007ca36464a0159 Reviewed-on: https://chromium-review.googlesource.com/557890 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485140}
-
Sonny Sasaka authored
This CL removes BluetoothLowEnergyExtensionFunctionDeprecated and migrate the subclasses to use BluetoothLowEnergyExtensionFunction instead, which is based on UIThreadExtensionFunction. BUG=737211 Change-Id: Ibd3781973582dbd339ccf021604f44de04ad6bba Reviewed-on: https://chromium-review.googlesource.com/560780 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#485139}
-
Antoine Labour authored
This fixes how we handle matrix attributes to properly take into account all the locations that they use instead of just the first one. Bug: 736639, 738228 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0ca7d9b8a962d7de13016f5c04d5ab1d7348f514 Reviewed-on: https://chromium-review.googlesource.com/553746Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485138}
-
Brian White authored
BUG=739941 Change-Id: I385237e7643707381109879908bf5d493bf62345 Reviewed-on: https://chromium-review.googlesource.com/563542 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#485137}
-
chrome-release-bot authored
TBR=thakis@chromium.org Change-Id: I3fbceeb755e372c2b436d41f7be9c8f55a21c4bc Reviewed-on: https://chromium-review.googlesource.com/563781Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#485136}
-
Tom Anderson authored
Patch thanks to kylixrd@chromium.org! BUG=593874 R=thestig@chromium.org TBR=rdevlin.cronin@chromium.org CC=kylixrd@chromium.org Change-Id: If554b0e1ed1d40386e7a639dc9b8869225500b51 Reviewed-on: https://chromium-review.googlesource.com/564284 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#485135}
-
einbinder authored
The text button has a fixed height, so it doesn't need vertical padding. The padding caused the text to be not centered on Windows. BUG=none Review-Url: https://codereview.chromium.org/2938663002 Cr-Commit-Position: refs/heads/master@{#485134}
-
Chris Cunningham authored
Also includes type mapping for media::EncryptionScheme. Bug: 611224 Change-Id: I151aacd4ea2dfe9e02ff7c82c922bc5a982e1fd4 Reviewed-on: https://chromium-review.googlesource.com/544913Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#485133}
-
Dave Schuyler authored
This CL touches up some typos, mostly in the settings internet code. Not a big deal, but I wanted something low risk yet helpful to do late on a Friday. TBR=stevenjb@chromium.org (code health) Bug: None Change-Id: I76616bc258d9fb92323d37c57341de2575ee72d8 Reviewed-on: https://chromium-review.googlesource.com/564203Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#485132}
-
sclittle authored
This CL causes Chrome to show the same client-generated placeholders for both Server LoFi and Client LoFi, so that all LoFi images have a consistent appearance. BUG=680645 Review-Url: https://codereview.chromium.org/2930323003 Cr-Commit-Position: refs/heads/master@{#485131}
-
Dave Schuyler authored
This CL moves the on startup settings off of the main settings page and into a subpage. Bug: 653376 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I46dd91fbd3e1bc4b28b6465ad0a3a08b7bee1927 Reviewed-on: https://chromium-review.googlesource.com/557971Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#485130}
-