- 08 Mar, 2018 40 commits
-
-
Dominic Mazzoni authored
When an Android accessibility service sends us a CLICK or FOCUS action on a specific node in a WebView, we should first focus the WebView itself. Otherwise clicking on a text field using an accessibility service doesn't actually move input focus there and pop up the virtual keyboard. Bug: 819669 Change-Id: I8e4069324e45516fbc1621723885ad8448fdc862 Reviewed-on: https://chromium-review.googlesource.com/953322Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#541748}
-
Ramin Halavati authored
Local annotation is added to SpdySession::TryCreatePushStream. Bug: 656607 Change-Id: I164d9d6df34b9f38e6077c5746a04f2e53a7061d Reviewed-on: https://chromium-review.googlesource.com/951728 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#541747}
-
Xiaohan Wang authored
This reverts commit 7a87490b. Reason for revert: Crash. See crbug.com/819916 Original change's description: > Add a SubresourceLoadInfo struct to content/ > > This data type is useful for sending stats from the renderer to the > browser, in SubresourceResponseStarted methods. Currently there are six > fields that are passed around, but soon there may be more in order to > get PageLoadMetrics working with the Network Service. > > BUG=816684 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I26a62ebb5aa82f225a70fe54098433c5c3342941 > Reviewed-on: https://chromium-review.googlesource.com/947582 > Commit-Queue: Conley Owens <cco3@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541550} TBR=dcheng@chromium.org,jcivelli@chromium.org,jam@chromium.org,cco3@chromium.org Change-Id: I48effa0d5a7407dfbbaf41d5d1708a1491f31639 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816684,819916 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/954588Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541746}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I74ff926d9dd9173fc2e8abbe800700631873629a Reviewed-on: https://chromium-review.googlesource.com/954984 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541745}
-
Matt Falkenhagen authored
This has been enabled on Android since Chrome 62 by server-side field trial configuation, and since Chrome 64 by the client code. As part of the launch process for issue 733466, we received approval to enable it on all platforms after Android 62 rolled out widely, which is definitely true now. This CL still keeps the feature flag, but it should be removed completely later. Bug: 733466, 819476 Change-Id: Idcd85b1afb3e7724a1ff6a3b9cd8e1db6ec23788 Reviewed-on: https://chromium-review.googlesource.com/952955Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#541744}
-
Manuel Rego Casasnovas authored
The ImeTextSpanThickness enum has 3 values: * kNone: When you don't want to paint the underline (this was done with transparent color before). * kThin: For regular ImeTextSpan. * kThick: For thick ones. With the enum the API calls are much clearer than using a boolean. BUG=554893 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I813716c08d73fc962080952c9729d3167fc12c0e Reviewed-on: https://chromium-review.googlesource.com/919494Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#541743}
-
Mina Almasry authored
Improve the initial implementation by adding proper pause/resume/seek support. The AudioDecoderForMixer will notify the AvSync of these actions. The AvSync will turn on/off its AV monitoring as needed, and will reset its linear regressions as needed. BUG=internal 73746352 TEST=On device, pause/play work very well now, without any noticeable jitter by myself at all. Correction logs indicate that we will do a hard correction after Seek and usually a soft correction after resume, but there is no visible jitter to me at all Change-Id: I21376e41eee15161098578208625974ff0385cf8 Reviewed-on: https://chromium-review.googlesource.com/947720 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#541742}
-
yoshiki iguchi authored
In the original Android and the previous ARC, the bundle notification was not expanded automatically, because their height may be too long vertically to expand. We recentlly re-implementing auto-expander in Chrome-side. This CL implements that behavior to Chrome auto-expander. Bug: 810656 Test: manual test Change-Id: Ie6cc878fff04148402448ddd2aa4f02f6541164b Reviewed-on: https://chromium-review.googlesource.com/942129 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#541741}
-
Kenneth Russell authored
This reverts commit 4eeae7ba and adds the pyobjc wheel to Chromium's root .vpython. At this point, vpython is used on all of the bots for the system Python, so it should be suitably warmed up before getting into any of Chromium's tests. Bug: 776804, 804174 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I35c602ca6e0368532685ae8afc3139692a6153fa Reviewed-on: https://chromium-review.googlesource.com/954704Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541740}
-
Brandon Jones authored
Brings Chrome's implementation inline with the latest spec changes. Bug: 819744 Change-Id: I716bab14bdbcc1c452a4dd447adbe28ffef05f98 Reviewed-on: https://chromium-review.googlesource.com/953259 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#541739}
-
Takuto Ikuta authored
pkg_config added -isystem in abspath. Let me use relative path here for cache utilization on goma backend when building chrome in different directory. Change-Id: Id48db3036711c07788bb370753acc7a9b217a89d Reviewed-on: https://chromium-review.googlesource.com/954526Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#541738}
-
Kenneth Russell authored
These were copy-pasted and edited instead of going back to the source of truth, chromium_gpu_fyi.py. TBR=nodir@chromium.org NOTRY=true Bug: 811799, 811814 Change-Id: Ic3f4e5063058940024adc330f7129f2d6fb24275 Reviewed-on: https://chromium-review.googlesource.com/954717 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541737}
-
Jennifer Apacible authored
This change fixes a browser crash when the PiP media controls button is toggled more than once. BUG: 817984 726621 Change-Id: I53d504b9de44b724a3992c709fa26c0fca9be5bc Reviewed-on: https://chromium-review.googlesource.com/951909 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#541736}
-
tzik authored
This updates //courgette to use base::RepeatingCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //courgette from 3 to 0 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: I40ec7c5cd7486f6b1110f13e35fd0368a4db9f3c Reviewed-on: https://chromium-review.googlesource.com/954886Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#541735}
-
tzik authored
This renames the existing GetMock{,Tick}Clock on TestMockTimeTaskRunner with DeprecatedGetMock{,Tick}Clock, and adds new GetMock{,Tick}Clock. The old one returns a new Clock or TickClock object for each call, and passes its ownership. OTOH, the new one returns a raw pointer to a clock held by the TestMockTimeTaskRunner instance. This is needed to update the ownership policy of base::Clock and base::TickClock from the injectee-owned style to the injector-owned style. Bug: 789079 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8b831eff74e6a8d0f1f67dc1806e3cc24831196f Reviewed-on: https://chromium-review.googlesource.com/937148 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:Ken Rockot <rockot@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Adding the write barrier to collection backings regressed blink_perf.parser by 16% Bug: 818696 Change-Id: If964e2ccf39beb3010063bf785e97c60ddf007c2 Reviewed-on: https://chromium-review.googlesource.com/953443Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541733}
-
Scott Violet authored
Without this code thinks an event has been processed when it may not have been, which leads to assertions failing. This is only an issue with the Window Service, which triggers throttling more often. BUG=817112 TEST=test only change Change-Id: Ie290dcc827e4be67263f0430c540af271b16ab02 Reviewed-on: https://chromium-review.googlesource.com/954702Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#541732}
-
Steven Holte authored
Change-Id: I6c00beafaf5d1eea6a7452ed187924ae9f4433fa Reviewed-on: https://chromium-review.googlesource.com/944666 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#541731}
-
Megumi Hattori authored
The inline settings should be triggered by long tap. BUG=818734 TEST=manual Change-Id: Ieeb7a0c009b15157bd90c823ece84ed39bf676eb Reviewed-on: https://chromium-review.googlesource.com/950504Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#541730}
-
Bo Liu authored
This allows a bunch of code to be deleted as well. Need to fix up unit tests which was still using synchronous draw, and thus having wrong expectations. Change-Id: Ia5504545f213bf709951eb2213dc40aaca4fc6be Reviewed-on: https://chromium-review.googlesource.com/949085 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#541729}
-
Yuki Shiino authored
Makes CallbackInterfaceBase and its subclasses use wrapper-tracing to retain the underlying v8::Object. Lets existing clients of CallbackInterfaceBase, which don't support wrapper-tracing, use V8PersistentCallbackInterface<T> instead. The behavior and lifetime shouldn't change. Bug: 778580 Change-Id: If5db42a3b8cd5622de0576a920128a0b5ab0861f Reviewed-on: https://chromium-review.googlesource.com/951163Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Alan Cutter authored
This is a simple clean up CL that has no changes in behaviour. The bubble anchor code can use the recently added ButtonProvider instead of a specialised getter on FrameView. Change-Id: Ia067afe36f07c3ce4b77344c28f6467e4a9a1801 Bug: 811178 Reviewed-on: https://chromium-review.googlesource.com/950642Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/98bb968f7bed..8861da8356ee $ git log 98bb968f7..8861da835 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I457bf7ff2fff46c97fe3c04f333458d23b7473eb Reviewed-on: https://chromium-review.googlesource.com/954356Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541726}
-
Eric Willigers authored
kRtcPeerConnectionId is 2384 2383 is already taken by kRTCConstraintEnableDtlsSrtpFalse tools/metrics/histograms/enums.xml was already correct but web_feature.mojom needing correcting. No release branches affected: M66 Branched Chromium @ revision: 540276 Bug was introduced: Cr-Commit-Position: refs/heads/master@{#540486} BUG=775415 TBR=eladalon@chromium.org Change-Id: I4baccfe7ce21cc24ca704fbc1b49e92ae3365a80 Reviewed-on: https://chromium-review.googlesource.com/954524Reviewed-by:Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
This patch makes PasteMode to be an enum class for better type safety and improving code health. Using forward declaratuion in other header files instead of including |PasteMode.h|. Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I74ea67e08607779cb823cb379c415263d537303f Reviewed-on: https://chromium-review.googlesource.com/954423Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#541724}
-
Sammie Quon authored
Notify click wont work because it fires after the release event. We need to observe both press and release events to mimic keyboard press and release. Test: none Bug: none Change-Id: I314aed2dcc870c8579a48c8abed45b0065737819 Reviewed-on: https://chromium-review.googlesource.com/954048Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#541723}
-
Yury Khmel authored
We need to distinguish logout and restart in app push install logger. Currently there is no easy way to get this information. At this moment only BootTimesRecorder is explicitly notified. This CL makes this information public and let log collector use it. Bug: b/73277923 Test: Manual + unit test Change-Id: I64eea3b748e4ad089365fe3453e9c5fc0e6c3162 Reviewed-on: https://chromium-review.googlesource.com/949826Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#541722}
-
https://chromium.googlesource.com/angle/angle.git/+log/40dba69082bd..ed8b49195844 $ git log 40dba6908..ed8b49195 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 jmadill Vulkan: Fix missing depth/stencil access flags. 2018-03-02 jmadill Add RenderTargetCache helper. 2018-03-07 ynovikov Revert "Add NPOT validation to copyTextureCHROMIUM" 2018-03-06 tobine Roll (2/2) to latest LVL as of 3/6/18 Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ia569df5da9d8c64bf0ae27133237b8586e9e789e Reviewed-on: https://chromium-review.googlesource.com/954051Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541721}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I310daa91088a4eacbf0a56ea19d512f3c76fc105 Reviewed-on: https://chromium-review.googlesource.com/954782Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#541720}
-
Yutaka Hirano authored
We've attached the header to requests initiated by sendBeacon() but it is not spec conformant. Let's stop doing that. Bug: 755725 Change-Id: Ia8b85a27b84c77b35edc211c325490467c853330 Reviewed-on: https://chromium-review.googlesource.com/952104Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#541719}
-
https://skia.googlesource.com/skia.git/+log/88df8d2e5a87..df04ce29490a $ git log 88df8d2e5..df04ce294 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 csmartdalton ccpr: Draw curves in a single pass 2018-03-07 fmalita [skottie] Reduce parser verbosity 2018-03-07 reed add TrimPathEffect 2018-03-07 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ da8c41528..e5ac7a7c8 (2 commits) 2018-03-07 fmalita [sksg] Cache transformed TrimEffect geometry 2018-03-07 bsalomon Make ProxyUtils::MakeTextureProxyFromData use wrapped textures when origin is kBottomLeft Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ic90bcf59454676f4c2eab16fb6da1db3d256b13f Reviewed-on: https://chromium-review.googlesource.com/954047Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541718}
-
Toni Barzic authored
Adds DetachableBaseNotificationController that observes DetachableBaseHandler in order to detect when a detachable base different than the last base used by the active user changes. When a detachable base change is detected, it shows a system notification. The notification serves a security purpose - it warns the user that the detachable base they are using has changed, and that the base could be compromised (to steal their keystrokes). Note that the notification is shown only if the session is unblocked at the time - lock screen and login screen will implement their own UI to notify the user about the base change. If/when the session is unblocked, the attached base is set as the last one used by the user to prevent the notification from showing up next time the user attaches the same base. Bug: 796300 Change-Id: I7ff8fdf3e02e5833df2a709169fdd076285f3a4b Reviewed-on: https://chromium-review.googlesource.com/952477Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#541717}
-
Chris Nardi authored
Tests that were duplicates of those already existing in web-platform-tests were deleted. Other tests were either moved to the CSSOM directory in WPT, or appended to already existing tests. The README was also deleted, as it is no longer accurate. Change-Id: I0acb41c6102a572a1fc2401630732a8ff1c5263d Reviewed-on: https://chromium-review.googlesource.com/945135Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541716}
-
Kurt Horimoto authored
This CL exposes the previous named layout guide API via a UILayoutGuide subclass called NamedGuide. In addition, this CL adds the ability to reset the view to which the named guide is being constrained, as this will be necessary for voice search, as it can be launched by a variety of buttons. Bug: 805120 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I054c3072cf59ce8ec84eb9002aa228c3a70b2167 Reviewed-on: https://chromium-review.googlesource.com/941407 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541715}
-
Erik Luo authored
The console prompt currently listens for ArrowUp/ArrowDown and loads the next/previous command from history, if the cursor is on the first/last line. Since a logical CodeMirror line may wrap onto multiple visual rows, this may unintentionally load the next command. This CL adds a check whether the cursor is truly on the first/last visual row. Problem gif: https://imgur.com/a/s7gPL Bug: 808130 Change-Id: I04363e25206cece28b32b80dfc548340413112cf Reviewed-on: https://chromium-review.googlesource.com/927690 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#541714}
-
Esmael El-Moslimany authored
Bug: 819317 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iee782ed92e4f3b5ec21239718b75f2d8f1a4188d Reviewed-on: https://chromium-review.googlesource.com/953123Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#541713}
-
Benjamin Pastene authored
TBR=jbudorick@chromium.org Bug: 817779 Change-Id: I99e51513bc6279ba98409952f20b0dec66a62cd4 Reviewed-on: https://chromium-review.googlesource.com/954607Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#541712}
-
Giovanni Ortuño Urquidi authored
After this patch, Desktop PWAs should no longer capture links without users enable the kDesktopPWAsLinkCapturing flag. Final patch to disable link capturing by default: [1] Specify that throttle and tests are for experimental feature (https://crrev.com/ba5d9af) [2] Extract tests that should run when link capturing is off (https://crrev.com/e3aa04a) [3] Handle out-of-scope navigations and stop link capturing by default (https://crrev.com/c/942597) [4] Disable link capturing by default (This patch) Bug: 814102 Change-Id: I0d03c93c2594c3da7d5139496502244e299c8e84 Reviewed-on: https://chromium-review.googlesource.com/950484Reviewed-by:Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#541711}
-
Kenneth Russell authored
These exist only to be mirrored into the optional tryservers, but their existence breaks on LUCI, where the triggers were silently ignored on Buildbot. The same will have to be done for the other optional Windows and Android trybots. Also, let the GPU FYI service account trigger jobs. TBR=nodir@chromium.org Bug: 815092, 819899 Change-Id: I263dcfc4e95b99aac5dee9466c341f1c552b145d Reviewed-on: https://chromium-review.googlesource.com/954587Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/749b609d11e8..04d792fb7510 $ git log 749b609d1..04d792fb7 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 dsinclair [formcalc] Consider width along with depth of tree Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I950aa2cc06b39f07b958f6d727b641c9411e2815 Reviewed-on: https://chromium-review.googlesource.com/953261Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541709}
-
