GitLab

Rename local variable from 'p' to 'parcel.  Call parcel.setDataPosition(0)
between write and read.  Fix a log message for punctuation.

Fixes (from logcat):
  E/Bundle  ( 5115): readBundle: bad magic number
  E/Bundle  ( 5115): readBundle: trace = java.lang.RuntimeException
  E/Bundle  ( 5115):      at android.os.Bundle.readFromParcelInner(Bundle.java:1677)
  E/Bundle  ( 5115):      at android.os.Bundle.readFromParcel(Bundle.java:1670)
  E/Bundle  ( 5115):      at org.chromium.base.library_loader.Linker.useSharedRelros(Linker.java:494)
  E/Bundle  ( 5115):      at org.chromium.content.app.ChildProcessService$1.setupConnection(ChildProcessService.java:100)
  E/Bundle  ( 5115):      at org.chromium.content.common.IChildProcessService$Stub.onTransact(IChildProcessService.java:57)
  E/Bundle  ( 5115):      at android.os.Binder.execTransact(Binder.java:388)
  E/Bundle  ( 5115):      at dalvik.system.NativeStart.run(Native Method)

BUG=388356

Review URL: https://codereview.chromium.org/371943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282298 0039d316-1c4b-4281-b951-d872f2087c98

We're working on fixing these, but disable them to make the waterfall
green until they are working.

BUG=382573
TEST=none
NOTRY=true
NOTREECHECKS=true

depends on https://codereview.chromium.org/379933002/

Review URL: https://codereview.chromium.org/383473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282297 0039d316-1c4b-4281-b951-d872f2087c98

Tests on XP are failing. 

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34594 
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29

We should use LoadLibrary and GetProcAddress to call SetupDIGetDeviceProperty
because it is not available in WinXP.

> Retrieve "connected" property from BLE devices.
> 
> We have to use the SetupDIGetDeviceProperty API to retrieve this specific property, as the "connected" status is something common to many PnP devices.
> 
> BUG=388016
> 
> Review URL: https://codereview.chromium.org/379943003

TBR=rpaquay@chromium.org

Review URL: https://codereview.chromium.org/383693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282295 0039d316-1c4b-4281-b951-d872f2087c98

We need to revert r282212 which breaks XP tests.
> Expose "visible" and "authenticated" properties.
> 
> They are always "true" for now, due to the way BLE devices work under Windows 8.
> 
> BUG=388016
> 
> Review URL: https://codereview.chromium.org/378293007

TBR=rpaquay@chromium.org

Review URL: https://codereview.chromium.org/388453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282294 0039d316-1c4b-4281-b951-d872f2087c98

glQuery objects are not sharable, so managing IDs for each client
locally in GLES2Implementation.

BUG=

Review URL: https://codereview.chromium.org/371363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282292 0039d316-1c4b-4281-b951-d872f2087c98

Updating the history state has been a surprisingly rich source of performance
bugs. This minimal page exemplifies them.

BUG=391158

Review URL: https://codereview.chromium.org/378803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282291 0039d316-1c4b-4281-b951-d872f2087c98

Default chunk size is 32KB and it is too small for provided file systems, which
require IPC calls for each chunk. Such small chunks cause the IPC overhead to
slow down the reading process drastically.

Moreover, since there is no streaming support in XMLHttpRequest, returning
data in chunks in providing extensions, requires making separate HTTP requests
with appriopriate Range header. That introduces another overhead.

This patch introduces a wrapper on a FileStreamReader, which converts 32KB
chunk requests to 512KB chunk requests to the underlying file stream  reader.

As a result, the overhead of IPC and HTTP is decreased significantly.

TEST=unit_tests: *FileSystemProvider*BufferingFileStreamReader*
BUG=248427

Review URL: https://codereview.chromium.org/318563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390819

Review URL: https://codereview.chromium.org/377383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282289 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282288 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177731:177792&mode=html
TBR=yutak@chromium.org,junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/384503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282287 0039d316-1c4b-4281-b951-d872f2087c98

They are always "true" for now, due to the way BLE devices work under Windows 8.

BUG=388016

Review URL: https://codereview.chromium.org/378293007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282286 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338887

Review URL: https://codereview.chromium.org/370383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282285 0039d316-1c4b-4281-b951-d872f2087c98

Previously setClientSession was trying to call clientSession when it's
null.

BUG=392345

Review URL: https://codereview.chromium.org/380053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282284 0039d316-1c4b-4281-b951-d872f2087c98

This change depends on http://crrev.com/329853012 

The tests for this change will be added in the LayoutTests of Blink: http://crrev.com/373713004


BUG=373120

Review URL: https://codereview.chromium.org/373713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282283 0039d316-1c4b-4281-b951-d872f2087c98

Addresses are always non-NULL per spec. This merges a change that has already
been applied to the google-internal version of protobuf.

BUG=381910
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/379973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282282 0039d316-1c4b-4281-b951-d872f2087c98

Under-development Android versions do not have a numeric
version, so falls back to a "default version".

Using a real released Android version like 4.3.0 will
incorrectly trigger code paths, such has version-specific
gpu blacklists.

First attempt at fixing this was using 0.0.0, which caused
websites parsing Android version in the user agent to break.

So this is the second attempt, use the latest public major
version and minor version, and use a higher bug release
version to avoid conflicts with the gpu blacklist.

BUG=387179

Review URL: https://codereview.chromium.org/381813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282281 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional

This updates the relevant .patch and README files, combining these fixes with
the previous set of MSVC warning fixes.  This also removes the now-unused
vs2013-optimization.patch file.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/385503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282280 0039d316-1c4b-4281-b951-d872f2087c98

The CL removes the unused scaleControl proeprty in the view port class.

BUG=245926
TEST=None

Review URL: https://codereview.chromium.org/383583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282279 0039d316-1c4b-4281-b951-d872f2087c98

Partially implement OSExchangeDataProviderMac, just enough to get
OSExchangeDataTest and TextFieldTest.DragAndDrop* to pass.
The implementation is backed by NSPasteboard, and relies on the category
NSPasteboard(ChimeraPasteboardURLUtils) defined in third_party/mozilla.

BUG=378134

Review URL: https://codereview.chromium.org/368973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282277 0039d316-1c4b-4281-b951-d872f2087c98

See http://googleonlinesecurity.blogspot.com/2014/07/maintaining-digital-certificate-security.html

BUG=392251

Review URL: https://codereview.chromium.org/380033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282276 0039d316-1c4b-4281-b951-d872f2087c98

Based on review comments from https://codereview.chromium.org/337093003/

BUG=

Review URL: https://codereview.chromium.org/361083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282275 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/363563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282274 0039d316-1c4b-4281-b951-d872f2087c98

Changed registration API to work for one network at once.
Fixed comments.
Replaced argument GCDDevice with just string id.

BUG=383167
R=alexsemenov@chromium.org, asargent@chromium.org, asvitkine@chromium.org, noamsml@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282099

Review URL: https://codereview.chromium.org/363883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282273 0039d316-1c4b-4281-b951-d872f2087c98

Implementation of shared worker code path when WebView guest creates a shared worker to request file system access.

BUG=343382

Review URL: https://codereview.chromium.org/338353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381541

Review URL: https://codereview.chromium.org/360123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282271 0039d316-1c4b-4281-b951-d872f2087c98

This provides PrintTo(..) functions for the geometric types in ui/gfx/
so that failing gtest assertions pretty-print the values instead of
dumping the bytes of the objects. This way gtest assertions on these
types can be written in the form:

  EXPECT_EQ(a, b);

instead of
  EXPECT_EQ(a.ToString(), b.ToString());

which is currently used (inconsistently) to provide more readable
failure messages.

This is a bit tricky since gtest uses streams and somewhat complicated
template expansion magic to pretty print values and we don't want to
link the stream-based code into production code paths. This declares the
PrintTo() functions in the headers defining each of the geometry types,
using the <iosfwd> header to keep stream bloat to a minimum, and defines
the formatters in gfx_test_support. This way every test that
instantiates these printers has to declare a dependency on
gfx_test_support or it fails to link, but a test does not have to
#include any particular header to see the correct printer declaration
and thus expand the template correctly.

If we were to declare the PrintTo() functions in a test only header such
a gfx_util.h then the pretty printers would work reliably only if
*every* target in a translation unit that instantiated the comparison
saw this declaration. If some unit tests in a target #included the
header and some did not then it would be intederminate whether the
template instantiation linked in to the test binary was the pretty
printed one or the hex dump one (and in practice this appears to be
inconsistent across clang and gcc for whatever reason).

Review URL: https://codereview.chromium.org/368903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282270 0039d316-1c4b-4281-b951-d872f2087c98

MessagePopupCollection contains plenty size of conditions and ifdefs
to work properly with each type of the desktop we have, and some
logic makes side effects on another desktop. This design is unhealty
and adding more conditions sounds incorrect.

Considering this, it would be better to extract platform dependent
parts as a delegate class (PopupAlignmentDelegate) and allow
subclasses to provide platform-specific features.

This design is also beneficial for win-ash, because we had
OS_CHROMEOS layout data and logic which actually means Ash.

BUG=389656
R=stevenjb@chromium.org, dimich@chromium.org
TBR=jamescook@chromium.org, harrym@chromium.org
TEST=message_center_unittests, ash_unittests, some manual checks

Review URL: https://codereview.chromium.org/369573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282269 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282268 0039d316-1c4b-4281-b951-d872f2087c98

They started to fail since the switch to Clang on Linux.

BUG=392768
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/386543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282267 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Turn on clang by default on linux, 3rd try. (https://codereview.chromium.org/378363006/)

Reason for revert:
This change should not have been reverted, since
it was easy to just disable these tests. thakis
explicitly requested "please ping thakis before
reverting it".

Original issue's description:
> Revert of Turn on clang by default on linux, 3rd try. (https://codereview.chromium.org/379413002/)
> 
> Reason for revert:
> NaClBrowserTestNonSfiMode.Messaging and NaClBrowserTestNonSfiMode.Irt failed.
> 
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Irt
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Messaging
> 
> Original issue's description:
> > Turn on clang by default on linux, 3rd try.
> > 
> > This is mostly to collect performance and size data for now, and to find out
> > if more bots need work. Unless things look really good, I'm going to revert
> > this by thursday morning (PDT).
> > 
> > BUG=360311
> > TBR=ajwong@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282246
> 
> TBR=awong@chromium.org,thakis@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=360311
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282265

TBR=awong@chromium.org,thakis@chromium.org,horo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=360311

Review URL: https://codereview.chromium.org/382743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282266 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
NaClBrowserTestNonSfiMode.Messaging and NaClBrowserTestNonSfiMode.Irt failed.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Irt
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Messaging

Original issue's description:
> Turn on clang by default on linux, 3rd try.
> 
> This is mostly to collect performance and size data for now, and to find out
> if more bots need work. Unless things look really good, I'm going to revert
> this by thursday morning (PDT).
> 
> BUG=360311
> TBR=ajwong@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282246

TBR=awong@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=360311

Review URL: https://codereview.chromium.org/378363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360311
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/376403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282261 0039d316-1c4b-4281-b951-d872f2087c98

Match the NSS, CryptoAPI (Win) and Security (OS X) approaches by
declaring the scoped types as specializations of our existing scoped
classes.

Like NSS, this requires an intermediate helper type, because our
scoped_ptr<> doesn't accept deleter functions as template
arguments (though they are valid in C++11's unique_ptr<>). A few base
cryptographic (non-certificate) types are used in
scoped_openssl_types.h, while the remainder are left for
implementations to specialize as needed.

In an ideal world, this would be scoped_ptr<FOO, FOO_free>, but that
will require unique_ptr<> support.

BUG=388904

Review URL: https://codereview.chromium.org/361193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282257 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch

Defining UChar32 as a signed type may look wrong, but it's actually how the type
is already defined over in third_party/icu/.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/380913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282255 0039d316-1c4b-4281-b951-d872f2087c98

This change plumbs top level window resize notifications from X11 through to the WindowManager and to the GLSurface associated with the top level window. It's an incremental step towards adding support for window manager level layout management (see crbug.com/389785).


BUG=388524

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281955

Review URL: https://codereview.chromium.org/354933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282254 0039d316-1c4b-4281-b951-d872f2087c98

R=avd@chromium.org,rch@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/380543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282253 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/380863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282252 0039d316-1c4b-4281-b951-d872f2087c98

The downstream dependencies in Chrome for Android have been
updated to use org.chromium.base.FieldTrialList, so the old
code can be removed.

BUG=378035

Review URL: https://codereview.chromium.org/378403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282251 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes the deprecated ExtensionInstaller and uses
ExtensionInstallChecker in CrxInstaller and UnpackedInstaller.

BUG=386404
TEST=browser_tests
TBR=pam@chromium.org (for include in supervised_user_service_unittest.cc)

Review URL: https://codereview.chromium.org/381553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282250 0039d316-1c4b-4281-b951-d872f2087c98

We'll have a slightly modified test list.

BUG=382573
TEST=none

Review URL: https://codereview.chromium.org/379933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282249 0039d316-1c4b-4281-b951-d872f2087c98