GitLab

BUG=None
TEST=Panel minimize and restore tests.
Review URL: http://codereview.chromium.org/7977037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94007,70276
TEST=

Review URL: http://codereview.chromium.org/7811026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102392 0039d316-1c4b-4281-b951-d872f2087c98

This makes compositor_unittests compiles on Linux.

Although running it doesn't work yet because we return NULL in
TestCompositorHost::Create() and it expects something different than NULL.

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7996005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102391 0039d316-1c4b-4281-b951-d872f2087c98

Implement the EmbeddedTool class in valgrind_test.py to allow running tools that are embedded into binaries.
Merge tools/asan with tools/valgrind.

This CL depends on http://codereview.chromium.org/7926011/
Review URL: http://codereview.chromium.org/7922010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102390 0039d316-1c4b-4281-b951-d872f2087c98

 Child widget should not be parented to desktop.
 This was causing tab contents for prerendering be parented to desktop.
Fix for DCHECK failure in NativeWidgetViews::OnKeyEvent
 Child widget should not be activated.
Reset non_client_view_ when new contentview is set.

BUG=none
TEST=updated widget_unittests

Review URL: http://codereview.chromium.org/7979035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87300
TEST=Build official linux build

Review URL: http://codereview.chromium.org/7967015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102388 0039d316-1c4b-4281-b951-d872f2087c98

These two pyauto tests were disabled 3-4 months back.  They appear to
be working now.

BUG=87959,83459
TEST=None

Review URL: http://codereview.chromium.org/7994016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102387 0039d316-1c4b-4281-b951-d872f2087c98

R=krisr@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7973011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102378 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102372 0039d316-1c4b-4281-b951-d872f2087c98

Convert SHA256_LENGTH from a constant-in-anonymous-enum to a static const.  This defines the constant where it's declared to preserve the existing readability.

Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that.  Will be watching the trybots...

The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but in general naming enums used to declare constants like this is bizarre ("enum Constants { ... }"?).

BUG=92247
TEST=Compiles
Review URL: http://codereview.chromium.org/7823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102369 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102368 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7977031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102366 0039d316-1c4b-4281-b951-d872f2087c98

The separation between the view and the model in the NTP code for
viewing "recently closed tabs" when displayed in a smallish popup
menu should be more generic and available in the model, not just
in the view. 

BUG=
TEST=


Review URL: http://codereview.chromium.org/7931027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102365 0039d316-1c4b-4281-b951-d872f2087c98

This improves run time from ~3 minutes to ~2 minutes for me locally.

BUG=28291

Review URL: http://codereview.chromium.org/7974012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90489

Review URL: http://codereview.chromium.org/7980053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102362 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7974014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102360 0039d316-1c4b-4281-b951-d872f2087c98

2. Fix pango rendering of Arabic joining shapes. In Pango, different font means different runs, and it breaks arabic shaping across run boundaries. Do not reset font attribute if it is the same as default.

BUG=90426
TEST=RenderTextTest.MoveLeftRightByWord*. 
Build chromeos, open it with --use-pure-views, type in تسیک
then select the 2nd and 3rd characters, check whether the characters' shapes changes (from joining to not joining).
Review URL: http://codereview.chromium.org/7892044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102359 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org
BUG=90442
TEST=none

Review URL: http://codereview.chromium.org/8002003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102353 0039d316-1c4b-4281-b951-d872f2087c98

The uninstall prompt is owned by the settings page (the dialog's delegate), which gets destroyed when the user navigates to a new page. We need to make sure we invalidate pointers to the settings page when this occurs.

This adds an ExtensionUninstallDialog with platform specific implementations.

GTK: The settings page owns the ExtensionUninstallDialogGtk, which closes the GTK prompt when being destroyed.

VIEWS: The views framework is a bit more convoluted because views owns the prompt's views::View. We have two classes: ExtensionUninstallDialogDelegateView owned by views, and ExtensionUninstallDialogViews owned by the settings page. If the user accepts or denies the prompt, we proxy the events through ExtensionUninstallDialogViews so we can invalidate pointers back to the views widget. If the settings page is destroyed, the ExtensionUninstallDialogViews closes the views widget after invalidating pointers back to the settings page.

COCOA: You can't navigate away from the page when the prompt is open, so the dialog can't outlive its delegate.

BUG=75011
TEST=see bug.

Review URL: http://codereview.chromium.org/7920023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102351 0039d316-1c4b-4281-b951-d872f2087c98

The use of a protected virtual destructor is to prevent the destruction of a
derived object via a base-class pointer.

That's it, CompositorDelegate should only be deleted through derived class.

Example:

class Delegate {
 public:
  ...

 protected:
  virtual ~Delegate() {}
};

class Foo : public Delegate {
};

Delegate* delegate = new Foo;
delete delegate;  // It should prevent this situation!

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7974010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102350 0039d316-1c4b-4281-b951-d872f2087c98

Revert 102346 (already landed in 102342. It's a great CL, but having it in the tree once is enough.) - clang downloader: Clean up temporary files on the bots.

BUG=96722
TEST=none


Review URL: http://codereview.chromium.org/7994010

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/7970013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7926010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102348 0039d316-1c4b-4281-b951-d872f2087c98

Linux: try libgio-2.0.so.0 first and then libgio-2.0.so when trying to use gsettings for proxy settings.

Some distributions only have libgio-2.0.so.0, unless development packages are installed.

BUG=91744

Review URL: http://codereview.chromium.org/7982053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102347 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96722
TEST=none


Review URL: http://codereview.chromium.org/7994010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102346 0039d316-1c4b-4281-b951-d872f2087c98

I added accented character data for French layout to demonstrate how the data is used in this implementation.
I'll add the data of alternative characters for several symbols and the data for US layout in the later CLs.


BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7754019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102345 0039d316-1c4b-4281-b951-d872f2087c98

Two parts:
1.) Let the banned_directories_ require full directory matches, not
    just suffixes.
2.) Remove "clang" from banned_directories_. Now that mac builds just
    go into xcodebuild / out, it's no longer required.

Regressed in http://codereview.chromium.org/7824047

BUG=97452
TEST=Try jobs to linux_clang report style problems again.
tools/clang/plugin/tests/test.sh passes again.

Review URL: http://codereview.chromium.org/7980045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102344 0039d316-1c4b-4281-b951-d872f2087c98

Locally, a full build is 50% faster with this.

BUG=none
TEST=mac trybot build time should go down at least 7 minutes.

Review URL: http://codereview.chromium.org/7994008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96722
TEST=none

Review URL: http://codereview.chromium.org/7994010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102342 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rsleevi@chromium.org
BUG=96300
TEST=none

Review URL: http://codereview.chromium.org/7969018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compiles.

Review URL: http://codereview.chromium.org/7982032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102337 0039d316-1c4b-4281-b951-d872f2087c98

Remove webkit_glue::BuildUserAgent(), change the contract in webkit_glue so that SetUserAgent() must be called before GetUserAgent().

This was causing a dependency inversion between webkit_support and its clients, and was needed for the content component build.

For content users, calling SetContentClient() will automatically initialize the user agent (retrieved from client->GetUserAgent()).

As a bonus, fixing this allowed me to re-test the "mimic_windows" code path and it looks like we no longer need it.

R=jam@chromium.org,tony@chromium.org
BUG=11136,90442
TEST=visit yahoo! mail using Chromium on Linux, ensure that we don't get an "unsupported browser" warning.

Review URL: http://codereview.chromium.org/7922023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97131
TEST=views_unittests

Review URL: http://codereview.chromium.org/7996008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102335 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org
BUG=90442

TEST=

Review URL: http://codereview.chromium.org/7967013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102334 0039d316-1c4b-4281-b951-d872f2087c98

content.

R=jam@chromium.org,crogers@google.com,allanwoj@chromium.org
BUG=90442
TEST=none

Review URL: http://codereview.chromium.org/7981049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102332 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/7925006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102330 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org

Review URL: http://codereview.chromium.org/7994009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102329 0039d316-1c4b-4281-b951-d872f2087c98

substitution in the resource_ids file correctly when it is invoked by
ninja (which uses a relative path for this, whereas our gyp-generated
make files use an absolute path).

BUG=97420
TEST=this builds: ninja -C out/Debug chrome_extra_resources

Review URL: http://codereview.chromium.org/7995013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102327 0039d316-1c4b-4281-b951-d872f2087c98

Changed Panel.xib to add icon in NSView type.

BUG=none
TEST=manul test to verify it exists

Review URL: http://codereview.chromium.org/7981035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102326 0039d316-1c4b-4281-b951-d872f2087c98

Revert 102322 - For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". (This isn't possible by simply naming the enum as technically the enum doesn't define all of the possible combinations of bits.) This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too.

I also added CERT_STATUS_NO_ERROR in place of "0" as a magic number.

Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots...

The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph.

BUG=92247
TEST=Compiles
Review URL: http://codereview.chromium.org/7819009

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7995014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102325 0039d316-1c4b-4281-b951-d872f2087c98

For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". (This isn't possible by simply naming the enum as technically the enum doesn't define all of the possible combinations of bits.) This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too.

I also added CERT_STATUS_NO_ERROR in place of "0" as a magic number.

Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots...

The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph.

BUG=92247
TEST=Compiles
Review URL: http://codereview.chromium.org/7819009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102322 0039d316-1c4b-4281-b951-d872f2087c98