- 03 Sep, 2018 40 commits
-
-
Bernhard Bauer authored
Every single instance already does that anyway. Also, bind all set properties on the model when the PropertyModelChangeProcessor is constructed, like LazyConstructionPropertyModel does. Change-Id: I5b9b440e5dbcb26fd19ccdea5f8738fed098b4dd Reviewed-on: https://chromium-review.googlesource.com/1199483 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#588392}
-
Bernhard Bauer authored
LazyConstructionPropertyMcp supports asynchronous view inflation and batches updates while the view is hidden. It replaces LazyViewBinderAdapter. Bug: 847420 Change-Id: I3c7d057bf342c674b08e0fee657eb67c345485de Reviewed-on: https://chromium-review.googlesource.com/1142155 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588391}
-
Tanja Gornak authored
This CL implements following logic: * Receive message from the FCM channel. * Extract data from the message. * Pass parsed message to the Listener. * Convert parsed message to the invalidation. The message receiving logic should gracefully handle these two important corner cases. (1) Subscription race. The client sends registration request for the topic T1. But before response arrives invalidation for the topic T1 arrives. Such invalidations shouldn't be dropped. (2) Unsubscription race. Client send unsubscription request for topic T1. The invalidations for the topic T1 should be immediately dropped. Bug: 879571, 801985 Change-Id: I79fa620122b9df54203c27f09dd2569bdcdb4c30 Reviewed-on: https://chromium-review.googlesource.com/1193884 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#588390}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3611afc1c118..88c1a9ecbc52 git log 3611afc1c118..88c1a9ecbc52 --date=short --no-merges --format='%ad %ae %s' 2018-09-03 srte@webrtc.org Adds infinite addition and subtraction to time units. 2018-09-03 nisse@webrtc.org Reland "Delete leftover includes and declarations for MediaConstraintsInterface" 2018-09-03 nisse@webrtc.org Reland "Refactor TestAudioDeviceModule to not depend on EventTimerWrapper." 2018-09-03 srte@webrtc.org Adds check for unused field trial parameters. 2018-09-03 jonasolsson@webrtc.org Add a StringBuilder class. Created with: gclient setdep -r src/third_party/webrtc@88c1a9ecbc52 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I29d71a248925dccf2d5b6f777d3837704e3856ca Reviewed-on: https://chromium-review.googlesource.com/1201670Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588389}
-
Denis Kuznetsov authored
Bug: 676195 Change-Id: I75ba73a7ee75d446c8d5b79d8f4c45aed569940d Reviewed-on: https://chromium-review.googlesource.com/1201855Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#588388}
-
Ulan Degenbaev authored
The motivation for this change is to make the paths to heap space nodes static so that they can be plumbed into UMA/UKM reporting. This groups the nodes by the isolate type and turns the dynamic "isolate_0x*" into leaf nodes in the tree. V8 memory dump before: - V8 - isolate_0x1234 - heap_spaces - code_space ... - isolate_0x5678 ... - isolate_0x9012 V8 memory dump after: - V8 - main - heap - code_space ... - workers - heap - code_space - isolate_0x5678 - isolate_0x9012 ... In this example, "isolate_0x1234" is the main isolate, so it is removed. The other isolate nodes are for workers, so they are made into leaf nodes. Besides that there are other minor changes: - "heap_spaces" is renamed to "heap". - the V8 code stats are reported under "code_stats" node. Bug: chromium:852415 Change-Id: I6e4c6e6fddb6e8cf9be3fe6d5fca837ac6fbdc34 Reviewed-on: https://chromium-review.googlesource.com/1181263 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#588387}
-
Sergey Poromov authored
New API is BrowserPolicyConnectorChromeOS::GetEnterpriseMarketSegment() that returns one of: UNKNOWN, EDUCATION, ENTERPRISE. Bug: 846067 Test: Browser test added Change-Id: Id3d9744985ed0b93dcb5aecbfe7b0163009dba3d Reviewed-on: https://chromium-review.googlesource.com/1199345 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#588386}
-
Gemene Narcis authored
This CL move the class that removes blacklisted credentials that are duplicates in separate files and create stronger unittests for that class. Bug: 862930 Change-Id: Ia07004779bc66d01a3268f7fc4d2779beabb89a2 Reviewed-on: https://chromium-review.googlesource.com/1199385 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588385}
-
Ramin Halavati authored
On ChromeOS, user profile is used to store flags. If the current profile is incognito, this CL bypasses that to the original profile and stores directly to that. As users are notified that a relaunch is required to apply the flags, this does not change any behavior. Bug: 861722 Change-Id: I4248c98b459d7828a5ccd46ad90c18955ac8c342 Reviewed-on: https://chromium-review.googlesource.com/1198746Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#588384}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: I38696ce73cf0ab206997401a8a88c182b319be5c Reviewed-on: https://chromium-review.googlesource.com/1190244 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#588383}
-
Matthew Cary authored
Bug: 880043 Change-Id: I9fb59352cd8054665a81efffc7ae6e574033a94b TBR: vakh@chromium.org,carlosil@chromium.org Change-Id: I9fb59352cd8054665a81efffc7ae6e574033a94b Reviewed-on: https://chromium-review.googlesource.com/1202062Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#588382}
-
Alexandr Ilin authored
This CL removes obsolete prefs that were kept for one year for migration. The list of prefs being removed: * user_experience_metrics.stability.current_foreground_activity_type * user_experience_metrics.stability.launched_activity_flags * user_experience_metrics.stability.launched_activity_counts * user_experience_metrics.stability.crashed_activity_counts Change-Id: I623ed26609ada80dd60c85536fd5b789baadc8b0 Reviewed-on: https://chromium-review.googlesource.com/1202022Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#588381}
-
Guido Urdaneta authored
This constrainable property is nonstandard, only supported with the deprecated syntax, and rarely used. This change does not remove the property from the Web, but disables its effects and prints a console message instead, similar to other similar properties. Drive-by: minor lint fixes. Bug: 880032 Change-Id: I197428ca76594389193351f8a9ea55b11d2419e5 Reviewed-on: https://chromium-review.googlesource.com/1201861Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#588380}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f53025e8bf1..09a7bb222172 git log 2f53025e8bf1..09a7bb222172 --date=short --no-merges --format='%ad %ae %s' 2018-09-03 csmartdalton@google.com Reland "ccpr: Implement stroking with fine triangle strips" Created with: gclient setdep -r src/third_party/skia@09a7bb222172 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ib7d9a1eef9997979aaeb39164649b906c6bfe756 Reviewed-on: https://chromium-review.googlesource.com/1201668Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588379}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ed774e45. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24015 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ife1b2101d828db03cdd557df7d53f82b03727c70 Reviewed-on: https://chromium-review.googlesource.com/1201904 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588378}
-
jdoerrie authored
TBR=btolsch Bug: 880045 Change-Id: I5ab168f982bc7e4c1eca62d8e2ce2da41116549f Reviewed-on: https://chromium-review.googlesource.com/1202102Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588377}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/689b5874d4fb..3611afc1c118 git log 689b5874d4fb..3611afc1c118 --date=short --no-merges --format='%ad %ae %s' 2018-09-03 phoglund@webrtc.org Roll chromium_revision bbc67a1b..4d01f290 (587546:588344) 2018-09-03 mbonadei@webrtc.org Remove clang:find_bad_constructs suppression from modules/video_capture. 2018-09-03 nisse@webrtc.org Allow send bitrate < start bitrate in RampUpTest. Created with: gclient setdep -r src/third_party/webrtc@3611afc1c118 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I93de1fdfc5875f0cda48eaeefcfbac64bd47fee2 Reviewed-on: https://chromium-review.googlesource.com/1201669Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588376}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7f82b8491f3faeb782cebd4d9b88b2b3a0246711 Reviewed-on: https://chromium-review.googlesource.com/1199664 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#588375}
-
Olga Sharonova authored
To make bots to run the audio service in a utility process, launched on startup. This will result in expected performance regressions in media tests (see the bug). Bug: 870171 Change-Id: Id301763a6117d0b4a4d26809d74032c4c188c1e2 Reviewed-on: https://chromium-review.googlesource.com/1199185Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#588374}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/246eeff7e1d8..227095125570 git log 246eeff7e1d8..227095125570 --date=short --no-merges --format='%ad %ae %s' 2018-09-03 dgarrett@google.com firmware_stages: Run pushimage against board firmware artifacts. 2018-09-03 dgarrett@google.com manifest_versions: Add buildspec creation helpers. Created with: gclient setdep -r src/third_party/chromite@227095125570 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I38351b76ef7e85aa43fbd0f7336e75c65396bd0f Reviewed-on: https://chromium-review.googlesource.com/1201667Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588373}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f18b35284288..689b5874d4fb git log f18b35284288..689b5874d4fb --date=short --no-merges --format='%ad %ae %s' 2018-09-03 nisse@webrtc.org Use monotonic clock for PhysicalSocketServer timeouts. 2018-09-01 phoglund@webrtc.org Roll chromium_revision c1d47013..bbc67a1b (585833:587546) 2018-09-01 phoglund@webrtc.org Remove MSVC debug bots from CQ. 2018-08-31 julien.isorce@chromium.org ScreenCapturerMac: destroy the streams and remove the DisplayStreamManager 2018-08-31 steveanton@webrtc.org Use AsyncInvoker in DtmfSender instead of MessageHandler 2018-08-31 steveanton@webrtc.org Use AsyncInvoker in DataChannel instead of MessageHandler 2018-08-31 steveanton@webrtc.org Use AsyncInvoker in JsepTransportController instead of MessageHandler 2018-08-31 steveanton@webrtc.org Use AsyncInvoker in PeerConnection instead of MessageHandler 2018-08-31 srte@webrtc.org Removes redundant starting rate. 2018-08-31 devicentepena@webrtc.org AEC3: option for using the stationarity estimator at render from the beginning of the call 2018-08-31 danilchap@webrtc.org Uninline non-trivial AudioOptions functions 2018-08-31 danilchap@webrtc.org Implement periodic cancelable task for task queue 2018-08-31 phoglund@webrtc.org Bump xcode versions for WebRTC bots. 2018-08-31 alessiob@webrtc.org Moving LappedTransform, Blocker and AudioRingBuffer. 2018-08-31 danilchap@webrtc.org Cleanup RtpPacketizerVP8 tests 2018-08-31 nisse@webrtc.org Reland "Add spatial index to EncodedImage." 2018-08-31 peah@webrtc.org AEC3: Parametrize the shadow filter output usage 2018-08-31 qingsi@google.com Add the multicast DNS message format. 2018-08-30 alessiob@webrtc.org Removing the intelligibility enhancer. 2018-08-30 wfh@chromium.org Add no_size_t_to_int_warning suppression to webrtc. 2018-08-30 brandtr@webrtc.org Revert "Reland "Optimize execution time of RTPSender::UpdateDelayStatistics"" 2018-08-30 terelius@webrtc.org Reland "Optimize execution time of RTPSender::UpdateDelayStatistics" 2018-08-30 srte@webrtc.org Adds TaskQueue congestion controller tests in VideoSendStreamTest. 2018-08-30 srte@webrtc.org Adds support for frame rate control in FrameGeneratorCapturer. 2018-08-30 srte@webrtc.org Fixes breaking bug in feedback based GoogCC. 2018-08-30 phoglund@webrtc.org Roll chromium_revision 33a17747..c1d47013 (585798:585833) 2018-08-30 nisse@webrtc.org Revert "Refactor TestAudioDeviceModule to not depend on EventTimerWrapper." 2018-08-30 nisse@webrtc.org Use a lock to protect members accessed by RtpVideoStreamReceiver::GetSyncInfo() 2018-08-30 nisse@webrtc.org Delete StreamStatistician::IsRetransmitOfOldPacket 2018-08-30 andersc@webrtc.org Obj-C SDK Cleanup 2018-08-30 nisse@webrtc.org Refactor TestAudioDeviceModule to not depend on EventTimerWrapper. 2018-08-30 danilchap@webrtc.org Cleanup RtpPacketizerVp8 2018-08-30 phoglund@webrtc.org Roll chromium_revision ca3a5e1c..33a17747 (585726:585798) 2018-08-30 benwright@webrtc.org Injects FrameEncryptorInterface into RtpSender. 2018-08-29 benwright@webrtc.org This change integrates the FrameEncryptorInterface and the 2018-08-29 ssilkin@webrtc.org Move VP9 frame rate controller to separate class. 2018-08-29 nisse@webrtc.org Revert "Add spatial index to EncodedImage." 2018-08-29 nisse@webrtc.org Add spatial index to EncodedImage. 2018-08-29 devicentepena@webrtc.org AEC3: Adding a reset of the ERLE estimator after going out from the initial state. 2018-08-29 mbonadei@webrtc.org Remove clang:find_bad_constructs suppression from call:call. 2018-08-29 titovartem@webrtc.org Remove deprecated ctors of DirectTransport and its subclasses and FakeNetworkPipe 2018-08-29 valeriian@webrtc.org Adding CustomAudioAnalyzer interface in APM. 2018-08-29 devicentepena@webrtc.org AEC3: Reset the ERLE estimation after a delay change 2018-08-29 sakal@webrtc.org Use generic video header frame ID as picture ID. 2018-08-29 kthelgason@webrtc.org Add config option to run VideoCodecTest in real time. 2018-08-29 kthelgason@webrtc.org Export constants from RTCAudioSessionConfiguration. 2018-08-29 titovartem@webrtc.org Add support of overriding network simulation in video quality tests. 2018-08-29 kthelgason@webrtc.org Remove kVideoCodecUnknown completely. 2018-08-29 danilchap@webrtc.org Cleanup RtpPacketizer interface 2018-08-29 henrika@webrtc.org Increases max size of webrtc::AudioFrame from 60ms to 120ms @32kHz. Created with: gclient setdep -r src/third_party/webrtc@689b5874d4fb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:851883,chromium:None,chromium:None,chromium:None,chromium:None,chromium:879451,chromium:588506,chromium:None,chromium:878319,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie676e811ca23db391939ff0facf56f6aa46abbcd Reviewed-on: https://chromium-review.googlesource.com/1201666Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588372}
-
Maksim Sisov authored
The concept is pretty simple here - instead of using many map structures, just use a single Buffer structure, which will keep all the neccessary data we need to create/swap/destroy buffers/wl_buffers. In other words, the Buffer is both representation of dmabuf on the GPU side and the wl_buffer on the browser side. And it has a direct association between the |widget| and the dmabuf. Note that different Buffers can have the same widget they are attached/ being attached/were attached to. tl:dr; The Buffer structure holds all the necessary data to create native wl_buffers now. That is, it holds zwp linux params variable, which is used for creation of wl_buffers and asynchronous mapping between the Buffer and the wl_buffer on CreateSucceeded calls. Also, the Buffer holds associated widget and a buffer_id, which is to find and attach a wl_buffer to a wl_surface requested by the GPU process. In the future, the Buffer is going to keep a gpu callback, which will hold a swap result and a presentation feedback of the swap request. There is no functionality change, but I'm just rather improving the code. Bug: 859012, 820047 Change-Id: I7812d10e0a9e7fb472298231a191dfa09701bd2a Reviewed-on: https://chromium-review.googlesource.com/1193447 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#588371}
-
Mohamed Amir Yosef authored
All the work should have been done already in BookmarkModelTypeProcessor::ModelReadyToSync() which has been called right before firing the BookmarkModelLoaded() event in BookmarkModel::DoneLoading(). Bug: 516866 Change-Id: I41baab58e09c98f73a0eb782efed382ba2ee94c3 Reviewed-on: https://chromium-review.googlesource.com/1196556 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#588370}
-
Mohamed Amir Yosef authored
This CL implements BookmarkModelTypeProcessor::GetAllNodesForDebugging(). In addition it fixes EntityData::ToDictionaryValue() because it's broken today and the modification time is not properly shown in chrome://sync-internals/ for data types migrated to USS. Bug: 516866 Change-Id: I59400e1d19902c86179a20bee46583607938db54 Reviewed-on: https://chromium-review.googlesource.com/1196370 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#588369}
-
Philipp Hancke authored
see https://github.com/w3c/webrtc-stats/issues/301 IDL: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats BUG=webrtc:9674 Change-Id: I6bf2de6a6c7fb1e28424cc3d24219477f8af02e5 Reviewed-on: https://chromium-review.googlesource.com/1196377 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#588368}
-
Jan Wilken Dörrie authored
This reverts commit 8817f77a. Reason for revert: Flaky on Mac (https://crbug.com/879812). Original change's description: > Update BrowsingDataRemoverBrowserTest to include MediaLicenses > > MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the > BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only > External Clear Key CDM to store the license in the file system, if it is > available. > > BUG=843995,808690 > TEST=new browser_tests pass > > Change-Id: Ib4019e6357f04ec6005cfda039ab81c06ab022b5 > Reviewed-on: https://chromium-review.googlesource.com/1170175 > Commit-Queue: John Rummell <jrummell@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588090} TBR=xhwang@chromium.org,jrummell@chromium.org,msramek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843995, 808690 Change-Id: I9eefaabb06b959e5f4abbbc92c73777bf3951b14 Reviewed-on: https://chromium-review.googlesource.com/1201851Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588367}
-
Denis Kuznetsov authored
Bug: 854101 Change-Id: Ideef55c0e73fcf02096cd50f86a6f320f48651f1 Reviewed-on: https://chromium-review.googlesource.com/1190242 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#588366}
-
Oscar Johansson authored
//storage/browser takes around 6.2 CPU minutes to build without jumbo. With jumbo the build time is reduced by around 83 %. This commit enables jumbo support in storage/browser. Bug: 871163 Change-Id: I51254087ea584d64fc599aa232ab2b73027791ec Reviewed-on: https://chromium-review.googlesource.com/1170691Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#588365}
-
Mike West authored
Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/35t5cJQ3J_Q/FH45dl0vAwAJ Bug: 794548, 879994 Change-Id: Ie87aedd0027921960ff429d5d8ecf168572c82de Reviewed-on: https://chromium-review.googlesource.com/1199068 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#588364}
-
jdoerrie authored
TBR=yosin@chromium.org Bug: 698165 Change-Id: Id60c22d2729cedf72297700bb2a82d45f3b48029 Reviewed-on: https://chromium-review.googlesource.com/1201852 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588363}
-
Mythri Alle authored
Earlier, the cached code was fetch along with the HttpResonse. With IsolatedCodeCache feature, the code cache is decoupled from HttpCache and cached code has to be fetched explicitly. This cl changes ResourceLoader to also request for cached code. ResourceLoader would wait for response both from HttpCache and CodeCache before it send response data to the resource. Bug: chromium:812168 Change-Id: I845e867fa452f270b787bedfd70105bda254ffdc Reviewed-on: https://chromium-review.googlesource.com/1154980 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#588362}
-
Rayan Kanso authored
Bug: 863939 Change-Id: I54735be657f2b8841de09c0e67738cd1ded1bcf7 Reviewed-on: https://chromium-review.googlesource.com/1194077Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#588361}
-
Yoichi Osato authored
We have TraversalInclusiveAncestorsIterator and TraversalAncestorsIterator for NodeTraversal and FlatTreeTraversal. However only difference between them is if it starts from node or its parent. It doesn't relate how traverse. Therefore, |TraversalInclusiveAncestorsIterator(node) === TraversalAncestorsIterator(parent(node))|. Then this patch unifies them. Change-Id: I7c37a23ecc3913433880fa3d83292cac475aea5e Reviewed-on: https://chromium-review.googlesource.com/1201703Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#588360}
-
Mihai Sardarescu authored
This CL allows users to be included in the Unified Consent experiment, regardless of their Desktop Identity Consistency state. Screenshots: https://drive.google.com/file/d/1B-rkxD3kPtdBw5toDYJGE-SWuO7PQULL/view?usp=sharing https://drive.google.com/file/d/1W8elDHLNBLJ5rK8QpX1K0xocgoTNpTI6/view?usp=sharing https://drive.google.com/file/d/1Abi8z1FPONLsuaErVgwkfFJdkeHT3o2c/view?usp=sharing Bug: 873064 Change-Id: I27674fe5e6826aba605bbb9b3b4edb3938dc036f Reviewed-on: https://chromium-review.googlesource.com/1169814 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#588359}
-
Erik Språng authored
Bug: chromium:853185 Change-Id: I5e0a76e83318d7761d9d010b0083abc048f563e4 Reviewed-on: https://chromium-review.googlesource.com/1183665 Commit-Queue: Erik Språng <sprang@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#588358}
-
Jan Wilken Dörrie authored
This reverts commit 9ce49488. Reason for revert: Likely culprit of https://crbug.com/879995. Original change's description: > a11y: hide the rest of the browser when a tab-modal dialog is present > > When a tab-modal dialog is shown, the page underneath it is inert. But > NVDA reads the page underneath the dialog when users press Insert+B to > read the whole dialog. To fix this, we hide the rest of the browser > from the accessibility tree when a tab-modal dialog is visible by > modifying AXPlatformNodeDelegate::PopulateChildWidgetVector to return > only the dialog. > > Bug: 775680 > Change-Id: I2a5ec2eeef5ffe50ebd8819836c89ae73ddfdd36 > Reviewed-on: https://chromium-review.googlesource.com/1189054 > Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588142} TBR=dmazzoni@chromium.org,sky@chromium.org,jamwalla@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 775680 Change-Id: I44b9322799880ee613a6380f8ead0c3d86e21549 Reviewed-on: https://chromium-review.googlesource.com/1201824Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588357}
-
Marina Ciocea authored
Bug: 850878 Change-Id: I215d84b4e3c8234ba8e318fd27ecb22739f950d3 Reviewed-on: https://chromium-review.googlesource.com/1201842Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#588356}
-
jdoerrie authored
TBR=gab@chromium.org Bug: 879984 Change-Id: I994de9e8f5f9ac51fde51e7376b399d271f53181 Reviewed-on: https://chromium-review.googlesource.com/1201849Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588355}
-
calamity authored
This reverts commit 45ed2663. Reason for revert: getsubstringlength-emoji-ligatures.html is failing on Webkit Win10 starting at https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/40081 Original change's description: > Distribute widths evenly among code points in SynthesizeGraphemeWidths > > Previously we did not consider the possibility of a typographic unit > containing multiple surrogate pairs, and could as an effect "lose" part > of the width. > > Distribute the width evenly among code points instead to at least get > some sort of consistency. > > Bug: 879361 > Change-Id: I51a4e6c574926215a087b0bc824ac90d580ff169 > Reviewed-on: https://chromium-review.googlesource.com/1199423 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#588183} TBR=pdr@chromium.org,fs@opera.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879361 Change-Id: I2c73e397bcfb9d458e4bf29f022cc95ac53ed5c0 Reviewed-on: https://chromium-review.googlesource.com/1201628Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#588354}
-
Joel Hockey authored
This function will be called from FilesApp when a user shares a folder with the crostini container by doing either 'Share with Linux' on a folder, or by opening a file with a crostini app. This function calls through to seneschal/9p file server to mount the specified folder into the linux container. Bug: 878324 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I13199ce69679b31fc29cca38ce245e72eb2a1ca6 Reviewed-on: https://chromium-review.googlesource.com/1193624 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#588353}
-