GitLab

For ResourceLoadScheduler experiment, we plan to add more aggressively
targeted variants of PageLoad.Clients.MultiTabLoading.* metrics that
will only be logged if there are more than X loading tabs.

This will give us the distribution of number of loading tabs, and will
help us determine the threshold of the targeted metrics.

Bug: 792759
Change-Id: I8aefd59f52cefd4c1e449795cfdace4fc44fdf98
Reviewed-on: https://chromium-review.googlesource.com/807866
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522329}

https://chromium.googlesource.com/angle/angle.git/+log/43fd0d44d2a6..030017a4855c

$ git log 43fd0d44d..030017a48 --date=short --no-merges --format='%ad %ae %s'
2017-12-06 kainino Mark StaticType related functions as constexpr

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I6c652e1bfd589baf3fa99824cf976994e43e0a8b
Reviewed-on: https://chromium-review.googlesource.com/813176Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522328}

Some observers can have code that computes policy in an expensive way.

Bug: 792524
Change-Id: I4787f295e946efe889528a0a7df19421791856f4
Reviewed-on: https://chromium-review.googlesource.com/811367
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522327}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ee13fe4b..5ce45836

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Icd31f3446c5ddde57f7719bc73bb22e13028372b
Reviewed-on: https://chromium-review.googlesource.com/812215Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522326}

https://skia.googlesource.com/skia.git/+log/409506c4c978..5031e5f8b77f

$ git log 409506c4c..5031e5f8b --date=short --no-merges --format='%ad %ae %s'
2017-12-07 angle-deps-roller Roll skia/third_party/externals/angle2/ 43fd0d44d..030017a48 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: I51ca44960d6bf5517cc1e6828bae8751410031f5
Reviewed-on: https://chromium-review.googlesource.com/813194Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522325}

Something that significant should trigger compiles and tests.

Bug: 792130
Change-Id: Ia6c467f97e54ac4b8e8b6c6bc8ab00ff4a9acd65
Reviewed-on: https://chromium-review.googlesource.com/812503Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522324}

This CL deletes viz::FrameSinkManagerClient. FrameSinkManagerImpl has a
pointer to each CompositorFrameSinkSupport directly now since this is
needed anyways. The FrameSinkManagerImpl::clients_ map is removed as a
result.

SinkAndSupport will always contain a CompositorFrameSinkSupport* while
the CompositorFrameSinkSupport object exists. SinkAndSupport::sink will
be non-null when FrameSinkManagerImpl owns the compositor frame sink.

CompositorFrameSinkSupport::Init()/Create() are also no longer needed
since SetBeginFrameSource() is no longer virtual. Remove Init() and make
the constructor public. Create() is left since it's widely used for now
but is marked deprecated.

Also remove some old/wrong forward definitions and fix some style guide
violations.

Bug: 792192
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I14f9662c9db485ce18edf1d358493648997d3648
Reviewed-on: https://chromium-review.googlesource.com/810866Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522323}

Anonymous IO surfaces that are only used on the gpu service as render
targets don't need to be cleared on initialization. vmiura@ found that
this quadruples the cost of binding the io surface and that this cost is
deferred to the flush.

R=piman
BUG=781586

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If7d0425a57fec4772f05daaf04dee9aaee0c730f
Reviewed-on: https://chromium-review.googlesource.com/804597
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522322}

https://webrtc.googlesource.com/src.git/+log/cc65bd018d54..40f0b37d3b9a

$ git log cc65bd018..40f0b37d3 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If518287f5bad040339c3f43276f92653d4ed6d6c
Reviewed-on: https://chromium-review.googlesource.com/812981Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522321}

Moved to CastBrowserMainParts, per the bug.

Bug: internal b/27811461
Test: none
Change-Id: Ic3fd8f7ed51473e8a61caff62c5caa762af03b84
Reviewed-on: https://chromium-review.googlesource.com/811286Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522320}

Currently https scheme will not be highlighted if toolbar uses brand
color. However, security icon does not apply the same rule which makes
them inconsistent when there is a brand color. This CL updates the
security icon to use the same rule for highlight as https scheme.

Bug: 646676
Change-Id: I2d974eaf6c6f9ca36e39a78c2a6a43c6a8e07489
Reviewed-on: https://chromium-review.googlesource.com/807327Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Lei Tian <ltian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522319}

These were added in r522197 (from r522122) and are failing.

Bug: 777879
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia969cea09329d027b88d6eacbd3c50f322bbe52e
NOTRY: true
TBR: kinuko
Reviewed-on: https://chromium-review.googlesource.com/812586
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522318}

This change puts a prompt string into the omnibox whenever the field is
empty.  Once a character is entered, or when the field later becomes
empty, the hint is shown.

BUG=
R=bshe
TBR=cpu@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib05f091fb339a4c06d83a0502e1d0d1b51b0d277
Reviewed-on: https://chromium-review.googlesource.com/812208Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522317}

TBR=olivierrobin@chromium.org,jwd@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I82ddd62efc5a9911b7454359c1b39eb118e40e84
Reviewed-on: https://chromium-review.googlesource.com/807641Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522316}

Holding a weak reference to activities is the preferred approach
in a lot of client code, so making this support null seems OK
to me.  I think it would be fine to update each client as well...
don't have a strong preference.

The gotcha (which I wasn't aware of) is that ConcurrentHashMap
does not handle null keys/calls of get(<key>).

BUG=792377

Change-Id: I34549aecf68c04f6140bbc4eaaa3405409347cba
Reviewed-on: https://chromium-review.googlesource.com/811431Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522315}

crrev.com/517091 switched the backup settings sync path from ArcIntentHelper
to a new special apk. This CL cleans up the legacy ArcIntentHelper path now.

BUG=783567
TEST=Manual: (un)tick backup in ARC optin and confirm it in Android settings

Change-Id: I77c123cc4be1e310303cad329249162e2ecd900b
Reviewed-on: https://chromium-review.googlesource.com/807487
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522314}

Previously, there was a 30s timeout to wait for memory dump providers to emit
data, and for the profiling service to emit a memory dump. Now, we wait 10s for
memory dump providers to emit data, and then upload as soon as the heap dump is
added.

Bug: 
Change-Id: I18a334fd59a30fc6021cf8f4e343a19907abc546
Reviewed-on: https://chromium-review.googlesource.com/810052
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522313}

Change-Id: Ie3b80db7f3b8f1048002f76d5ada29bce74e193d
Reviewed-on: https://chromium-review.googlesource.com/790041Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522312}

These were added in r522067 and are failing.

Bug: 792776
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I512e7a63765f9a8911d7271a9458aa699e902eaa
NOTRY: true
TBR: jam
Reviewed-on: https://chromium-review.googlesource.com/813315Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522311}

BUG=584597
R=thestig@chromium.org

Change-Id: Ie131b7eb5f994fef3a0808992ec02fa8aa6beed7
Reviewed-on: https://chromium-review.googlesource.com/803738Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522310}

EXPECT_TRUE(ptr); ptr->Dereference(); is a bad idea.
Also remove old TODOs and switch to raw string literals.

Change-Id: I50fdf7bce646c1099a7538d655c87fa6032eff17
Reviewed-on: https://chromium-review.googlesource.com/810041
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522309}

Bug: 761419
Change-Id: I1a789861540ae8be495bca4e67b42fa132c1a1fe
Reviewed-on: https://chromium-review.googlesource.com/812212Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522308}

If the time difference is small, then we probably opened an app window
in response to a client side redirect and left the tab opened. This
will let us know how common this problem is.

Bug: 785661
Change-Id: Icc5a015cd5c0ae9fda5ad457ad564ead4b812332
Reviewed-on: https://chromium-review.googlesource.com/798951
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522307}

NotificationDelegate has a method DisableNotification, which blocks
notifications from the same origin.
Currently, this method is only used by NotificationMenuModel, which is
right click menu of the notification.
This will also be used by inline settings.

To call the delegate method, NotificationMenuModel currently stores
the reference to the Notification instance.
The view should neither have the Notification reference nor call the
NotificationDelegate directly.

This CL adds MessageCenter::DisableNotification and corresponding
delegate methods to resolve this.

TEST=manual
BUG=782533

Change-Id: I0688a00cf3e7fbdda23e74a885a455109811763c
Reviewed-on: https://chromium-review.googlesource.com/795413Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522306}

https://pdfium.googlesource.com/pdfium.git/+log/11506300e6a6..7b0be4ced5f3

$ git log 11506300e..7b0be4ced --date=short --no-merges --format='%ad %ae %s'
2017-12-06 brucedawson Move m_CharCodes to local for crash investigation

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I96c5ea75c5911e8061ad9cf3d773305c6856c266
Reviewed-on: https://chromium-review.googlesource.com/812978
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522305}

This adds the ability for trace.py to request compression of traces,
giving us much more headroom in /tmp. Compressed traces are about 1/10th
the size of uncompressed traces.

Compressed traces have to be base64 decoded when read from the websocket,
since those have a bizarre requirement that the payload be valid utf-8.

BUG=791708

Change-Id: I22f0c4aa70e22d9a33e3f2d3dd9a2180df33a815
Reviewed-on: https://chromium-review.googlesource.com/812012Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522304}

Initializing stores (through constructors) can assume that objects are
not yet marked and thus don't require write barriers.

This CL breaks placement new for Member which can violate the assumption
that the enclosing object is white. A follow up will fix this.

Bug: chromium:757440, chromium:790691
Change-Id: Id0ef91ba1887837593603eaf73f56a127f8fda0a
Reviewed-on: https://chromium-review.googlesource.com/812344
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522303}

Calling cancel() seems not neccessary when WebView first starts.
this could break the exsiting autofill session when WebView is
only for ads.

Bug: 791182
Change-Id: I7feb37f930ba1eedcab6cbeb50645d4128656fe8
Reviewed-on: https://chromium-review.googlesource.com/806319Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522302}

In order to be able to save passwords from iframes and to fill passwords on
account select in frames (i.e. after clicking on a username field and choosing
a username from the list above keyboard), processing of form related events
in iframe is required. Handlers for these events are in forms.js. This CL
contains:
1.Creating frame_web_bundle script for injecting in all frames (in contrast
to web_bundle, that's injected only in the main frame).
2.Adding form.js into frame_web_bundle script.
3.Updating form.js:
  a.No action for iframe that have different origin that the main frame.
  b.Added window.top for calls from __gCrWeb.message and __gCrWeb.common, that
allows avoid injecting common and message into each iframes. That minimizes
a script that injected in each frame to ~1K (in comparison ~7K when common
and message are injected).

Bug: 554927
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia63c9dd382036a59753409c0e089a466ad958447
Reviewed-on: https://chromium-review.googlesource.com/803616
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522301}

This patch fixes Site Settings on Android to properly display popup
exceptions. This fixes a regression from an earlier patch that made
drilling down from single category permissions show all permissions
(bug 673620), which made it impossible to clear popup exceptions on
any individual site.

Bug: 791897, 763982
Change-Id: Ib1383289c8f7e0fb3643a9ad0a8ef0f7c3f3b137
Reviewed-on: https://chromium-review.googlesource.com/810224Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522300}

Previously, NetworkStateHandler contained the following bug:
  (1) Connect Ethernet network (the default network).
  (2) Connect Tether network (Ethernet is still default).
  (3) Disconnect Ethernet network (Tether should be the default).
  (4) NSH notifies that the new default is null, which is incorrect.

This issue was caused by an early return in
NetworkStateHandler::DefaultNetworkServiceChanged() which prevented the
default network change event from being propagated.

This CL fixes an issue which prevents ARC++ apps from utilizing a Tether
connection, since ARC++ relies on default network change events to
forward network connections to Android apps.

Bug: 766933, 672263
Change-Id: Ib4824bfef1d3e7faa86b631a7cc87870c818ab42
Reviewed-on: https://chromium-review.googlesource.com/809535
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522299}

Due to the recent rework of how to decide if events should be recorded
or not, the test events created through sync-internals was not updated.
This fixes them by making two changes.

1. event_case() is now correctly set so that the service can identify
the type of event.

2. navigation_id's presence is not set if the text field is not filled
in, allowing it to bypass the requirement for history sync to be
enabled.

Bug: 792730
Change-Id: Icabf100da886cbd28efc8db2ce3e6e8cb4a50af1
Reviewed-on: https://chromium-review.googlesource.com/812975
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Patrick Noland <pnoland@google.com>
Cr-Commit-Position: refs/heads/master@{#522298}

* Convert GetPopupPosition to take a gfx::Size(), because it does not
  use the position of the passed Rect.
* Convert member variables that always match constant values to just
  use constants
* Convert non-mutating functions to static

I noticed these while looking at WindowPositioner for mustash.

TBR=msw@chromium.org

Bug: 764009
Test: ash_unittests, chrome unit_tests WindowSizer*
Change-Id: Ie9c16a0a41fc46d8b6ca8918e1cfa757f80e8b70
Reviewed-on: https://chromium-review.googlesource.com/811684
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522297}

This reverts commit f2c18626.

Reason for revert: virtual/modern-media-controls/media/controls/modern/slow-doubletap.html consistently times out on Win7 Tests (dbg)(1):

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65034
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65035
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65036
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/65037


Original change's description:
> Reland: Media Controls: Double tap on either side to jump
> 
> Add double tap gesture recognition to MediaControlOverlayPlayButton so
> it can detect double tap gestures on the side and jump accordingly. Adds
> LayoutTests as a virtual test suite so they are tested with the modern
> media controls flag on.
> 
> BUG=779989
> 
> TBR=jbroman@chromium.org
> 
> Change-Id: I2d6e3c79d5ca3b447eda70f35da3dd22283a14b3
> Reviewed-on: https://chromium-review.googlesource.com/800150
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522139}

TBR=mlamouri@chromium.org,beccahughes@chromium.org

Change-Id: If52d84a124f06cfd44b0dcbfacc5470a6920d7dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 779989
Reviewed-on: https://chromium-review.googlesource.com/813135Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522296}

Due to a bug fix now we are enabling tests ChromeDriverPageLoadTimeoutTest.testHistoryNavigationWithPageLoadTimeout and ChromeDriverPageLoadTimeoutTest.testRefreshWithPageLoadTimeout.

Tests ChromeDriverTest.testDoesntHangOnFragmentNavigation and PageLoadingTest.testShouldBeAbleToGetAFragmentOnTheCurrentPage are now enabled for HEAD but they are disabled for v63 and v64

Bug: chromedriver:2025
Change-Id: I16079017885504c77c0128bc64fefa598cd42e0b
Reviewed-on: https://chromium-review.googlesource.com/812148Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522295}

Memory ablation payload is just a single dirty byte in otherwise zero
page. The lz4 compression ratio of such page is 151, i.e. the effect
of the payload greatly reduces as its pages are moved into zram.

This CL fills the payload with random bytes to make sure its effect
is not diminished by zram.

Measurements on 1GiB Android Go device show that this change increases
time spent on touching one chunk (512KiB) by 30% (2.7ms to 3.5ms).

Bug: 710048
Change-Id: I1e5cfebb1593bf3c3a917fd40fd689e43a144263
Reviewed-on: https://chromium-review.googlesource.com/809962Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522294}

We're hitting scenarios where it appears that we may be creating an
EGL window surface for a given window before destroying the previous.
This leads to errors on Android, and shouldn't be possible. We're
suspecting that someone may be taking a reference on the glSurface,
extending the lifetime beyond the expected range. This CL adds logging
to catch this scenario.

Bug: 787086
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I31bb0c55fb393a0719486f32f885273ee81ab9f8
Reviewed-on: https://chromium-review.googlesource.com/802186
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522293}

The library Motion Transitioning for Objective-C is a new dependency
of the Material Components for iOS. Library description:

  Light-weight API for building UIViewController transitions.

Bug: 785248
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifcc89ff8871b1630c7a9feb04c39cc61d9408335
Reviewed-on: https://chromium-review.googlesource.com/803621Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522292}

Using wpt-import in Chromium f0303631.
With Chromium commits locally applied on WPT:
2e6a737d "WPT: Add form-based file upload coverage"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6982

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=robertma

No-Export: true
Change-Id: Ie7ffdba0f5344ed20ad1d95cfa3219536c46d8cd
Reviewed-on: https://chromium-review.googlesource.com/812150
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522291}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I54509993b185fa581ad75c81ee39ece60a8d3ee0
Reviewed-on: https://chromium-review.googlesource.com/789724
Commit-Queue: Chris Watkins <watk@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522290}