GitLab

euckr-decode-ksc_5601.html is failing on WebKit Mac10.13.

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20(retina)/36

Tbr: jsbell@chromium.org
Bug: 864994
Change-Id: I5773da2363a7d4b3a9bf85b307fd6ab4b0e7790f
Reviewed-on: https://chromium-review.googlesource.com/1141875
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576031}

Use the map passed in the parameters of the resource fetch priority
finch study to schedule resource loading tasks on Blink.

Bug: 860545
Change-Id: I156afc89a347cc26816070679d2a8a568217720a
Reviewed-on: https://chromium-review.googlesource.com/1140155Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576030}

fast/dom/Window/window-focus-self.html is failing on Windows.

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/38018
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/38017

Tbr: kochi@chromium.org
Bug: 816766, 863067
Change-Id: Ie54d5722b6c9c76d548d43a190ab827f051cdeb9
Reviewed-on: https://chromium-review.googlesource.com/1141869
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576029}

This is causing crashes in M68. From code inspection, everywhere
NavigationContext is created, a navigation item unique ID is set. So
the only other possibility is somewhere between when the context is
created and |webView:didFinishNavigation|, the pending item associated
with the context disappeared. Not updating the error retry state in this
case is not detrimental. It only affects use cases when network error
is to be displayed, which is a small fraction of all page loads.

Bug: 851969,854752
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I71f911e402ccc002b0bfd8c2ef6686926b73d147
Reviewed-on: https://chromium-review.googlesource.com/1141134Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576028}

1) Removes the logic to bring the most recently used suggestion to the
   front of the list for consistency with other platforms.
2) Keeps the GPay logo as the first suggestion when "Clear Form" is moved
   the front of the list.

Bug: 852529
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5f214078f2a64507a0c326665d5dce9a2f35d7f4
Reviewed-on: https://chromium-review.googlesource.com/1140900Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576027}

Bug: 863974
Change-Id: Idfeae3e29ff93b0897e822035d2f35282b6c8ca1
Reviewed-on: https://chromium-review.googlesource.com/1141046
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576026}

Temporarily move consent_auditor_factory.{h,cc} to
ios/chrome/browser/sync.

Otherwise I cannot wire ControllerDelegateOnUIThread for USER_CONSENTS
in ios_chrome_sync_client, because consent_auditor_factory depends on
UserEventService, which is located in sync folder (i.e. this leads to
BUILD.gn cycle).

The plan is to move it back once it does not depend on UserEventService
anymore (i.e. USER_CONSENTS are completely launched).

Bug: 840357,850428
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2157e913ee6d6d3adde86b3121fdb021aed3614c
Reviewed-on: https://chromium-review.googlesource.com/1141583Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576025}

They are implemented behind the CSSLogical runtime flag.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ

Spec: https://drafts.csswg.org/css-logical/#inset-properties

BUG=850004

TEST=external/wpt/css/css-logical/logical-box-inset.html

The test still has some failures because sideways writing modes have
not been implemented yet (http://crbug.com/680331).

Change-Id: I296bf83bb7200f1215b7f088284d34c6c69259c9
Reviewed-on: https://chromium-review.googlesource.com/1138620Reviewed-by: Anders Ruud <andruud@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#576024}

This CL implements the following:
1. Committing local bookmark deletions.

2. Adjust a browser test in /single_client_bookmarks_sync_test.cc
to remove the requirement of merge logic in the case of USS. This
change should be rolled back upon implementing USS merge logic.


Bug: 516866
Change-Id: I98ed87de7e1124dc535290a4f47faf21f1691668
Reviewed-on: https://chromium-review.googlesource.com/1127170
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576023}

This CL is implementation of overriding of prefilled values in username
fields if the server believes that these values are placeholders.

The life of server prediction for filling prefilled values is the
following (it's called may_use_prefilled_placeholder in code):
1. The server sends it and it's propagated as part of FormStructure to
FormParser (it's implemented before this CL).
2. It's parsed in password_field_prediction.cc to PasswordFieldPrediction
3. FormParser puts it to PasswordForm.
4. In password_form_fill_data.cc it's propagated to PasswordFormFillData
5. It's sent to the renderer over MOJO
6. PasswordAutofillAgent uses it to override prefilled values if any.

The reason of putting processing may_use_prefilled_placeholder in
FormParser not in NewPasswordFormManager is that NewPasswordFormManager
should know nothing about form structure, it's FormParser responsibility
to process it.

Small deletion of dead code is done: parameter |set_selection| from
FillUserNameAndPassword, since it's never set to true.

Initial CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1124474

TBR=mkwst@chromium.org

Bug: 847793, 831123
Change-Id: I5f9a98d755400b2ab9706d27578764a0b46b3f86
Reviewed-on: https://chromium-review.googlesource.com/1140321Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576022}

2nd review following the same criteria as before; the images
match, or less, by reviewing build 8068.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6da3c540b87a0d30974d6f825f23c026a03a0486
Reviewed-on: https://chromium-review.googlesource.com/1141755
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576021}

Fix for crrev.com/c/1138621. Opening the account settings was missing
from the patch. This test runs on iPad without Bijou UI.
See: https://chromium-review.googlesource.com/c/chromium/src/+/1138621/15/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm#b447

TBR: rohitrao@chromium.org
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I42668af76d53475667ac4ec8a02859fa834132fb
Reviewed-on: https://chromium-review.googlesource.com/1141573
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576020}

This adds the checker that the number of Decode()s in flight is less than or
equal to the requested number.
In addition, by this change,
(1) if a decoder is deleted, doesn't execute DecodeNextFragment() and doesn't
check the number of Decode()s,
(2) doesn't DecodeNextFragment() in NotifyResetDone() caused by
MID_STREAM_RESET or RESET_AFTER_FIRST_CONFIG_INFO, because requested number
Decode()s are being executed.

BUG=chromium:834170
TEST=VDA unittest at kevin

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icdb94ff57b824690cf8346e7d9c6889ba57ae0d3
Reviewed-on: https://chromium-review.googlesource.com/1130970Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576019}

This addresses the issue where a previously signed-in user logs out, but
their album info is not cleared due to the auth error.

Bug: 864011
Change-Id: I2935d5428367a6d18fff5889a6f3c424b50f9983
Reviewed-on: https://chromium-review.googlesource.com/1139900
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576018}

Sync2Ptr was a temporary type, used during migration of SyncPtr APIs
from returning |bool| to |zx_status_t|, to remove risk of implicit
conversions to |bool|.

Some libzx call-sites (e.g. use of zx::process::self()) are also
updated to be compatible with changes in the latest Fuchsia SDK.

TBR: dcheng, jochen
Change-Id: I9e9350931e18f2bddc0ef7234d225821cf7d22f1
Reviewed-on: https://chromium-review.googlesource.com/1141659
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576017}

Before: https://screenshot.googleplex.com/uaoCMDztv5s.png
After: https://screenshot.googleplex.com/zZnYTUShvnX.png

Bug: 863452
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I41986b5288daa1c68135b9ca6fb6828c4cd444a9
Reviewed-on: https://chromium-review.googlesource.com/1141223
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576016}

This allows session restored tabs to persist their time since last use across
sessions, allowing them to be appropriately prioritized.

BUG=800885

Change-Id: Ic578b93b418d07d83b47b9ae4e9ea561800f9fcc
Reviewed-on: https://chromium-review.googlesource.com/1140785
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576015}

This CL adds a metrics of
- Scroll by touch on message center
- Scroll by arrow key on message center
- Scroll by mouse wheel on message center

Bug: 854470
Test: None

Change-Id: I11cad33ceaa192ee0afe3e6712632181ba055be0
Reviewed-on: https://chromium-review.googlesource.com/1120089
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576014}

This reverts commit f53c3ea9.

Reason for revert: break media_perftest (crbug.com/864942)


Now I look at the code, I also have concerns about the approach of the CL. Please discuss with me on the approach to implement the feature.

Original change's description:
> Reland #3 of "gtest perf tests: Output well formed test results json"
> 
> This reverts commit 3cf9eadf.
> 
> Reason for revert: Will fix errors
> 
> Original change's description:
> > Revert "Reland "Reland "gtest perf tests: Output well formed test results json"""
> >
> > This reverts commit 4da4a0c8.
> >
> > Reason for revert: Failing on mac and windows.  I will add more comments to crbug.com/855234
> >
> > Original change's description:
> > > Reland "Reland "gtest perf tests: Output well formed test results json""
> > >
> > > This reverts commit 89c5e790.
> > >
> > > Reason for revert: Testing possible fixes
> > >
> > > Original change's description:
> > > > Revert "Reland "gtest perf tests: Output well formed test results json""
> > > >
> > > > This reverts commit f02c92e1.
> > > >
> > > > Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315
> > > >
> > > > Original change's description:
> > > > > Reland "gtest perf tests: Output well formed test results json"
> > > > >
> > > > > This reverts commit 9eeaba4e.
> > > > >
> > > > > Reason for revert: Will re-land with fix
> > > > >
> > > > > Original change's description:
> > > > > > Revert "gtest perf tests: Output well formed test results json"
> > > > > >
> > > > > > This reverts commit 71b865f4.
> > > > > >
> > > > > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307)
> > > > > >
> > > > > > Original change's description:
> > > > > > > gtest perf tests: Output well formed test results json
> > > > > > >
> > > > > > > This CL changes the run_gtest_perf_test.py script to output well formed
> > > > > > > test results json.
> > > > > > >
> > > > > > > Bug: 855234
> > > > > > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796
> > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1112635
> > > > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > > > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > > > > > Cr-Commit-Position: refs/heads/master@{#570943}
> > > > > >
> > > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > > > > >
> > > > > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac
> > > > > > No-Presubmit: true
> > > > > > No-Tree-Checks: true
> > > > > > No-Try: true
> > > > > > Bug: 855234
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/1118238
> > > > > > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > > > > > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > > > > > Cr-Commit-Position: refs/heads/master@{#571083}
> > > > >
> > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > > > >
> > > > > Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: 855234
> > > > > Reviewed-on: https://chromium-review.googlesource.com/1118789
> > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > > > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#571245}
> > > >
> > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > > >
> > > > Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 855234
> > > > Reviewed-on: https://chromium-review.googlesource.com/1119445
> > > > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > > > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > > > Cr-Commit-Position: refs/heads/master@{#571321}
> > >
> > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> > >
> > > Change-Id: I25bc4bb1f77031d95dd70347bfed886112b76218
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 855234
> > > Reviewed-on: https://chromium-review.googlesource.com/1120798
> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#571968}
> >
> > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> >
> > Change-Id: I031c5d6204e0b53fa2719168a38292455d676167
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 855234
> > Reviewed-on: https://chromium-review.googlesource.com/1124539
> > Reviewed-by: Emily Hanley <eyaich@chromium.org>
> > Commit-Queue: Emily Hanley <eyaich@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#572183}
> 
> Change-Id: I6c994148908ed9a223b8b59219b6b4a6957cd9ca
> Bug: 855234
> Reviewed-on: https://chromium-review.googlesource.com/1125420
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575747}

TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org

Change-Id: I250655ba8a77cbee8ea46d7471c4691e761fa88e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855234
Reviewed-on: https://chromium-review.googlesource.com/1141824Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#576013}

Previously, the profiling tools selected the first connected
devices. This gives inconsistent and surprising results if there is more
than one device connected. This change asserts that either exactly one
device is connected, or the device is explicitly specified via a new
--device flag.

Bug: 843561
Change-Id: I51e310b83028876936bc8e042d96c9e16044360b
Reviewed-on: https://chromium-review.googlesource.com/1124843Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576012}

Upcoming work will add APIs to IdentityManager to interact with the
user's Gaia accounts in the cookie jar. To implement these APIS,
IdentityManager will need to interact with GaiaCookieManagerService. In
preparation for that work, this CL threads GaiaCookieManagerService in
to IdentityManager.

Design doc:

https://docs.google.com/document/d/1hcrJ44facCSHtMGBmPusvcoP-fAR300Hi-UFez8ffYQ/edit?pli=1#heading=h.y7yywe14x23d

TBR=rohitrao@chromium.org

Bug: 859882
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I40f1abd6c8beca89476567bbb94979ad42ff7df1
Reviewed-on: https://chromium-review.googlesource.com/1140156
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576011}

Change-Id: I42be273b8ca5c5c6bcf2dff9f1599559f99bbe5b
Reviewed-on: https://chromium-review.googlesource.com/1141571Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576010}

This CL moves the passphrase section just below the account if the user
has set a a custom passphrase and if Unified Consent is enabled.

Changing the strings and fixing the vertical spacing between the elements in
the enter passphrase section will be addressed in a follow-up CL.

Mock:
https://drive.google.com/open?id=1vAn34VbmHuiEpp8jQaB4v9K2T-G-ziqU

Screenshot:
https://drive.google.com/open?id=1OizYyUmyAEView0RrJkZfinxt-Rtz5Xp

Bug: 834361
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5b7401c641291439f1bd61e6acd1523102b8a667
Reviewed-on: https://chromium-review.googlesource.com/1133380Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576009}

https://skia.googlesource.com/skia.git/+log/77552dbce365..5dbb0c3db56a


git log 77552dbce365..5dbb0c3db56a --date=short --no-merges --format='%ad %ae %s'
2018-07-18 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 04f0f133032c..e2c00841a55f (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@5dbb0c3db56a

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I27a868a649457d77eb6304987b402ba89798f44f
Reviewed-on: https://chromium-review.googlesource.com/1141608Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576008}

It was kind of an artificial state: All the other states are mutually
exclusive and form a clear hierarchy, but auth errors can coexist with
most of the other states. In that case, we'd "override" the overall
state to be AUTH_ERROR, which made it impossible to check whether, e.g.,
the SyncEngine was initialized.
This CL removes the AUTH_ERROR state - interested clients will have to
call GetAuthError() again, which they probably had to do anyway to check
for transient vs. persistent errors etc.

Bug: 839834
Change-Id: I829a1495671a34eb783d56dc73519025f9bfed7b
Reviewed-on: https://chromium-review.googlesource.com/1141578Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576007}

The goal of this log was not to enter suspending mode while uploading
a large resource, but it also causes hanging POST requests, sometimes
used for chat channels, to prevent a system from entering suspend mode.
It also can keep systems awake after their lid is closed, consuming
battery unexpectedly.  Chrome is the only browser that does this.

We'll either need to port the behavior to work with the network service,
or remove it from Chrome before we ship the network service (So it's one
less difference between Chrome with / without the network service).  We
opted to go with the latter approach, since the current behavior can
cause problems.  There's also a wake lock web API under discussion,
though not yet shipped.

TBR=jam@chromium.org

Bug: 571250, 789673
Change-Id: I6e121b9a862496dfb2da630a180cd00cdde30528
Reviewed-on: https://chromium-review.googlesource.com/1140207
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576006}

This is a reland of 4a0cf651

Original change's description:
> [Sync] Deprecate BookmarkData in SyncEntity and remove related code
> 
> Bug: 860643
> Change-Id: Ic472b0d4a182cb70fce2a035197897cdb9e609c2
> Reviewed-on: https://chromium-review.googlesource.com/1127791
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575221}

Bug: 860643
Change-Id: I61fc398f00e53f7b4c51f85e82da897cd5f91d9d
Reviewed-on: https://chromium-review.googlesource.com/1141626Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576005}

https://pdfium.googlesource.com/pdfium.git/+log/89063ecda876..30688fb1c434


git log 89063ecda876..30688fb1c434 --date=short --no-merges --format='%ad %ae %s'
2018-07-18 thestig@chromium.org Do not add invalid objects to the cross reference table.
2018-07-18 thestig@chromium.org Avoid writing const/non-const versions of the same function.
2018-07-18 art-snake@yandex-team.ru Use CPDF_CrossRefTable within CPDF_Parser
2018-07-18 art-snake@yandex-team.ru Make CPDF_Parser::GetTrailer const method.


Created with:
  gclient setdep -r src/third_party/pdfium@30688fb1c434

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:851994
TBR=dsinclair@chromium.org

Change-Id: Ifa585071269b19dea2a21848eac1e7bce60e1711
Reviewed-on: https://chromium-review.googlesource.com/1141604Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576004}

https://webrtc.googlesource.com/src.git/+log/0f5400acfa40..881fe53d1fae


git log 0f5400acfa40..881fe53d1fae --date=short --no-merges --format='%ad %ae %s'
2018-07-18 mbonadei@webrtc.org Remove linux_internal_compile_lite from CQ.
2018-07-18 qingsi@google.com Provide a default no-op implementation of RegisterUMAObserver in


Created with:
  gclient setdep -r src/third_party/webrtc@881fe53d1fae

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I201dd236ffff84cbbf708e17bbb2f97657446cc8
Reviewed-on: https://chromium-review.googlesource.com/1141607Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576003}

https://chromium.googlesource.com/catapult.git/+log/e8dc05ccba6b..a824624071cc


git log e8dc05ccba6b..a824624071cc --date=short --no-merges --format='%ad %ae %s'
2018-07-18 wangge@google.com added milestone and build mapping table


Created with:
  gclient setdep -r src/third_party/catapult@a824624071cc

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:863390
TBR=sullivan@chromium.org

Change-Id: I2b0e9090759a7e5617f9ad6673fcdb2405d616f9
Reviewed-on: https://chromium-review.googlesource.com/1141605Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576002}

https://android.googlesource.com/platform/external/perfetto.git/+log/debca810f01d..510bbe089b53


git log debca810f01d..510bbe089b53 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 hjd@google.com perfetto-ui: Add query page


Created with:
  gclient setdep -r src/third_party/perfetto@510bbe089b53

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I76c6832c79bf4d7bda808a34cab9e4c363b4758c
Reviewed-on: https://chromium-review.googlesource.com/1141606
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576001}

Change the update notification text to notify the user that the device
will wipe itself when it's rebooted.

Currently, this is done by comparing the version number of the current
and the new Chrome OS image. We're planning to later change this to an
actual DBus call to update_engine, which will return true exactly when
a powerwash will happen.

There will also be a follow-up CL which will change the notification
text to a rollback-specific one (currently it says "Update available").

Bug: 863088
Change-Id: Ic92444b0520f9e3e7f4e9f8a736abe6f6af20913
Reviewed-on: https://chromium-review.googlesource.com/1140320
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576000}

This CL adds a couple of tips for printing variables in lldb
to docs/mac_build_instructions.md.

Bug: none

Change-Id: I46a2eea3f69132ee3947de8abf7c37a8c692db30
Reviewed-on: https://chromium-review.googlesource.com/1141764Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575999}

Bug: 864611
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I94b04a494f58a3e39437695b555f447ba1c70f9a
Reviewed-on: https://chromium-review.googlesource.com/1140920Reviewed-by: David Tu <dtu@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#575998}

Give PersonalDataManager a separate datastore for server data.
The constructor of PDM can choose whether to use an in-memory
or persistent storage for server cards. When we do Butter for
Addresses, we will make those use the server db too.

This extracts the database selection logic from PersonalDataManager
into a helper class. It also removes some duplicate tests from
AutofillMetricsTest that are already covered in
PersonalDataManagerTest.

Bug: 854643
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia344b9ae22a0bd485a71d2e09e38778fa2ff35ea
Reviewed-on: https://chromium-review.googlesource.com/1086932
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575997}

Using wpt-import in Chromium 9159e523.
With Chromium commits locally applied on WPT:
048081e4 "Reporting: Payload field should be `body`, not `report`"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21538

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/encoding

TBR=foolip

No-Export: true
Change-Id: Iad4d316bd4edda2d62698c5ab9e151b6943351aa
Reviewed-on: https://chromium-review.googlesource.com/1141646
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575996}

When deleting browsing data, test that all data has been removed from
level db instances in the profile directory. This improves the existing
test that scans files after a deletion. As LevelDB is using compression
to store it's data, we need to handle it specifically.

Bug: 846297
Change-Id: I93506910430668c735ea6a242352d4497ae19b62
Reviewed-on: https://chromium-review.googlesource.com/1140060
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575995}

Since CL:1125855, the new default is that policy-installed extensions
can not be inspected by developer tools.
However, some autotests rely on inspecting policy-installed extensions
and it is infeasible to change the policy the device sees there.
Introduce the "--force-devtools-available" command-line switch which
enforces developer tools availability.

Bug: 838146
Test: browser_tests --gtest_filter=*DevTools*
Change-Id: I666d9785195eff53f1a1346d95177985d1573d72
Reviewed-on: https://chromium-review.googlesource.com/1140308Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575994}

This should save memory, because all the fields in a oneof share
memory, and at most one field can be set at the same time.

Also remove the unused requested_types field, that depended on
having multiple specifics messages in one entity.

Based on https://codereview.chromium.org/2650253002/

BUG=687426

Change-Id: I83a5b03b222e4ab272bedf41b35cdfd28b4bbc9d
Reviewed-on: https://chromium-review.googlesource.com/1129140
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575993}

and ExceptionState

Changing attribute src of HTMLSourceElement and HTMLImageElement to URLString
Change of SetSrc of HTMLSourceElement and HTMLImageElement to hava arguments
USVStringOrTrustedURL; calling setAttribute mentioned above from it
Changing calls of SetSrc in other files so that the arguments match; wrapping
arguments and using ASSERT_NO_EXCEPTION
Adding tests for SetSrc

Bug: 739170
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic99a338783bfcbfc5c2dca5061352367c2daeaec
Reviewed-on: https://chromium-review.googlesource.com/1137821
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575992}