- 26 Mar, 2019 40 commits
-
-
James Lissiak authored
This change adds 4 new performance histograms for the DevTools using the prefix 'DevTools.Launch': - DevTools.Launch.Console - DevTools.Launch.Elements - DevTools.Launch.Network - DevTools.Launch.Sources These histograms measure the time between the DevTools window being shown during 'DevToolsWindow::ToggleDevToolsWindow' and a point in each tool that corresponds to the 'ready' state as seen by a user. These end points are unique to each tool but are as follows: - Console: At the end of the ConsolePrompt constructor - Elements: At the end of _updateMetrics when the styles panel has been populated for the initially selected node - Network: After the panel is shown - Sources: After the NetworkNavigatorView has been loaded These tools were chosen as they represent the most popular in terms of usage and will allow us to identify any significant performance impact in the time taken to launch the DevTools when these panels open by default. To see time captured by the histograms in terms of a perf trace for each tool please take a look at the following screenshots: https://imgur.com/a/rcAgQ8h In the traces you can see that the end marker for each load is at the end of the trace near first meaningful paint, and just as the user will see the content of the tool render fully. To accomplish the histograms, a new native function has been added to the DevTools ui bindings/embedder classes called 'recordPerformanceHistogram'. Along with the plumbing and a new helper function in the frontend javascript Host.UserMetrics file called 'panelLoaded' When the frontend javascript loads, it will store the initial panel to be loaded from the preferences. Once that panel has been created and the appropriate loaded marker has been hit, the duration of the launch will be calculated using performance.now(). That duration is then sent to the native code which will fire the appropriate histogram via the 'UMA_HISTOGRAM_TIMES' macros. The mechanism is similar to the existing one used for enumerated histograms and can be expanded to fire additional performance histograms in the future. Also added a new test for user-metrics to ensure that the panelLoaded function will correctly record the histograms. Change-Id: Ib9f0bf80c651231d6d2e308bee36c1a1223f04db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506388Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: James Lissiak <jalissia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#644407}
-
Min Qin authored
BUG=842245 Change-Id: Ieea0d3bcaef8f8f47a32c74845c056c452ca7f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532922 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644406}
-
Mohamed Amir Yosef authored
This CL extends life-time of histograms that are still useful for investigation of a long-standing recurring bug. I am also adding one more owner. Bug: 893969,893998 Change-Id: Ibf5abc0919e5198ab025a436e1ef38bd9e0e3907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538082Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#644405}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8a240a71a0c..7175abb56021 Created with: gclient setdep -r src-internal@7175abb56021 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: I5cb731fcd89cf8d7a61b532e994a8df53c45db83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539896Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644404}
-
Aga Wronska authored
Docked magnifier is not a part of shelf, so shelf should not store this value and make in available to other objects. Refactoring it will simplify ShelfLayoutManager interface and remove unnecessary dependencies on Shelf. Move docked magnifier height to RootWindowController. Trigger observer when the height changed. Test: manually with 2 displays + existing unit tests Bug: 944685 Change-Id: I9fa5cd9c7c22f23ef95321b885c6632d1561f49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536597 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#644403}
-
Xianda Sun authored
As we use hit test region's data to compute transforms, not submitting data for pointer-events none OOPIFs can break transforming requests to those regions. This CL makes v2 viz hit test always submit a region for pointer-events none OOPIFs with kHitTestIgnore flag, see: https://chromium-review.googlesource.com/c/chromium/src/+/1487850 for v1 change. Bug: 934007 Change-Id: If049d3a94b82175094683fc29aea013d34603061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524083Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#644402}
-
Austin Eng authored
This patch adds GPUFences and GPUQueue::signal which is enough to test roundtrip operations from Blink through the command buffer to Dawn and back. When a GPUFence is signaled on a GPUQueue, the GPUFence's completedValue will update when the fence passes. The GPUFence can register an onCompletion callback which resolves a Promise when the fence passes. Bug: 941543 Change-Id: Ifae65dee1b1aeb3d3d78387983cbae4444d57c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497770Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#644401}
-
oysteine authored
This reverts commit 60955896. Reason for revert: Re-enabling tests after https://chromium-review.googlesource.com/c/chromium/src/+/1536801 Original change's description: > Disable all BackgroundTracingManagerBrowserTests due to data race. > > Bug: 945484 > Change-Id: Ie7ae6d64752b0aac9c88110b23a67b42c4580908 > TBR: sahel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538784 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644108} TBR=pkasting@chromium.org,sahel@chromium.org Change-Id: I83156abb16d6e34a85a8530e78558b58c7832274 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 945484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534867Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#644400}
-
Jonah Chin authored
Patch that fixes the win7 error that happened in previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1496534 Should complete this revert first: https://chromium-review.googlesource.com/c/chromium/src/+/1538811 This is necessary in Windows since some fonts are not limited to weights that are multiples of 100. Eg. Segoe UI with a weight of 350 should match the semilight font as opposed to the regular one. Bug: 944301 Change-Id: I59e30d05be13bbfdc0bc06b82f2656f25ede525f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538890 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#644399}
-
Ben Pastene authored
This will let us call tast and sanity tests via a shell script on the device. (Actually switching them will come in a follow-up CL.) This will be useful for coverage tests, since they need special setup on the device's filesystem prior to the tests. Bug: 934059 Change-Id: I2a907d176faf4ce12411bd2157188f909e494cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534857Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#644398}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7f34b929. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ib302f6b2bfc3699af46247ece09b334b147c68ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539694Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644397}
-
Jonas Olsson authored
This CL adds descriptions for the histograms added in https://webrtc-review.googlesource.com/c/src/+/127884 Bug: webrtc:10413 Change-Id: I37adf4a909242aa41b159a5454284a24aded6e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538426 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#644396}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/v8/v8/+/1534635 this works well enough automatically. Additionally, this assert was unintentionally also hit with target_cpu = "arm64", so this CL fixes that too. Bug: 794838,893460 Change-Id: I32d7a67b2f818aacfaeef39a03a1107b596b9dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536310 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#644395}
-
Lutz Justen authored
Adds the ability to start the Kerberos dameon. Since most users probably won't use Kerberos, the daemon is not started by default, but on demand. BUG=chromium:933798 Change-Id: Iccb1f3228c154ae2e6d9b7e9db5fa419b74b2653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524288Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#644394}
-
Yusuke Sato authored
BUG=None TEST=try TEST=git grep -A1 ArcSessionRunner | grep '::Bind(' Change-Id: Ie80757dfb56c52b0862e7dbc63dfe4c1fc8affea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535741Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#644393}
-
Andres Calderon Jaramillo authored
This CL increases the largest maximum size that we expect a VAAPI driver to report for JPEG decoding. The reason is that eve is reporting support for a larger size than expected (16384x16384). Test: VaapiJpegDecoderTest.* pass on eve. Bug: 944369 Change-Id: I856c83e014a24c8c57236ec7d754444d9567b8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539916 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#644392}
-
Martin Robinson authored
Split different ATK interface implementations into various namespaces. This makes each method name simpler and also allows us to avoid having to slightly rename some methods to avoid collisions. This change also cleans up the organization of the file in general and fixes various code style issues. In particular, instead of relying on a mix between anonymous namespaces and the 'static' keyword to ensure static linkage, just use the anonymous namespace. This is what Google code style dictates. Bug: 945289 Change-Id: I12f831a2264f0aebf3d45856ebb10ca11b9363a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538186 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644391}
-
Daniel Bratell authored
The mojo Range class needs range_struct_traits.h and the build system wasn't setup to allow that. Simplest for everyone is to integrate the struct_traits target into the mojom target and let the mojo system figure out dependencies. This made everything simpler. Without this fix you got errors like the one below: ERROR at //out/Default/gen/content/common/input/input_handler.mojom-test-utils.cc:49:11: Can't include this header from here. ^-------------------------------------- The target: //content/common:mojo_bindings is including a file from the target: //ui/gfx/range/mojo:struct_traits It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //content/common:mojo_bindings --> //services/ws/public/mojom/ime:ime --[private]--> //ui/gfx/range/mojo:struct_traits Bug: 938893 Change-Id: If01554d38ca3d5f4280d32c658d1f7044f14c29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536056Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644390}
-
Alison Maher authored
GetChildren retrieves a collection of all embedded objects that fall within a text range. More info here: https://docs.microsoft.com/en-us/windows/desktop/api/uiautomationcore/nf-uiautomationcore-itextrangeprovider-getchildren Unit test added to AXPlatformNodeTextRangeProviderTest. Support was added to AXPlatformNodeDelegate and BrowserAccessibility to retrieve the descendant nodes that are exposed to the platform API. Unit test added for this to BrowserAccessibilityTest. Bug: 928948 Change-Id: Id10b9ada1a8acabfea685bb0d95a4420007dc7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529077 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Mike Wittman authored
Drops the 'Native' part of the StackSampler name in support of a future cross-platform sampler implementation that delegates to platform-specific code at a lower level of abstraction. This is a reland of f7d1ff11 with a test compilation fix. Bug: 909957 Change-Id: I54a9dcaac13a451fe1bea0f37e5e8b4edf1a7bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537747 Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Alexei Filippov authored
The provider reports number of files currently being monitored by the watcher. This is needed to confirm there's no memory leak in the SharedFileWatcher. BUG=810155 Change-Id: I560a4ce8c7a297cd60162c528e8c76c37f3a47ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539017Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#644387}
-
Adithya Srinivasan authored
This is a follow up to https://crrev.com/c/1423462. Moving ForwardMessageToPortalHost to FrameNavigationControl associates it with the Frame navigation messages and the legacy Frame IPC channel, ensuring a defined ordering between postMessage and navigation messages. Bug: 914120 Change-Id: I1fdb9a5be5b2d034764d28464aaeba955efc9320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536536Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Liquan(Max) Gu authored
The FCP++ histograms will expire at 2019-04-25. This CL is to extend the date. Bug: 945571 Change-Id: Ica4d8a38600fbc89accf22ca4b797734585f8653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539693Reviewed-by:
-
Abhishek Bhardwaj authored
This change changes the wake lock type acquired by Assistant on Chrome OS from kPreventDisplaySleepAllowDimming to kPreventAppSuspension. This is needed because Assistant often grabs wake locks for non-UI related operations that don't need the display to be on. Without this change when the display goes off, but the system is still on, and Assistant grabs a wake lock the screen turns on without any notification. BUG=945743 TEST=Run unit tests and manual testing. Change-Id: If3ad3d01c63499ed6646a0e5655dbdfec6c68008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539461 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Auto-Submit: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#644384}
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: I0f249c9671ed35d7d186b291d108c35d2ac0b00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535351Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
Matt Mueller authored
Bug: 51988 Change-Id: I63e487637181b1b5c933bceb46ff182a12afc764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538985Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#644382}
-
Dominic Mazzoni authored
Bug: none Change-Id: Iec4ac4ab0ae6a8b911fc0f9d807b34ed003e1e1d Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539862 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#644381}
-
Daniel Bratell authored
Generated files in components/policy used header files that they didn't depend on. This oversight caused errors when running gn check --check-generated (brand new gn feature!) For instance: ERROR at //out/Default/gen/components/policy/policy_constants.h:14:11: Include not allowed. #include "components/policy/core/common/policy_details.h" ^--------------------------------------------- It is not in any dependency of //components/policy:generated The include file is in the target(s): //components/policy/core/common:internal which should somehow be reachable. This CL fixes those errors by listing/allowing necessary dependencies. An alternative would be to extract policy_details.h and policy_map.h into a new build target, including everything they depend on. I didn't investigate how much work that is because of time constraints. Bug: 938893 Change-Id: I69775047ae70f15138ad0754f4c4d51bd02c7530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527534 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#644380}
-
Nicolas Ouellet-payeur authored
Bug: 892725 Change-Id: I6ea4ea928c6c746163564a66732c04a8c9755e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538611Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#644379}
-
Tomasz Wiszkowski authored
This change: - reduces code complexity and dependency on duplicate resources, - fixes a glitch on Android P and Q where text colors would not be correctly reflected by the theme, - drops redundant color definitions. Bug: 944496 Change-Id: I3058edc9c6414ead398bb4e7f3d223fd0a8c77d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536541Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#644378}
-
Jared Saul authored
This line of code is crashing in M73: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27autofill%3A%3ACreditCardSaveManager%3A%3AOnUserDidIgnoreOrDeclineSave%27#-propertyselector,productname:1000,productversion:20,magicsignature:50,magicsignature2:50,stablesignature:50 Bug: 943220 Change-Id: I78f493c0ce2e170e3baa8e5691d3f431ae180529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539101Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#644377}
-
Eric Seckler authored
Adds a OnTracingEnabled to the TracingSession mojo interface, which is called by ConsumerHost when all expected services have connected and begun tracing. Also adds the necessary plumbing to notify the ProducerHost about started data sources. Bug: 933535 Change-Id: I82ef580a05da7a0ee59afa17b8bfa15cbcf31ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530908Reviewed-by:
-
Sammie Quon authored
TBR=oshima@chromium.org Test: none Bug: none Change-Id: Ide8cfcebc2b92545561a86a8f62bb839a01ba25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539067Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#644375}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7857648f..88a0c6d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chrome.try:Mac Builder Perf TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1ae4c6edc8bea051a43f0da1bcbdaa13f4d56871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539695Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#644374}
-
jdoerrie authored
This change implements IOSChromePasswordManager::IsMainFrameSecure by exposing the WebState on the PasswordManagerClientDelegate and then using it to call WebStateContentIsSecureHtml(). Bug: 940906 Change-Id: Ia5afca02f141cf601c1b09e7f693f4dc2810daa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538510Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#644373}
-
Mohamed Amir Yosef authored
Before this CL, BookmarkModelTypeProcessor schedules a save upon changes in ModelTypeState even if they dont't involve changes in Sync entity metadata. This results in frequent writes of the bookmarks file which could be potentially large for some users. This CL makes sure that the file is saved only upon changes in the entity metadata. Bug: 945820 Change-Id: Ib0d581b1b585e5cc4bff1721bf8767abc047316d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538526 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#644372}
-
Michael Giuffrida authored
Renames AppListTabletModeContainer to HomeScreenContainer to reflect that it contains the home screen (either app list or kiosk next app). Hosts the KioskNextHome app window in this container when KioskNextShell is enabled. Also moves KioskNextShell tests from LoginUtilsTest to their own file. Bug: 937549 Change-Id: Icd2a878ed67a913128058e3d5fe688b65de7c5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538688Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#644371}
-
Daniel Bratell authored
Since mojom will put headers from ui/gfx/ipc/color into code in other targets, the dependency need to be public so that other code get the right dependency. Without the fix gn check --check-generated reports this: ERROR at //out/Default/gen/services/viz/public/interfaces/compositing/compositor_frame.mojom-test-utils.cc:51:11: Can't include this header from here. #include "ui/gfx/ipc/color/gfx_param_traits.h" ^---------------------------------- The target: //services/viz/public/interfaces:interfaces is including a file from the target: //ui/gfx/ipc/color:color It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //services/viz/public/interfaces:interfaces --> //ui/gfx/mojo:mojo --[private]--> //ui/gfx/ipc/color:color Bug: 938893 Change-Id: I5ab887bc137223c74e7b84ffc75a9fee0b3c01cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538412 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: -
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7c820116b0c09f65812b39723c6c7048183d1b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644369}
-
Daniel Bratell authored
Since mojo will insert #include "media/base/ipc/media_param_traits_macros.h" in code using the media types mojo types, the dependency on media/base/ipc, where that header lives, need to be public. The error reported otherwise (by gn check --check-generated) was: ERROR at //out/Default/gen/media/mojo/interfaces/traits_test_service.mojom-test-utils.cc:30:11: Can't include this header from here. #include "media/base/ipc/media_param_traits_macros.h" ^----------------------------------------- The target: //media/mojo/interfaces:test_interfaces is including a file from the target: //media/base/ipc:ipc It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //media/mojo/interfaces:test_interfaces --> //media/mojo/interfaces:interfaces --[private]--> //media/base/ipc:ipc Bug: 938893 Change-Id: I7781ced5305ace65654da9ee4cf1a7f82ecac1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538434 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
