- 07 Jul, 2020 40 commits
-
-
Philip Rogers authored
svg/dom/content-model.html does some manual parsing of the layout tree dump which breaks if the LayoutSVGRoot gets a paint layer. This patch updates the test to pass if the LayoutSVGRoot has a paint layer or not. Bug: 1101002 Change-Id: Ic7d3b13e57784f9d40c4998b56ea233a44045b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284869 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#785806}
-
Fawaz Mohammad authored
This patch adds a function to the Chrome DevTools Protocol in the WebAuthn Domain. This function makes it possible to choose whether an authenticator responds to MakeCredentials / GetAssertion, by toggling the automaticPresenceSimulation parameter in the authenticator. Bug: 1086270 Change-Id: Ief1b98189201d039b087ad37cdfb967d03d3b054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280472 Auto-Submit: Fawaz Mohammad <fawazm@google.com> Commit-Queue: Fawaz Mohammad <fawazm@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#785805}
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ R=gab@chromium.org Bug: 1097092 Change-Id: Ib3fddf7372997fc0b3dea61c2020014d35bd9402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262254 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785804}
-
Charlie Hu authored
Bug: 1095641 Change-Id: I7558008667c0c3a83dbb19c9211bad78db1dd3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272611Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#785803}
-
Clemens Arbesser authored
Bug: 1102828 Change-Id: I9c11111e018b1c5428c857e28511dcd9cbb98295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285042Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#785802}
-
Megan Jablonski authored
Fix three Tab UI bugs: 1. The always translate checkbox in the menu was retranslating an already translated page when toggled. 2. When reverting a translation from the tab UI, the model's view state was not being updated. This meant if a user untranslated the page after clicking the always translate button in the menu, then clicked always translate again, the page wouldn't translate since the model's state is incorrectly "translated" rather than "before translate". 3. The 'always translate' button beneath the tab UI was not being updated when the always translate menu item was being clicked. Additionally this CL removes some unused code that was missed in the experiment cleanup. Bug: 1099571 Change-Id: I0b3545463acc257ab69cd616bce2e9e833cf2ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269751Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#785801}
-
Daniel Nicoara authored
Makes it easy to tell if the aura::Window is visible or not since this information can't always be deduced from Layer or occlusion state. BUG=None TEST=Manually by inspecting an aura window that was hidden/visible. Change-Id: I17f513de4b14f412ea6195e6ac2d928c5ba8e2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283234 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#785800}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: I2e83ea768461f2041fd173bca193e6e510d5d886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277250 Auto-Submit: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#785799}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I5ac471fc28121a13f02f2d6824704eca8d017f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283631Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#785798}
-
Christoph Schwering authored
The first one, Autofill.Autocomplete.{NotOff,Off}. EditedAutofilledFieldAtSubmission.{Address,CreditCard}, measures how frequently users change fields filled by Autofill, spliced by whether autocomplete = off or not. The second one, Autofill.Autocomplete.{NotOff,Off}.FillingAcceptance. {NotOff,Off}, measures the how frequently users accept suggestions, spliced by whether the field from which Autofill was triggered has autocomplete = off or not. Change-Id: If2491f59168c5c72284a4f418cb184b1b7722a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268997 Commit-Queue: Christoph Schwering <schwering@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#785797}
-
Kevin McNee authored
NaClBrowserTestPnacl.PnaclDebugURLFlagOff NaClBrowserTestPnacl.PPAPIPPBInstance and NaClBrowserTestPnacl.PnaclDyncodeSyscallDisabled are flaky on Win7 (32). Tbr: dschuff@chromium.org Bug: 1059468 Change-Id: Ibf8efe698cc71c6ed01e5395a4a75ceb6c60f382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285022Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#785796}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I4c0f95f063d3b8873a3eaf5969c085f167b37ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283640Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#785795}
-
Nate Chapin authored
Bug: 1102070, 1101831 Test: html/semantics/forms/the-form-element/form-action-in-inactive-document-crash.html Change-Id: I16d786cdcc3924e109d63b06aad06b003deec9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283724 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#785794}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86436e7f59cd..e1b96bb59d41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mcnee@google.com,hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mcnee@google.com,hendrich@google.com Change-Id: I618af14e481d08050a4b40ee13b54a2a4844a251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284943Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785793}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05da783f87fb..cf5e35f72130 2020-07-07 fmalita@chromium.org Use ContextInfo::directContext() in skottie2movie.cpp 2020-07-07 zepenghu@google.com sync with master 2020-06-14 zepenghu@google.com replace max_len with if statements 2020-06-12 zepenghu@google.com adjust input size 2020-06-12 zepenghu@google.com fixed format 2020-06-12 zepenghu@google.com fixed width and height 2020-06-11 zepenghu@google.com add 2 dom api to fuzz 2020-06-11 zepenghu@google.com add 2 dom api to fuzz 2020-06-11 zepenghu@google.com add 2 dom api to fuzz 2020-06-11 zepenghu@google.com add 2 dom api to fuzz 2020-06-10 zepenghu@google.com fix import 2020-06-10 zepenghu@google.com add svg fuzzer 2020-06-10 zepenghu@google.com add svg fuzzer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Ifaa6c3bb49ead9c0c2c29a37019e73e81f99cf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284942Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785792}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Iebcb442701bfd4c2c5b7226251ff8a4a6b479de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283737Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#785791}
-
Scott Violet authored
OnRootScrollOffsetChanged should only be sent if all root scroll offsets have been requested and only on android. BUG=1100552 TEST=none Change-Id: Ibc53cf127df0107e5ac69f9378601c9d25d357e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283056Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Hongbo Song authored
Change-Id: Ib98cfb9bf32fd4c31e7fedd8dbf31674760abcb5 Bug: 922980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283772Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I5b9c69ffd73f28221a4c81acc12a6bd9772b95c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283635Reviewed-by:
-
Ben Pastene authored
When running tests that are launched from the host (eg telemetry tests), the test_runner will take all args passed to it after the last known arg and treat that as the host-side test command. Consequently if a known arg is interleaved into the unknown args, the test runner will not pick it up. By treating unknown args (rather than trailing args) as the command, we can embed known args into the list. This will let something like crrev.com/c/2283576 land as-is where we add '--flash' as the very last arg. Without this CL, that arg is treated as an arg to telemetry instead of an arg to the test runner. Bug: 1057152 Change-Id: Id5326dfa3bceab86ae97dc260c9699cf35f56b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283899Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#785787}
-
Adam Kallai authored
e46f30cc5497 fix: include missing header file Bug: 1100363 Change-Id: Ie98728d3495f89356260be89e85f4d041b360972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283215Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#785786}
-
Tim Volodine authored
Add tests for the case when Safe Browsing is disabled. Corresponds to the BASIC_SAFE_BROWSING_ENABLED Profile setting. BUG=1015418,1102074 TEST=run_weblayer_browsertests --gtest_filter=SafeBrowsingBrowserTest* Change-Id: I84fa60d14954bca1d15efab9ea102e17410110cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281007 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#785785}
-
Benoit Lize authored
logging.cc locks the log file on POSIX, using either a global pthread_mutex_t, or a global base::internal::LockImpl. They are backed by the same OS primitive, as base::internal::LockImpl wraps pthread_mutex_t, so we can use base::internal::LockImpl everywhere. LockImpl is used instead of Lock as it is said that Lock uses logging internally. This is equally true for LockImpl (through a DCHECK()), so there is no reason to not use base::Lock directly. Finally, now that we have C++ local statics, use these to simplify the code. Change-Id: Ibc0dfbad61ebac27301d7aae0bc1cf8357ec4de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282760Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#785784}
-
Nate Chapin authored
This most likely regeressed in https://chromium-review.googlesource.com/c/chromium/src/+/2258955 In that CL, I moved the implementation of NavigateLocalAdsFrame() from document.cc to oom_intervention_impl.cc. The only behavior change I can see is that instead of giving FrameLoadRequest an origin context in its constructor, I switched it to nullptr. The crash reports aren't providing terribly useful stack traces, but my guess is that this is crashing at https://chromium.googlesource.com/chromium/src/+/962a6c5c187940f445c958c627875113ca31297a/content/renderer/render_frame_impl.cc#5685 RequestorOrigin() is DCHECKed non-null at the start of the function, but I believe it would be null if FrameLoadRequest was given a nullptr origin context. Bug: 1101967 Change-Id: I573e8c13adc8d26fa10644f77c4b609ebfe0ccfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283257Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I78bf887c091b2dc16b1b7bfd53c98e797b586148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283049Reviewed-by:
-
Nektarios Paisios authored
Uses a single method for determining whether a node is a text node throughout the accessibility codebase This patch takes us one step closer to merging AXNodePosition with BrowserAccessibilityPosition. A single method, AXNode::IsText(), is now used to determine whether a node in the accessibility tree is a text node. Also, took the opportunity to search the entire codebase for narrower role checks and replace them with AXNode::IsText(). More specifically the following usage patterns were replaced: role == ax::mojom::Role::kStaticText / kInlineTextBox / kListMarker ax_role_properties > ui::IsText() / ui::IsTextOrLineBreak() AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: Ie3ecda66e75a0df6c6f460c2d2855db6d1705ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282744 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785781}
-
WangHui authored
No logic changed. Signed-off-by:
WangHui <wanghui210@huawei.com> Change-Id: Iacf0dfa0e17195378c0cc998c00750196f3383a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282834Reviewed-by:
-
Rohit Rao authored
Starting with iOS 11, apps can ask for write-only access to photos. This CL switches ImageSaver to use the new write-only API. It also removes calls to the read-write PHPhotoLibrary APIs and removes code that checks the photos authorization state, since there is no way to check the value of the write-only permission in advance. BUG=1102479 Change-Id: I245149c8480e9e02fa0c6218aa652bd26c9f7c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283654 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#785779}
-
ckitagawa authored
This CL simplifies the visibility state of the player so that there are fewer mVisible* lists and instead uses the visibility property of View. Bug: 1099722 Change-Id: I57745d54f0e8447e9abc83c8e7394838a2a19c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273460Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#785778}
-
Oleh Lamzin authored
Add non removable block device info to the probe service. Bug: b:158658869 Change-Id: I6f125a5127372040c884f24a11ac38391beca753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268797 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#785777}
-
Antonio Gomes authored
... instead of WebMediaStreamSource. CL also converts DidStopMediaStreamSource() in html_media_element_capture.cc. BUG=704136 R=guidou@chromium.org Change-Id: Id88fe7e809210885157af84a5dc7b746b0a7f18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283583 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#785776}
-
Marc Treib authored
This reverts commit 39804b20. Reason for reland: The code that was crashing before has been deleted. Original change's description: > Revert "Sync cleanup: Remove DEPRECATED_EXPERIMENTS ModelType" > > This reverts commit df3250dd. > > Reason for revert: Suspected of causing crashes, see crbug.com/1047879 > > Original change's description: > > Sync cleanup: Remove DEPRECATED_EXPERIMENTS ModelType > > > > It has been deprecated and unused for a while. > > The specifics proto itself can't be removed yet because it's still used > > on the server. > > > > Bug: 1009361 > > Change-Id: Ic183a6e244435cfce60ccdda34bff3e22a032ff3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022670 > > Commit-Queue: Marc Treib <treib@chromium.org> > > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#736397} > > TBR=treib@chromium.org,jkrcal@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1009361, 1047879 > Change-Id: I762fbf6f1b4b752a47b34e6a101a066d0c78aebc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036005 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738205} TBR=treib@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1009361, 1047879 Change-Id: I104a665136b4b6e74b36c03e0bb09c8e57d76bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282816Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#785775}
-
Nicolás Peña Moreno authored
This CL does the following: * Introduces OWNERS files in folders that did not have one. * Adds WPT-NOTIFY to get bugs on failures from upstream. * Sets speed-metrics-dev@ as the team. * Updates some specific owners in some cases. Change-Id: I6b0da49a7abb34e9b4a69513942f955967df6433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283418Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#785774}
-
Andrew authored
Add InstallResult and UninstallResult to histograms.xml and enums.xml to collect the metrics of the results of Install and Uninstall calls to dlcservice. DLCs are ChromiumOS Software packages that are installed in the stateful partition. These metrics are needed to know if the installation or unistallation of the DLC modules is successful or not. Details on the DLC metrics can be found in chromiumos/platform2/+/refs/heads/master/dlcservice/metrics.h or chromium:2265289 and chromium:2246295 and chromium:2274742. BUG=chromium:1069121 TEST=None Change-Id: Ib710e5193e25c56667cc1cb864b9c31821b7cdf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267448 Commit-Queue: Andrew Lassalle <andrewlassalle@chromium.org> Reviewed-by:
-
Monica Basta authored
This CL handles launching selected profile from the profile picker and then closing the picker. Bug: 1063856 Change-Id: I5bfd15a115503dad2749f21f159cb8df25ed0a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279890 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#785772}
-
Jose Dapena Paz authored
After the changes to convert to SIMD several operations in WebAudio oscillator node, GCC refuses to compile a call to _mm_cmplt_ps since we try to store it in m128i, but mm_cmplt_ps returns an m128. To fix that, we reinterpret_cast<__m128i>, as that's how we want to interpret the bits. Verified with webaudio/Oscillator/* web tests. Bug: 819294 Change-Id: Ia00a7695476e84996548b6c679ffeedead49213b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247792Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#785771}
-
Jose Dapena Paz authored
Similar to previous fix to oscillator node. In GCC, an implicit cast to m128i of the result of mm_cmplt_ps is not valid. In this case, as the next usage of the return value is already an m128, we just change the type of the return value to m128 too. Bug: 819294 Change-Id: I9ae9103a837920a5bfe432d7c81930bb4a5fce78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283211Reviewed-by:
-
Matt Jones authored
This patch removes the 'toolbar textbox aplha' param from the native methods since it is always 1 and the 'view height' param since it is unused. The visibility param in the SceneLayer has also been removed as it is handled by one of the SceneOverlay interface methods. Bug: 1100332 Change-Id: Ia43c405ede070bc4d2ac3b95e00f7b35ac94628c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278168 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#785769}
-
Jonathan Backer authored
Work is on going to port this feature to other platforms, notably OSX and CrOS. Extending the expiry will help developers. Change-Id: Id24eb3e54e3db48bc4240268137ffd27761135b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284922Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#785768}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9eb2d25b67f1..1402ed576596 2020-07-07 rharrison@google.com Roll 6 dependencies and update expectations. (#1097) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ifddd5d9105f5dd3e4769017990b350d374e090d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284801Reviewed-by:
-
