- 20 Jul, 2017 40 commits
-
-
Sean O'Brien authored
Scroll events from the touchpad may arrive in the |GestureEventQueue| out of order, such that a GestureFlingStart arrives before a GestureScrollUpdate. Currently, the debounce filter removes the GestureFlingStart. This CL will forward the GestureFlingStart after emptying the debounce queue. BUG=717205 Change-Id: I42bd147195b9a2be8e34391c534c625cc785e2e0 Reviewed-on: https://chromium-review.googlesource.com/553424 Commit-Queue: Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#488353}
-
Matthew Halpern authored
Currently GRC's process CPU measurement mechanisms are tightly integrated with the process coordination unit implementation. This CL moves the CPU usage measurement from the resource_coordinator service to the content_browser service. Decoupling process CPU measurement from the CU model allows the coordination units to focus on representing browser state within GRC, rather than updating it. In GRC terms, the migrated render process CPU measurement infrastructure is a "probe" that externally triggers updates to the CU graph. A new feature flag has been added for enabling render process CPU usage profiling. To do so, run: out/Default/chrome --enable-features=GlobalResourceCoordinator,GRCRenderProcessCPUProfiling \ http://example.com BUG=691886,741768 Change-Id: I2fc7609c6963776a167c5f76abe078dedb0e2efe Reviewed-on: https://chromium-review.googlesource.com/565906 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oystein Eftevaag <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#488352}
-
Yipeng Wang authored
Generated jni headers should not be included by multiple .cc files. This double-include is breaking upcoming changes to the JNI generator. BUG=683256 Change-Id: I92318e46de45841557544bf04503bee27fc52e9a Reviewed-on: https://chromium-review.googlesource.com/578743Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yipeng Wang <yipengw@chromium.org> Cr-Commit-Position: refs/heads/master@{#488351}
-
Brett Wilson authored
Fixes linking in Windows non-component builds since the profiling process is now a child process. Move AllocationTracker::Alloc into a separate class AllocationEvent so it can be used in the exporter. Hooks up a simple test for the exporter. The exporter is not currently hooked up to any triggering. Change-Id: Ic9dda085032694ff1a5872e357ca2e03c0d42ad3 Reviewed-on: https://chromium-review.googlesource.com/575395 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#488350}
-
Peter Kasting authored
Ensure that the KeyValueImport test actually checks that GetFormValuesForElementName() overwrites the existing consumer value. This test would have failed in the initial version we wrote to convert the WebDataService off the DB thread, and was noticed by eye. This also refactors some common caller code into the callee in a couple places. Bug: none Change-Id: I3fc17a97b95e28c019f98e6692eedceb3fee260a Reviewed-on: https://chromium-review.googlesource.com/578586Reviewed-by:
mahmadi <mahmadi@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#488349}
-
Alexei Filippov authored
Change-Id: I9f6597ba0c296a478e5501c7f13a536210c4ceff Reviewed-on: https://chromium-review.googlesource.com/578740Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#488348}
-
Lei Zhang authored
Change-Id: Ib89e0f4a329b0e9ae844a90ca7506b330655a61f Reviewed-on: https://chromium-review.googlesource.com/578987Reviewed-by:
Dan Sinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#488347}
-
Kevin Marshall authored
Fix threading bug in RemovableStorageProvider test path RemovableStorageProvider replies to GetAllDevices() queries on the FILE thread instead of the caller's thread for test cases. This fixes the issue by posting the reply to the correct thread. (Caught by the stricter WeakPtr impl; see CL 2908073007) R=sky@chromium.org CC=wez@chromium.org Bug: 729716 Change-Id: Ie0983e03ba91c8c09ba339ea6c7061de28e69030 Reviewed-on: https://chromium-review.googlesource.com/529864Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#488346}
-
yunlian authored
When I try to enable thinlto on ChromeOS build, I hit this assert. This CL fixes that. BUG=None TEST=USE="thinlto" emerge-terra chromeos-chrome, the assertion is gone. Review-Url: https://codereview.chromium.org/2960273002 Cr-Commit-Position: refs/heads/master@{#488345} -
Matt Menke authored
https://chromium-review.googlesource.com/569298 added an extra check for hostname validity before doing a DNS lookup, but it only covered the main Resolve() path, not the two Resolve*FromCache ones. This prevents bad domains from getting into the cache, but certain bad domain names can still be resolved from the Resolve*FromCache calls without a DNS lookup, like *.localhost domains. This CL fixes that, and merges more common code between the different resolution methods, so hopefully this will be less likely to regress in the future. Bug: 496468 Change-Id: I3ec16ae77a1f1a074e37a2c29a23d2423a4b42e0 Reviewed-on: https://chromium-review.googlesource.com/578207 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#488344}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c7c5420fbc58..f1ed1692b568 $ git log c7c5420fb..f1ed1692b --date=short --no-merges --format='%ad %ae %s' 2017-07-20 sullivan Migrate benchmark health report to an experimental script using APIs. 2017-07-20 loloangela Fix errors related to bad-continuation param Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4f86d7c4b13cd7d1d62442112a5382042b5b0e81 Reviewed-on: https://chromium-review.googlesource.com/579665 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488343}
-
Nico Weber authored
I had removed this in https://codereview.chromium.org/2959083002, but it looks like dump_syms still needs it on arm for now. Bug: 744956,735027 Change-Id: Ia438c53abc6d6f7f39aada563bdcb68d328b1115 Reviewed-on: https://chromium-review.googlesource.com/579930Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#488342}
-
Max Morin authored
Changing which device is the default one will change the device enumeration result since https://chromium-review.googlesource.com/c/538754/. This CL makes sure to invalidate the device cache in MediaDevicesManager when this happens. Tested by plugging in various devices into a Pixel, verifying that input and output from each device has the same group id, and in addition that the "default" device has the same group id as the actual device that is considered default. Moreover, after changing the default device in the system UI and re-enumerating the result, the group id is updated accordingly. BUG=636300 R=jennyz Change-Id: Ie847bd052a609022826f31fbc3059a98049b875d Reviewed-on: https://chromium-review.googlesource.com/577532Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488341}
-
Scott Violet authored
_classic is mildly misleading given some of these files are used in mushrome, but it's better than aura. BUG=none TEST=none Change-Id: I688be31ecc92138d3f53781519972c8172c64645 Reviewed-on: https://chromium-review.googlesource.com/578654 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#488340}
-
Nico Weber authored
Bug: 330631 Change-Id: I930ef6a08833811313cd4cec61a400d283d12aa6 Reviewed-on: https://chromium-review.googlesource.com/580128Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#488339}
-
Jun Cai authored
This CL removes some unnecessary class forward declaration at SensorProxy.h Bug: None Change-Id: Ia626f912dcd604e12927dd8c2fe1e0da1a65b8be Reviewed-on: https://chromium-review.googlesource.com/579660Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#488338}
-
Kyle Milka authored
This is part 3 of 6 for FieldTrial refactoring for WebView Part 1: https://chromium-review.googlesource.com/c/562098/ Part 2: https://chromium-review.googlesource.com/c/561920/ Part 3: https://chromium-review.googlesource.com/c/561922/ Part 4: https://chromium-review.googlesource.com/c/561980/ Part 5: https://chromium-review.googlesource.com/c/562417/ Part 6: https://chromium-review.googlesource.com/c/562021/ This CL fixes a bug introduced in https://chromium-review.googlesource.com/c/561922/. It also contains a unit test for the bug. This new class contains the code previously in VariationsService that is needed by both Chrome and WebView, mainly the portions needed to call CreateTrialsFromSeed. The VariationsService class now contains an instance of this new class. BUG=678288 Change-Id: Ib1acf1a30ad50baded043b2fc05e9d87cd1fb4a3 Reviewed-on: https://chromium-review.googlesource.com/576288 Commit-Queue: Kyle Milka <kmilka@google.com> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#488337}
-
Xiaoqian Dai authored
This reverts commit dd9a923e. Reason for revert: It broke ash_unittests https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28342. I'll investigate into it later. Original change's description: > Cros Tablet Window management - Split Screen part II > > This is a reland of https://codereview.chromium.org/2955203002/. The > original CL broke ash_unittests. > > Wire up the SplitViewController with the overview mode. It's a following > up CL of https://codereview.chromium.org/2960843004/. > > Changes in this CL: > 1. The split view mode can be initiated by dragging the window in > overview mode to the side of the screen > 2. After one window is snapped to one side of the screen, all the other > overview windows will display in the other side of the screen, allowing > the user to select another window to snap. When two windows are snapped > to both sides of the screen, the overview mode will be ended. > 3. The first snapped window will remain snapped until the user > explicitly exit the split view mode. All the other windows (incluing > newly created window) will be open in the other side of the screen. > Clicking/Tapping on the overview button also open the overview windows > in the other side of the screen. > > Not covered in this CL: > 1. The highlighted region showing where split will occur is not > implemented in this CL. > 2. The split divider is not implemented in this CL. > > BUG=725683 > TBR=oshima@chromium.org, varkha@chromium.org > > Change-Id: I307ac438bb45c0df5e347be296964375782ef3e7 > Reviewed-on: https://chromium-review.googlesource.com/578490 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488272} TBR=oshima@chromium.org,varkha@chromium.org,xdai@chromium.org Change-Id: I6c852c91bc93fa749cbf0f2fb1d56c2dee41a9b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725683 Reviewed-on: https://chromium-review.googlesource.com/580347Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#488336}
-
Steven Holte authored
Bug: 745939 Change-Id: I30d487641e5cb3130961c46305e4999e2e7ef63d Reviewed-on: https://chromium-review.googlesource.com/577062 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#488335}
-
Victor Costan authored
Bug: 746653 Change-Id: Ieb6e9bcc5e119573f98d6e629caf47d099eba774 Reviewed-on: https://chromium-review.googlesource.com/578393Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#488334}
-
Amber Won authored
On the placeholder page, add a PDF icon in the center and a bar on the bottom of the page, which includes the file name and a link to the view the PDF. Bug: 737787 Change-Id: Ia3612ee812118514666bafa195720b2191d31f6b Reviewed-on: https://chromium-review.googlesource.com/578309 Commit-Queue: Amber Won <amberwon@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488333}
-
Neal Gompa authored
Mageia 6 introduces DNF as an alternative package manager. In addition, Mageia 6 switches the PackageKit backend to the DNF one, meaning that the urpmi configuration does not apply to tools like Apper, GNOME Software, and Plasma Discover, which use PackageKit as the package management backend. Since DNF (being the successor to Yum) is configured the same way as Yum is, let's reuse the Yum configuration setup for Fedora to configure it for Mageia. We do this by changing to declare an array PACKAGEMANAGERS and iterate through them and execute the actions for each PACKAGEMANAGER. This way, we can easily support future transitions and parallel package manager configurations from distributions in the future. Bug: 729888 Change-Id: I19a80ee1e150d8cfea53944a2030e6ea0ae1ce44 Reviewed-on: https://chromium-review.googlesource.com/572394Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#488332}
-
Mark Cogan authored
This CL removes the last parts of contextual search from shipping code. The settings UI is moved into contextual_search/, and is still built and tested for unit tests, but all of the remaining logic around initializing CS and enabling it, and possibly showing the settings, is removed. The IDC_SHOW_CONTEXTUAL_SEARCH_SETTINGS command is also removed. Bug: 738881 Change-Id: I41226091de512660b5969623083c6a450d86cd59 Reviewed-on: https://chromium-review.googlesource.com/577870Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#488331}
-
arthursonzogni authored
This is a followup of https://codereview.chromium.org/2975623002/. It prevents the renderer from ignoring main resource requests with the "cid" scheme and adds tests that check an Android Webview can intercept any requests with this scheme. BUG=739658 Change-Id: I03e039f5e84f2be8638c46812f2216803a0f1d4d Reviewed-on: https://chromium-review.googlesource.com/574591Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#488330}
-
Hidehiko Abe authored
ArcProvisionNotificationService internally accessed to ArcSessionManager::profile(). Instead, it will use the given BrowserContext. BUG=672829 TEST=Ran trybot. Change-Id: Ic1f60318d4727863a41654cd5aa73b3bd319725d Reviewed-on: https://chromium-review.googlesource.com/579890Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488329}
-
mfomitchev authored
Proper fix is in https://codereview.chromium.org/2983883002/, but I'd rather not land that while on leave. I will land the proper fix when I come back if this is still not replaced with the new UI. BUG=668296 Review-Url: https://codereview.chromium.org/2985543002 Cr-Commit-Position: refs/heads/master@{#488328}
-
robliao authored
This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ Review-Url: https://codereview.chromium.org/2978253002 Cr-Original-Commit-Position: refs/heads/master@{#487625} Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f Review-Url: https://codereview.chromium.org/2978253002 Cr-Commit-Position: refs/heads/master@{#488327}
-
Victor Costan authored
Getting the whitespace removed will make SQLite patch management easier. This CL was generated using the following commands. cd third_party/sqlite find src/ -type f -not -iname "*.db" -not -iname "*.eps" -not -iname "*.ico" \ -not -iname "*.jpg" -not -iname "*.pfx" -not -iname "*.tiff" \ -not -iname "*.vsix" -exec sed --in-place 's/[[:space:]]\+$//' {} \+ find patches/ -type f -exec sed --in-place 's/[[:space:]]\+$//' {} \+ ./google_generate_amalgamation.sh Bug: 746653 Change-Id: I933ab436d5a1be05074821d92e818dd6bf72009f Reviewed-on: https://chromium-review.googlesource.com/578677Reviewed-by:Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#488326}
-
Christopher Grant authored
BUG= Change-Id: I71fd5ed6623499c55332e3ccc3372123768d37c8 Reviewed-on: https://chromium-review.googlesource.com/579689Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#488325}
-
Jean-François Geyelin authored
The KAV buttons should be aligned with the ones from GBoard. Bug: Change-Id: I8ba048719326ed93890fa989092cc460d0071e29 Reviewed-on: https://chromium-review.googlesource.com/579971 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488324}
-
Stephen McGruer authored
Bug: 746963 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I60bcffb65161c16521afc22b3aa1ed3d2bfe346d Reviewed-on: https://chromium-review.googlesource.com/579528Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#488323}
-
Nicolas Capens authored
The issue was a general UBSan one, not a UBSan vptr issue. Also, we didn't have to blacklist the false positive, but instead provided UBSan wth the necessary type info. BUG=737384 Change-Id: Ie6299e1edfc010ef976ab4fbefacba4d06e305b7 Reviewed-on: https://chromium-review.googlesource.com/579448Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com> Cr-Commit-Position: refs/heads/master@{#488322}
-
Sky Malice authored
ExtractIntegerValueAtIndex's main piece of functionality was that it would first try to read the number as a string, and if the failed, it would fallback to reading it as a double/integer. However, the string read is not needed, as the javascript side always passes a number. Bug: Change-Id: I189e96865ec834bb8753f0d9f418cb3cd9925d17 Reviewed-on: https://chromium-review.googlesource.com/569848 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#488321}
-
Matthew Jones authored
In the cases where a normal web page is not being displayed, the browser controls are permanently shown (i.e. error page or interstitial). Because of this, When the browser controls are at the top of the screen, these views have a top margin applied to them so the full page can be visible. This code was never updated for bottom browser controls. This change adds logic to apply a bottom margin when bottom browser controls exist. BUG=738616 Change-Id: I155140d8341185b9cdb55f964d2491893732b4dc Reviewed-on: https://chromium-review.googlesource.com/576268 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#488320}
-
Christian Fremerey authored
This CL is part of the Mojo Video Capture work. Design doc for dev work [1]. Design doc for launch [2]. After this CL we differentiate in the UMA logging between enumeration-only usages of the service and usages that include actual capture. BUG:584797,721812 [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing [2] https://docs.google.com/document/d/1RLlgEdvqRA_NQfSPMJLn5KR-ygVzZ2MRgIy9yd6CdFA/edit?usp=sharing Change-Id: If6fd5fd1480edf18cce861f6c880d811a2f9a58c Reviewed-on: https://chromium-review.googlesource.com/572220 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#488319}
-
Julien Brianceau authored
Bug: none Change-Id: I2014adfa408153e801a5c5b94423e63ecb08c48b Reviewed-on: https://chromium-review.googlesource.com/579191Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488318}
-
Geoff Lang authored
ANGLE's shader translators hold a significant amount of memory for the builtin symbols. By lazily creating the shader translator, it may never be intialized at all if all compiles hit the program binary cache. BUG=695135 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I095dd2efa33e111726db893cd14c3c3574bdd6ce Reviewed-on: https://chromium-review.googlesource.com/570540Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#488317}
-
Alex Zhang authored
Added the missing return true and unit tests for both BufferFormat and BufferUsage enum traits. Bug: 732825 Change-Id: Idd41676f01a11f7666bf2c1c07621b4b9eae6b4a Reviewed-on: https://chromium-review.googlesource.com/578211Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xingyu Zhang <staraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488316}
-
Peter Wen authored
This reverts commit 0e0ca1fb. Reason for revert: <INSERT REASONING HERE> Original change's description: > Android: Turn on UnusedResources lint check > > Fixes current lint warnings and starts to remove obsolete old > suppressions. Moving towards a world where we have as few suppressions > as possible. > > Bug: 731159 > Change-Id: If960d984b0906b80d3cd8c504a0d0af83f6a8a89 > Reviewed-on: https://chromium-review.googlesource.com/578488 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Reviewed-by: Yuwei Huang <yuweih@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488307} TBR=wnwen@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Change-Id: I0347f22ffdf8ff7fa50a94a5d164dc4b790851f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731159 Reviewed-on: https://chromium-review.googlesource.com/580227Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488315}
-
Scott Little authored
This reverts commit 0e0ca1fb. Reason for revert: Broke compile on Android Arm64 Builder (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29 Original change's description: > Android: Turn on UnusedResources lint check > > Fixes current lint warnings and starts to remove obsolete old > suppressions. Moving towards a world where we have as few suppressions > as possible. > > Bug: 731159 > Change-Id: If960d984b0906b80d3cd8c504a0d0af83f6a8a89 > Reviewed-on: https://chromium-review.googlesource.com/578488 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Reviewed-by: Yuwei Huang <yuweih@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488307} TBR=wnwen@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Change-Id: I7dc0c54b509fe2597a38bb6d660d9c4e7232321d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731159 Reviewed-on: https://chromium-review.googlesource.com/579749Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#488314}
-