GitLab

This is a precusor cleanup extracted from
https://chromium-review.googlesource.com/c/chromium/src/+/957760/7
in the broader effort to restrict usage of MessageLoop::current().

This CL was uploaded by git cl split.

R=msw@chromium.org

Bug: 825327
Change-Id: I7d3d65d961089d61bacc89b5de1d526ea0cf94fc
Reviewed-on: https://chromium-review.googlesource.com/986756
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546965}

This CL adds the sync-account-control row in the sync-subpage when
unified-consent is enabled.

This does not apply to CrOS.

Bug: 800972
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie44c5de4702018b7804a54153f70a556b6c45ee2
Reviewed-on: https://chromium-review.googlesource.com/974646
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546964}

These nibs aren't used in polychrome builds, since they always use secondary
Views UI instead of Cocoa.

Bug: 825610
Change-Id: I745b64938254d1cef9a41045888cc1933e7c11d8
Reviewed-on: https://chromium-review.googlesource.com/986477Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546963}

The issue is that different line ending encodings were not properly
handled (\r\n vs \n) in the fingerprint comparison code.  Due to this,
a connection between different platforms, such as Windows to Linux,
would fail the FingerprintMatch verification check and close the
connection.

Note: There may be a better way to normalize the line endings upstream
but I am not familiar enough with WebRTC to make that change.

Change-Id: I03fee025c81bf3c1b5f54204beed5c8d938cbbc8
Reviewed-on: https://chromium-review.googlesource.com/986657
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546962}

This fixes an issue with the support library where we would sometimes
create an InvocationHandler and look up methods using the wrong
ClassLoader. This ensures we always use the correct ClassLoader.

dupeMethod() is only used here, so it's safe to change the signature.

See the crbug for more information.

Bug: 826988
Test: Manual, did this in my demo CL at http://crrev/c/965883
Change-Id: I7ca7bb90aec81a6a30ce4d6393cf40ee54d40c19
Reviewed-on: https://chromium-review.googlesource.com/985631Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546961}

Bug: 826063
Change-Id: I1930da3effd7952d2019e480048778075a0bcd58
Reviewed-on: https://chromium-review.googlesource.com/981686
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#546960}

This reverts commit 328b9d9e.

Reason for revert: Test ran on bots for half day. Started failing after more changes in base/.
I guess the extract didn't run because input arg was missing.

Original change's description:
> Revert "Reland "Android: Add code to parse the CFI info added to the apk""
>
> This reverts commit a06ad561.
>
> Reason for revert: crbug.com/827116
>
> Original change's description:
> > Reland "Android: Add code to parse the CFI info added to the apk"
> >
> > This reverts commit 88328b68.
> >
> > Reason for revert: Attempt fixing cfi bot by removing unwind tables in cfi
> > builds.
> >
> > Original change's description:
> > > Revert "Android: Add code to parse the CFI info added to the apk"
> > >
> > > This reverts commit 1d8b0c00.
> > >
> > > Reason for revert: https://crbug.com/826718
> > >
> > > CL causes failures on Android CFI builder.
> > >
> > > Original change's description:
> > > > Android: Add code to parse the CFI info added to the apk
> > > >
> > > > The previous CL added support for adding unwind tables in apk:
> > > > https://chromium-review.googlesource.com/c/chromium/src/+/956971
> > > > This CL parses and adds test for unwinding on base_unittests_apk.
> > > > The non-official builds do not contain debug info since all bots set
> > > > strip_debug_info=true. So, make sure base_unittests do not take this
> > > > flag.
> > > >
> > > > BUG=819888
> > > >
> > > > Change-Id: Ib69909e14f9f8623ac07154ef60be248558b08a4
> > > > Reviewed-on: https://chromium-review.googlesource.com/958326
> > > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > > Reviewed-by: Primiano Tucci <primiano@chromium.org>
> > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#546343}
> > >
> > > TBR=dcheng@chromium.org,primiano@chromium.org,dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,dskiba@chromium.org
> > >
> > > Change-Id: Ib9bcb81ffa30861ea91107c1a1f3ccb8f29a7f7d
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 819888
> > > Reviewed-on: https://chromium-review.googlesource.com/983972
> > > Reviewed-by: François Doray <fdoray@chromium.org>
> > > Commit-Queue: François Doray <fdoray@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#546472}
> >
> > TBR=dcheng@chromium.org,primiano@chromium.org,fdoray@chromium.org,dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,dskiba@chromium.org
> >
> > Bug: 819888
> > Change-Id: Iadb8825988a311c6576c219b9a67e35b45838d7b
> > Reviewed-on: https://chromium-review.googlesource.com/984452
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#546597}
>
> TBR=dcheng@chromium.org,primiano@chromium.org,fdoray@chromium.org,dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,dskiba@chromium.org
>
> Change-Id: Ib9dab098899b40b8814fb94c3d239d08eecc714f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 819888
> Reviewed-on: https://chromium-review.googlesource.com/986572
> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546836}

TBR=dcheng@chromium.org,primiano@chromium.org,fdoray@chromium.org,dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org,dskiba@chromium.org,tobiasjs@chromium.org

Change-Id: Ieef28dee93a9270e8de3e1f9e1ca7212178c2465
No-Presubmit: true
No-Tree-Checks: true
Bug: 819888
Reviewed-on: https://chromium-review.googlesource.com/985960
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546959}

HistoryInserter now used the collectionViewModel super class (ListModel) so it can work with both
CollectionItems and TableViewItems.

Bug: 805192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I02f170b00ca4957b834d26498084558e0f13de85
Reviewed-on: https://chromium-review.googlesource.com/985476Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546958}

This CL adds a Factory for:
(1) CryptAuthGCMManagerImpl
(2) CryptAuthDeviceManagerImpl
(3) CryptAuthEnrollmentManagerImpl

This pattern is needed for testing a future CL which introduces these 3
classes to the DeviceSync service.

Bug: 824568, 752273
Change-Id: I62b6336e5552b664eb522b893b4049c41343a6d1
Reviewed-on: https://chromium-review.googlesource.com/985894Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546957}

Previously, when a frame A navigates to B, we set and replicated the
origin and a few other things (such as insecure request policy or CSP
headers) prior to calling DidNavigateFrame().  This turned out to be
problematic because DidNavigateFrame() destroys the A frame's subtree
(as part of CommitPending() -> ResetForNewProcess()), which might
trigger unload handlers in the old frame's subframes.  Those unload
handlers would incorrectly see the new frame's origin (B) in the old
frame's proxy.  To fix this, this CL moves DidNavigateFrame() to
be done prior to the replication of origin and other properties.

Bug: 825283
Change-Id: Iff86ac8cad17cfef5349d9bbbc41d8dadd681bb1
Reviewed-on: https://chromium-review.googlesource.com/984729Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546956}

Change-Id: I52ac4148a483010522f0c4e8b2bc480b34b51d61
Reviewed-on: https://chromium-review.googlesource.com/972196
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546955}

* Removes the delegate interface on native side.
* moves fetch request and clear state to Java side
* Adds method for fetching suggestions with clustered resutls
  to the ContextualContentSuggestionsService (shim)

Bug: 824182, 824183
Change-Id: Ia33b79dd4af1219f93b1b1c913ebabb9e05a7dc1
Reviewed-on: https://chromium-review.googlesource.com/982641
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546954}

A change to the window tree can cause occlusion to be computed. If
a WindowDelegate changes the window tree when it is notified that
the occlusion of its window changed, occlusion has to be computed
again.

The number of times that occlusion can be recomputed before it has to
be stable was previously set to 2. This CL increases it to 3 to support
this case:

  Shos tab's WebContents ->
    Compute occlusion (1) ->
    Show modal dialog's WebContents (WebContentsModalDialogManager) ->
    Compute occlusion (2) ->
    Show modal dialog's RenderWidgetHostViewAura ->
    Compute occlusion (3) !!

Once showing or hiding a WebContents no longer involves calling
Show()/Hide() on the aura::Window of a RenderWidgetHostViewAura,
the value can be changed back to 2.

Bug: 827268
Change-Id: I58131b4c3b3dfa71db3075cad21b7f01ddf1b997
Reviewed-on: https://chromium-review.googlesource.com/986742Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546953}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/95f3837e..33685668

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Id31dee250b4a927929388f205708daf1f2ceadd8
Reviewed-on: https://chromium-review.googlesource.com/986678Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546952}

Also delete the experimental CQ builder for gathering win_chromium_dbg_ng data.

BUG=731547,731384

Change-Id: I93b18ba53bc0a658c659d4e69ea1aaacdd4c12d3
Reviewed-on: https://chromium-review.googlesource.com/986666Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546951}

For some reason, plus.google.com triggers a WKWebView bug that triggers
|webView:didFinishNavigation| before |webView:didCommitNavigation|
when navigation back to NTP. With WKBasedNavigationManager,
|webView:didFinishNavigation| triggers the presentation of native
content which relies on states updated in |webView:didCommitNavigation|.

Finish-before-commit has been observed before (crbug.com/727289). The
original fix made it possible to call didCommit without crashes after
didFinish has already been called. This is not sufficient for the
WKBasedNavigationManager use case because native controller needs last
committed navigation item to have been updated.

This CL calls didCommit in didFinish if a finish-before-commit scenario
is detected. UMA counters are added to track the frequency to ensure
this is indeed an exceptional case.

Bug: 818796
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I274cc37b494478882b4d8f2a773c33df5b29c703
Reviewed-on: https://chromium-review.googlesource.com/981299
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546950}

This CL moves generic_sensor_browsertest.cc from
//content/browser to //content/browser/generic_sensor directory.

Bug: None
Change-Id: Ib80513221c99b0583a1b809401de193d547fbc4c
Reviewed-on: https://chromium-review.googlesource.com/982261Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546949}

We are consolidating down to one script for running our perf tests, but
during migration that requires an additional isolate per isolate that we
run while we switch over to the new script.

Bug: 757933
Change-Id: I88c5cbd57bbc7751c3291f8e51f443bfebd87e7f
Reviewed-on: https://chromium-review.googlesource.com/983693Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546948}

As was pointed out in the attached bug, we don't need this anymore, and
can derive it from the other state the UI has.

BUG=803236
R=bshe

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4ad0d4ec40e0d7e7f22b72ba6918a9dcb6544a72
Reviewed-on: https://chromium-review.googlesource.com/984953
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546947}

In part of re-using once-created NGInlineItem to reduce the shaping,
this patch refactors NGInlineItemsBuilder to be stateless.

Instead, the collapsing type at the end of NGInlineItem is stored in
each NGInlineItem. NGInlineItemsBuilder uses it to determine
whitespace collapsing across NGInlineItems.

Because the cross-item collapsing can make the re-use more complex,
the algorithm is taken out from the main loop. We may need some
more iterations on this part to ensure cross-item whitespace
collapsing works correctly when we start re-using NGInlineItems.

Bug: 808100
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I3092729a7fcefe87a9e01f57ca74e5b402572a29
Reviewed-on: https://chromium-review.googlesource.com/984915Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546946}

Change-Id: I7f35f8125cbf1bb1bd4896e47ae6f77208d0ec90
Reviewed-on: https://chromium-review.googlesource.com/986885Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546945}

Bug: 758690
Change-Id: Iedd97eb384586d2fdde08abe3d173e7c95beb6b3
Reviewed-on: https://chromium-review.googlesource.com/985111Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546944}

This reverts commit b31c30d7.

Reason for revert: This has caused a regression in chromeos filemanager opening offline docs.  See http://crbug.com/826062

Original change's description:
> Fix auto reloading when a renderer is created without network.
> 
> Pass correct status of network to error handler's constructor.
> 
> R=​jam@chromium.org, juliatuttle@chromium.org
> 
> Change-Id: Ie48ab19418c87f20f0b441fbe1ab6d44a503da22
> Reviewed-on: https://chromium-review.googlesource.com/878327
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534685}

TBR=jam@chromium.org,juliatuttle@chromium.org,inverse12@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia05faf69b8170371d757661203cd14fdec01de01
Reviewed-on: https://chromium-review.googlesource.com/985592Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546943}

Printing out a FrameSink debug label is useful whenever we have a missing
surface and there's no reason why this should be behind a DCHECK_IS_ON
guard anymore.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I3adc1f35a6be640dfb3f04d8d19812f3ac5f68e6
Reviewed-on: https://chromium-review.googlesource.com/986749
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546942}

The interactions with the scrim are now in the bottom sheet's
controller rather than directly in the bottom sheet. This aligns with
the MVC architecture in that the sheet's controller handles
interaction with outside classes.

Bug: 826507
Change-Id: If6c410a6704c187169c91857dee412fd7fddc6c3
Reviewed-on: https://chromium-review.googlesource.com/982638
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546941}

The predictors database is cached in memory and can be flushed on disk
only periodically. This CL adds a delay before updating the predictors
database on disk.

Bug: 808036
Change-Id: I29a1376c131fa33cd946ffceb7e0480c3d38093b
Reviewed-on: https://chromium-review.googlesource.com/980876
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546940}

We were getting overlapping frames where the next frame's incoming SubmitFrame
got executed while the previous frame was still processing. This is inefficient
due to potentially introducing mid-frame flushes, and also confusing from a
code logic point of view.

To avoid this, defer an incoming SubmitFrame if we're not in a state where we
can handle it.

This also includes deferring SubmitFrame if the mailbox bridge isn't ready yet.
That way, we avoid having JavaScript produce frames which we end up discarding.
This should speed up the time-to-first-visible-frame a bit.

Change-Id: If20f05de7fe06c2a028d267b8ac8a2c38c488374
Reviewed-on: https://chromium-review.googlesource.com/985643
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546939}

Avoid a subtle issue in the PowerPrefs class where we can
unexpectedly suspend immediately after automatically locking
the screen as a result of switching to the set of shorter
while-locked inactivity delays. Instead, we hold off on
using the shorter delays until the screen has been turned
back on or manually turned off.

Bug: 807861
Change-Id: Ic5a6b74381c67666b7aed94d60d487eb77004658
Reviewed-on: https://chromium-review.googlesource.com/986461
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546938}

Move media::cast::UdpSocketClient to components/mirroring/service.
Also, extracted MockUdpSocket and MockNetworkContext to a separate file
to allow used by other tests (in a coming CL).

Purely codes moving and namespace changes. No behaviour change and no
new codes added.

Bug: 734672
Change-Id: Ie9f3573db885697204fb74b66a0f5e968d41e593
Reviewed-on: https://chromium-review.googlesource.com/982932Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546937}

Split the condition for calling BadMessageReceived() in order to
determine which of the two conditions is failing.

Bug: 827056
Change-Id: I142b3610847f7b33546c1fc7bf4f015e2b76f381
Reviewed-on: https://chromium-review.googlesource.com/986738Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546936}

These tests were broken a while ago, but seem to have been fixed.

Bug: 640068
Change-Id: Ic69c9736e6a5999dba2d3aee6bc00c30a1f7a7ce
Reviewed-on: https://chromium-review.googlesource.com/986538Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546935}

This experiment affects only http resources that
are fetched from a SPDY/H2/QUIC proxies.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifee25862f6720669536b0467c22218d0eb63b1f5
Bug: 826558
Reviewed-on: https://chromium-review.googlesource.com/907669Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546934}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia0fb4fd59d85169466e732fbd72eb2eb2addc693
Reviewed-on: https://chromium-review.googlesource.com/985984
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546933}

https://swiftshader.googlesource.com/SwiftShader.git/+log/5cd502b..f8cdc74

BUG=

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I4975860a520bb7757028c069981ead9d13dc23c2
Reviewed-on: https://chromium-review.googlesource.com/985899Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546932}

The callbacks are called on a different thread than the main thread.
Need to post them to main thread instead of directly handling it.

Bug: None
Test: locally build and run, no DCHECK crash
Change-Id: Ib08e5363348959e0702d80cac96c20f28975cd56
Reviewed-on: https://chromium-review.googlesource.com/985898
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546931}

They're broken pretty badly on windows.

Bug: 826735
No-Try: True
Change-Id: I65320b55b66d3780b542b8a0b521f72cee0f30f0
Reviewed-on: https://chromium-review.googlesource.com/986650Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546930}

Record whether DevTools is currently active in CrashKeys.

Bug: 824774
Change-Id: I697bf892037c63216890d9d5f7ccc67e037f3b19
Reviewed-on: https://chromium-review.googlesource.com/986453
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546929}

This reverts commit 07b2231e.

Reason for revert:

We need to be more conservative with plugin behaviour changes.
TODO: document the process, then attempt to re-land this change
via that process.

Original change's description:
> drop unnecessary realpath usage in the FindBadConstructs plugin
>
> All we need to do is ensure that there's a leading '/' in the path, we
> don't expect the path to exist necessarily, and we don't need to resolve
> symlinks.  We just want to be able to search for directories by doing a
> string search of the form "/foo/".  And since we don't use realpath
> anymore, this should work with distributed compilation systems like icecc.
>
> This will also avoid mis-classification of files in chromium checkouts
> that are inside a directory with the same name as one of the so-called
> "banned" directories, eg a checkout in /home/gen/chromium/.
>
> BUG=583454

Change-Id: Ic840387bb2244d967e66fd078684c56435fe940a
Reviewed-on: https://chromium-review.googlesource.com/986435Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#546928}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9952338f4a2faeaaec02d15a4917f9542ee57926
Reviewed-on: https://chromium-review.googlesource.com/985980
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546927}

Attempts to refill a form that was modified after an
initial fill if it respects these conditions:

- Only if the form is modified after a fill
- Only if the form is modified less than 1 second after
  the fill
- Only once per page
- Only refill group types that were filled initially
- Only if the form has the same "NameForAutofill"

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iaad7a49f8d0237fadacde590d473a9fcb3ae6323
Reviewed-on: https://chromium-review.googlesource.com/943251
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546926}