- 20 Jul, 2020 40 commits
-
-
Kenichi Ishibashi authored
This CL replaces old writers with new mojo-based writers in tests. Bug: 1055677 Change-Id: I68959e056092d2b6560067002b8ccfe466d8010a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306113Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790156}
-
Joshua Peraza authored
498c36b82a03 mac arm64: Provide something more useful from SystemSnapshot::CPURevison e3c94b87f0ef [fuchsia] Move //zircon/system/ulib/fdio to //sdk/lib/fdio fd001f792eb7 build: Make crashpad_dependencies="external" work in the GN build ef8a063055c6 Fuchsia: Propagate failure to initialize exception snapshot 06a688ddc1bc linux: setup a signal stack 9f66d569fb87 linux: put test attachment in temp directory 070b18d326b6 linux: fix alt-stack tests with asan Change-Id: Idcc5fd3ec95619844c36a505f4e2bafa6b13dcfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308850 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#790155}
-
Xianzhu Wang authored
Bug: 1104064 Change-Id: I518bc448da22853a2e58eb59b9373965d6dfb343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304989 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#790154}
-
Garrett Beaty authored
(cherry picked from commit b2d7d5eb3cab76d97b381040f217f82456d3b587) Bug: 1056428 Change-Id: I53a06c4fa23faec756e303372922eba774bd1c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298295Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/4195@{#4} Cr-Original-Branched-From: 1d94de40-refs/heads/master@{#785504} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303987 Cr-Commit-Position: refs/heads/master@{#790153}
-
Ayu Ishii authored
Migrate to more inclusive terminology. Bug: 1097275 Tbr: siggi@chromium.org Change-Id: I7546b5aa80b5d8e8c5dec24ec01b7e8053955ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258354 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#790152}
-
My Nguyen authored
This metric is used for Chrome OS Language Settings Update Bug: 1106033 Change-Id: Ifee2f391b02777108c8a6fedcbc38bb5c7c763f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302973 Auto-Submit: My Nguyen <myy@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#790151}
-
Eric Orth authored
When configuring NetworkService to do DNS in SECURE mode, override the configuration to allow up to two retries. The retries themselves aren't super important, but as the DNS stack lets the original request continue in parallel with retries, this has the overall effect of significantly increasing the effective timeout. Bug: 1105138 Change-Id: Id8aec72a555c3a0e1bafdf16333d4efdc59b39d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308037Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#790150}
-
chinsenj authored
When a user has a windowed app that can be fullscreened and they toggle overview, if they also toggle fullscreen fast enough it will cause visual glitches with overview mode(no blur, no opaque background, etc.) This CL addresses this by adding a check to HandleToggleFullscreen() to see whether the overview is in its start animation. If it is, the toggle fullscreen call is ignored. Otherwise, it proceeds normally. Test: AcceleratorControllerTest.DontToggleFullscreenWhenOverviewStarts Bug: 1094739 Change-Id: Ifff8afa39f238e2725220a0bbb4a92836ea1393d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303380Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#790149}
-
Lan Wei authored
Since we will not transfer user activation through post message to autoplay videos in a cross-origin subframe without any user activation. We will delete the ExperimentalAutoplayDynamicDelegation flag. Bug: 1067307 Change-Id: I183318d207c999fe7c97b7a8b1c9052866aaeec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291212Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#790148}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5efa529cc107..d71ded6e61c7 2020-07-20 ddorwin@google.com Update tests/presubmit.sh with modern syntax for Fuchsia bugs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2aa9a990b49f72b46fdd6f33137ce1d4f116153d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308364Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790147}
-
Anders Hartvoll Ruud authored
This was only needed for the pre-CSSCacade path, and can be now be removed. Change-Id: Ib4e93b1ac142abcddeb15f78be616efc75801e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299340 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790146}
-
Ben Pastene authored
Currently, CrOS HW tests will wait 10min for a device on an up-to-date OS, and fallback to a device running any OS after that. With crbug.com/1057152, we are now flashing the device to the right OS as part of the task. So we no longer need to wait so long for the right device when we can flash it ourselves. Flashing takes about 5min, so a 5min deadline maintains a 10min delay at the worst. This also moves the expiration value from an arg to a module constant since the arg was never passed, and likely won't ever be. Bug: 1057152 Change-Id: Ia66e714b02f9f4b6b0d011fd96a80f42d0294d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287954Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#790145}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/55e855496d00..49108a1283c3 2020-07-20 geofflang@chromium.org Support BGRA_1010102 IOSurfaces in CGL and Vulkan. 2020-07-20 cnorthrop@google.com Capture/Replay: Fix vertex array objects for MEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1100599 Tbr: timvp@google.com Test: Test: NBA2K20 MEC Change-Id: I019fba5b8aa45570bf9f9e578976bc33d2a618cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790144}
-
Mei Liang authored
crrev.com/c/2247404 removes two methods from StaticLayout that are explicitly plumbed through the layout system by acquiring through Observers: * onTabCreated * onTabModelSwitched The removal causes the TabStrip in Tablet to misbehave, since the TabStrip SceneOverlay is expecting those removed plumbed signals. This CL fixes the issue by replacing those signals with observers in the StripLayoutHelperManager. After the fix, those two plumbed signals can be removed completely from the SceneOverlay interface. So, this CL also removes those two signals. Change-Id: Ic53428e8cec934a034a065cb82e643cbfc0859f6 Bug: 1106752, 1100332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305374Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790143}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. This CL we should replace eventSender.mouseScrollBy with wheelTick which uses gpuBenchmarking.smoothScrollByXY in events/mouse-event-buttons-attribute.html. Bug: 1047176 Change-Id: Ife50b732a6ec0733e84b034c07565a4a5138b51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173614 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790142}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de55e0b54668..62a87ddd43fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tinazwang@google.com,karandeepb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1078815,chromium:1105530 Tbr: tinazwang@google.com,karandeepb@google.com Change-Id: I7cec952c87663a00d5e311ce00b60c26275cdff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308671Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790141}
-
Vikas Soni authored
Remove estimated_size from constructor of SharedImageBackingScopedHardwareBufferFenceSync. It is not required since estimated size is calculated from format and size. Bug: 1091945 Change-Id: I1f763eb9e19cc5a427b647edcf884e3dda37307e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307355 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#790140}
-
Mila Green authored
Bug: 1105589 Change-Id: I6d7e8b0b7858a4f1a538684758644f134318c0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298045 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790139}
-
Karandeep Bhatia authored
Skip the following tests on Mac as they seem to be failing consistently: * http/tests/devtools/tracing/timeline-layout/timeline-layout-with-invalidations.js * http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidations.js * http/tests/devtools/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.js BUG=1107572 TBR=tkent@chromium.org Change-Id: I75082401e41f2b11df3013b0b84349026d3094df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308519Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#790138}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3c13bf1fa865..026b1e2be09a 2020-07-20 aninditaghosh@google.com Merge "Load in trace_processor shell given file path to trace" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia751c6308d0c6119f6e8da6fecaf6b3824fc5ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790137}
-
Alex Cooper authored
This reverts commit 715c3a3a. Reason for revert: Fix Test Class setup Original change's description: > Revert "Update vr_pixeltests exceptions" > > This reverts commit 7da56cfe. > > Reason for revert: Test is still failing: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20(dbg)(1)/83673 > > Original change's description: > > Update vr_pixeltests exceptions > > > > https://crrev.com/c/2304097 updated the tests that originally required > > this exception to be added so that they now automatically skip/pass on > > Windows 7, so we don't need to keep these exceptions anymore. > > > > Bug: 1106809 > > Change-Id: Ia84e677ed9d6f74e040a24a73a0fa4a14720b778 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304936 > > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Auto-Submit: Alexander Cooper <alcooper@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#789684} > > TBR=thakis@chromium.org,alcooper@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1106809 > Change-Id: Id8a98cce9da8ec8933e75686718f92e7b7ec2d15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307011 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789861} TBR=thakis@chromium.org,aboxhall@chromium.org,alcooper@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1106809 Change-Id: Ia8e1f6261091de3bde7de3f55d4ea77771c1a59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307636 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#790136}
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/5f43fedcddba..747e80a9b369 $ git log 5f43fedcd..747e80a9b --date=short --no-merges --format='%ad %ae %s' 2020-07-20 dneto [spirv-reader] Drop NonWritable NonReadable for now 2020-07-20 rharrison Fix issues with BUILD.gn 2020-07-20 dsinclair [msl-writer] Cleanups and refactors. 2020-07-20 dsinclair [msl-writer] Handle uniform buffers. 2020-07-20 dneto [spirv-reader] Support DescriptorSet and Binding 2020-07-20 dneto [spirv-reader] Handle old-style storage buffers 2020-07-17 dneto Rolling 6 dependencies 2020-07-16 dneto [spirv-reader] Support Location on module vars 2020-07-16 dneto [spirv-reader] Ignore empty string user names Created with: roll-dep src/third_party/tint/src Change-Id: I02397ad4a90cc8e31a6706d2e8258a3076728691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308453 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#790135}
-
Sammie Quon authored
NotificationMD already had a clip installed previously, so the mask code was never called, so its safe to just delete. ScrollArrowView has only one override ScrollableScrollArrowView which turns of ink drop ripples and highlights, so its safe to remove the ink drop codes. Test: manual Bug: 1056490 Change-Id: I3e4b068f3e819901b1da7d4ab42bc74e62a0295f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308450Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790134}
-
Kristi Park authored
Fix symbol not found error for org.chromium.base.annotations.UsedByReflection Change-Id: I7505cfe99a276ba6083f82521bb9f8c86cc7509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309132 Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#790133}
-
Alexander Cooper authored
All code that previously referenced this feature has been removed, as the feature is now fully enabled. The flag wasn't removed with the code as I mistakenly believed that there were some finch configs that needed updating/removing that couldn't be updated/removed until Chrome stable had the flag enabled by default; however, after re-reading documentation it seems as though the corresponding finch configs should be left alone. This thus just removes the feature entry which is no longer doing anything. Fixed: 1090108 Change-Id: Iaf3a6121914be83ae72179bc0e89fa60a2d921f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308036 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#790132}
-
rbpotter authored
Adding closure targets for: destination_select_test destination_search_test destination_search_test_chromeos Bug: 1000989 Change-Id: Iac91004ee5b78120f2a894194a28a13f7626ca1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303875Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#790131}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I27938446752d625ed487061459879409a5eddd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308452Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790130}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Ib9e97d0404d003c21fa1d2e1b6b5bcfdc7bad1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293008Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#790129}
-
Dave Tapuska authored
In order to move the RenderWidget handling of this message we must first move the message then we can progressively move the implementation. BUG=1097816 Change-Id: I8dbc29902fd0062f03ff938af4d56a16446d54df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302912 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790128}
-
Vasiliy Telezhnikov authored
This CL adds requests queue to FrameInfoHelperImpl to make sure all requests are ordered to keep VideoFrameFactoryImpl pipeline ordered. Before this change VFFI would cache FrameInfo to avoid thread hops to GPU thread and it was possible that some CreateVideoFrame requests will be completed out-of-order. After this change VFFI doesn't cache FrameInfo and always call FrameInfoHelper. FrameInfoHelper does all necessary caching to avoid unnecessary hops to GPU thread and guarantees that callbacks with FrameInfo will come in order. Change-Id: Iacb63cf3746991c911f1f0d5e3667db3dbd56c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304092 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#790127}
-
Jan Wilken Dörrie authored
This change prepares //net for the switch of base::string16 to std::u16string on all platforms. This was achieved by making net_unittests compile on Windows after the switch was made. Furthermore, it fixes small issues in //base and //sql. Bug: 911896 Change-Id: I11fd80998e9f5e954a87870533685a3f77fa42d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303431 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790126}
-
Kevin Marshall authored
Allow each fuchsia.web.Context's browser process to delegate the ambient-executable capability to child processes, but not to use the capability itself. Bug: 1106561 Change-Id: I886263daec4c4aea7fd3eb80dd5ab6c46a400cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303978Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#790125}
-
Jun Mukai authored
ash_shell (and ash_shell_with_content) were introduced for quick-checking of ash behaviors, as it's fast to build. However, it's not used by many people, and I've noticed that it's broken in many ways. I believe no one is using it actually, so I think it's the time to remove it at all. ash_ui_perftests, which depends on ash_shell_lib_with_content, is also removed, as it was introduced for a purpose but isn't used actually. Bug: none Test: build passes Change-Id: I68d4de5b0172f51240a99e61facbe4f7ee606ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307909Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#790124}
-
Michael Spang authored
This reverts commit 0fc9ef09. Reason for revert: This no longer compiles, the flag is removed from our build after 0f1575a6 ("media/chromeos: refactor flags enabling new VideoDecoder"). Probably it's no longer needed. Original change's description: > chromecast: force disable new accelerated video decoder > > The new accelerated video decoder uses V4L2SliceVDA, which is > not supported by Cast devices. > > So instead, we will force disable use of this new decoder > through command line switch, which will fallback to use > VdaVideoDecoder, which uses V4L2VDA. > > Bug: b/158230739 > Test: Verify mirroring on Cast display devices > Change-Id: I7765e6861c09a0357e2d923a20c9a56c1bdcb065 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238876 > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Commit-Queue: Peter Qiu <zqiu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776861} TBR=zqiu@chromium.org,halliwell@chromium.org,tguilbert@chromium.org,seantopping@chromium.org,yucliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/158230739 Change-Id: Idaac0f78fc54b6fb4bf0d2f028ad5be96cfd7ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306377Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790123}
-
Charlie Harrison authored
A previous change ensured that large custom cursors > 32x32 would be dropped if they are not fully contained with the visual viewport. However, the computation did not account properly for OOPIFs, where cursor coordinates were not adjusted to the viewport offset. This CL further adjusts the cursor rect by translating it to the root view's coordinate space via LocalToAncestorPoint, before checking for containment within the visual viewport. Bug: 1099276 Change-Id: I0a03e7cc249cd785f9e76f931cfc7931b127d56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278597 Auto-Submit: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#790122}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: I7c230f4a72a7bfccec5ad48c70aa8a39a099342e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292707Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#790121}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ade0fed37fc7..6caaa1da7bfa 2020-07-20 bsheedy@chromium.org [Telemetry] Log screenshot output on failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106927 Tbr: sadrul@google.com Change-Id: Id15637220783b5da66311458cb7e83155b592a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790120}
-
Xi Han authored
Bug: 1103838, 1092642, 1076274 Change-Id: I6bf58ef38c834ce15fae04f0743f646fcb98970f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290755Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790119}
-
Peter Boström authored
Bug: None Change-Id: Ib88ea119296aa359d03aad85a864bd203464fdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308691 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#790118}
-
Maxime Charland authored
This CL adds a label in the Recently Closed section of the Recent Tabs view to tell users this is where they will see tabs they recently closed. (Googlers only links) Screenshot: https://drive.google.com/file/d/1oKVGpIV26NS2Tb4GF1kWJZV0RItwsiFk/view?usp=sharing Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: If33b1f650e978f1aca4260e9f76682f4defd8e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297919 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790117}
-