- 18 Mar, 2018 9 commits
-
-
Darren Shen authored
We're currently using InputMethodManager in the Wayland server to observe changes in the keyboard layout. However, under mash, exo will be in the ash process and InputMethodManager will be in the chrome process, so we cannot depend on InputMethodManager from the Wayland server. We remove the use of InputMethodManager in the Wayland server for observing keyboard changes by using ImeController instead, which uses Mojo for communication. We also add a way of retrieving the current keyboard layout from ImeController. This is a similar design to how ImeController handles caps lock, but it's simpler because we never need to set the layout from ash side. Changes to layout on the chrome side just propagate to the ash side from ImeControllerClient to ImeController. Bug: 772382 Change-Id: I84df1ee1b7e0f54716125fec9d4cd49f3442ed79 Reviewed-on: https://chromium-review.googlesource.com/961505 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#543958}
-
David 'Digit' Turner authored
The process_resources() GN template and the associated process_resources.py script are huge and difficult to understand because they can be used to perform two slightly related different things. In preparation for a future CL that will introduce a new resource compilation mode, this CL tries to clarify the situation by splitting them into two sets of GN template + script: - prepare_resources() + prepare_resources.py, which are used to create .resources.zip archives of raw/uncompiled resources for resource related targets, as well as generating a corresponding R.txt and .srcjar(R.java) file. This corresponds to what process_resources() did when it was called from android_resources() and junit_binary(). Note that this always generates non-final resource IDs, as well as a dummy onResourcesLoaded() method, necessary to compile, but not link, the ResourceRewriter class used to implement the system webview feature. - compile_resources() + compile_resources.py, which are used to compile all resource dependencies of a given binary (e.g. android_apk) into an intermediate .ap_ file. This corresponds to the behaviour of process_resources() when called from android_apk(). This generates final resource IDs by default, unless |shared_resources| or |shared_resources_whitelist| is used. Also, as a simplification, |shared_resources_whitelist| now implies |shared_resources|, except that it restrict the list of non-final resource IDs. - Removed generate_constant_ids, since compile_resources() will always generate constant ids unless shared resources are being used. And prepare_resources() always generates non-constant IDs, as before the CL. + Add documentation for the prepare_resources() and compile_resources() internal GN rules, to make them a little less intimidating. + Removed |app_as_shared_lib|, since even before this CL all resources were generated with package ID 0x7f anyway, or fixed a compile_resources() time. Hence |shared_resources| did the exact same thing. + Improve --help output for prepare_resources.py and compile_resources.py by using option groups for inputs and outputs. R=agrieve@chromium.org,yfriedman@chromium.org,estevenson@chromium.org,trevordixon@chromium.org Bug: 820459 Change-Id: If05ac24a57c4dfa11f9ce43c30ab22e957b2765d Reviewed-on: https://chromium-review.googlesource.com/957095 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#543957}
-
https://skia.googlesource.com/skia.git/+log/38c3d93810d7..a7b84c5a50da $ git log 38c3d9381..a7b84c5a5 --date=short --no-merges --format='%ad %ae %s' 2018-03-18 caryclark fix fiddle example Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I6d94d5c4b4029105372a7af9b9afde2f3343eec3 Reviewed-on: https://chromium-review.googlesource.com/967900Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543956}
-
Justin Novosad authored
The purpose of this change is to prevent the re-occurrence of flaky rendering bugs caused by missing calls to GrContext::resetContext. This change uses a new subclass of GLES2Implementation called GLES2ImplementationWithGrContextSupport, which takes care of calling GrContext::resetContext() whenever the gl state is changed. These calls are lightweight: they just perform an 'or' on an integer. To avoid calling GrContext::resetContext() when gl calls are made from within skia, the bindings were modified in CreateGLES2InterfaceBindings in order to signal the GLES2ImplementationWithGrContextSupport so that it knows the the current GL call is made from skia. Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I59470a8188df235a36d6de0e9aaff57b69ff9d6a Bug: 807974, 810159 Reviewed-on: https://chromium-review.googlesource.com/924616 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543955}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=stevenjb@chromium.org Change-Id: I23c215ddf53e773d05ef31b5d87ea6687bb59f5d Reviewed-on: https://chromium-review.googlesource.com/967884Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#543954}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I808a20a4eebf9c5e1089050f7711b1f1de304ccb Reviewed-on: https://chromium-review.googlesource.com/967883Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543953}
-
yiyix authored
As the Finch trial for draw occlusion has successfully completed, remove all metrics that added for collecting user data, including Display.Draw.Quads.Resized, Display.Draw.Quads.Skipped, Display.Draw.Quads.Smaller, Display.Draw.Quads.With.Complex.Transform, Display.Draw.Quads.With.Complex.Transform.Area. Bug: 672929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I792cec955827a04e9a39968beb685f121b0669db Reviewed-on: https://chromium-review.googlesource.com/967061Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#543952}
-
Weiliang Chen authored
LayerImpl has IsActive function to check if layer is on active tree. Use that function instead of the PictureLayerImpl's GetTree function. R=danakj Bug: 822873 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I169e9ccbca359cc56cb48a7b3587d8bd2f5b753c Reviewed-on: https://chromium-review.googlesource.com/967268 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ie07ed3765cd857e540f6427f70c9b7153b318f9b Reviewed-on: https://chromium-review.googlesource.com/967880Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#543950}
-
- 17 Mar, 2018 31 commits
-
-
David Reveman authored
We should not be generating keyboard press events when a key is already pressed. Fix this issue by restoring the "pressed keys" set in the Keyboard class. Seat is still tracking pressed keys in order to ensure that accelerator key presses are not lost. Bug: 820641 Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardKey Change-Id: I56c7110361c0894f3fd8d882c45c1d2bfe3d634f Reviewed-on: https://chromium-review.googlesource.com/967727 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#543949}
-
Jay Civelli authored
Now that it uses a Mojo service, SafeMediaMetadataParser can be simplified as it does not require thread hops. Which also means it does not need to be ref counted anymore. Also changed Bind calls to BindOnce where appropriate. Bug: 822922 Change-Id: Id684d9e7bb52f11f19d992f0d5dcb80c8d7e4770 Reviewed-on: https://chromium-review.googlesource.com/967364 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543948}
-
Weiliang Chen authored
This function is only called on tests, and it goes to effect tree to get correct information. Remove this from LayerImpl. R=danakj Bug: 822873 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I21e13b32de44a5a5c50fbdc5029f2fe620a17e09 Reviewed-on: https://chromium-review.googlesource.com/967089Reviewed-by:
-
Findit authored
This reverts commit 33cfbf08. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 543944 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMzY2ZiZjA4ODFlYmU3ZWQyMGRhNmU2ZjU2M2M3YjQ1YTkzNDRhNDMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4761 Sample Failed Step: compile Original change's description: > Add Chrome OS Account Manager > > - Loads Login Scoped Tokens (LSTs) from disk to memory > - Persists updates to LSTs to disk > > Design doc is linked in the bug id. > This CL creates the core of Account Manager and its ability to load > and persist its state. > Follow up CLs will: > - Link it with OAuth2TokenService via an OAuth2TokenServiceDelegate. > - Add UI components to modify Account Manager's state. > > Bug: 820046 > Change-Id: I1b43e11cfc7ed3592daf4a79ff664d377644f6a8 > Test: chromeos_unittests --gtest_filter="*AccountManager*" > Reviewed-on: https://chromium-review.googlesource.com/955523 > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543944} Change-Id: Idd138c68b9de07ed160651c3a948aceb8fb5d92e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820046 Reviewed-on: https://chromium-review.googlesource.com/967467 Cr-Commit-Position: refs/heads/master@{#543946}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd20cd72..6887bb98 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2fddf6ffe24f6f49f58a7744828924e485ba7e32 Reviewed-on: https://chromium-review.googlesource.com/967730Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543945}
-
Kush Sinha authored
- Loads Login Scoped Tokens (LSTs) from disk to memory - Persists updates to LSTs to disk Design doc is linked in the bug id. This CL creates the core of Account Manager and its ability to load and persist its state. Follow up CLs will: - Link it with OAuth2TokenService via an OAuth2TokenServiceDelegate. - Add UI components to modify Account Manager's state. Bug: 820046 Change-Id: I1b43e11cfc7ed3592daf4a79ff664d377644f6a8 Test: chromeos_unittests --gtest_filter="*AccountManager*" Reviewed-on: https://chromium-review.googlesource.com/955523 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543944}
-
Daniel Cheng authored
Bug: 822832 Change-Id: If46f840560b99b9dbc5c10ae7656df51c3083d1b Reviewed-on: https://chromium-review.googlesource.com/967013 Commit-Queue: Ojan Vafai <ojan@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543943}
-
Julien Isorce authored
This reverts commit ed312194. Reason for revert: It should have been "gpu_info.gl_vendor" instead of "gpu_info.driver_vendor" Original change's description: > Skip GpuOESEGLImageTest on ATI proprietary driver > > Detect the GL_VENDOR string from the default GL implementation. > If it is the ATI proprietary driver then do not switch to EGL/GLES2 > as there is a known bug and this driver crashes in eglInitialize > instead of failing properly. > > BUG=822716 > > Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I00b883012c31867f938bf3f68440058738bb312b > Reviewed-on: https://chromium-review.googlesource.com/966662 > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543735} TBR=kbr@chromium.org,cwallez@chromium.org,piman@chromium.org,julien.isorce@chromium.org Change-Id: I88454724ed1a39688f18278404ea28d978b1331d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822716 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/967821Reviewed-by:
Julien Isorce <julien.isorce@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#543942}
-
https://skia.googlesource.com/skia.git/+log/876dd31483bc..38c3d93810d7 $ git log 876dd3148..38c3d9381 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 egdaniel Don't emit empty command buffers in vulkan Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ia7a76ca236ddd37faa89a6ffdb6646f35a86a85d Reviewed-on: https://chromium-review.googlesource.com/967726 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=alemate@chromium.org Change-Id: I38aeda14a35b2f61590a0bc4ef940d89e60dcfb1 Reviewed-on: https://chromium-review.googlesource.com/967728 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
-
Daniel Bratell authored
There is a common helper method IsTouchOptimized() that is a shortening of ui::MaterialDesignController::IsTouchOptimizedUiEnabled(). That helper method is placed in anonymous namespaces which are merged in jumbo builds, causing clashes. Alternatives are to find a shared location for this method (maybe in //ui?) or inline it. This patch inlines it. Bug: 803406 Change-Id: Ia389432bfdb506d27b625c916a9baf73b7b70f30 Reviewed-on: https://chromium-review.googlesource.com/966204Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#543939}
-
Daniel Bratell authored
There are two different kTextContexts in chrome/browser/ui, living in different namespaces that in jumbo builds become the same namespace. This patch renames them so that they have unique names. This affects Opera builds but not Chrome builds yet since jumbo is not yet supported in chrome/browser/ui in Chrome. Bug: 803406 Change-Id: I3354881b9dedae9499356800cbaed4de3cc0da4c Reviewed-on: https://chromium-review.googlesource.com/966202Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 90fd0807. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13931 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=qyearsley No-Export: true Change-Id: Ia4bbca97799972b46cc9f468d6471b711642f216 Reviewed-on: https://chromium-review.googlesource.com/967725 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543937}
-
Harald Alvestrand authored
This test would hang if anything ever went wrong, because failures were not being checked. Rewrote the test to always use failure callbacks. Also switched to using rtcp-mux. Tested by 120 runs on workstation. Bug: chromium:452623 Change-Id: Ie73c32edf22b4ca40e9f5e01b9e9fe5cc054623f Reviewed-on: https://chromium-review.googlesource.com/967761 Commit-Queue: Harald Alvestrand <hta@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543936}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I81e01c6caf7b28c878f2271ab68f8edb7c00603b Reviewed-on: https://chromium-review.googlesource.com/967724Reviewed-by:
-
Vaclav Brozek authored
pylint reports a number of issues for PRESUBMIT.py. One of them is a real error (using an undefined variable instead of a file name), the rest just nits. Still, good to fix them all to allow pylint discover new failures easily in the future. Bug: 821981 Change-Id: I857be0b4072bfe41687c52d38335d5efebcc952f Reviewed-on: https://chromium-review.googlesource.com/966502 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Change-Id: Ibff3db80b7da087e0ea7870e1ac445bdfd3c81c0 Reviewed-on: https://chromium-review.googlesource.com/967006 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543933}
-
Sandeep Vijayasekar authored
Test: Build cast shell Bug: internal b/69007670 Change-Id: I1771fe2f7112da7f80d2b8c345bb63beca92b9d2 Reviewed-on: https://chromium-review.googlesource.com/967519 Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#543932}
-
https://webrtc.googlesource.com/src.git/+log/cdd2a97f5af1..8a1b20a21329 $ git log cdd2a97f5..8a1b20a21 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4ba5fb4997647bd36c4685c1099914f48c898ec0 Reviewed-on: https://chromium-review.googlesource.com/967661 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543931}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f2ff9cbcb973..d49af833556c $ git log f2ff9cbcb..d49af8335 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 gmeinke cbuildbot: add firmware key-id to metadata.json Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I58a06e0453b6154ccc0244975d63e3a20c031f0e Reviewed-on: https://chromium-review.googlesource.com/967606Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543930}
-
Koji Ishii authored
BlockPainter::PaintChild() calls LayoutBox::FlipForWritingModeForChild() which subtracts X() twice, so that child painter can add flipped block physical offset. Because LayoutNG does not apply flipped block to its Offset(), this resuts in incorrect paint offsets. I think ideally paint should be able to handle without flipped block throughout all painters, but I don't have enough knowledge to switch to, or to add, such a mode to all painters at this point. This patch matches NGBoxFragmentPainter's semantics to existing painters for flipped block physical coordinate. ~120 tests pass, ~10 new failures, but remaining failures indicate that paint offset needs more fixes. The semantics for floats, abspos, tables, etc. are not clear yet to me. Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I35857fff030452dc618a529a5c45169e6fac378b Reviewed-on: https://chromium-review.googlesource.com/966047 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543929}
-
Tom Anderson authored
This cl adds an additional condition of use_sysroot=true to enable the app shell installer. This matches the Linux condition [1]. This is needed to fix gn bootstrap for Chromium packagers, who build without the sysroot. [1] https://cs.chromium.org/chromium/src/chrome/installer/BUILD.gn BUG=822321 Change-Id: Iae8ba0576525a51a3be91960deb939c760c80b86 Reviewed-on: https://chromium-review.googlesource.com/966967Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543928}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: If18e023f64654b3d5dcc2b5cb86649fb138c0d20 Reviewed-on: https://chromium-review.googlesource.com/967607Reviewed-by:
-
Xiaohui Chen authored
Bug: 822456 Test: ldd can resolve locally build library Change-Id: If5125576ce1c9a26e47ae98f6576a1f2371920c4 Reviewed-on: https://chromium-review.googlesource.com/963599 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543926}
-
Tarun Bansal authored
Bug: 821974 Change-Id: Icceeabb2e31c702341d898193f5ad6870b2d3f1e Reviewed-on: https://chromium-review.googlesource.com/967095 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#543925}
-
https://webrtc.googlesource.com/src.git/+log/317a5228766f..cdd2a97f5af1 $ git log 317a52287..cdd2a97f5 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I61e4328cbf06d04bdd346dbcd910b140961f7b4c Reviewed-on: https://chromium-review.googlesource.com/966970Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ad8f333d567..f2ff9cbcb973 $ git log 3ad8f333d..f2ff9cbcb --date=short --no-merges --format='%ad %ae %s' 2018-03-13 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." Created with: roll-dep src/third_party/chromite BUG=821615 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I15450adb1a013377fa94601083205f8316ad3000 Reviewed-on: https://chromium-review.googlesource.com/967515Reviewed-by:
-
Gabriel Charette authored
Scripted cleanup for upcoming CL. Removes browser_thread_impl.h from all files that didn't have "BrowserThreadImpl". TBR=jam@chromium.org Bug: 815225 Change-Id: Ica66babda894ef3f43981227f48e84f659a57897 Reviewed-on: https://chromium-review.googlesource.com/967545Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543922}
-
Karan Bhatia authored
This reverts commit 1f76c848. Reason for revert: WebViewTests/WebViewTest.DownloadCookieIsolation_CrossSession/0 is flaky with network service. Original change's description: > Fix webview tag's using an on-disk directory with the network service enabled. > > Bug: 769401 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ia9ad46583b00f88631eccbc65c23cf6864134f26 > Reviewed-on: https://chromium-review.googlesource.com/965921 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543837} TBR=creis@chromium.org,jam@chromium.org,mmenke@chromium.org Bug: 769401, 822999 Change-Id: I0feb3dcddc8c7a767b1026c9f3a206419ab89225 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/967056Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543921}
-
Avi Drissman authored
It's unclear how much the "Start Speaking" on the whole page is used. It was implemented only three years ago and has never worked correctly. It's not clear what it even means to speak the entire web document for modern web pages. However, this makes a decent attempt at doing so. BUG=659753, 584798, 585164, 819773 TEST=as in 659753 Change-Id: I252f38c7c7879173c3c4e0afd9dc3a42c81b8a64 Reviewed-on: https://chromium-review.googlesource.com/956029Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543920}
-
Karan Bhatia authored
BUG=821547 TBR=hajimehoshi@chromium.org Change-Id: I6be988b01770624e793d5571e2dc37400e99c0bd Reviewed-on: https://chromium-review.googlesource.com/967511 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
