GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=184229

BUG=421001
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/672133002

git-svn-id: svn://svn.chromium.org/blink/trunk@184233 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yhirano
BUG=412705

Review URL: https://codereview.chromium.org/675453002

git-svn-id: svn://svn.chromium.org/blink/trunk@184232 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a set of trace events to track reason when RuleFeatureSet
schedules StyleInvalidator invocations.
These schedules are later consumed by StyleInvalidator to setNeedsStyleRecalc
for nodes invalidated by the selector changes.

These trace events are postprocessed in devtools and connected to StyleInvalidator
invalidate events by joining their DescendantInvalidationSet ids.

BUG=410701

Review URL: https://codereview.chromium.org/664033002

git-svn-id: svn://svn.chromium.org/blink/trunk@184231 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The signature of Window's postMessage is message, target origin,
transferables; not message, transferables, target origin.

https://html.spec.whatwg.org/multipage/comms.html#dom-window-postmessage

BUG=

Review URL: https://codereview.chromium.org/651603004

git-svn-id: svn://svn.chromium.org/blink/trunk@184230 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Depending on the frame results in a crash inside <template> tags, which don't have one.

BUG=421002

Review URL: https://codereview.chromium.org/654583003

git-svn-id: svn://svn.chromium.org/blink/trunk@184229 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Doing so removes a FrameLoader-reachable Persistent reference to
a DocumentState.

R=
BUG=340522

Review URL: https://codereview.chromium.org/639023004

git-svn-id: svn://svn.chromium.org/blink/trunk@184228 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch enables the inspector to issue a warning when developers add a event handler after an initial evaluation of the ServiceWorker script.

BUG=401870
TEST=manually

Review URL: https://codereview.chromium.org/657213004

git-svn-id: svn://svn.chromium.org/blink/trunk@184227 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/672063002

git-svn-id: svn://svn.chromium.org/blink/trunk@184225 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=184220

BUG=425008
TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/668273004

git-svn-id: svn://svn.chromium.org/blink/trunk@184224 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch preloads "sources" panel in edit-dom-actions initializer in
order to support "Edit as HTML" action.

R=pfeldman

Review URL: https://codereview.chromium.org/675473002

git-svn-id: svn://svn.chromium.org/blink/trunk@184223 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 * Use standards mode.
 * Adjust test slightly to make ref easier to make.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/655253004

git-svn-id: svn://svn.chromium.org/blink/trunk@184222 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove _builder_statuses_with_names_matching_regexps from buildbot.py
because it isn't used anymore

Review URL: https://codereview.chromium.org/670933002

git-svn-id: svn://svn.chromium.org/blink/trunk@184221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=425008

Review URL: https://codereview.chromium.org/671963002

git-svn-id: svn://svn.chromium.org/blink/trunk@184220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves the SVG inline flow box paint code to
SVGInlineFlowBoxPainter. This is a straight code move with no changes.

BUG=412088

Review URL: https://codereview.chromium.org/671943004

git-svn-id: svn://svn.chromium.org/blink/trunk@184219 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Motivation:
1) Getters are evil
2) "type" is too generic
3) "contentType" method returns exactly the same value.

BUG=

Review URL: https://codereview.chromium.org/667743002

git-svn-id: svn://svn.chromium.org/blink/trunk@184218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Optimize layout and painting by avoiding or short-circuiting vertical
writing mode logic unless it is used at least once in a document.

A per-document containsAnyVerticalWritingModes flag is introduced that
is set the first time a vertical writing mode is encountered. Unless
this flag has been set all flipForWritingMode functions short-circuit.
Some of the RenderBox flip methods is moved to the header file to allow
for better inlining.

Early testing indicates a ~10% performance improvement across the board
with 35 of our 42 layout performance tests showing a 6% to 19%
performance improvement. The remaining 7 tests show no significant
improvement and none of them show any regression.

R=dglazkov@chromium.org, pdr@chromium.org
BUG=425364
TEST=PerformanceTests/Layout

Review URL: https://codereview.chromium.org/669803002

git-svn-id: svn://svn.chromium.org/blink/trunk@184217 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424914

Review URL: https://codereview.chromium.org/667263002

git-svn-id: svn://svn.chromium.org/blink/trunk@184216 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds DescendantInvalidationSet "id" field in
invalidation tracking trace events.
This id will be used to join ScheduleStyleInvalidation
events and StyleInvalidatorInvalidation events in devtools.

ScheduleStyleInvalidation events are to be added in a
separate CL: https://crrev.com/664033002

BUG=410701

Review URL: https://codereview.chromium.org/669033002

git-svn-id: svn://svn.chromium.org/blink/trunk@184213 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds style recalc invalidation tracking to the invalidation
tracking experiment. Our full design doc is at:
https://docs.google.com/document/d/1BXT3_gD--YdbIYMlTzNGsyUUMBCZJ7V5qGJhMA-pGrs/edit

This patch implements the invalidation tracking logic for style recalc
events. All style invalidations are recorded and when a style recalc
occurs they are collected and displayed to the user. Additional
style invalidation information (e.g., detailed reasons) will be added
in a followup.

The existing invalidation tests have been renamed because they are
only for paint events. A new test has been added for style recalc
events.

BUG=410701

Review URL: https://codereview.chromium.org/653283005

git-svn-id: svn://svn.chromium.org/blink/trunk@184212 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/670073004

git-svn-id: svn://svn.chromium.org/blink/trunk@184211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is interesting bug from slashdot.org. When the page is first loaded,
it has a js scroll call but a NaN scroll position is passed in.

We used to have IntPoint representing scrollPosition, and the scroll position
goes as:
double(NaN) -> static_cast<int> -> int(LONG/INT_MIN) -> adjusted to 0
and it happens to work that page is not scrolled with NaN scroll position.

Now that we change to use DoublePoint to represent scroll position, the NaN
value eventually gets adjusted to be the maximal scroll position and the page
will scroll to the bottom when loaded.

Instead of depending on the nasty conversion rule of NaN, lets make it specific
that if NaN is passed in, just early out in the scrolling path.

BUG=424987

Review URL: https://codereview.chromium.org/670833002

git-svn-id: svn://svn.chromium.org/blink/trunk@184210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=sigbjornf@opera.se
BUG=426078

Review URL: https://codereview.chromium.org/671983002

git-svn-id: svn://svn.chromium.org/blink/trunk@184209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a compressor node is in the active signal chain. the reduction
(.reduction) value returns the reduced amount of gain from
the compression. However, when user requests the reduction value after
the signal chain is deactivated (i.e. a source node stops), the returned
value is the last calculated in the compressor. This value should be
zero since there is no incoming audio signal.

Repro case:
http://jsfiddle.net/hoch/k5e3meuL/1/

Related StackOverflow post:
http://stackoverflow.com/questions/26413675/how-to-fix-frozen-div-when-using-compressor-reduction-value-to-monitor-compressi

BUG=425616

Review URL: https://codereview.chromium.org/645853010

git-svn-id: svn://svn.chromium.org/blink/trunk@184208 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=True
TBR=rune@opera.com
BUG=425552

Review URL: https://codereview.chromium.org/674543003

git-svn-id: svn://svn.chromium.org/blink/trunk@184207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Signal WorkerThread termination earlier (patchset #1 id:1 of https://codereview.chromium.org/667813003/)

Reason for revert:
This seems to cause a crash: http://crbug.com/426063

Original issue's description:
> Signal WorkerThread termination earlier
> 
> This CL resolves a race in WorkerThread::cleanup.
> workerThreadTerminated() notification may release a reference to the WorkerThread instance, that causes race between the termination signal.
> 
> BUG=405420
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184061

TBR=haraken@chromium.org,aandrey@chromium.org,sigbjornf@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=405420,426063

Review URL: https://codereview.chromium.org/671913003

git-svn-id: svn://svn.chromium.org/blink/trunk@184206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Extending more existing suppressions to the virtual test suite.

TBR=aboxhall

Review URL: https://codereview.chromium.org/676503002

git-svn-id: svn://svn.chromium.org/blink/trunk@184205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/654753003

git-svn-id: svn://svn.chromium.org/blink/trunk@184203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 * Make test small enough to fit in content_shell. (Only the baselines for
   the -webkit-writing-mode versions were incorrect, though).
 * Used explicit column-gap to simplify ref.
 * Used even-size column-rule to simplify ref.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/670473002

git-svn-id: svn://svn.chromium.org/blink/trunk@184202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It can happen that the first data chunk for a large script is small. To handle
this, we don't give up with streaming immediately when we receive a small data
chunk, but simply delay the decision to start the streaming.

See crbug.com/425475 for discussion about when this can happen.

BUG=

Review URL: https://codereview.chromium.org/655263003

git-svn-id: svn://svn.chromium.org/blink/trunk@184201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=420022

Review URL: https://codereview.chromium.org/672613002

git-svn-id: svn://svn.chromium.org/blink/trunk@184200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Timing out following chromium r300644, but this looks like a test-only
failure due to invalid cert in the localhost HTTPS server.

BUG=426047
TBR=aboxhall@chromium.org,horo@chromium.org

Review URL: https://codereview.chromium.org/668773003

git-svn-id: svn://svn.chromium.org/blink/trunk@184199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=184190

BUG=417409
TBR=dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/674563002

git-svn-id: svn://svn.chromium.org/blink/trunk@184198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=mkwst
BUG=426041,424178

Review URL: https://codereview.chromium.org/656633003

git-svn-id: svn://svn.chromium.org/blink/trunk@184197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=425976

Review URL: https://codereview.chromium.org/649633005

git-svn-id: svn://svn.chromium.org/blink/trunk@184196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

to allow implicit 'import site' by the python runtime.

NOTRY=true
BUG=425932

Review URL: https://codereview.chromium.org/674503002

git-svn-id: svn://svn.chromium.org/blink/trunk@184195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If shift is held when dragging starts on the flame chart rectangle selection box will be drawn for the selected region. Selected range duration will be printed at the left top corner of the rectangle with precision of 0.01 ms.

BUG=407113

Review URL: https://codereview.chromium.org/665423003

git-svn-id: svn://svn.chromium.org/blink/trunk@184194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/653613002

git-svn-id: svn://svn.chromium.org/blink/trunk@184193 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424599

Review URL: https://codereview.chromium.org/667423002

git-svn-id: svn://svn.chromium.org/blink/trunk@184192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=skia:2889

Review URL: https://codereview.chromium.org/660083002

git-svn-id: svn://svn.chromium.org/blink/trunk@184191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

"copy" also needs temp layer, but we optimized it via clearing the canvas.
It's why we missed handling "copy" when we fix the bug related to shadow with "source-in".
This CL optimizes shadow with "copy" by not-drawing a shadow.

TEST=layout test fast/canvas/canvas-composite-shadow.html
BUG=417409

Review URL: https://codereview.chromium.org/672593002

git-svn-id: svn://svn.chromium.org/blink/trunk@184190 bbb929c8-8fbe-4397-9dbb-9b2b20218538