GitLab

- UI part of ProxyConfigServiceImpl is moved to UIProxyConfig and UIProxyConfigService.
- ProxyConfigServiceImpl uses NetworkStateHandler instead of NetworkLibrary except for the legacy migration of device proxy settings.
- UI code continues to use NetworkLibrary for now.

BUG=234982
TBR=willchan@chromium.org (for trivial but reviewed change in net/proxy/proxy_config.*)

Review URL: https://chromiumcodereview.appspot.com/14846004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241938
R=piman@chromium.org

Review URL: https://codereview.chromium.org/16360018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204015 0039d316-1c4b-4281-b951-d872f2087c98

Unlike normal operation, in layout tests the renderer can request a synchronous
change of its size. The renderer and the browser therefore often run out of
sync. However, it's important that the renderer always acks a resize request
from the browser.

Previously, I tried to track the size the browser expects the renderer to have
in the renderer, however, this turns out to not work when the compositor is in
hidpi mode. Instead of trying to fix this up somehow, just ignore whether or
not the browser is expecting resize acks during layout tests

BUG=244369

Review URL: https://chromiumcodereview.appspot.com/16285005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204014 0039d316-1c4b-4281-b951-d872f2087c98

This is a less aggressive patch than the description below. The original was reverted for breaking the Android tests bot (https://codereview.chromium.org/16299003).

Removes check install step and moves it into the device status check. This will allow us to examine Android install speeds, which have recently caused timeout problems when installing large APK's. Unlike the original CL, low install speed only causes a warning (i.e. does not fail the step). The step fails if the battery of an online device is less than 5%.

BUG=230970, 224004, 242237

---------------------------------------------------
Original CL:
Move CheckInstall to device status and fail on low install speed and battery.

Removes the recently added CheckInstall step and moves the checking to the
device status check step. Recently, devices will install very slowly causing
tests to fail with device problems. We have also seen battery issues. The new
device status check step will fail if any devices install unreasonably slow
(i.e. < 800 KB/s) or have critically low battery level (i.e. < 5%).

BUG=230970, 224004, 242237

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203587

Review URL: https://chromiumcodereview.appspot.com/16110005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204013 0039d316-1c4b-4281-b951-d872f2087c98

In this specific case, expired Online Wallet instruments.

R=groby@chromium.org,estade@chromium.org
TBR=aruslan@chromium.org
BUG=168680
TEST=unit_tests and manual

Review URL: https://chromiumcodereview.appspot.com/15961007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204012 0039d316-1c4b-4281-b951-d872f2087c98

This policy may disable incognito mode, or set it to enforced (i.e. disable
non-incognito windows). This change introduces a CHECK that prevents any code
paths from opening a disabled window type; such code paths should still be
fixed, but this CHECK prevents working around the policy.

BUG=244246

Review URL: https://chromiumcodereview.appspot.com/15670011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204011 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244956
TEST=manual
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16290009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204008 0039d316-1c4b-4281-b951-d872f2087c98

R=dsinclair
NOTRY=True
BUG=232925

Review URL: https://chromiumcodereview.appspot.com/15736032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204007 0039d316-1c4b-4281-b951-d872f2087c98

If the user flings down a page while the page is still loading, we may
hit a situation where the fling animation stops at the bottom edge of
the content, pauses while the loading proceeds and then continues once the
content grows taller. This results in a jarring pause in an otherwise
continuous animation.

This patch fixes the issue by preventing the fling animation from trying
to scroll beyond the content edge. In other words, as soon as the
content overscrolls on a specific axis, we prevent the fling animation
from scrolling on that axis again.

BUG=244376
TEST=InputHandlerProxyTest.GestureFlingStopsAtContentEdge

Review URL: https://chromiumcodereview.appspot.com/16156002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204006 0039d316-1c4b-4281-b951-d872f2087c98

This code is simple/test/mock implementations of APIs to use in DumpRenderTree,
webkit_unit_tests, and various other bits of unit test code around the codebase.
Nothing here is used for test_shell since there is no test_shell any more.

This moves the code to webkit/support/ along with the rest of DRT/w_u_t support
code. Hopefully we'll be able to delete most of this soon along with
DumpRenderTree. In the meantime this simplifies webkit/

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203242

Review URL: https://codereview.chromium.org/15946006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=246460
TEST=existing DriveMetadataStoreTest

Review URL: https://chromiumcodereview.appspot.com/15954013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204004 0039d316-1c4b-4281-b951-d872f2087c98

Since not all net error codes can be mapped onto Android error codes,
at least provide a minimal description for the client.

Review URL: https://chromiumcodereview.appspot.com/15979017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222350

Review URL: https://chromiumcodereview.appspot.com/16236003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203998 0039d316-1c4b-4281-b951-d872f2087c98

> Introduces the default sound for notifications.
>
> Currently no one is using this but will be used soon.
>
> BUG=164248
> R=dewittj@chromium.org, jhawkins@chromium.org
>
> Review URL: https://codereview.chromium.org/15896033
>
> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203991 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mukai@chromium.org, sreeram@chromium.org

Review URL: https://codereview.chromium.org/16359012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203997 0039d316-1c4b-4281-b951-d872f2087c98

These cases weren't caught by the automated pass and/or needed
to be solved in another way than using .get().

BUG=245942
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/16207005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203996 0039d316-1c4b-4281-b951-d872f2087c98

I believe FileRef::ReadDirectoryEntries is the one depends on it.

BUG=
R=binji@chromium.org, sbc@chromium.org

Review URL: https://codereview.chromium.org/15969018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203995 0039d316-1c4b-4281-b951-d872f2087c98

This contains the binary drawables related to this CL:
https://codereview.chromium.org/15992008/

BUG=241380
R=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/16093029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203994 0039d316-1c4b-4281-b951-d872f2087c98

The main change here is that ProcessChangedRules (includes converting the rules
and writing them to disk) is now postponed to when the rules registry becomes
ready. After start-up, this will just mean that ProcessChangedRules will be
added to the message loop queue.

A minor change is a new way to manage ProcessChangedRules tasks:
If there is not the UI part (which does the writing), ProcessChangedRules tasks
are not ever posted.
If there is the UI part, then at any time at most one ProcessChangedRules task
is ever scheduled. This avoids unnecessary work duplication.

BUG=236368

Review URL: https://chromiumcodereview.appspot.com/15911005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15994017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203992 0039d316-1c4b-4281-b951-d872f2087c98

Currently no one is using this but will be used soon.

BUG=164248
R=dewittj@chromium.org, jhawkins@chromium.org

Review URL: https://codereview.chromium.org/15896033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203991 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes GL_PACK_ALIGNMENT and GL_UNPACK_ALIGNMENT part of the
autogenerated GL state.

Review URL: https://chromiumcodereview.appspot.com/16240016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203990 0039d316-1c4b-4281-b951-d872f2087c98

> cros: Update charging not reliable battery status
> 
> Don't display the "charging not reliable" battery status in the 
> non-charging-non-discharging state, as that can happen normally in
> some circumstances. Also, update the string to be more human-friendly.
> 
> BUG=246336
> TEST=manual, see bug
> 
> Review URL: https://chromiumcodereview.appspot.com/16057022

TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/16226023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203989 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203988 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cira@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/16360002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203987 0039d316-1c4b-4281-b951-d872f2087c98

Add a regression test for a non-cacheable login page with a help link.

BUG=b/8888772

Review URL: https://chromiumcodereview.appspot.com/16337004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203986 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/15974008/ which renames SessionStateObserver to LockStateObserver

* Rename few instances of email to user_id
* Add SessionStateDelegateChromeos implementation

BUG=180903
R=bartfab@chromium.org, skuhne@chromium.org, sky@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/15718003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203985 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241146

Review URL: https://chromiumcodereview.appspot.com/15821012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241387
TBR=pam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16325010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203983 0039d316-1c4b-4281-b951-d872f2087c98

On operating systems that support it (Vista+), begin background
processing mode before doing major disk I/O in the installer if it was
launched below the normal process priority class. One hopes that this
avoids making users' machines unresponsive while an update is being
applied in the background.

BUG=167622
TEST=mostly covered by "setup_unittests.exe
--gtest_filter=SetupUtilTest.Adjust*", but it will also be interesting
to look at verbose installer log files for an install and for a Google
Update-driven update. Only the latter should contain "Entered background
processing mode."

Review URL: https://chromiumcodereview.appspot.com/16023027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203982 0039d316-1c4b-4281-b951-d872f2087c98

After r203462 translate UI/UX meets criterions to enable it by default.
Now, let's enable alpha language support by default.

BUG=242178
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16282003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203981 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/16274004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203980 0039d316-1c4b-4281-b951-d872f2087c98

Removes mock expectations that are no longer needed. This also results
in removal of all direct {Mock}NetworkLibrary dependencies
in chromeos/login/*.

BUG=189035

Review URL: https://chromiumcodereview.appspot.com/16196006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203979 0039d316-1c4b-4281-b951-d872f2087c98

There was a TODO about this in object_backed_native_handler.h.

The passed handle was a Persistent behind the scenes, and we're going to disable
copying Persistents. We'd need to pass a Local handle instead, but this way the
TODO gets done with a similar amount of effort.

BUG=236290

Review URL: https://chromiumcodereview.appspot.com/16032015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203978 0039d316-1c4b-4281-b951-d872f2087c98

This allows libraries installed by naclports "make" commands
to be visible to create_nmf by default.

BUG=179526
R=binji@chromium.org

Review URL: https://codereview.chromium.org/15896036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203977 0039d316-1c4b-4281-b951-d872f2087c98

Introduces a new Profile::CREATE_STATUS_REMOTE_FAIL type, and renames
CREATE_STATUS_FAIL to CREATE_STATUS_LOCAL_FAIL. Adds callbacks and reorganizes
profile creation to allow registration errors to propagate back up to the UI
layer, and displays them in the profile creation dialog. Adds a spinner to the
creation dialog. Adds UMA metrics.

BUG=234991
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/15774008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203976 0039d316-1c4b-4281-b951-d872f2087c98

- use them in the different components
- minor cleanup of some of the elements while at it

BUG=135948

Review URL: https://chromiumcodereview.appspot.com/15533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=246634
NOTRY=true
TBR=beaudoin@chromium.org
TEST=none

Review URL: https://codereview.chromium.org/15979028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203974 0039d316-1c4b-4281-b951-d872f2087c98

The previous patch (r203795) is not a good way because chrome.app.window.contentWindow is always undefined. This patch introduced another method to check if it is running as apps instead.

BUG=243414
TEST=Confirm a close button works correctly on normal Files.app and doesn't work on chrome://files.
R=mtomasz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16207004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203969 0039d316-1c4b-4281-b951-d872f2087c98

If ProfileSyncService gets a transient network error trying to contact the
backend, we no longer treat this as a fatal signin error.

Also, we no longer display a "wait for the backend to startup" spinner in cases
where we know the spinner will immediately be dismissed, to avoid a gnarly
infinite loop in the UI code.

BUG=244769

Review URL: https://chromiumcodereview.appspot.com/16173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203968 0039d316-1c4b-4281-b951-d872f2087c98

> Remove Activity Log usage of Extension objects
> 
> Previously, the AL used Extension objects when notifying the UI of new activity. If an extension were uninstalled in the middle of logging something, the Extension object would be deallocated before the UI tried to use the reference. Since we are replacing the old UI, I am switching to using IDs instead of Extension objects.
> 
> [[[ Reverted because it was causing heapcheck failures. Retrying a new version. ]]]
> 
> BUG=236395
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203218
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203618
> 
> Review URL: https://chromiumcodereview.appspot.com/15686007

TBR=felt@chromium.org

Review URL: https://codereview.chromium.org/16286017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203967 0039d316-1c4b-4281-b951-d872f2087c98