GitLab

CSSFontSelector keeps a set of weakly referenced clients; when notifying
those the set is copied into a temporary heap vector before iterating.

Allocating that vector might potentially cause a GC, which in turn
could cause some of the weak references to be cleared. With the outcome
that the temporary vector will contain empty tail elements.

Speculatively check&handle that eventuality when iterating.

R=haraken
BUG=568173

Review URL: https://codereview.chromium.org/1642913002

Cr-Commit-Position: refs/heads/master@{#372112}

BUG=582080

Review URL: https://codereview.chromium.org/1645003003

Cr-Commit-Position: refs/heads/master@{#372111}

Disable the ScreenAvailabilityNotSupported unit test on Android,
because it's flaky on some android bots (see crbug.com/581878)

BUG=581878
TBR=avayvod@chromium.org,dskiba@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1646823003

Cr-Commit-Position: refs/heads/master@{#372110}

Required setting parent/self visible for the FrameView associated
with a WebPagePopupImpl. Previously these defaulted to invisible.

BUG=569643

Review URL: https://codereview.chromium.org/1616183002

Cr-Commit-Position: refs/heads/master@{#372109}

build-side is here: https://codereview.chromium.org/1645723004/

BUG=525873

Review URL: https://codereview.chromium.org/1649593002

Cr-Commit-Position: refs/heads/master@{#372108}

Moar nits.

BUG=None
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1641243002 .

Cr-Commit-Position: refs/heads/master@{#372107}

BUG=NONE

Review URL: https://codereview.chromium.org/1551423003

Cr-Commit-Position: refs/heads/master@{#372106}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e77121fb..86e3d587

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1648633002

Cr-Commit-Position: refs/heads/master@{#372105}

This fixes one expectation in
NavigationControllerBrowserTest.FrameNavigationEntry_FrameUniqueName following
PlzNavigate switch to frame history entries.

BUG=575210

Review URL: https://codereview.chromium.org/1631273003

Cr-Commit-Position: refs/heads/master@{#372104}

GZIP is detrimental.

BUG=580102
TEST=AutofillDownloadManager
TBR=asvitkine

Review URL: https://codereview.chromium.org/1624543002

Cr-Commit-Position: refs/heads/master@{#372103}

Also create a basic abstraction layer for
SiteSettings to use when communicating with
the C++ layer.

BUG=543635

Review URL: https://codereview.chromium.org/1607483005

Cr-Commit-Position: refs/heads/master@{#372102}

Screenshot(desktop): https://screenshot.googleplex.com/t7eysxXatw5.png
Screenshot(mobile): https://screenshot.googleplex.com/m732e5H2FJA.png
BUG=404671

Review URL: https://codereview.chromium.org/1617293002

Cr-Commit-Position: refs/heads/master@{#372101}

Delete words that are no longer true.

BUG=
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1642023003 .

Cr-Commit-Position: refs/heads/master@{#372100}

Otherwise, HTMLImportLoader::startWritingAndParsing can be called after the HTMLImportLoader is disposed.

BUG=582006

Review URL: https://codereview.chromium.org/1648603002

Cr-Commit-Position: refs/heads/master@{#372099}

The renderer now no longer uses these NaCl libraries, so we don't need
to initialise them on startup in module_ppapi.cc.

This leaves UrandomFD() unused, so we can remove it.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Review URL: https://codereview.chromium.org/1646733002

Cr-Commit-Position: refs/heads/master@{#372098}

This will be needed by upcoming CL that componentizes omnibox_edit_unittest.cc.

TBR=jochen

Review URL: https://codereview.chromium.org/1634743003

Cr-Commit-Position: refs/heads/master@{#372097}

Use ThreadTaskRunnerHandle to get thet task runner, and use that for
posting tasks from the ash code.

BUG=none

Review URL: https://codereview.chromium.org/1640503002

Cr-Commit-Position: refs/heads/master@{#372096}

The SocketParams for all requests in a group should be identical.

BUG=533571

Review URL: https://codereview.chromium.org/1580903002

Cr-Commit-Position: refs/heads/master@{#372095}

NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1643653004

Cr-Commit-Position: refs/heads/master@{#372094}

BUG=580337
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1648523002

Cr-Commit-Position: refs/heads/master@{#372093}

The CalcDrawProps trace event in DoUpdateLayers actually measures
almost all of DoUpdateLayers. This CL moves it to the right scope
and renames it to BuildPropertyTrees.

BUG=581774
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1641023002

Cr-Commit-Position: refs/heads/master@{#372092}

TBR=oilpan-reviews,tkent
BUG=477839
NOTRY=true

Review URL: https://codereview.chromium.org/1640233005

Cr-Commit-Position: refs/heads/master@{#372091}

Reland of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #1 id:1 of https://codereview.chromium.org/1646803002/ )

Reason for revert:
The test you reverted it for is flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http/tests/inspector/resource-tree/resource-tree-non-unique-url.html

You should mute it and file a bug.

Original issue's description:
> Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2 id:20001 of https://codereview.chromium.org/1641933002/ )
>
> Reason for revert:
> http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started failing
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...
>
> Reverting to see if we can get that test to pass again.
>
> Original issue's description:
> > DevTools: remove V8ScriptRunner use from InjectedScript*.
> >
> > BUG=580337
> >
> > Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> > Cr-Commit-Position: refs/heads/master@{#372020}
>
> TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=580337
>
> Committed: https://crrev.com/718abf542ea95a35036331f3c78caf21959155dc
> Cr-Commit-Position: refs/heads/master@{#372034}

TBR=dgozman@chromium.org,jochen@chromium.org,noel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337

Review URL: https://codereview.chromium.org/1645663004

Cr-Commit-Position: refs/heads/master@{#372090}

This is one of a few of these types of warnings that I've found as I
continue my quest to get the battor_agent_unittests running on the
trybots.

TBR=zhenw@chromium.org,nednguyen@google.com
BUG=571458

Review URL: https://codereview.chromium.org/1642113002

Cr-Commit-Position: refs/heads/master@{#372089}

And with that in place, undo the partial fix by r371169.

R=haraken,jochen
BUG=581948
NOTRY=true

Review URL: https://codereview.chromium.org/1645923002

Cr-Commit-Position: refs/heads/master@{#372088}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1645753003

Cr-Commit-Position: refs/heads/master@{#372087}

NOTRY=true

Review URL: https://codereview.chromium.org/1641223002

Cr-Commit-Position: refs/heads/master@{#372086}

BUG=506903

Review URL: https://codereview.chromium.org/1639353002

Cr-Commit-Position: refs/heads/master@{#372085}

skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful. It's quite common for functions to be declared as returning SkCanvas* but defined as returning skia::PlatformCanvas*, so it's also not future-proof.

R=fmalita@chromium.org,reed@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org

Review URL: https://codereview.chromium.org/1618703006

Cr-Commit-Position: refs/heads/master@{#372084}

This allows us to know who uses the old-style constraints,
who uses the new-style constraints, and who uses constraints
on APIs that should migrate away from using them.

BUG=576613

Review URL: https://codereview.chromium.org/1641653002

Cr-Commit-Position: refs/heads/master@{#372083}

This CL reimplements the algorithms presently used for selection
in terms of the new form constraints.
A new mock constraints factory is also added.

BUG=543997

Review URL: https://codereview.chromium.org/1617243005

Cr-Commit-Position: refs/heads/master@{#372082}

The CL http://crrev.com/1638413003 will remove enhanced bookmarks but
the iOS code (and only the iOS code) dealing with bookmarks uses four
utility functions. This CL copies those functions to iOS before they
disapear.

BUG=None

Review URL: https://codereview.chromium.org/1647903002

Cr-Commit-Position: refs/heads/master@{#372081}

TBR=chongz@chromium.org, kinuko@chromium.org
BUG=582016

Review URL: https://codereview.chromium.org/1644643003

Cr-Commit-Position: refs/heads/master@{#372080}

Only import adblocker if we actually define any rules. If we define
rules, and fail to import adblockerparser, give detailed installation
instructions.

Fix typo that prevented the filtering from working in the model, and have the filtering actually use the new adblocker matcher rather than the old heuristic.

Review URL: https://codereview.chromium.org/1645953002

Cr-Commit-Position: refs/heads/master@{#372079}

BUG=570315

Review URL: https://codereview.chromium.org/1646503002

Cr-Commit-Position: refs/heads/master@{#372078}

virtual/threaded/printing/ellipsis-printing-style.html [ Skip ]
printing/ellipsis-printing-style.html [ Skip ]

Started happening after the rebaselines for the associated
CL [1] landed. The rebaselines are missing it seems.

[1] https://code.google.com/p/chromium/issues/detail?id=390040#c14

TBR=wkorman@chromium.org,chrishtr@chromium.org
BUG=390040
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1649563004

Cr-Commit-Position: refs/heads/master@{#372077}

Oilpan is enabled on ToT, and is reading from TestExpectations and has
no Expectations file of its own (for now).

Mark the tests as a flake, and place them in TestExpectations "Oilpan"
area of that file.  They fail both in Oilpan Win Release and Debug.

[ Win7 ] fast/text/emphasis-combined-text.html [ Pass Failure ]
[ Win7 ] fast/text/emphasis-vertical.html [ Pass Failure ]

since the following expectation already existed, and were retained for
issue 521730.

crbug.com/521730 [ Win10 ] fast/text/emphasis-combined-text.html [ Failure ]
crbug.com/521730 [ Win10 ] fast/text/emphasis-complex.html [ Failure ]

TBR=wkorman@chromium.org
BUG=574660
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1644953002

Cr-Commit-Position: refs/heads/master@{#372076}

If a ScriptRunner has been disposed of already, allow ScriptLoaders
to notify of their failure without asserting.

R=haraken
BUG=570012

Review URL: https://codereview.chromium.org/1642863002

Cr-Commit-Position: refs/heads/master@{#372075}

It's a part of larger task to move the whole initialization
on the separate thread. Previous CL introduced some hard to
track issues and broke some perf bots. This CL is first part
to make sure bots are fine. It moves gconf related
initialization on the file thread.

BUG=472183, 468989, 468112

Review URL: https://codereview.chromium.org/1640273002

Cr-Commit-Position: refs/heads/master@{#372074}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a7e38c146fe9..8e3a22b7dbec

$ git log a7e38c146..8e3a22b7d --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1649703003

Cr-Commit-Position: refs/heads/master@{#372073}