- 17 Sep, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL converts TestServicePtr and TestServiceRequest to new Mojo types. It uses Remote, PendingReceiver and Receiver instead of QueryableDataStorePtr, QueryableDataStoreRequest and Binding. Bug: 955171 Change-Id: I61f3d6b66ac6f5faffe533800bbe482a2db772ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803948 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#697068}
-
Chris Lu authored
This change doesn't include any action taken by the InfobarBadgeTabHelper since currently there is no significant state change needed. A following CL will have changes to the model that makes the banner dismissal action significant. A test for this method will be added to BadgeMediatorUnittests with that CL. Bug: 976901 Change-Id: I44df4e1df9282c6c43c52ae6c40178995c714962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800521 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#697067}
-
Khushal authored
Follow up for https://skia-review.googlesource.com/c/skia/+/240824. This change rebaselines the layout test which passes after the change above and switches passthrough tests skipped previously to failed. R=fserb@chromium.org, kbr@chromium.org Bug: 900706 Change-Id: I1e783570cf73835c09dfb9cfd503abb42facd8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808076 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697066}
-
Ella Ge authored
This CL changes linear resampling to scroll predictor's default predictor type and also fix related unit tests. This is to prepare the enabling of scroll resampling. So when the flag turn on, it will default to use linear resampling predictor type. This is to get a better scroll experience on scrolling, detail see the doc: https://docs.google.com/document/d/1KrlQ0m5Ty9RKE1IorjEXDldYFJvUV_Ww10lnjh-TRN0/ Bug: 1000682 Change-Id: I3928428700a36f8c25ac2c0c1294b3a4478bc579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786868 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697065}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e76231afda98..007200e00a46 Created with: gclient setdep -r src-internal@007200e00a46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6cbbf07abb6ba53f07010875dc0b659cbe7665f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697064}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b47704b0bd34..b2ce62ac41eb git log b47704b0bd34..b2ce62ac41eb --date=short --no-merges --format='%ad %ae %s' 2019-09-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b2ce62ac41eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Iafac4d3ddb106117b0a5e2238190c34fe6fd1de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697063}
-
Zhenyao Mo authored
conformance/textures/image_bitmap_from_video/conformance/textures/image_bitmap_from_video/ BUG=1002269 TEST=bot TBR=kbr@chromium.org Change-Id: Ic02ff5afca8012e218822f4f5d6ba0134b148f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808411Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697062}
-
Fergus Dall authored
TBR=ftirelo@chromium.org TBR=dvadym@chromium.org TBR=cfroussios@chromium.org TBR=mahmadi@chromium.org TBR=battre@chromium.org TBR=tmartino@chromium.org TBR=kolos@chromium.org TBR=sebsg@chromium.org TBR=estade@chromium.org TBR=rogerm@chromium.org Bug: 1004585 Change-Id: I5f27138ce281f342cf52f6681139de50ce6f8fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808295Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697061}
-
Zhenyao Mo authored
https://chromium-review.googlesource.com/c/chromium/src/+/1801232 made a mistake and disabled the wrong test suite. BUG=1002313 TEST=bot TBR=kbr@chromium.org,jmadill@chromium.org Change-Id: Ibd89171c0a6787f03a08b1c5f6dcafeff4b2b7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808500Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697060}
-
Xing Liu authored
Currently we remove canceled and non resumable downloads on Android. However, we still see some users having memory issues with thousands of download records on other platforms. This CL removes canceled, and all interrupted download after 90 days on all platforms. Browser tests will be added in following CL. Bug: 851650 Change-Id: I4decd1626ee088c646c20d5c4bca10fab6378324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799694 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#697059}
-
Hesen Zhang authored
Implements reading config from Finch with unittest. Bug: 1004498 Change-Id: Ib4326314d849cf66d8e702359a71fba74649471d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808098 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697058}
-
Tom Anderson authored
This fixes a regression introduced between PS14 and PS15 of CL [1] where blend_toward_max_contrast() was switched for blend_for_min_contrast(). But for dimmed text, we specifically don't want to blend for min contrast because this will usually result in the same text color. What we want is a new text color distinct from the original text color, specifically with less contrast. Also updated COLOR_OMNIBOX_RESULTS_ICON while we're at it to use derive_default_icon_color(), which logically makes more sense, and gives results quite close to the colors before CL [1]. Updated colors: [2] [1] https://chromium-review.googlesource.com/c/chromium/src/+/1754155/14..15 [2] https://docs.google.com/spreadsheets/d/1Nev_DSPECQ9vGrFDO-ARjLudL6O2NjOTnBu_9mTq_cU/edit?usp=sharing Bug: 1004135 R=pkasting Change-Id: I243f809b409de7178408601a1fb80e4bddce7087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808191 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697057}
-
Austin Tankiang authored
DriveFS is going to be used regardless of its feature flag, and the legacy drive sync client will be deleted, so clean up code that relies on the legacy drive sync client. Bug: 1002339 Change-Id: I85827f39bd174362a9a9e37eb5721384fea37d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798947Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#697056}
-
Yuki Shiino authored
Supports Interface.operations, operation_groups. Also fixes several minor things. Bug: 839389 Change-Id: I77fbd80172d3d7ca5f385a1bc2ceabc40079556f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800856 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#697055}
-
nancy authored
BUG=1002351 Change-Id: I8df9f7f59599d5874c7170555a285b46141bb125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803035Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#697054}
-
Wei-Yin Chen (陳威尹) authored
Bug: 998949 Change-Id: I29fbedca05f986d33f486684c1db8909bcd6b14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805296Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697053}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e65bb926f1f3..ca95a4ccd809 git log e65bb926f1f3..ca95a4ccd809 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 saklein@chromium.org portage_util: Add HasPrebuilt function. Created with: gclient setdep -r src/third_party/chromite@ca95a4ccd809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0b3a551ed36c5612944d8769faa6fff395280d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808229Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697052}
-
Fergus Dall authored
TBR=tommi@chromium.org TBR=sergeyu@chromium.org TBR=sandersd@chromium.org TBR=xhwang@chromium.org TBR=liberato@chromium.org TBR=dalecurtis@chromium.org TBR=chcunningham@chromium.org TBR=wolenetz@chromium.org TBR=jrummell@chromium.org TBR=tguilbert@chromium.org Bug: 1004580 Change-Id: I82e9610eda564e0197e5e4f546108f4ac7fd5f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808292Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697051}
-
Antonio Gomes authored
This is a preliminary step to Onion souping //content/renderer/p2p. The following typemaps got added, and listed to [1]: - services/network/public/cpp/ip_address_for_blink.typemap (based on ip_address.typemap) - services/network/public/cpp/ip_endpoint_for_blink.typemap (based on ip_endpoint.typemap) - services/network/public/cpp/network_interface_for_blink.typemap (based on network_interface.typemap) Additionally, the following typemap files got listed in [1] as-is: - services/network/public/cpp/p2p.typemap - services/network/public/cpp/mutable_network_traffic_annotation_tag.typemap [1] //third_party/blink/renderer/platform/mojo/blink_typemaps.gni BUG=787254 R=dcheng@chromium.org, haraken@chromium.org Change-Id: Ife391517c3191bea57e41aa2a94efe091805257d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804541Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#697050}
-
Tina Lu authored
Bug: 656625 Change-Id: I6a21ede043092e7db201c8b1edd3f3bd4740e558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804516 Commit-Queue: Tina Lu <ltina@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697049}
-
Yuchen Liu authored
Check if cdm object still alive before calling fidl APIs on it. Bug: 1001358 Test: Open page using Widevine on device without Widevine service. Change-Id: Ib82ab66b8dc5eec03a4f64c5e499fef3a93a0493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802711Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697048}
-
Yue Zhang authored
This CL adds components needed for the toolbar menu in TabGridDialog. Right now there is no consumer for this part of logic. Bug: 1000381 Change-Id: I03b51e8bbcefdb0f5ac4fc8224303f3d3debeff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785517 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697047}
-
rbpotter authored
Since the tools/polymer/polymer.py script has been updated to handle export annotations, revert https://chromium-review.googlesource.com/c/chromium/src/+/1795315, which split of the AnchorAlignment enum into a separate file, since it is no longer necessary. Bug: 965770 Change-Id: I7109485280d8d22befe4cdccca3a7e5cf54629bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804957 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#697046}
-
Zhenyao Mo authored
Right now we collect them for all gpu_integration tests, which caused Win10 Intel bot to timeout. Instead, we only need to do that for info collection test. This also fixes a potential racing in GpuDataManager. BUG=1004472,977034 TEST=gpu bots R=kbr@chromium.org Change-Id: I4010fda150ff3872b1dcefd2ac8aa7e4ad689e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808012 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697045}
-
Dmitry Gozman authored
Calling into WebLocalFrame::WillStartNavigation may cancel the navigation, for example when dispatched javascript event handlers do "window.stop()". Currently, we call RFO::DidStartNavigation prematurely, and never issue a paired "canceled" call when WillStartNavigation fails. We can instead try to start and only then issue observer notification to ensure proper sequence. Tests which navigate from onload handler now correctly report "first navigation finished, second navigation started" instead of the reverse. onreadystatechange-detach previously reported a new navigation, which does not actually happen because frame detaches itself before being able to start navigating. This behavior is fixed now. Bug: 855189 Change-Id: Ia12518ebddf54557f4699cd39168217762c874eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800916Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697044}
-
Miyoung Shin authored
This is a followup CL of https://crrev.com/c/1787663 and uses base::NullCallback instead of base::DoNothing for mojo interface in TrayBluetoothHelperExperimental class. Bug: 955171 Change-Id: I66fba9b9ffb8db2163111930254a9a87eaa19667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806157Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697043}
-
Kent Tamura authored
I2IS: https://groups.google.com/a/chromium.org/d/msg/blink-dev/g8MP8KUf96w/360rLewrDwAJ Bug: 995679 Change-Id: I8d670ddb3a6a97642fcb5d6161178a3a86ccd568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798246Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697042}
-
Miyoung Shin authored
This CL converts HidManager{Ptr, Request} in device, services, chrome and extensions to the new Mojo type. Bug: 955171 Change-Id: Iaeb03869b1ed99a769bc88553167c7b265aae32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804942Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697041}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b35cce04ad4..e76231afda98 Created with: gclient setdep -r src-internal@e76231afda98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:954450,chromium:913074 Change-Id: I8f2960259f237ecad8db32751191859c6e7858ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808223Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697040}
-
Julie Jeongeun Kim authored
This CL migrates AutofillRendererTest and FormAutocompleteTest with new Mojo types, PendingAssociatedReceiver and AssociatedReceiverSet instead of using AutofillDriverAssociatedRequest and AssociatedBindingSet. Bug: 955171 Change-Id: I06127b19f8f896ad6d13777637f6b5c3725d5af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806615Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697039}
-
Julie Jeongeun Kim authored
This CL converts QueryableDataStorePtr and QueryableDataStoreRequest to new Mojo types. It uses Remote, PendingReceiver and ReceiverSet instead of QueryableDataStorePtr, QueryableDataStoreRequest and BindingSet. Bug: 955171 Change-Id: Iecdac72ae103960845b4764b0513c7ac98a99ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804712Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697038}
-
Austin Tankiang authored
DriveFS is going to be used regardless of its feature flag, and the legacy drive sync client will be deleted, so clean up code that relies on the legacy drive sync client. Bug: 1002339 Change-Id: Iba820095870d8aad1ba92b747af0849b750a150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798257Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#697037}
-
Andrew Xu authored
This CL enables the scrollable shelf to show context menu for proper gestures (like long-time tapping). It helps to keep the UI consistency with the shelf view. Bug: 1003584 Change-Id: I74b69ffea84fedc6c780cacc01b6eea680b6875b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801320Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697036}
-
Ryan Sturm authored
NavigationPredictor currently only recieves the first 40 links from the renderer. Instead, we should report the first 100. In pages that have a large number of small navigational links at the top, we may not see the main content links in NavigationPredictor. Bug: 1001593 Change-Id: I074bb70fb5cca14799a875b74c15ebdbdfe69a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797137 Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#697035}
-
Ryan Sturm authored
This restriction has limited the data pool the predictor can choose links from, and may severely limit coverage of the predictor. Instead of only using links from the visual viewport, links from anywhere on the page will be used as long as they have a size. Bug: 1001593 Change-Id: Iea4387d72952e850a02a7f4fdc1818d252daae26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797135Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697034}
-
Fergus Dall authored
TBR=fdoray@chromium.org Bug: 1004578 Change-Id: I3d9fdd9c114f93b91958653f4ab1d73bed7e7b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808291Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697033}
-
Fergus Dall authored
TBR=treib@chromium.org, rdevlin.cronin@chromium Bug: 1004573 Change-Id: I4ecd8c752b587b26c17f6176db230449fcee4c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808287Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697032}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f73f0f401a6b..2c210a490857 git log f73f0f401a6b..2c210a490857 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 ehmaldonado@chromium.org Revert "git-cl: Use bb to schedule try jobs." Created with: gclient setdep -r src/third_party/depot_tools@2c210a490857 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:976104 Change-Id: I099edf7da9f0952681d485edd6bb6ad9bdd20800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697031}
-
Andrew Xu authored
With the flag of scrollable shelf enabled, when adding a shelf item, scrollable shelf is notified when the shelf view's bounds animations end. Tests should wait for bounds animations to finish. Otherwise, they will fail. This CL fixes such an issue. Bug: 1002576 Change-Id: Ib2e80916a11a2b90f248886992f7221b1dce6563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808189 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697030}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eb8f5aa220f6..b19a360c1269 git log eb8f5aa220f6..b19a360c1269 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 ntfschr@chromium.org Devil: IsApplicationInstalled API Created with: gclient setdep -r src/third_party/catapult@b19a360c1269 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1002774 Change-Id: I25fb405a04d46177fd178d014d433978dfd097cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808222Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697029}
-