- 20 Dec, 2016 40 commits
-
-
blink-w3c-test-autoroller authored
Using update-w3c-deps in Chromium d0059913. Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7835 TBR=qyearsley@chromium.org NOEXPORT=true Review-Url: https://codereview.chromium.org/2590903002 Cr-Commit-Position: refs/heads/master@{#439825}
-
fhorschig authored
Calling |ClearAllVariationParams| will now create a new instance of the FieldTrialList so |SetVariationParamsWithFeatureAssociations| will work again. BUG=672010 Review-Url: https://codereview.chromium.org/2590883002 Cr-Commit-Position: refs/heads/master@{#439824}
-
jif authored
BUG=675624 Review-Url: https://codereview.chromium.org/2589763002 Cr-Commit-Position: refs/heads/master@{#439823}
-
boriay authored
Test ChromeVisibilityObserverBrowserTest.VisibilityTest is flacky on Linux: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1) (32)/builds/36743/steps/browser_tests/logs/stdio Actually problem on showing window after browser creation but it is better to wait all async operations with RunLoop. BUG= Review-Url: https://codereview.chromium.org/2591783002 Cr-Commit-Position: refs/heads/master@{#439822}
-
jbriance authored
Rebase protobuf to current HEAD to pull the 3 following changes: * 4c5d3ed Fix integer overflow in FastUInt32ToBufferLeft * 4587a3f [arm/gcc] Don't rely on KUSER_HELPERS feature for atomics * a5a2c1d generic atomicops: Use strong compare_exchange This change has been made following steps described in third_party/protobuf/README.chromium file, please refer to it for further information. BUG=599051,673488 Review-Url: https://codereview.chromium.org/2495533002 Cr-Commit-Position: refs/heads/master@{#439821}
-
jvanverth authored
Rebaselines for this test should be complete. BUG=673752 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2588033003 Cr-Commit-Position: refs/heads/master@{#439820}
-
jmadill authored
These tests are flaky, and until we can figure out how to enable retries only on this config, we should disable them. BUG=674932 TBR=kbr@chromium.org,ynovikov@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2594713002 Cr-Commit-Position: refs/heads/master@{#439819}
-
lukasza authored
BUG=582312 Review-Url: https://codereview.chromium.org/2589923002 Cr-Commit-Position: refs/heads/master@{#439818}
-
jmadill authored
https://chromium.googlesource.com/angle/angle.git/+log/37ee8a6..f047097 BUG=chromium:671162 TEST=bots NOTRY=true TBR=geofflang@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2591793002 Cr-Commit-Position: refs/heads/master@{#439817}
-
bashi authored
The code generator wrongly uses `Nullable<Callback*>` when nullable callback functions are used like below: callback C = void(); interface I { void f(C? callback); } Since C++ impl of callback functions are garbage collected types, we can just use `Callback*`. BUG=675859 Review-Url: https://codereview.chromium.org/2588303002 Cr-Commit-Position: refs/heads/master@{#439816}
-
michaeldo authored
Combine duplicated method logic. Add unittest to ensure activity stops when webState is deallocated. BUG=none Review-Url: https://codereview.chromium.org/2587173002 Cr-Commit-Position: refs/heads/master@{#439815}
-
avi authored
Its last caller was removed in r306479. BUG=556939 Review-Url: https://codereview.chromium.org/2586413002 Cr-Commit-Position: refs/heads/master@{#439814}
-
rohitrao authored
I added parentheses to the frame calculation expression to work around clang-format issues, but I added them in the wrong place and made the math wrong. This CL removes the parentheses and restores the original expression. BUG=675595 Review-Url: https://codereview.chromium.org/2590223002 Cr-Commit-Position: refs/heads/master@{#439813}
-
jochen authored
Creating a wrapper might fire events synchronously which in turn can modify the wrapper. There is, however, an invariant for interceptors that if they modify their holder, they need to signal this. Therefore, when we create a wrapper, always signal that the write happened. BUG=670155 R=tkent@chromium.org,haraken@chromium.org Review-Url: https://codereview.chromium.org/2566663002 Cr-Commit-Position: refs/heads/master@{#439812}
-
mlamouri authored
The HTMLMediaElement no longer adds the MediaControls to the shadow tree in order to prepare for the class to be an interface implemented by modules. This CL also removes a couple of reset() call. BUG=662761 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2588823002 Cr-Commit-Position: refs/heads/master@{#439811}
-
blundell authored
Revert of Maintain HostZoom connection per-frame on browser side (patchset #4 id:100001 of https://codereview.chromium.org/2581143002/ ) Reason for revert: Seems to cause problems on Mac: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac10.10%2F28001%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout Original issue's description: > Maintain HostZoom connection per-frame on browser side > > HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo > connection is per-frame. Before this CL, HostZoomMapObserver was > maintaining one HostZoom connection and rebinding it every time a new > RenderFrame was created. This meant that HostZoomMapObserver was > continually losing connections to existing frames. This CL changes > HostZoomMapObserver to maintain one connection per-RenderFrame in a > map indexed by the corresponding RenderFrameHost. > > BUG=673065 > TEST=Visit news.ycombinator.com and increase the zoom level to 175%. > Click the top link. Hit back: news.ycombinator.com should still be > zoomed to 175%. > > Committed: https://crrev.com/8e24b7d133424fb221891601d6254b7df58188d5 > Cr-Commit-Position: refs/heads/master@{#439800} TBR=scottmg@chromium.org,wjmaclean@chromium.org,nick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673065 Review-Url: https://codereview.chromium.org/2595603002 Cr-Commit-Position: refs/heads/master@{#439810}
-
drott authored
TBR=eae,kojii Review-Url: https://codereview.chromium.org/2590213002 Cr-Commit-Position: refs/heads/master@{#439809}
-
lgrey authored
BUG=648557 Review-Url: https://codereview.chromium.org/2586363002 Cr-Commit-Position: refs/heads/master@{#439808}
-
toyoshim authored
Remove a TODO that I left before because I confirmed that current code is correct, and chaging it makes many unit tests fail. BUG=670232 Review-Url: https://codereview.chromium.org/2587323002 Cr-Commit-Position: refs/heads/master@{#439807}
-
toyoshim authored
Now, core/fetch has a dependency to bindings/core/, but this won't be permitted once the directory is moved to platform/loader/fetch. This patch moves this last unexpected dependency, and make it finally possible to move under platform/. BUG=655920 Review-Url: https://codereview.chromium.org/2578983002 Cr-Commit-Position: refs/heads/master@{#439806}
-
ecobos authored
This were reviewed upstream in https://github.com/w3c/csswg-test/pull/1155 This should reduce the noise in https://codereview.chromium.org/2450093005, and make it more manageable and straight-forward to review. BUG=657748 Review-Url: https://codereview.chromium.org/2588093003 Cr-Commit-Position: refs/heads/master@{#439805}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/32db0e1a..54a5b164 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2595563002 Cr-Commit-Position: refs/heads/master@{#439804}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/ace343286d90..3711e1185d53 $ git log ace343286..3711e1185 --date=short --no-merges --format='%ad %ae %s' 2016-12-20 reed switch to _deprecated suffix for exotic SkClipOps Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@google.com Review-Url: https://codereview.chromium.org/2590203002 Cr-Commit-Position: refs/heads/master@{#439803}
-
yhanada authored
BUG=670247 TEST=Manual test by checking Configuration.hardKeyboardHidden when entering maximize mode. Review-Url: https://codereview.chromium.org/2590893002 Cr-Commit-Position: refs/heads/master@{#439802}
-
yigu authored
BUG=568901 TEST=ScrollingCoordinatorTest.BackgroundAttachmentFixedShouldTriggerMainThreadScroll; FrameThrottlingTest.ScrollingCoordinatorShouldSkipThrottledFrame; ScrollingCoordinatorTest.RecalculateMainThreadScrollingReasonsUponResize third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2531603003 Cr-Commit-Position: refs/heads/master@{#439801}
-
blundell authored
HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo connection is per-frame. Before this CL, HostZoomMapObserver was maintaining one HostZoom connection and rebinding it every time a new RenderFrame was created. This meant that HostZoomMapObserver was continually losing connections to existing frames. This CL changes HostZoomMapObserver to maintain one connection per-RenderFrame in a map indexed by the corresponding RenderFrameHost. BUG=673065 TEST=Visit news.ycombinator.com and increase the zoom level to 175%. Click the top link. Hit back: news.ycombinator.com should still be zoomed to 175%. Review-Url: https://codereview.chromium.org/2581143002 Cr-Commit-Position: refs/heads/master@{#439800}
-
vabr authored
PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY. This CL removes the code to obtain the Finch group for the experiment, related tests, and also the functionality only executed for the unused FULL variant of the experiment (mainly the SmartLock warm welcome). BUG=486739 Original Review-Url: https://codereview.chromium.org/2579823003 Original Cr-Commit-Position: refs/heads/master@{#439740} Reverted because of breaking iOS build. Patch set 1 here is the reverted one, subsequent patches are fixing the breakage. TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chromium.org,dfalcantara@chromium.org, Review-Url: https://codereview.chromium.org/2588263003 Cr-Commit-Position: refs/heads/master@{#439799}
-
maksim.sisov authored
This CL fixes a tsan data race, which is caused by calling StopFetchingData from different threads. It must not be allowed. Use the same thread by using a PostTask. BUG=673760 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng Review-Url: https://codereview.chromium.org/2569763004 Cr-Commit-Position: refs/heads/master@{#439798}
-
oka authored
Initialize MetadataBoxController and QuickViewController only when it is needed. This CL doesn't lazy load polymer element of quick view. It will be done with subsequent CL(s). BUG=675536 TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2589133002 Cr-Commit-Position: refs/heads/master@{#439797}
-
pastarmovj authored
BUG=629512 TEST=Builds both 32 and 64 bit dlls on a 32bit build system. Review-Url: https://codereview.chromium.org/2590433003 Cr-Commit-Position: refs/heads/master@{#439796}
-
vabr authored
MakeWeakCopies is a helper function inside the FormFetcherImpl implementation. It transforms a vector of unique_ptrs into the result of calling get() on them. It used to be used for pointers of different types, therefore it was a function template. But after https://codereview.chromium.org/2552263002, MakeWeakCopies is only used with PasswordForms. This CL: * Converts MakeWeakCopies to a simple function. * Removes some unnecessary "autofill::" in the same file. BUG=621355 R=vasilii@chromium.org Review-Url: https://codereview.chromium.org/2587313002 Cr-Commit-Position: refs/heads/master@{#439795}
-
robertphillips authored
The rebaseline request was landed in https://codereview.chromium.org/2573803002/ (Bump CSSFilterEffects pixel test revision number to force rebaseline) BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2588793002 Cr-Commit-Position: refs/heads/master@{#439794}
-
oka authored
BUG=613465 TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2592593002 Cr-Commit-Position: refs/heads/master@{#439793}
-
jif authored
When the iPad Tab Switcher creates an incognito tab for the first time, an incognito BVC is created. The Tab Switcher takes a screenshot of the new incognito tab, and animates its size from a small cell to a fullscreen tab. Before this CL, the first incognito tab was created with an incorrect size, resulting in the screenshot used in the animation being incorrect. BUG=671724 Review-Url: https://codereview.chromium.org/2591683002 Cr-Commit-Position: refs/heads/master@{#439792}
-
altimin authored
Review-Url: https://codereview.chromium.org/2593603002 Cr-Commit-Position: refs/heads/master@{#439791}
-
jochen authored
BUG=664838 R=mlamouri@chromium.org Review-Url: https://codereview.chromium.org/2590183002 Cr-Commit-Position: refs/heads/master@{#439790}
-
maksim.sisov authored
Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601905,601903,601900 Review-Url: https://codereview.chromium.org/2090713003 Cr-Commit-Position: refs/heads/master@{#439789}
-
pastarmovj authored
The dll will always be present but only registered when running a system install because we need access to the LOCAL_MACHINE hive. BUG=642115 TEST=setup_util_unittest,mini_installer,manual Review-Url: https://codereview.chromium.org/2507753002 Cr-Commit-Position: refs/heads/master@{#439788}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62479fdb..32db0e1a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2595513002 Cr-Commit-Position: refs/heads/master@{#439787}
-
magjed authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/37d7b3f..ba5e7e2 $ git log 37d7b3f..ba5e7e2 --date=short --no-merges --format=%ad %ae %s 2016-12-20 nisse@webrtc.org Delete unused method PayloadRouter::MaxPayloadLength. 2016-12-20 danilchap@webrtc.org Style cleanup in RTCPReceiver Rename variables and private functions to follow style, replace remaining asserts with DCHECKs. add 'ms' suffix to time variables derived from clock_ add 'ntp' suffix to time variables derived from ntp time. No functional changes expected. 2016-12-20 magjed@webrtc.org Revert of Add disabled certificate check support to IceServer PeerConnection API. (patchset #8 id:140001 of https://codereview.webrtc.org/2557803002/ ) 2016-12-20 henrik.lundin@webrtc.org Add a unit test for Opus complexity adaptation 2016-12-19 zhihuang@webrtc.org Add an abstract class for IceTransport 2016-12-19 brandtr@webrtc.org Add GUARDED_BY's in FlexfecReceiver. 2016-12-19 brandtr@webrtc.org Clean up storage of FlexFEC payload type in webrtc::VideoCodecSettings. 2016-12-19 danilchap@webrtc.org Revert of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame. (patchset #1 id:1 of https://codereview.webrtc.org/2574943003/ ) 2016-12-19 hbos@webrtc.org Removed undefined method from webrtcsession.h. 2016-12-19 johan@webrtc.org Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame. 2016-12-19 asapersson@webrtc.org Move histogram for number of pause events to per stream: 2016-12-19 kthelgason@webrtc.org Reland of Properly report number of quality downscales in stats. (patchset #1 id:1 of https://codereview.webrtc.org/2586783003/ ) 2016-12-19 henrik.lundin@webrtc.org Re-enable Opus complexity tests on Android 2016-12-19 kthelgason@webrtc.org Revert of Properly report number of quality downscales in stats. (patchset #11 id:220001 of https://codereview.webrtc.org/2564373002/ ) 2016-12-19 kwiberg@webrtc.org CodecInst operator<< 2016-12-19 asapersson@webrtc.org Reland of Disabling NOTREACHED which we're hitting flakily in browser tests. (patchset #1 id:1 of https://codereview.webrtc.org/2585183002/ ) 2016-12-19 brandtr@webrtc.org Add multithreaded fake encoder and corresponding FlexFEC VideoSendStreamTest. 2016-12-19 hbos@webrtc.org Fix segfault when PeerConnection is destroyed during stats collection. 2016-12-19 kthelgason@webrtc.org Properly report number of quality downscales in stats. 2016-12-19 hbos@webrtc.org RTCStatsCollector: Utilize network thread to minimize thread hops. 2016-12-19 philipel@webrtc.org Now expect the correct number of streams in EndToEndTest.GetStats. 2016-12-19 hnsl@webrtc.org Add disabled certificate check support to IceServer PeerConnection API. 2016-12-19 denicija@webrtc.org Add QP stats to the statsview in AppRTCMobile for ios. 2016-12-19 henrik.lundin@webrtc.org Revert of Re-enable Opus complexity tests on Android (patchset #1 id:1 of https://codereview.webrtc.org/2589673002/ ) 2016-12-19 henrik.lundin@webrtc.org Re-enable Opus complexity tests on Android 2016-12-19 brandtr@webrtc.org Move FlexfecReceiveStream from api/call/ to call/. 2016-12-18 asapersson@webrtc.org Revert of Disabling NOTREACHED which we're hitting flakily in browser tests. (patchset #1 id:1 of https://codereview.webrtc.org/2477663002/ ) 2016-12-18 kjellander@webrtc.org Move tools/mb -> tools-webrtc/mb 2016-12-17 magjed@webrtc.org Put iOS H264 High profile under a field trial 2016-12-17 kjellander@webrtc.org Move tools/valgrind-webrtc -> tools-webrtc/valgrind 2016-12-16 skvlad@webrtc.org Revert of Delete unused code from systeminfo. (patchset #3 id:40001 of https://codereview.webrtc.org/2578323005/ ) TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2588273003 Cr-Commit-Position: refs/heads/master@{#439786}
-