GitLab

https://chromium.googlesource.com/chromium/src/+/461aa3adc

BUG=568678
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/1520633002 .

Cr-Commit-Position: refs/heads/master@{#364464}

The patch implements WI.SASSSupport.diffModels method, which computes
diff of two AST models.

The current implementation doesn't handle rule diff, i.e. adding
and removing rules, or modification of rule selectors.

BUG=527993
R=pfeldman

Review URL: https://codereview.chromium.org/1504923008

Cr-Commit-Position: refs/heads/master@{#364463}

This CL cleans the SyncBackendHostImpl unittest of //content and //chrome
dependencies and moves it into its proper location next to the production code
that it is testing.

BUG=544975

Review URL: https://codereview.chromium.org/1516433004

Cr-Commit-Position: refs/heads/master@{#364462}

Review URL: https://codereview.chromium.org/1512813003

Cr-Commit-Position: refs/heads/master@{#364461}

Add a simple JavaScript v8 wrapper for Contextual Search, that just defines chrome.contextualSearch.setCaption(String, Boolean);

Adds a simple Contextual Search component with mojo communication to handle enabling of the v8 wrapper only on a renderer which is presented in the Contextual Search Overlay view.

BUG=523554

Review URL: https://codereview.chromium.org/1385663002

Cr-Commit-Position: refs/heads/master@{#364460}

This change removes the logic from the close button that disables
the Reader Mode panel for a particular tab. Now refreshing the page
will reshow the panel.

BUG=

Review URL: https://codereview.chromium.org/1514603004

Cr-Commit-Position: refs/heads/master@{#364459}

Review URL: https://codereview.chromium.org/1514523004

Cr-Commit-Position: refs/heads/master@{#364458}

BUG=564667

Review URL: https://codereview.chromium.org/1511753004

Cr-Commit-Position: refs/heads/master@{#364457}

The recording was disabled in https://codereview.chromium.org/1464313007/

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1511743004

Cr-Commit-Position: refs/heads/master@{#364456}

Instead of requiring an expectations file for DumpAccessibilityTree tests,
just skip tests without an expectations file on that platform. Make it easier
to rebaseline expectations by automatically overwriting expectations of
failing tests when the user passes a command-line switch to
content_browsertests: --generate-accessibility-test-expectations

This lets us delete a bunch of empty expectations files and more easily
see at a glance which files are missing expectations for which tests.

BUG=none

Review URL: https://codereview.chromium.org/1505903002

Cr-Commit-Position: refs/heads/master@{#364455}

This sets the default for minidump upload to being disabled from command
line flag (if enabled, then depends on user and network preferences).
Also, separates out the case of command line disabled uploads, such that
the associated minidumps are not uploaded, and also not deleted.

BUG=538340

Review URL: https://codereview.chromium.org/1461883003

Cr-Commit-Position: refs/heads/master@{#364454}

Review URL: https://codereview.chromium.org/1517623002

Cr-Commit-Position: refs/heads/master@{#364453}

As part of serializing cc::LayerTreeHost, we also need to
serialize the cc::LayerTreeSettings.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1504273002

Cr-Commit-Position: refs/heads/master@{#364452}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f45287d1..3b13f76f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1512353002

Cr-Commit-Position: refs/heads/master@{#364451}

Revert of mash: Add a couple of apptests for AcceleratorRegistrar. (patchset #2 id:20001 of https://codereview.chromium.org/1510713002/ )

Reason for revert:
AcceleratorRegistrarTest.AcceleratorsRemovedOnHandlerDestroy is flaky on both trybots and the main waterfall (see https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/35418 for one random example where it failed).

BUG=568634

Original issue's description:
> mash: Add a couple of apptests for AcceleratorRegistrar.
>
> . Test that different AcceleratorRegistrars get different namespaces, and so can
>   install accelerators with the same id.
> . Test that differentl registrars do not allow registering accelerators with the
>   same event matcher.
> . Test that destroying an AcceleratorHandler removes associated accelerators.
>
> BUG=548363
>
> Committed: https://crrev.com/8aac81dc92c8eaaec476b0c6c5ccf3e114590b68
> Cr-Commit-Position: refs/heads/master@{#363719}

TBR=ben@chromium.org,sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=548363

Review URL: https://codereview.chromium.org/1516013002

Cr-Commit-Position: refs/heads/master@{#364450}

BUG=568386

Review URL: https://codereview.chromium.org/1514133002

Cr-Commit-Position: refs/heads/master@{#364449}

Review URL: https://codereview.chromium.org/1517753002

Cr-Commit-Position: refs/heads/master@{#364448}

This was mistakenly removed in https://codereview.chromium.org/1510083002.
https://codereview.chromium.org/1508363002 makes this clear also.

BUG=555381
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/1506013006

Cr-Commit-Position: refs/heads/master@{#364447}

Domain Reliability reports details of URL requests with a certain
probability (sample rate). By including the sample rate in the
beacon, the collector can estimate how many other requests (on
average) were not reported.

BUG=567307

Review URL: https://codereview.chromium.org/1497803004

Cr-Commit-Position: refs/heads/master@{#364446}

BUG=525142

Committed: https://crrev.com/42290cb91a66566637a1715737b1961a8480b934
Cr-Commit-Position: refs/heads/master@{#363785}

Review URL: https://codereview.chromium.org/1438603002

Cr-Commit-Position: refs/heads/master@{#364445}

This is a major change to |HeapDumpWriter| which enables it to dump the
format described in https://goo.gl/KY7zVE. This will allow the heap
profiler to break down the heap by type or backtrace, but also
combinations of those.

This changes the interface of |HeapDumpWriter| slightly from a two-step
process (insert allocations, dump json) to a three-step process (insert
allocations, compute what to dump, convert to json). The main reason for
doing this is testability. Aggregation and json conversion are now
completely orthogonal. This means that the aggregation algorithm can be
tested without having to parse the json first, and the json conversion
is simpler to test too.

This is part of the heap profiler in chrome://tracing.

BUG=524631

Review URL: https://codereview.chromium.org/1494293005

Cr-Commit-Position: refs/heads/master@{#364444}

BUG=568610
TBR=thakis@chromium.org,jschuh@chromium.org

Review URL: https://codereview.chromium.org/1518823002

Cr-Commit-Position: refs/heads/master@{#364443}

Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated
for the target platform, and the nmf format is different hence
requiring a different action.

BUG=462791

Review URL: https://codereview.chromium.org/1494423002

Cr-Commit-Position: refs/heads/master@{#364442}

Use TileTask instead of RasterTask, because TaskSetFinishedTaskImpl
could be there as well. The bug was found by Control Flow Integrity check,
and is similar to two previously fixed bugs:

https://codereview.chromium.org/1494273002/
https://codereview.chromium.org/1248923002

BUG=568407,457523
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1515843002

Cr-Commit-Position: refs/heads/master@{#364441}

It's enabled by default both in clang and in recent gccs.

BUG=none

Review URL: https://codereview.chromium.org/1502233005

Cr-Commit-Position: refs/heads/master@{#364440}

Test was disabled because number of calls to
PersonalDataManager::Refresh didn't match expectation. I think this
happened because calls to Refresh were posted to UI thread, but test
didn't run message loop at the end of the test.

BUG=57884
R=zea@chromium.org

Review URL: https://codereview.chromium.org/1511333003

Cr-Commit-Position: refs/heads/master@{#364439}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/30fe5e762e06261..66cf29b1bc869b

This updates from VER-2-6-1 + 1 to VER-2-6-2.

It is expected that this will change the weight of CFF fonts.
If this becomes undesireable, there is a patch which can be applied.

BUG=chromium:551028

Review URL: https://codereview.chromium.org/1518643003

Cr-Commit-Position: refs/heads/master@{#364438}

This removes all of the base class members from display item and instead
calculates them during allocation.  This is done by processing each item
as it is added, which requires passing in all the ctor args to
CreateAndAppendItem.  This reduces the size of all display items by 16
bytes so that the largest is now "only" 80 bytes and the smallest is 8.

Also, DisplayItemList had a bug where it would allocate an item,
(maybe) process all added items, and then SetNew on that last item.  In
that case, the processing would skip the final item because it was just
a newly allocated item.  This patch fixes that by the above changes
to CreateAndAppendItem.

R=vmpstr@chromium.org,chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1494223003

Cr-Commit-Position: refs/heads/master@{#364437}

Also, submit another data use report if previous report has
been pending for more than 2 minutes. This prevents
ExternalDataUseObserver from getting blocked in case the
call back fails.

BUG=540061

Review URL: https://codereview.chromium.org/1491793002

Cr-Commit-Position: refs/heads/master@{#364436}

Pass all object parameters to JNI methods in JavaParamRef<> wrappers.
This matches previous changes made to do this for JNI non-method
functions.

BUG=506850

Review URL: https://codereview.chromium.org/1509373004

Cr-Commit-Position: refs/heads/master@{#364435}

BUG=527588

Review URL: https://codereview.chromium.org/1512973003

Cr-Commit-Position: refs/heads/master@{#364434}

BUG=skia:4644

Review URL: https://codereview.chromium.org/1520453003

Cr-Commit-Position: refs/heads/master@{#364433}

The function AcquireIOSurface accounts for most of the situations where
GpuMemoryBuffer allocation fails.

Add a CHECK that mach_port_allocate succeeds, because there is no
recovery for being out of resources in this way.

Add a CHECK that, if the browser returns Mach port, that port is valid
can be successfully opened as an IOSurface. This should never be hit,
because the browser should return a valid port if it reports success.

Add a CHECK that mach_msg succeed. The suspicion is that this will
account for all failures of AcquireIOSurface (and that this particular
part of the patch will need to be reverted due to high crash rates).

BUG=554541

Review URL: https://codereview.chromium.org/1503393006

Cr-Commit-Position: refs/heads/master@{#364432}

These are failing on the official builders. A fix for that is out for
review, but in the mean time this disables those tests to get the bots
green.

BUG=567497
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/1513573008

Cr-Commit-Position: refs/heads/master@{#364431}

Per conversation with UX, this change updates the height of the extensionview in route-details to 136px from 160px. The custom controls provided for the extensionview should be cropped/scaled to fit the extensionview from the provider side.

BUG=567807

Review URL: https://codereview.chromium.org/1511603006

Cr-Commit-Position: refs/heads/master@{#364430}

BUG=138542, 488550

Review URL: https://codereview.chromium.org/1499423004

Cr-Commit-Position: refs/heads/master@{#364429}

The animation between peeking and maximized states is too fast. This
change adds 200ms to that animation duraton.

BUG=

Review URL: https://codereview.chromium.org/1511023003

Cr-Commit-Position: refs/heads/master@{#364428}

The code was cut and pasted and kept its old namespace.

Remove SkPointToCGPoint and CGPointToSkPoint, which were not used anywhere.

BUG=561010

Review URL: https://codereview.chromium.org/1508893003

Cr-Commit-Position: refs/heads/master@{#364427}

BUG=

Review URL: https://codereview.chromium.org/1504713013

Cr-Commit-Position: refs/heads/master@{#364426}

This is a follow-up to https://codereview.chromium.org/1507413003/ and
lets all translation units in a release build build if -Wextra is enabled
for chromium_code targets.

(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)

BUG=567877

Review URL: https://codereview.chromium.org/1513043002

Cr-Commit-Position: refs/heads/master@{#364425}