GitLab

Bug: 768881
Change-Id: Ie82d66ef053ea88461ae9d65eface09e513ba3c7
Reviewed-on: https://chromium-review.googlesource.com/1057432
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558876}

BUG=843212

Change-Id: Iab38833fabfe1c6729c76419d50e39cfe7eb098a
Reviewed-on: https://chromium-review.googlesource.com/1060384Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558875}

Under X11 we use the VK_KHR_xlib_surface extension but this extension is
not supported by VK_LAYER_LUNARG_standard_validation. When these
extensions are used together, the validation layer never observes the
surface creation and fails the first time it is used.

Disable VK_LAYER_LUNARG_standard_validation so that debug builds can be
used with vulkan under X11.

Bug: 843346
Test: vulkan_tests with debug build

Change-Id: I4a42a8adb134a62043a14d416ae30f02e254cbd6
Reviewed-on: https://chromium-review.googlesource.com/1060459Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558874}

To ensure the ripple animation works when transitioning the
search box drawable between the NTP and the Toolbar, we need
to share the same drawable (including local state).  We need
to also ensure the bounds of the drawable is reset when
transitioning owners between the toolbar and the NTP.


Change-Id: I35261971da8f19c81d5764872912ea0cc93379ad
Reviewed-on: https://chromium-review.googlesource.com/1054851
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558873}

Bug: 834167
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ib3477a3d53ec89736cb334abb2349a728d980968
Reviewed-on: https://chromium-review.googlesource.com/1059732Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Greg Daniel <egdaniel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558872}

Fix border, background, and mask painting for inline blocks spanning two
or more lines or that are otherwise fragmented across multiple entities.

This involved refactoring the existing inline box painting code to allow
code sharing between legacy and LayoutNG painting code. It also required
changing LayoutNG painting to further distinguish between inline and non
inline boxes as the background image painting code in particular require
taking the other fragments for a fragmented object into account when the
image offsets and clipping is computed.

Finally, this cleans up the flow box paint logic for both legacy and NG.

Bug: 714962
Test: fast/backgrounds/border-radius-split-background-image.html
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If8e987c313c2792090908f181800448da54f133d
Reviewed-on: https://chromium-review.googlesource.com/1058677
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558871}

Change-Id: I361f46b8e27fca1813f004d542c6060ee255def6
Reviewed-on: https://chromium-review.googlesource.com/1060460Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558870}

This class is no longer used, and can be removed.  acondor@ noticed
this.  Thanks Aldo!

BUG=
R=tiborg

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I671c1daedda6fb28d54be7160d2c46e43ed22364
Reviewed-on: https://chromium-review.googlesource.com/1058015Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558869}

There is still work to be done here, but this is a good step. The
interesting parts:
. An aura::WindowTargeter is used to ensure events target the right
  Window. In particular if one client intercepts events from another
  client.
. Custom EventHandlers are used to forward to the remote client. This
  is mildly tricky to ensure top-levels are handled correctly.

BUG=837692
TEST=covered by test

Change-Id: I58f0d23e7d7dd6c6c31f3cfbb44889588c4f8f84
Reviewed-on: https://chromium-review.googlesource.com/1054427
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558868}

A while back there were a series of viz_browser_tests that were timing out on
Windows trybots.

There was no stack traces at the time. We could no reproduce these locally.
However there were a bunch of other timeouts happening on Windows outside of
viz configurations at the time.

This speculatively re-enables those tests.

viz_browser_tests is not currently on Windows CQ so Windows related failures
will only affect our FYI bots.

TBR=kylechar@chromium.org
TEST=viz_browser_tests

Bug: 821029
Change-Id: I8a1d3369915da11e0110c9bf9611d0130fb8f470
Reviewed-on: https://chromium-review.googlesource.com/1060417Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558867}

Instead of directly calling SafeSeedManager::RegisterPrefs, WebView
should call VariationsService::RegisterPrefs, as Chrome does.
VariationsService::RegisterPrefs calls SafeSeedManager::RegisterPrefs
and VariationsSeedStore::RegisterPrefs. The latter registers
kVariationsSafeCompressedSeed, which prevents the crash:
"Trying to read an unregistered pref: variations_safe_compressed_seed".

BUG=842934

Change-Id: I2f4fa631c2e03ecc650bb051e2050a89b7676e6e
Reviewed-on: https://chromium-review.googlesource.com/1060427Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558866}

Previously we cancelled any active interaction because we couldn't tell
if the active interaction was from a voice or a text query. Now that
AssistantQuery has been subclassed into AssistantTextQuery and
AssistantVoiceQuery, we can tell if the current query is voice
or text.

Bug: b:79756284
Change-Id: I90f5599ac51c3aad72b029f4de7cd253387a5b6a
Reviewed-on: https://chromium-review.googlesource.com/1060337Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#558865}

This metric was helpful in narrowing down problems to SafetyNet, but
there are better SafeBrowsing internal metrics for this now.

Bug: None
Change-Id: I38e07af1b4923a98333a45d9b61b1a00c5ce5ae4
Reviewed-on: https://chromium-review.googlesource.com/1060260Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558864}

The code coverage reports from llvm-cov will emit detailed coverage
information for instantiated templates, but by default, will emit
the method names using their mangled form. llvm-cov allows for
providing a custom demangler.

This conditionally provides custom demangler, using c++filt when
running on Linux and macOS. Longer-term, a solution based on
llvm-symbolizer is more desirable for platform neutrality, but
this helps bridge the short-term need.

BUG=843246

Change-Id: I718016b05af0842ac148d06e968f362bc68b5fc8
Reviewed-on: https://chromium-review.googlesource.com/1060264
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558863}

The version of the global interface should be increased when the
protocol is modified, as it is how we detect a version incompatibility
immediately on bootup.
For consistency, the version of zcr_notification_surface_v1 is also
increated in this CL.

Bug: 829383, 834027
Change-Id: I33e8fbdbe0798e70743ad2af83e4ada80e7797dc
Reviewed-on: https://chromium-review.googlesource.com/1055030Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558862}

As suggested in
https://chromium-review.googlesource.com/c/chromium/src/+/1035091
since we'll need to add this to content/browser/DEPS and the
WebURLError class isnt' a good fit for this.

Bug: 838291
Change-Id: I95491371a70fa4d765328b25d89f0a69149cc071
Reviewed-on: https://chromium-review.googlesource.com/1060111Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558861}

There are currently a set of FYI bots running Viz varients of test suites:
  --enable-features=VizDisplayCompositor

This change ads a viz variant of interactive_ui_tests to these FYI bots. So that
we can begin getting coverage of this suite.

TEST=viz_interactive_ui_tests

Bug: 843331
Change-Id: Id56e2f8f0f1748823d5c17d938ff0582c066301c
Reviewed-on: https://chromium-review.googlesource.com/1060423Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558860}

TBR=nodir@chromium.org

Bug: 776178
Change-Id: I776aa0c16d989cb3e5388aa674cb0f5561725b8d
Reviewed-on: https://chromium-review.googlesource.com/1060251Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558859}

When filling forms, we fill section by section. Therefore, when
clearing them, we should also clear section by section. Meaning that
only the section to which the clicked element belongs should be cleared.

Example:

If the user fills a shipping address and then a billing address, and
then they decide to clear the shipping address, they should be able
to clear only that section. Currently, we would clear the whole form.

This could also help us for solving the problem of placeholders in
the future.

We won't change the string "Clear form", bc in everyday language,
one form would most likely refer to a logical section.

Test added.

Bug: 816941

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I61862c9eeff6139d889381fd5de97c0712972572
Reviewed-on: https://chromium-review.googlesource.com/1048408
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558858}

R=vadimsh@chromium.org

Bug: 731542, 790165, 731544, 790171, 731354, 790170, 776178, 790167
Change-Id: I16904d084b758f41037361779e1f57a7f32e2a24
Reviewed-on: https://chromium-review.googlesource.com/1060383Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558857}

Creates tableviewcellaccessoryitem and tableviewcellaccessorycell. Implements it for "show full history" cell in Recent Tabs.

Screenshot: https://drive.google.com/open?id=1yYsY1BMOgqLV1jz6G8x-oOlOHTlsAEih

Change-Id: I60a911a12fe95f24d706c669f85ef08691ad911e
Reviewed-on: https://chromium-review.googlesource.com/1053351
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558856}

BUG=None

Change-Id: I5bca24884e190cbe1d599360f85b250a1fe4aff0
Reviewed-on: https://chromium-review.googlesource.com/1060234Reviewed-by: Carlos Pizano <cpu@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558855}

It makes no sense to allow a frame_rect with overflowing max
coordinates. This doesn't come up in actual pages, but it is a source
of annoying fuzzer bugs.

R=skobes@chromium.org,bokan@chromium.org
BUG=842417

Change-Id: I5b1435f5972b160fbf5f1daaf4bae7ef00748608
Reviewed-on: https://chromium-review.googlesource.com/1060027Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558854}

Before this change, only output pictures were traced. This CL adds
tracing for the output (task) queue and the reorder queue. This memory
is held in IOSurfaces, and isn't attributed to Chrome in other ways.

Based on results from this new memory tracing, this CL increases the
number of requested picture buffers significantly, to avoid
pathological cases where we continue to decode pictures after running
out of picture buffers.

Bug: 840548
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I026a8b4126a176112919f47e30c42f11e1f96b7c
Reviewed-on: https://chromium-review.googlesource.com/1053222
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558853}

Because RunSegmenter needs pre-context but is forwad-only, it
scans the input string from the beginning for each shaping.
This characteristics does not work well with LayoutNG, where
it constructs a string for each block, segment it, and use
range shaping for each segment.

This patch keeps a cache of RunSegmenter in HarfBuzzShaper
instance, and re-use if caller shapes multiple ranges
incrementally.

This change turns 90 Timeouts in LayoutNG, 6 out of it to
Failure and others to Pass.

56 Timeouts are still left, probably from other reasons.
Most looks like testharness tests, probably from large
text files. I will look into them after this.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I09afa9c9bd38de09189b0242cc00e5d8dc739042
Reviewed-on: https://chromium-review.googlesource.com/1053346
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558852}

https://chromium.googlesource.com/angle/angle.git/+log/966cd5076be3..01e83581864b

$ git log 966cd5076..01e835818 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 geofflang Add dEQP EGL expectations OpenGL on Windows.
2018-05-10 lucferron Vulkan: Pre-work for copyImage/copySubImage features

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ida342dadbc543a0eaeb1c34cc49d0165657b24ea
Reviewed-on: https://chromium-review.googlesource.com/1060100Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558851}

TBR=mmoroz@chromium.org

Change-Id: Id96ec7a5d2ed444c613ccb324ed47c9df95eb6bc
Reviewed-on: https://chromium-review.googlesource.com/1060457Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558850}

Adds a message size check to the case where
ChannelAssociatedGroupController must post a task to the IO thread
before sending a message. This will allow us to extract useful stack
information from such message size violations.

Bug: 840388
Change-Id: I6861252dcc3451d4551c84e7e389566e8c62dced
Reviewed-on: https://chromium-review.googlesource.com/1059587Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558849}

The WebLayer* given to SetWebLayer() must be kept alive until /after/
the next call to SetWebLayer(), as the client will hold and use that
pointer, including inside the next SetWebLayer() call.

R=xhwang@chromium.org

Bug: 843114
Change-Id: Iee4bc139f02f918f60e7b13455ed2b47bedaa1b9
Reviewed-on: https://chromium-review.googlesource.com/1059698
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558848}

This CL introduces a new experimental feature
'document-stream-insertion' whose purpose is to limit the usage of
specific (anti-pattern) javascript API for "dynamic markup insertion".

The list of javascript methods to be blocked by this feature are:
document.{write, writeln, open, close}.
The set of disabled APIs is a subset of "dynamic-markup-insertion" from
HTML spec:

https://dev.w3.org/html5/spec-LC/apis-in-html-documents.html#dynamic-markup-insertion
https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#dynamic-markup-insertion

Bug: 841605
Change-Id: I9cc31fab36e2cea70cdce575e3868ce1d0cfecfa
Reviewed-on: https://chromium-review.googlesource.com/1053349Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558847}

R=primiano@chromium.org
BUG=839060

Change-Id: I12fce3acecc060ade7ea98b1c1556f40dcc4a4c9
Reviewed-on: https://chromium-review.googlesource.com/1048565Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558846}

This is to avoid the possible race when the page is
refreshed (so the callback id is now invalid) and the result
of GetIsPinnedToTaskbarState() from the previous javascript
call is received before the current page calls
getPinnedToTaskbarState().

Bug: 842925
Change-Id: I41e8cd3a40d22f98f020eb7bd02487713a62df98
Reviewed-on: https://chromium-review.googlesource.com/1058929Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558845}

It's not really used, we can use DragOperation instead.

Change-Id: I85b997c9534dc7ce6522a9806a4d7bc4e8f82642
Reviewed-on: https://chromium-review.googlesource.com/1058589Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558844}

(Reland of ea78046d with win compile fix.)

Change-Id: Iac81b6de149d42edf7bd5b2954d2a8ddc106a52f
Reviewed-on: https://chromium-review.googlesource.com/1058444
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558843}

TBR=zmo

Bug: 840394
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I61e8896bfff86145b124b9d4b24a59e5f31c756a
Reviewed-on: https://chromium-review.googlesource.com/1060014
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558842}

This updates the bindings generators and hard-coded interface names in
tests and the service_manager.

The remainder of the CL was generated by:

for f in $(find . -name '*.json' -not \( -path './out/*' -o -path './third_party/*' -o -path '*.xcassets/*' \)); do
  grep interface_provider_spec "./$f" >/dev/null && gsed -i s/::/./g "$f";
done

Tbr: jam@chromium.org
Bug: 835446
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0bb22615b9c66824c6f95da66e3d7016809d63c7
Reviewed-on: https://chromium-review.googlesource.com/1026419
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558841}

This updates the JS autocomplete keyword list with keywords from
Section 11.6.2.1
https://www.ecma-international.org/ecma-262/8.0/index.html

Screenshot: https://imgur.com/a/sX1wOP7

Bug: none
Change-Id: Ia555723e35311a83d6e64f19fc253a3ea9368384
Reviewed-on: https://chromium-review.googlesource.com/1058562Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558840}

Bug: 842929
Change-Id: I2e4f67cd3ae1620f6c4cb6fdfeb2a99139168f04
Tbr: mvanouwerkerk@chromium.org
Tbr: tedchoc@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1060119Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558839}

A double cannot hold all of the values that an int64_t can hold, and
this is certainly true for the max() and min() values. Adding a cast
suppresses a new VC++ warning and makes it explicit that some rounding
is going on.

Change-Id: I8373f6784360a0c71ed3f27fc21aec4bc8c1e77f
Reviewed-on: https://chromium-review.googlesource.com/1053730
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558838}

The goal of this CL is to understand whether TimeToReadyToCommit
regressions with --site-per-process are affected by whether the
navigation is for a main frame or subframe.

Bug: 808114
Change-Id: Ib55b51f2b777defc508443788cc036866e638075
Reviewed-on: https://chromium-review.googlesource.com/1058606
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558837}