GitLab

This reverts commit 1af1bc07.

Reason for revert: Blocking the Chrome on Chromeos uprev.

https://bugs.chromium.org/p/chromium/issues/detail?id=1123901#c6

Original change's description:
> arcvm: Start arcvm-adbd on starting ARCVM
> 
> This CL depends on the following CLs:
> https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2380431
> https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2378806
> https://chrome-internal-review.googlesource.com/c/chromeos/overlays/project-cheets-private/+/3238221
> 
> BUG=b:166314117
> TEST=arc.Boot.vm still passes, arcvm-adbd runs
> 
> Change-Id: I385a807d84a98b4a97dcc66daf6bef5881eef2bd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380733
> Commit-Queue: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803035}

TBR=yusukes@chromium.org,hidehiko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:166314117
Change-Id: I30644f24fbe139330a54e88aefc1b73c0340340e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392625Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804337}

The basename suffix '_test_helpers' (with an 's' at the end) gets
special treatment by audit_non_blink_usage.py: like other test code,
it's exempt from the audit. This came up when trying to use
the css_test_helpers namespace in a new animation_test_helper.h/cc
util, which was frowned upon by audit_non_blink_usage.py.

This CL also wraps the functions in a animation_test_helpers namespace.
This is just something I recommend, and not strictly required. (It
makes it less risky and more acceptable to add new helpers with
"common" names, like CreateAnimation).

Change-Id: I627fa6987c5dfad9b7c1d1452de10b07ee9b8ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391221Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804336}

https://android.googlesource.com/platform/external/perfetto.git/+log/5383c636752f..f39c62ab1284

2020-09-03 fmayer@google.com Merge "Check if target process has exited first."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ie1bbf442efcee24948b266e82ae38a88fc0757a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392719Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804335}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/600d59e343a0..fa82803f46aa

2020-09-03 madigens@gmail.com * ChangeLog: Add entry for last commit.
2020-09-03 dalboris@gmail.com Export version info (#58935)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I11ce70217ed73add9f3600415a200da959f13f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392352Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804334}

When the touch-selection context menu is re-shown after moving one of
the selection handles, it goes through RenderWidgetHostViewAndroid which
always sends the request to the mainframe renderer, which is incorrect
when the selection is inside an OOPIF.

This CL fixes it by having TouchSelectionControllerClientManagerAndroid
route the request to the manager's currently active client. If the
selection is in an OOPIF, then TouchSelectionControllerClientChildFrame
will handle it.

We still need to develop tests for touch handle movements & context
menus, both for OOPIFs and main frames.

Bug: 977215
Change-Id: I3649af49839778fea4462b35b1b11349e00edcc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382227
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804333}

Fixed version with integration test to guard against the bug that
required the revert.


Original message:

Use IncognitoTabModelObserver to break IncognitoTabModel->.incognito

Two new classes IncognitoNotificationPresenceController and
IncognitoProfileDestroyer now bind the TabModelSelector to the
.incognito package, controlling respectively the incognito notification
and the incognito Profile destruction.

Since TabModelSelectorBase creates the TabModels only after native load,
it acts as a relay for the events. It is changed to recognize that there
are two TabModels, one normal and one incognito, so it can observe the
incognito one.

Splitting IncognitoTabModel into interface and impl keeps tests from
having to depend on IncognitoTabModelImpl.

Bug: 1109013
Change-Id: I04421e2f58e7ab498fbab31657175ee5e2c310b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378733Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804332}

If the <munder>, <mover> or <munderover> elements have a computed
math-style property equal to compact and their base is an embellished
operator with the movablelimits property, then their layout algorithms
are respectively the same as the ones described for <msub>, <msup> and
<msubsup>. In this CL we delegate to the scripts algorithm which is
changed to be able to handle script types over, under and underover.

This CL does not handle embellished operators as defined [2] but just
the first case, i.e. <mo> elements but not the two other cases, to
simplify this CL.

To handle dynamic changes to the movablelimits attribute on <mo>
UpdateFromElement is implemented on LayoutNGMathMLBlockFlow.

To handle dynamic changes to attributes (like displaystyle) on math
elements UpdateFromElement is implemented on LayoutNGMathMLBlock.

[1] https://mathml-refresh.github.io/mathml-core/#children-of-munder-mover-munderover
[2] https://mathml-refresh.github.io/mathml-core/#embellished-operators

Bug: 6606
Change-Id: Ib4af58ed88b7d41944f4d4676bba812c3b7a3a2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383023Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#804331}

Rerecord the tests on Mac OS.
Upload the rendering_desktop_e0cf9b9bd8.wprgo to chrome-partner-telemetry.
Unzip the wprgo file to make sure the expected URL
"http://kenrussell.github.io/webgl-animometer/Animometer/tests/3d/webgl-indexed-instanced.html?webgl_version=2\u0026use_attributes=1\u0026use_multi_draw=1\u0026num_geometries=120000"
appears.

This should fix the request failure issue on current perf bots.

Bug: 890539
Change-Id: I4f409d4304cc910c81f4275780d3578c195349ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391595Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#804330}

https://imgur.com/a/OxpFoac

Change-Id: I07d79f0b682cf8da7ca1416a7882d34b560ee767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390963Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804329}

print_class_dependencies.py is used to audit deps, and normally we look
at outbound deps and inbound deps at different points and in different
situations.

Change-Id: Ie331b7502ff09827a3ddf08a6c2cc3b8d7183b90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391593
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804328}

This CL adds extra logging to NavigateToURLInSameBrowsingInstance that
was blamed for the first failed test assertion in the log stored in
https://crbug.com/859487#c3.

This CL doesn't contain any actual fix for the flakiness, but reenables
the test anyway, because
1) the test passed 50 times when run locally
2) hopefully the extra logging will help diagnose the flakiness if the
   test starts flaking again on the bots

Fixed: 859487
Change-Id: I90caf66b0ffbbd341a5c8cd00a5605d509aa31d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390998
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804327}

This is a reland of 0ad6a0b8

This CL fixes the _partial_java rule, which was failing due to
android resource issues in the original CL.

Original change's description:
> Replace AndroidX Preference[Dialog]FragmentCompat with the version from master
>
> This CL replaces the PreferenceFragmentCompat and
> PreferenceDialogFragmentCompat classes in the AndroidX preference
> library with the version from master, which has a change needed for
> WebLayer. The preference library maintainers say they won't create a new
> release just for this fix, so to get it we'll have to pull it in
> ourselves.
>
> Bug: 1092986
> Change-Id: I0e1c936f6372cb541cabfa29c2aea0d0ee7225fb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253029
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802334}

Bug: 1092986
Change-Id: I3330d3d5f9f9c1732cc853a8a3ab5fb59595a4a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382617
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804326}

Currently, we lazily initialize document the first time it is requested
*and* all of the data is loaded (https://crbug.com/1107442 fixed a case
where we would incorrectly initialize the document by creating it before
all of the data had been received).

It's much clearer to just initialize the document when all of the data
is received, and have GetDocument() be a simple getter.

Change-Id: I830dca5cc953ca8467fd936f5c783db21cfce051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316415
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804325}

This patch has the initial implementation of the VirtualKeyboard APIs
on Android. It uses the new virtualKeyboardPolicy that will let web
authors control the virtual keyboard behavior through JS by calling
virtual keyboard's show/hide APIs. In the next patch I'll implement
the geometrychange event that will let web authors control whether
to scroll the editable element into view by default or not and also
send the size of the virtual keyboard rectangle.
It is currently behind a runtime flag - VirtualKeyboard.
Explainers and Design Doc:
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/VirtualKeyboardPolicy/explainer.md
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/VirtualKeyboardAPI/explainer.md
https://docs.google.com/document/d/1I0LUNxK_gP5IaNQsbYN6gL6Zpm71XzduCKkublU5o5Q/edit?usp=sharing

Bug: 856269

Change-Id: I2424e016cad34e52f9c59503f1918f5c51e4bcd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386461
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804324}

Additionally, update all existing clients to use the kBluetoothLowEnergy
client.

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/2391739.

The CL originally got reverted because it used cached CQ results to
submit, but some other changes had landed since the CQ results were
cached which broke the build.

Original CL is patchset 1, and fix is in patchset 2.

Bug: 1106937
Change-Id: I72c6d0eec7e5afcfdde09a8439a10f856883732b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392916
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#804323}

This change is the first step in rectifying the confusion around
WidgetDelegate's ownership of its contents view, which is documented
at length in WidgetDelegate's class definition. Specifically, this
change makes it clear when it is *intended* that ownership of the
contents view is taken from the WidgetDelegate.

This is step 1 of this plan:
1) Introduce WidgetDelegate::TransferOwnershipOfContentsView() and
   migrate to it in places that are trying to take ownership
2) Introduce WidgetDelegate::SetContentsView(), which will either:
   a. Store the provided view in a unique_ptr, if it is not owned
      by client, or
   b. Store the provided view in a raw pointer, if it is owned by
      client
3) Replace all existing overrides of GetContentsView() with uses of
   SetContentsView()
4) Require that !owned_by_client() in SetContentsView(), which will
   likely require intense surgery of client classes
5) Have SetContentsView() take and TransferOwnershipOfContentsView()
   return a unique_ptr<View> rather than a View*

This multi-step plan avoids ever storing a view with owned_by_client
in a unique_ptr, which is an extremely simple route to an accidental
double-free.

Bug: 1075649
Change-Id: I3ee55423ba5e4e7b48a50a9f4e04299f0721d410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376449
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804322}

Different storage partitions should not be able to resolve blob URLs
created in other partitions. To ensure this, give each partition their
own blob url registry.

There is one exception though, a <webview> inside a chrome app should
be able to resolve blob URLs that were created by the chrome app. To
enable this, we add the concept of a "fallback url registry" to
BlobUrlRegistry, and pass the BlobUrlRegistry of the app in as fallback
when creating the storage partition for a <webview>.

Bug: 1106890
Change-Id: I809f24a2c0b4d8d21e53d46bb6d3e2027b21281b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324110Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804321}

Also setting builderless to False, so that dedicated machines would be useed

Bug: 1024915
Change-Id: I4e3b3fb134f8ddbb354c7ec44614f77c9cf7de89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392166Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Prakhar Asthana <pasthana@google.com>
Auto-Submit: Prakhar Asthana <pasthana@google.com>
Cr-Commit-Position: refs/heads/master@{#804320}

This change originally excluded newlines from the start and end of all
TextPattern API's. However, upon rebase, I discovered that this issue
was fixed via this change:

https://chromium-review.googlesource.com/c/chromium/src/+/2346653

...so that is no longer necessary. Instead, this change adds a test
to verify this important editing scenario as well as some minor
refactoring/cleanup.

Ax-Relnotes: N/A

Bug: 1049682
Change-Id: Ic20f36793484daa5b7043b1197697969e20244f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363369
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#804319}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/99d869bb..6d46b6f1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ifd4c071b99d7544b562122218f4fb7d48b781540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390546Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804318}

This CL adds feature flags and about:flags entries for a couple of
flags:
- MessagesForAndroidInfrastructure will control initialization of
  infrastructure classes (MessageQueueManager, etc.)
- MessagesForAndroidPasswordsName will control whether save/update
  password uses Infobars or Messages UI.

BUG=1123947
R=lazzzis@chromium.org

Change-Id: I4b3e3920d2909f8e6144cc197d8fddc029356f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388949Reviewed-by: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804317}

Change-Id: Ifa68ca8083ccb12602ae62f0f1e19e4827bc2afa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392711Reviewed-by: Zach Trudo <zatrudo@google.com>
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804316}

This is a preparation to attach LayoutSliderContainer to the slider
track part, instead of the slider container part. LayoutSliderContainer
adjusts the position of the thumb part, but the thumb part is not a
child of the slider container part, and it's a child of the slider
track part.

This CL has no behavior changes.

Bug: 1040826
Change-Id: Ie520e4f9fe5c474c40b55eb0e2d5d308c05300cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391893
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804315}

If fingerprint scan failed, provide visual feedback (animation and
prompt text change) to the user. Also add accessibility feedback:
ChromeVox would play an alert sound and say the fingerprint auth result.

These are the same effects as lock screen except that the prompt text
strings mention "authenticate" instead of "unlock".

Bug: b:156258540, b:144861739
Test: Tested with ChromeVox.
Change-Id: If15ba95e532500f8cbf47b421a48a3be3dfb4c6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386579Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804314}

use of test-only-api.js in preparation for launching official MojoJS support
in WPT. This would not change the test results on Chromium waterfall
(everything should continue to pass) or upstream WPT (tests currently
fail because MojoJS isn't enabled).

Bug: 1123988
Change-Id: I638c27ffe363a7011fba40e1a78339d8052ef18a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390203
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804313}

These files need to be accessible when running wpt
outside chromium environment.

see: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#mojojs

This is the first step towards making these tests pass outside the Chromium CI

Bug: 1123992
Change-Id: I0a6fdfdd5a7c2970d3c683cc4140af3b6d1b999e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391223Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Cr-Commit-Position: refs/heads/master@{#804312}

This changes:
* Removes the hairline around the menu
* Widens the menu view so that the gear and the cog are aligned with the
  edges of card content

New Screenshots:
Feed V2 Enabled: https://screenshot.googleplex.com/7X8V4WTYgTx9EUW
Feed V2 Turned Off: https://screenshot.googleplex.com/9UJLL9uDcjNGjyQ

Bug: 1123996
Change-Id: I8db77160cbae5e0121dfc3397d732b81532ff56a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388261
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Vincent Boisselle <vincb@google.com>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804311}

Add information about running ChromeDriver Python integration tests
targeting Android devices.

Notry: true
Change-Id: I6f97e77cd56ca143dac313759e5561edf7d6a697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392265Reviewed-by: Shengfa Lin <shengfa@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804310}

Bug: 1116418
Change-Id: I33bd57b176c9c603d60b83ca0e020aa5f5b4abff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390910
Commit-Queue: Yifan Luo <lyf@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804309}

This CL unifies those two buildflags file for Chrome OS.

BUG=1114198
TEST=Build locally. Ran tryjob.

Change-Id: Id7343da06ac6b17cb20cb20babdd8ab06ac40028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377525
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804308}

Implement an overloaded function to trace its argument into a given
TracedValue pointer. Thus enable using type deduction to decide which
way to trace a given argument.

Bug: 1111787
Change-Id: I058c3436f59f3b6d98e34c1f620b467e4d5c41e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364872
Commit-Queue: Karel Král <karelkral@google.com>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804307}

This CL implements a unittest in the AncestorThrottle for testing the
logic of the check for Content-Security-Policy: Embedded Enforcement.

Bug: 1094909
Change-Id: I935110d1718b7d39d364f20e57a24e59ba141463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294801
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804306}

This reverts commit 0839d38f.

Reason for revert: chromium/ci/linux-chromeos-rel never times out
All builds are < 2 hours:
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel

Original change's description:
> [infra] Increase linux-chromeos-rel build timeout from 3 to 4 hours
> 
> Bug: 1121834
> Change-Id: Ic98a994d225795788e10c4b161f9de1b1bde60d2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376572
> Auto-Submit: Gregory Guterman <guterman@google.com>
> Reviewed-by: Erik Staab <estaab@chromium.org>
> Commit-Queue: Erik Staab <estaab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#801637}

TBR=estaab@chromium.org,guterman@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1121834
Change-Id: Icbaf4999523e7c24bb0973b14c7517ae05c68e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392918Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804305}

This rolls up to sha 7da1d0666575e5735fd1286e6b3e67e9973f4643

Just one minor change to testharness, likely a no-op

Change-Id: Ia7e1318684542156d1906f1e67c7508aed903bac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392438
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Auto-Submit: Luke Z <lpz@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804304}

The feature has been sunset. Remove the related flags,
make some '..FeatureEnabled()' methods simply return false.

Cleaning up the rest of Duet-related code will follow soon.

Bug: 1081343
Change-Id: If58553cc7553b942bfbd97034efa86dc03f7aab9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386858Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Lijin Shen <lazzzis@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804303}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009030800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/tO_jo2xydYVZOxjRmrkRI5NL5AYbhmuV3J9LTRaaYEsC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: Id129d7a5a29e6e14fd3455e9f45411772689a149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392715Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804302}

This is from pre-compositing times.

R=avi@chromium.org

Change-Id: I95617aca135e455053130d53b357d95c0c563042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392399Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804301}

https://android.googlesource.com/platform/external/perfetto.git/+log/c4bfa82e48ed..fb45a94639ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I1057be90d5501c55c72f34a982c1b20d8a4a1407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390854Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804300}

- yuv_to_rgb_converter.cc was only able to correctly handle rectangle
  YUV textures (GL_TEXTURE_RECTANGLE_ARB). However, it couldn't handle
  GL_TEXTURE_2D textures correctly (The Metal backend uses GL_TEXTURE_2D
  for IOSurface unlike the default OpenGL backend).

- The shaders code as well as the OpenGL code were assuming the textures
  are rectangle whereas the 2D scenarios hadn't been tested properly.
  For example, the OpenGL code always passed texture size to
  "a_texScale" uniform to scale the texcoords, regardless of the texture
  being rectangle or 2D. In 2D fragment shader, the texcoords for UV
  texture were reduced by half as if the texcoords are for rectangle
  texture.

- Furthermore, when binding IOSurface to 2D textures, the code forgot
  to disable mipmap filtering. Because by default 2D textures have
  mipmap filtering enabled, and IOSurface bound textures don't have
  mipmap, this led to the YUV textures were reported as incomplete by
  OpenGL. Thus decoding wouldn't be able to sample real results from the
  YUV textures.

Bug: angleproject:4846
Bug: angleproject:2634
Bug: 1122432
Change-Id: Ie43b755c19b3dc149ddca3d68c381fee99479c00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378407
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804299}

This is a reland of 1180542b

The internal CL is rolled in now. Let's try again...

Original change's description:
> Remove BlockThirdPartyCookies preference
>
> The boolean BlockThirdPartyCookies preference was replaced by
> CookieControlsMode enum. Existing settings were migrated since M83.
> Since all usage of the preference has been removed, the preference
> can be removed and existing settings cleared.
>
> Bug: 1104836
> Change-Id: Ie6e38b0a424981395c627459d684030ea84a58b7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387805
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803844}

Tbr: engedy@chromium.org, gab@chromium.org
Bug: 1104836, 1124326
Change-Id: Iebe3205beb4426cda5305eb7c69eb4e575df2cfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391073Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804298}