GitLab

Change-Id: I0bc257f9ede24d5c7d4b2ca30263567a17f7e45b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728727Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683038}

It is crucial to know that Safe Browsing updates are being parsed and
applied successfully.

R=nikunjb

Bug: 969952, 974961, 975008, 975056
Change-Id: I09f9496828c62ef7ee9c8572f1f30781d250c044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721038Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683037}

We will get rid of chrome/browser/extensions/bookmark_app_extension_util.cc
completely. That's the last bookmark_app* prefixed file in extensions/.

We could inline these utils into finalizer but they are used in ntp/
(chrome://apps)

TBR=calamity@chromium.org

Bug: 901226
Change-Id: If978196d1f9e45cddd7d637603210fab02556eac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728530Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683036}

A crash has been introduced in media/alpha-video-playback.html
when running with SkiaRenderer and SwiftShader. This change updates
the flag expectations to skip the test. Until the root cause can be fixed.

TBR=backer@chromium.org
Test=skia_renderer_swiftshader_blink_web_tests
media/alpha-video-playback.html

Bug: 988120
Change-Id: I60d8eee0ab5c253ffe2900ac2effdfbebb090abb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730272Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683035}

Change-Id: Iccf1395b0fa95bccb6b4ceef8ea8ff0adf06ae70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729580Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683034}

This reverts commit 17ec7e69.

This whitelist is no longer needed. We want to open up this API for public use.

Original change's description:
> Whitelist usage of management.installReplacementWebApp
>
> This whitelists management.installReplacementWebApp to specific
> extensions as restrictions to ensure apps are related aren't yet
> implemented on the Webstore.
>
> For tests we need to generate manifest.json files based on the URL of
> the related app. Hence we can't check in a static crx/extension. This
> means that we need to provide a private key when generating the crx to
> ensure that the extension ID stays the same across test runs.
>
> Bug: 968407
> Change-Id: Ieceadeaf59011b7209fece3de06e89f2bea4b9e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635118
> Commit-Queue: Raymes Khoury <raymes@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#665044}

TBR=raymes@chromium.org,benwells@chromium.org,rdevlin.cronin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 989799
Change-Id: I7662316011114dc2b5d50fc9a8ad1124b8749582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727869Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Auto-Submit: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683033}

ExternalInstallOptions is tightly coupled with PendingAppManager:
Many options like start_url are not used in InstallManager.
This was super confusing.

InstallManager and WebAppInstallTask should not work with
ExternalInstallOptions and ExternalInstallSource.

This CL changes InstallWebAppWithOptions method
in InstallManager, WebAppInstallManager and
WebAppInstallTask to work with WebappInstallSource and
new InstallManager::InstallParams struct.

Drive by: this method is renamed to InstallWebAppWithParams.

Note that:
1) InstallParams is a strict subset of ExternalInstallOptions.
2) ExternalInstallSource is a strict subset of
WebappInstallSource.
3) WebappInstallSource is our universal install source (full
information). _All_ InstallManager methods take it as explicit
argument.

Bug: 901226
Change-Id: I6777ead452127dd4f131bcbe1501cbbf25568aee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727097Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683032}

This CL is the forth part of code to implement the arrow button in
the overflow bubble view.
See more details from the below doc link:
https://docs.google.com/document/d/1dO4H_4T6ttWFc75nCNi2Uh18k-3_M8-eOHcfMTcNwd0/edit?usp=sharing

Bug: 918024
Change-Id: I2ee940845c61a52e1250487c8dce1e942759adb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703268
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Mitsuru Oshima (Slow - traveling) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683031}

When a collection id is received in SetCustomBackgroundInfo send a
request for the next image in the collection. Save the data for the
returned image and the resume token in the custom background pref.

Bug: 850317

Change-Id: Ia6a4a89fd2b3491a61bc652440d7cb19926e1144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721841
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683030}

Under certain circumstances, such as aborting an animation and then
reassigning a unique_ptr to a new CallbackLayerAnimationObserver (eg
InkDropRipple::SnapToState(InkDropState ink_drop_state), the logic to
detect deletion in CallbackLayerAnimationObserver ends up causing a
heap-use-after-free because
CallbackLayerAnimationObserver::CheckAllSequencesCompleted() overwrites
the destroyed_ pointer that CallbackLayerAnimationObserver::SetActive() set.

In order to fix this issue, use of the destroyed_ pointer was replaced
with local WeakPtrs in order to detect deletion.

Change-Id: I051657fae929eb4d7200f965561e9d9fb21b44f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714626Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jeremy Apthorp <jeremya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683029}

The remaining class in content/renderer/media/stream pass around
instances of PeerConnectionDependencyFactory objects through their
ctors, but do not effectively use them.

This CL cleans this up, as a preparation step to Onion soupping them
all at once.

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ie2a7b7855b94caf8da4a633109c867b9b3d1515b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729573
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683028}

Changed VolumeManager's methods mountArchive() and unmount() to make
them return a Promise instead of taking completion callbacks.

Change-Id: I9debd4c7edc8256f24f539f81bac088c44edd09a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727653Reviewed-by: François Degros <fdegros@chromium.org>
Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683027}

This CL renames *_struct_traits.* to *_mojom_traits.* in //gpu.

*_struct_traits.* => *_mojom_traits.*

Bug: 806965
Change-Id: I7c31344d154b3d7390a8c9f92997cfb8fb868657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728413
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683026}

Deleting the directory not recursively returns false.

Bug: 936248
Change-Id: Ic899633b8fa786303edd6a587c140c2d8af08fcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730100Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#683025}

The text color changes when onmibox is scrolled at the top. This CL
updates the value of default_text_ color_secondary to white_alpha_70
such that NTP fakebox uses the same hint color text as the omnibox.

Bug: 984151
Change-Id: I8dbd0e32731a551ccaf3f00031c4631613fcb886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727374
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683024}

Implement CastMediaController for the native Cast MRP, which will allow
controlling the media playback in flinging sessions.

Bug: 987474
Change-Id: I8a8909bb0f67efb71629a30ea9b206368b66482a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625377Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683023}

These tests are failing on Linux.

TBR: zmin@chromium.org
Bug: 989757, 989756, 989755, 989747
Change-Id: I214199d9ee0196742f31170310939f82e6c1f47c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728055Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683022}

https://webrtc.googlesource.com/src.git/+log/add7ef974ee2..ea9798c5eb96

git log add7ef974ee2..ea9798c5eb96 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 titovartem@webrtc.org Update video quality tests units reporting.
2019-07-31 steveanton@webrtc.org Remove "Missing track ID" StatsCollector log message

Created with:
  gclient setdep -r src/third_party/webrtc@ea9798c5eb96

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I687e97f322a72f004997057a0f3a6311dd0948d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730289Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683021}

https://skia.googlesource.com/skia.git/+log/79b81c9b4709..acd8dbea94f7

git log 79b81c9b4709..acd8dbea94f7 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-07-31 benjaminwagner@google.com Revert "Add LUM8 case to GrGLCaps::getYUVAColorTypeFromBackendFormat"
2019-07-31 reed@google.com fix bench to scale up, so we don't skip high-qual-filter

Created with:
  gclient setdep -r src/third_party/skia@acd8dbea94f7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@google.com

Bug: None
Change-Id: I0b8b6be6f338774ce3c77de1217d34bf155aefba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730045Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683020}

It's been disabled for 6 years and has bitrotted.

Bug: 241691
Change-Id: Id7408131303d98dd0902fef13a9fb51bf512e21e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725117
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683019}

This change cleans up the accessibility platform code to use checks
for the kAutofillAvailable state instead of using out-dated methods.
We also remove the out-dated methods from the codebase.

This change applies to primarily Windows and Mac, but also does some
clean up in the general accessibility platform code.

Bug: 865101
Change-Id: Id24868ac54b70e9dfefd118ab84b89ceb5a4fed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725418
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683018}

Before this CL WorkerThread took FetchClientSettingsObjectSnapshot
and created CrossThreadFetchClientSettingsObjectData internally
before posting tasks from the main thread to worker thread.

This CL changes WorkerThread to take
CrossThreadFetchClientSettingsObjectData. This way we can eliminate
creating an intermediate GarbageCollected object for service worker
startup.

This CL doesn't have behaviroal changes.

Bug: 988335
Change-Id: Ibd717fc199d0d5dfa7e8fe3f30857ee19a828e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722166Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683017}

I usually want to hex encode a std::vector<uint8_t> or a uint8_t[] and
this makes it less verbose.

Change-Id: Ia4857b0d8f5cb760e6791e0778359e4050d02275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728047
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683016}

https://chromium.googlesource.com/angle/angle.git/+log/eb1b1646aebe..1dbbc7b3e232

git log eb1b1646aebe..1dbbc7b3e232 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 ynovikov@chromium.org Skip couple TextureBorderClampIntegerTestES3 tests.

Created with:
  gclient setdep -r src/third_party/angle@1dbbc7b3e232

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Bug: None
Change-Id: I1f2be3ca62a149084881f45165962ec93edf81a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730042Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683015}

This was a recent change made to the WebXR spec.

Bug: 976070
Change-Id: Ibdf4e4d7648d14540280594d7079696223a8dc62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728479Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683014}

Comment-only change.

Change-Id: Ia879b1b02f6d2d1dbcd7019ec2fff431285acacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716285
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683013}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/deb26d22f8ca..78b685d68f34

git log deb26d22f8ca..78b685d68f34 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 tcwang@google.com afdo: Use CWP and Benchmark versions as orderfile name.

Created with:
  gclient setdep -r src/third_party/chromite@78b685d68f34

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I8ef68c59abc9264de7c2288467ffe9ce68d2b80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730046Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683012}

Also moves highlight related tests to a new file, and add test utils
files for shared code.

Bug: 978168
Tests: added new tests

Change-Id: Ie9e8bfea304334ca2210c08e5f5ffefa7d102e19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689952
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683011}

On Android crashpad launches differently than on desktop platforms. This
requires refactoring the crash_handler unittests to support launching
via a specially built executable that we package with the unit tests
just for the Android build. This approach only works if the
enable_gwp_asan buildflag is set to true because otherwise
libchrome_crashpad_handler.so wont compile in the GWP-ASan crash handler
hook.

Bug: 973167
Change-Id: I40888e0d7a81961e22f808ab15d8b0c2a83b4494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730031
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683010}

Classes derived from printing::PrintManager each process a similar set
of messages, such as DidPrintDocument, GetDefaultPrintSettings, and
ScriptedPrint.  The framework necessary for handling these is very
similar across the classes, even if some of the classes need to do
something different for some particular message.

Simplify the code by pushing this common framework into the base class
printing::PrintManager.

Broken out of work to resolve a printing issue when print preview is
disabled in [1].

[1] https://crrev.com/c/1700275

Bug: 974480
Change-Id: If5a6a2f100900d9261f7c396f6bec55f299fea3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714807Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683009}

This is a reland of 5351d11f

Original change's description:
> [Fuchsia] Update to new FIDL string and vector APIs
>
> This removes usages of the old API that will become build failures when
> deprecation warnings are turned on.
>
> See: https://fuchsia-review.googlesource.com/c/fuchsia/+/304389
> Change-Id: Ie5db014401d79787101b2b4b6e7585fd7a23b1ce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727375
> Commit-Queue: Ian McKellar <ianloic@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682796}

TBR=ianloic

Change-Id: I805e7e0274e5f42bcbb8c53ef2afa57186d85582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728722Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683008}

Also clean up some old owners who aren't active in the code anymore.

Change-Id: Ib809d30c30c3203cb9cad16c9c643c678602b961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728447
Auto-Submit: Nathan Parker <nparker@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683007}

BUG=972848

Change-Id: I1965cbbc2b57db143e504a2bd8a233e6f7063248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724902Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#683006}

PlatformSensorReaderWinrtLightSensor

As the third step for implementing usage of the
Windows.Devices.Sensors WinRT API in Chromium, this CL:
  - Implements PlatformSensorReaderWinrtBase, the base class
    used to implement all of the Windows.Devices.Sensors based
    PlatformSensorReaders.
  - Implements PlatformSensorReaderWinrtLightSensor, the derived
    class of PlatformSensorReaderWinrtBase which adds support
    for light sensors using Windows.Devices.Sensors.LightSensor.
There is heavy use of templates since the Windows.Devices.Sensors
API is strongly typed.

Verified functionally by:
  - Built chrome.exe.
  - Ran chrome.exe on laptop with light sensor.
  - Navigated to website that polls the W3C light sensor:
    - Verified light sensor could be polled with WinRT feature
      flag on and off.
  - Ran chrome.exe on laptop without light sensor.
  - Navigated to website that polls the W3C light sensor:
    - Verified the light sensor failed to instantiate with the
      WinRT feature flag on and off.
Also ran new PlatformSensorReaderTestWinrt unit tests.

Bug: 958266
Change-Id: Iaa69d92f9e7923099653b4f554efc2852162b53f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703327
Commit-Queue: Wenjie Shi <wensh@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683005}

This gets attached to the XRInputSourceDescription mojo struct
which is sent from XR device processes to blink.

For WMR controllers, use:
["windows-mixed-reality", "touchpad-thumbstick-controller"]

Populating this array for other platforms such as Oculus and OpenVR
will come in later CL(s).

Bug: 979250
Change-Id: I06c6666c4c085f6578630c25059d07faff158bbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726903
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683004}

This testing is gated on the phone-home capability of mac/ios, which makes
it difficult to test.  Removing test.

Bug: 989629
Change-Id: Idb870e9f7307b2f31d7ce3eab9202a5e0c8c4acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729578
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683003}

Create() does not need to check IsSetPermittedInContext because
it is already checked when setting a cookie. It also does not have
to check for a secure scheme when creating a Secure cookie, because
that is checked when setting a cookie. Create() should only
need to check that the cookie it creates is canonical.

Bug: 989098
Change-Id: Ic5be164cfb60825c7775c3bc58986a835afa499e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726789
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683002}

Rename the api for setting custom backgrounds and add an additional
collection_id param. This will be used for the "daily refresh" feature
in https://crrev.com/c/1721841.

Bug: 850317
Change-Id: Ibf14af8db94b85dc489d0d24cb28af33495ff3b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717921Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683001}

This change adds an explicit ShowTouchToFill() API to the
PasswordManagerDriver and provides a stub implementation for
PasswordManagerClient.

Bug: 957532
Change-Id: I87a3d1b21caedfbf651c2294a4e10e8b4ac69e48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702251
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683000}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/364640e2491e..447b45d42307

git log 364640e2491e..447b45d42307 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 smut@google.com [vpython] Roll to 98a268c6432f18aedd55d62b9621765316dc2a16

Created with:
  gclient setdep -r src/third_party/depot_tools@447b45d42307

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Bug: chromium:898348
Change-Id: Id6f1378c96f5ca5490510d139d95f6757271508f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729839Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682999}