- 11 Jul, 2019 40 commits
-
-
Orin Jaworski authored
This CL makes OpenSearch description document fetching more robust by timing out old failed requests and retrying requests that would otherwise silently fail due to network change. Bug: 956689 Change-Id: I26e21194ea8911916b7766b3a6eb47d6d35643c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688437 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#676536}
-
Daniel Nicoara authored
This is disabled by default on regular builds to conserve space. Enable it in tests to gain coverage. Bug: None Test: None Change-Id: I215b80df0c2f7594310e94acb0e6ff313dd659ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678817Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#676535}
-
Alex Moshchuk authored
Bug: 975945 Change-Id: I6a9413d1f89cea042df59a99e5df7c4e72c3dd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693482Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676534}
-
Shivani Sharma authored
This CL changes the browser test to actually send a user gesture to a frame instead of calling the user activation API UpdateUserActivationState to be sure that the user activation API gets invoked correctly. *OnUserGestureResetSameDocumentEntriesSkipFlag Test: content_browsertests --gtest_filter= Bug: 907167 Change-Id: I4764f084095a162d5a6d0a7f603cdf3201c41d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690707Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#676533}
-
Fredrik Söderquist authored
When loading of images is disabled, ResourceFetcher will return an ImageResource{,Content} whose status is "not started". Since this resource will not get a "finished" notification, we didn't update the <img> to show fallback content when the image is first requested. Subsequent loads would yield the fallback correctly because the cached resource was returned. Add a case to ImageLoader::DoUpdateFromElement() to check for this case and call NoImageResourceToLoad(). Bug: 982603 Change-Id: I6377f87a45745c364f92ceb0e8c4dabd4fbc1b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695549Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#676532}
-
Scott Haseley authored
Setting expiry to M79 for various TabManager metrics that were previously set to M77, M78, or unset. Bug: 975494, 975864 Change-Id: I8cc98cbb8ef518f5e139dda033a7996db800a133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696530Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#676531}
-
Fredrik Söderquist authored
This collection of predicates are pretty intricate, and are a better fit for ImageLoader, so move them there into a new method called ImageIsPotentiallyAvailable(). Bug: 982603 Change-Id: I4825d833809cda7a9daa153a58c18d6fcbd92048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697650Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#676530}
-
Rayan Kanso authored
Change-Id: Ie80bd509889ce66372bd95b59cf75a9b7571723a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697251 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#676529}
-
Egor Pasko authored
I found that crazylinker tests are special enough not to be run during regular testing. I fixed a small issue and added a document about a few non-trivial-to-discover ways to test the crazylinker in Chromium checkout. After the fix all the off-CQ testing described in the doc passes on my Nexus5X, with the exception of fuzzers - I did not run those. Applying TBR for docs only. TBR=rmcilroy@chromium.org Bug: 981599 Change-Id: I7ead0ef59c6b402729393ba273798107afefed46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695309Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#676528}
-
Kristina Nelson authored
Previously these histograms were based off another histogram which resulted incorrect description and boolean bucket labels. Bug: 815290 Change-Id: I7fb9ced71e403317592c9f2adb8c6546b0ced4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690814 Commit-Queue: Kristina Nelson <krstnmnlsn@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676527}
-
Chris Blume authored
$ git log 76aabbd35..14eba7add --date=short --no-merges --format='%ad %ae %s' 2019-07-09 chrdavis Fix static const data duplication Change-Id: Iebb764e1af1ed4b7dd904f20e318549049207749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696481Reviewed-by:
Jonathan Wright <jonathan.wright@arm.com> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#676526}
-
jonross authored
The main expectation for scrollbar-layer-placement-negative-z-index-child has been changed: https://chromium-review.googlesource.com/c/chromium/src/+/1694249 However with the test running again it encounters a blurring related to using GPU Raster. Updating the expectations for skia_renderer_gl_blink_web_tests to account for this. We'll need the flag specific rebaseline. TBR=backer@chromium.org TEST=skia_renderer_gl_blink_web_tests Bug: 954328 Change-Id: I0fb92ff7ad7d6f463a28a0d45ae83c7af211011e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697305Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#676525}
-
Adam Langley authored
Several sites have not set a value for userVerification in either create or get calls. This means that they end up with “preferred”, which is generally not what they want. This change adds a warning to the console in this case. The warning can be silenced by explicitly setting userVerification to any valid value. BUG=980972 Change-Id: Ide02de81f654c7101744bbc36d66b7c0dee00cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696170 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#676524}
-
Will Harris authored
This API can't be relied on as it needs the NtMapViewOfSection intercept to be in place, which is not always the case. There were no callers to this API anyway. Also, tidy up the hardcoded values to make them more readable. BUG=None Change-Id: Ib45b524f465a2730f9164eac987ffa8b35181243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696526 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#676523}
-
Jun Cai authored
Per comment at: https://bugs.chromium.org/p/chromium/issues/detail?id=953075#c17 This CL fixes the string for translators. TBR=reillyg@chromium.org Bug: 953075, 960960 Change-Id: I005aaea8a8232eefbc07b981c57ba5af7bab2ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695930 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#676522}
-
Khushal authored
R=sunnyps@chromium.org Bug: 980122 Change-Id: Id45d60eb7cea1682badf1a02cc18dae572f24e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694246 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#676521}
-
Meilin Wang authored
The append and remove icons should be Google Grey 700 according to the spec. Also update the color of bookmark icon to keep consistency. Bug: 977265 Test: manually. Change-Id: Iee48f612e4e3784480469c3f9fe237e7268fece4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696531Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#676520}
-
Javier Ernesto Flores Robles authored
This allows the ToS to be rendered correctly for dark mode on iOS 13. Bug: 976640 Change-Id: I9e870b1bb979febbbd0255a63e130a20a4691f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691181 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#676519}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/741b96b175cb..4e5a41a08674 git log 741b96b175cb..4e5a41a08674 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 ilnik@webrtc.org Cleanup FEC code after refactoring 2019-07-11 ilnik@webrtc.org Refactor FEC code to use COW buffers 2019-07-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8bdf10df..3bcb1095 (676126:676409) 2019-07-11 sprang@webrtc.org Make new pacer padding more like old one Created with: gclient setdep -r src/third_party/webrtc@4e5a41a08674 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie00d26cf70005cac13c35eb046b4835847043fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698317Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676518}
-
Min Chen authored
- Delete NightLightToggleButton since there is no toggle button for night light in unified system tray now. - Delete all the unused night light related icons. Only kUnifiedMenuNightLightIcon is used in unified system tray now. Bug: 982950 Change-Id: Ib95fc9ac58906b0ddc04b37ccb9fe8cdf98047db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696688Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#676517}
-
Matt Mueller authored
Bug: 634470 Change-Id: I1a7d17d51b481ad3aabd220f3b88286c0d9ca405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693387 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#676516}
-
Collin Baker authored
Instead of snapping to fully highlighted or not highlighted at all, this implements an animation similar to current ink drops. A linear fade is used, but this can be changed easily using the utilities in gfx::Tween. Bug: 933384 Change-Id: Ife827b914064ac16eb9e549656ae05bfd049f517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696402 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676515}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3efcccc6e77a..14d669b045c8 git log 3efcccc6e77a..14d669b045c8 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 bpastene@chromium.org telemetry: Fetch binary deps for the host platform when running on CrOS. Created with: gclient setdep -r src/third_party/catapult@14d669b045c8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:938502 TBR=zhanliang@google.com Change-Id: I7ffd841c92cf22f3caa67c48fd6bc26d697d99d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698313Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676514}
-
Daniel Bratell authored
In some non-default, extreme, jumbo builds, the kDefaultHeight in download and the kDefaultHeight in hats ended up in the same translation unit which then prevented compilation. To avoid that, this patch renames them kDefaultDownloadItemHeight and kDefaultHatsDialogHeight. Bug: 979530 Change-Id: I38246cdcbbd7665c999ab74b51cf77ed90efcd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698362 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#676513}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ec162df61d3..d2d2d8ea056b git log 9ec162df61d3..d2d2d8ea056b --date=short --no-merges --format='%ad %ae %s' 2019-07-11 nednguyen@google.com chromite: Specify 'virtual/target-sdk-post-cross' in non board sepcific packages Created with: gclient setdep -r src/third_party/chromite@d2d2d8ea056b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I14c4ec565cd7ede956b245a68154c071237a3a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676512}
-
Vasiliy Telezhnikov authored
Bug: 981934 Change-Id: I52cf85b6d32eef2d2d93bb8fe450d9ec0ad5cc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695991 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#676511}
-
Robert Liao authored
This change removes some unused structures from HaTS service. BUG=979530 Change-Id: I8b07a12a7b3bccbada1ab96f87dc4b7df195fe05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696686 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#676510}
-
Min Chen authored
Delete ShowStickyHeaderSeparator and CreateListSubHeaderSeparator in TrayPopupUtils. Both of them have definitions in DetailedViewDelegate after introduced the unified system tray. Bug: 982950 Change-Id: Ia80c1e1e0e81eabb26fc6a93cd12dcf79e3789ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696529Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#676509}
-
Min Chen authored
PowerStatusView was added to show the time and battery status in settings row in the system tray menu. But there is no settings row in unified system tray menu now. related issue: https://bugs.chromium.org/p/chromium/issues/detail?id=127771 corresponding spec: https://docs.google.com/file/d/0B7t22qFrueRsVVAza0dtWmN5ZlE/view The time and battery status is provided by UnifiedSystemInfoView now. Based on the info above, this cl deletes PowerStatusView and related variables in tray_constants. Bug: 982950 Change-Id: I46e2700993277b2839a21b06590786292e060b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695739 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#676508}
-
Marijn Kruisselbrink authored
Bug: 979684 Change-Id: Ie30a8b3a7bf57caa9284db4aa4876fc09bb8e6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685938 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#676507}
-
Sean Kelker authored
Removed code that allowed RecurrentInterstitialFeature to be optional because this feature is now launched and enabled by default. Bug: 953972 Change-Id: I33aeb6d85f3712d5fa616235d81acb1106f709ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677001Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Sean Kelker <seankelker@google.com> Cr-Commit-Position: refs/heads/master@{#676506}
-
Robert Liao authored
BUG= Change-Id: Ie39f320c708c8c92297de067f7fd61227dc55c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697311Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#676505}
-
Min Chen authored
Bug: 972162 Change-Id: I960d903c2e7e9cd86c34019fa30d677ff78557de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696050Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#676504}
-
Alex Moshchuk authored
It might be useful to keep these for informing issue 621724, which is still not fixed. Bug: 975015, 975234, 621724 Change-Id: Ie6cf1d2784cc7aaeb52039865723184fb74be3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696683 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676503}
-
Julian Kung authored
Previously, each function MinimizeWindow, MaximizeWindow, etc... had their own code to change window state to normal before calling GetWindowBounds. This changelist refactors the code so window state normalization only occurs in one place. R=johnchen@chromium.org Change-Id: I0a865adf6e9e1d64afc0694930a6982789f6656a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696451 Commit-Queue: Julian Kung <juliankung@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676502}
-
Bryan McQuade authored
Now that we are making FID4 the official metric, this change brings the AMP-specific FID metrics in line with the core FID metrics. Change-Id: Ida5d91e6b06749b25fb9d3e0b47bf768c1cd9d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697956Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#676501}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db9e714c8b2c..360b8d795ccb Created with: gclient setdep -r src-internal@360b8d795ccb The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: Ibd1cdd202aa0722f5b1d898a2e82ede11a8ccb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697075Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676500}
-
Takuto Ikuta authored
Let me add a sanity check just to confirm UdevLoader::Get() works. I will use this test to investigate loader behavior in msan on xenial. Bug: 981731 Change-Id: I824f95767cb4ccdb73f544e8cea670571b1cc8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697661 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#676499}
-
yilkal authored
This cl removes KioskNextShelfView and updates the shelf widget. Bug: 977019 Change-Id: Ie47157bf6c1ccc85de1c9d2b7aea1b7ce0f637ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684757 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#676498}
-
Yi Gu authored
This reverts commit 52b6364a. Reason for revert: It caused some unexpected crashing. See https://crbug.com/983166. Suspecting that something is wrong with using GURL::GetOrigin(). Original change's description: > [VizHitTesting V2] Add dump without crash to identify sites with mismatch results > > This patch adds more info into the crash report, i.e. the report now > includes url, event type, global and local coordinates. > > Bug: 976284 > Change-Id: I70568ade1c94e018d5a42ef023b0eb65d9c40c55 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689960 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675995} TBR=sadrul@chromium.org,yigu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 976284 Change-Id: I2ebc9e51b6e59578555ab5e70f9fa9c6d68c0d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697072Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676497}
-